From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F24943802; Wed, 3 Jan 2024 03:55:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 423E6402BC; Wed, 3 Jan 2024 03:55:09 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 58386402A3 for ; Wed, 3 Jan 2024 03:55:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704250507; x=1735786507; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=waEMGFt8ui606K4EqiYnhwerIJNmJKXWoRE5qLUcSXk=; b=JY+5GyMEOhkNNEYBXqSsg0eVcn8QGrenLkJNdABVUUzYjVmhTd7FAbE8 ynsIpUNt5SYdr0SeIrWhY7p/oaQQK1YwYLaWWoEMtGyxBvK7T5+qDCHYa Ir/AGTRNd5JFDO54zPsXqN/+71AIeAWsepsToIi3JogCTOIyq+7PFpyc7 3BRhfeFrJXXj5QoBKa3As3WklB+Fap3rjbObEzMXI8mrWxo7PdCho+X+/ /Q/o5Gy9mJ7iIyS/IFV/dChWiRBQFiUNHxlqsPHB2Hrla+xq/Y6K5p34o NkebAeb8gvq/yeLUU9SAsdIAS8FT4QAoX45UEP/NGXSdj1IYJbUYTD4Q+ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="483133720" X-IronPort-AV: E=Sophos;i="6.04,326,1695711600"; d="scan'208";a="483133720" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2024 18:55:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="783376325" X-IronPort-AV: E=Sophos;i="6.04,326,1695711600"; d="scan'208";a="783376325" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Jan 2024 18:55:06 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 2 Jan 2024 18:55:05 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 2 Jan 2024 18:55:05 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 2 Jan 2024 18:55:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dKYdDMHdj1G5TN7Kva3P7aR/uA9oD0RLroQZg6ORXKWNO8fqne2Ddr7N9ghSuUJlOypdhcqKB4CBkqQjfa0II9Uq4LdeYHgI7WdxO3sMtOhLTiF2B2iobJ5tE1Gi0vuBlQW964j3EgHBPXHo48cy7B77e6WksQwKRC1izAXwfjVL7xme5UsX8mxwLTvQlD5X/FLa4zRcNwxI6y1zxyHdABP050ocAkIFPjngMcrGPF4m/MN1bgL5LyBKiY9FqNwHIYROK9N6DLA7mtVfaptjrqMAkpvfRK/JsddMdi2cXkwFTjHguQ63GZvmKsHAuS/JL/ZmZzX5IA8WYuU0cizjOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hpJZ2DE8HcMnOqDub0yyHqy2PlOk+6PiGz98R0/Jz98=; b=oGBRtUra0W92Cdq6E3+paDt0XdbnNJ2HsJc4xLVOh8iarQTz1vkZPNP+U9pXFr/nuO2mEq2wbkBGYp3ERx4ERY1O9Z20ahozxOgrlshH4O0Sob7t4Z0f9aDNgmooVXsWcRvXY345EGc+8u7dOwLbLknMC7kIRJyvMkXPx6Rk1OLhJHo3JNmM4CjQR1I4touhiKiAbKCKZeAKRxL1S8ZpU0PIeOSLuiG9myUfdASrL5YQAtCJVkrcE9dJwgETIXmykFPXdndUNbH9TnrNHY9JYp7USooJD2uNK+oVwKBeNMO88tQ/8hbMecS/n9sBZSyzVDX0UHUpLaGIDtBDzFuBwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SA1PR11MB6824.namprd11.prod.outlook.com (2603:10b6:806:29e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Wed, 3 Jan 2024 02:55:00 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::fc91:526:bead:4f73]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::fc91:526:bead:4f73%4]) with mapi id 15.20.7135.023; Wed, 3 Jan 2024 02:54:59 +0000 From: "Zhang, Qi Z" To: "Ye, MingjinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Ye, MingjinX" , "Wu, Wenjun1" , "Zhang, Yuying" , "Xing, Beilei" , "Su, Simei" , "Wu, Jingjing" Subject: RE: [PATCH v7 2/2] net/iavf: add diagnostic support in TX path Thread-Topic: [PATCH v7 2/2] net/iavf: add diagnostic support in TX path Thread-Index: AQHaPWyRrWqbtSHbfE6QVqY9xH6fXbDHY/Og Date: Wed, 3 Jan 2024 02:54:59 +0000 Message-ID: References: <20231229101104.2167028-2-mingjinx.ye@intel.com> <20240102105211.788819-1-mingjinx.ye@intel.com> <20240102105211.788819-3-mingjinx.ye@intel.com> In-Reply-To: <20240102105211.788819-3-mingjinx.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SA1PR11MB6824:EE_ x-ms-office365-filtering-correlation-id: 71e3f2b4-ada6-428c-a14b-08dc0c07601c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GLUKV21C9vy0ijQwtRnaxQ5ROO7d/K+BwEofyGx5/rjYKdbpuPxkPA/TkJvoaUkE0gV8hpzrniWeT2qb9trfBEgrnHN2nrdaBrwDp4xW5KQCPe3/YNvq3b33e2P/SrbrTBDpE18C51wpt2wp3MYF21VCl8TXBk2sXVqfI1kqd1Np8oTN8MNRAzxCH9TY+bQln5ijwnjFk7+KTZKSqBSq3t1uq/ZTZ3y9piXo45VODRImGWRTVKNyo34sT/pWPbMVBhGNz2swYOLJK92dw1sshpzVFTHHT/RSKyFqCpiA8Br2NbWNJcCInWjS1x6ir/bU97h4iXnYzecwhFrwqjd8Lpg7dKHZGoyfmpwVhwC6/7g3O+dTbAA4fzXf1/G07TA6VDb+IVgWGN/wSu9mF1vn1sVityxVZzMekc9EqL385aZw1eL27CwnFO4mztkNvGRHIZ5ATsK2V8iWjmOKksyA86amnObwbgX8rPTNI7ZaZY7Xp4ZkgfduS32YYP5mfJ2s695oC0GEi8pLjVRR1CYYVy06bAbYvXroxNiSY/MubnIVs5BpLpYHRZryvMq00uoVN34cQ2y7xOjj4EQDEZs198bgXSEw+lGZnZBOp5sHAZJMyagxijQ3MF5I2PXMCkT0 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(39860400002)(136003)(366004)(376002)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(8676002)(478600001)(316002)(8936002)(4326008)(110136005)(66476007)(64756008)(66556008)(83380400001)(76116006)(66946007)(66446008)(9686003)(71200400001)(6506007)(7696005)(53546011)(26005)(54906003)(52536014)(2906002)(41300700001)(5660300002)(33656002)(107886003)(38070700009)(122000001)(38100700002)(82960400001)(86362001)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FLZKEPo083SDS2LC3RQnbpofjv0roXrZ+TVrPK025CQyVKuGvyw4EqnjeuAx?= =?us-ascii?Q?G+mb5vcn4SnSSFWW1n+02kUjgps1afhcKP5wuD/xaqL0dxnKSrhA7hM8KvUV?= =?us-ascii?Q?fexmonMlhp4GTIrpIv8WUnpYkchY39VuZi4WIqkXy2ZxTJQZ+oMTPux9lqfq?= =?us-ascii?Q?Q8uIlCqFOLo+SztTbGzJHH0CrGKCE6VOj63WQfYAMj7wdeWVlDuwfhIMYc0D?= =?us-ascii?Q?8Djlmqlmqb7ylNpLfLIOVgZq5m/MWOYMRCbqjm5rUUoDzHl4e/A5uALzvkgU?= =?us-ascii?Q?C4EdWfG0hWJ+CZjXAIRQ4XlOTF7uZrHm7xcRb+16+CHJoH8jLBttbj3sTSXh?= =?us-ascii?Q?L3XVNR9mWTqUrLDBuxUom70GAEG3Z4K6Sy1UNuHTQYKAj4NuSaACepr/waWO?= =?us-ascii?Q?CH1Lf+FMbPa2FGcZTz1pSUs1PPFzjUlW/YQtqcoP6fY+WXfbbPDwFCA33DSC?= =?us-ascii?Q?wxxl22HKdLDFCJF2sZV5Jx0Iv6sPKRUNuEnHvlrMttaZrv36k+Y1RDug4vE8?= =?us-ascii?Q?/smA2iDD22Nn6qA4C7fwo0XjA3N6+d1msBgx3z02SRt82yd+U0zkwV13HV2U?= =?us-ascii?Q?4a73SX6UCWNRwnGb3Mk2ETSvLeK6l7BPqL/GhSTiTr/AT9rP8Fso3sKVDzSm?= =?us-ascii?Q?Ex5IIQroxl37+SGXHhwUsOG90zIuSfU7+G7YSLGsykUWv8LglE1phpSiFRa8?= =?us-ascii?Q?kJNnxXCweOKxaqRujL1ve1UrbLNt7OSFpZanzqhknaYM/RVoaBFm/JqPzrDe?= =?us-ascii?Q?4GuS+5RUwl3HEWCnB1qmu2rMr+/fKtSqjGMDeDwz91K7sdOyHX1rfBpg8Mr1?= =?us-ascii?Q?vFaQIqNr2gZSlFLuzAtAsNxUIsDFv9wa0VOGTJcYmCWCpFFg5zsYo41I+CsJ?= =?us-ascii?Q?bQzgOf5hkY/ZygvjWOIJq/2FwmbkD961u5cmOduxnrHfePdkXvZxa93pChj3?= =?us-ascii?Q?zKZbSH5E6bHqvpoRYfF2iAMHx/dxUTPpiMw2EfPrfGuz9X/YCFBp0gshn460?= =?us-ascii?Q?ccJeOqeFE7FxAJh7bQNBW0MCMjsoac50Tu69tlQcoqZtx88z8K8U6uD3YLbo?= =?us-ascii?Q?P3NBkBSO0DDwfdTdahAR6XWRtEKL9heDQhF55zCHuMPajHvcH19uocYbEMXP?= =?us-ascii?Q?OMRMzGhSL0o2BOMQaEvaHboYeerp2nLGvX24Yq/2jPpv1CA70D5vuaFGzS4H?= =?us-ascii?Q?3g9tLI39imErG+D2eRX7LuhIDhYBzNTtR8Bj3oZ+lBF+yNg8o/aXk4Vtu9gy?= =?us-ascii?Q?/aVw4+y0IBOT7swuQDDGlq3w/NAI46XmMaofENaPEWjBMtdLZWuJEU3vHzFM?= =?us-ascii?Q?xuGllG6iWWlt2rFsv8NTNCB60Riinr/3Lnq8EnPbtSPA0gbza3FBcHY73x6r?= =?us-ascii?Q?e8o9jqMO8SeJKhfQICg8njiDxEfp+vyKN5URw5DD28CeIjbnobcfDJZJqzZa?= =?us-ascii?Q?CJeftOIe77CJ68BMcHf8xuePZuZ1hL7BZNkKTV482M581QipS49H79qgfFSj?= =?us-ascii?Q?ww9H4SacMqO2QBsrJlqobwySZujNTWyiiJOlszmygOscKPeXGFeDU6zW/2SJ?= =?us-ascii?Q?FKBEtQoNry+o/icuRWhrOJHsqs3d5PPJw+p/tw+x?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71e3f2b4-ada6-428c-a14b-08dc0c07601c X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2024 02:54:59.6058 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9zfgxH2YMKsMdggKn5FT9gbew3NB/9hUTfHtSKqwCzOimUjnYwZOsccHyMwTeuAGShKM4AjuQlfnNoMAZ7fHLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6824 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Mingjin Ye > Sent: Tuesday, January 2, 2024 6:52 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Ye, MingjinX > ; Wu, Wenjun1 ; Zhang, > Yuying ; Xing, Beilei ; Su= , > Simei ; Wu, Jingjing > Subject: [PATCH v7 2/2] net/iavf: add diagnostic support in TX path >=20 > The only way to enable diagnostics for TX paths is to modify the applicat= ion > source code. Making it difficult to diagnose faults. >=20 > In this patch, the devarg option "mbuf_check" is introduced and the > parameters are configured to enable the corresponding diagnostics. >=20 > supported cases: mbuf, size, segment, offload. > 1. mbuf: check for corrupted mbuf. > 2. size: check min/max packet length according to hw spec. > 3. segment: check number of mbuf segments not exceed hw limitation. > 4. offload: check any unsupported offload flag. >=20 > parameter format: mbuf_check=3D[mbuf,,] > eg: dpdk-testpmd -a 0000:81:01.0,mbuf_check=3D[mbuf,size] -- -i >=20 > Signed-off-by: Mingjin Ye > --- > v2: Remove call chain. > --- > v3: Optimisation implementation. > --- > v4: Fix Windows os compilation error. > --- > v5: Split Patch. > --- > v6: remove strict. > --- > doc/guides/nics/intel_vf.rst | 4 ++ > drivers/net/iavf/iavf.h | 12 +++++ > drivers/net/iavf/iavf_ethdev.c | 72 +++++++++++++++++++++++++ > drivers/net/iavf/iavf_rxtx.c | 98 ++++++++++++++++++++++++++++++++++ > drivers/net/iavf/iavf_rxtx.h | 2 + > 5 files changed, 188 insertions(+) >=20 > diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst = index > ad08198f0f..8e39bc831c 100644 > --- a/doc/guides/nics/intel_vf.rst > +++ b/doc/guides/nics/intel_vf.rst > @@ -111,6 +111,10 @@ For more detail on SR-IOV, please refer to the > following documents: > by setting the ``devargs`` parameter like ``-a 18:01.0,no-poll-on-li= nk- > down=3D1`` > when IAVF is backed by an Intel\ |reg| E810 device or an Intel\ |reg= | 700 > Series Ethernet device. >=20 > + Enable mbuf check for Tx diagnostics by setting the devargs paramete= r > like > + ``-a 18:01.0,mbuf_check=3D[mbuf,,]`` when IAVF is back= ed > by an > + Intel\ |reg| E810 device or an Intel\ |reg| 700 Series Ethernet devi= ce. > + Please list all the options with descriptions which you already have them i= n the commit log. Its necessary for user to understand the detail about how to use the devarg= from document.