From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1D7F41BE4; Mon, 6 Feb 2023 03:58:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B2BD40A7D; Mon, 6 Feb 2023 03:58:47 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id CE6C4406A2 for ; Mon, 6 Feb 2023 03:58:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675652325; x=1707188325; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=cZOaLP9fz4EOVw3WGQe6DXpNUOlSdT/rpF5oQZsvq/0=; b=Rj8vQYfa1jTGb3cy2WMJcZShkrnuDH27pwFIufAgrRANCziAGJY08M8W 9b4+mm8GRbbpAcUmihskRCDn+glwFpSroCqVypi+TYNONPwo7mRmAG7hH 07qRAJXujgrq2WiNbfRJ8+WSvJ1/O1aQDu+5cHFd9BAkveDbLeAqLZW78 vtOiaKytSVsuy4813HB3PPEh1bDTFZWD+p3LGOTnXvh9Tv+6g3G05aYKP At1pjigUwRJ4qwyeeKBh2SCucRT7Yqh8DkCf3RfyBZcN26sHbpjgi0Aax lJ/bVYnftAZCZabqyxFJjyUe4pr8uhZCG6UHrIyQk2heSndHc2eUmHWq5 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="391516987" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="391516987" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2023 18:58:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="729871283" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="729871283" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 05 Feb 2023 18:58:44 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 5 Feb 2023 18:58:44 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 5 Feb 2023 18:58:44 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 5 Feb 2023 18:58:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QmBKMRAr9fcsbz2o5WVrmu0egrOmuOmhkXDNj3xJtI62C3sbFPwweXjqSr2oFyAbRrr1g1jhRCUd+4Ehn1XaPf7F1Nvb2+SjYuRRY/f5N7Il6VSFyJxOGhEixb3kuS42YPaDQcJn3nrpAGwEwkO6r7dQ/mH1KC61aLc7d02JjN2BilYiIOeVxSE6E+x5vIAN0Om02DYVs4OGVZJ4mVwVMK3UefoW5eT1wCIEw9G9uvV3ycse8KUkMlbHY3S01I1joQ/i32+ejcqJlqeMVFtY7GVVdSs5Koni8LbJ/9Av/nl8zNANCIHL09O+ZM9vz8/iQEz7cvhLA8H47IRVxeLMzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kW8PNSgDu9Vj2I+wMwVCS+2XcOFzdTcrpcUyqoubIMs=; b=b70xT/kGrCK83gl+DTIqOeou+Nlbvan8qO9+tGjgg8yZfKrfoPo9j2Br1IvF/c8zOh1Dxqv+ubTUr9T1B7tkP8bNgwTh7HlPOCbgxtfjlLau6EX9zrcd9NhlcH87/a69yXknQ9P6drgBU2SpjNg2Lw6Ki0RDMUkYLCzRPD8xGALeirG7tA7zSNShT5VEQfYnqM0zsoMsqhdQ47VNv8UrINecWVUfNkID+W5z+WAWTD1MByYj9jdorxK0m2dY2jBqo8HGZY0JgAVSSDTcnQBqvhfnFveJUDXhujVoFqDoQhA6NIMqDM68pRqBwx/yEANC4VV5nQWYT14GqEOC0t5GZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CO1PR11MB4865.namprd11.prod.outlook.com (2603:10b6:303:9c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 02:58:43 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::eb70:80e0:1b88:3ca5]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::eb70:80e0:1b88:3ca5%9]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 02:58:43 +0000 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Wu, Jingjing" CC: "dev@dpdk.org" Subject: RE: [PATCH v6 00/19] net/idpf: introduce idpf common modle Thread-Topic: [PATCH v6 00/19] net/idpf: introduce idpf common modle Thread-Index: AQHZN7e6xUJaat1UEUmlgJzjZ3zz/q7BPVsA Date: Mon, 6 Feb 2023 02:58:42 +0000 Message-ID: References: <20230202095357.37929-1-beilei.xing@intel.com> <20230203094340.8103-1-beilei.xing@intel.com> In-Reply-To: <20230203094340.8103-1-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|CO1PR11MB4865:EE_ x-ms-office365-filtering-correlation-id: bc946cec-6484-4aa5-d139-08db07ee0e77 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /rpcmXLkhF+Sjmo8n602XBzzqchM3T/JDMg4LCeWcDbaM9OWZpuj/RMaWO6a54tEZpLOPV7+hRgPCs413vofOxQ1Iv6LuTaRB0Y40EpzC2r3ixKnofX9jeGDwX+BYRnYzJbyb0ABIR0ZWJpNrw/OnfLcpmHyrnQbQY8g6g7xLlbFuL8IWAR4wZEsMYYEXdyhh3+gzpitP+Li2PVGWJv2JX3lmsk8uLygjLFouiAI0Jnio1eBB8XW2Iy9tAE2JnrBW2GotwOLVjyBvkw/uzsWH9A97HcUy+qkAqNPPSoFudnaLSZapf92A6GIfivJr2u1ruos1h8efF71/nf0kGgzUOZGuM2x6bZDUjH2VV34ub3da2GmVrp6GSuZSGn+T+1HAu5ARgoMEcLExMeaFi+hYpLeKUDEvxndPc12OL898uaGV8vS0lFlYpl/BTEO+atLLzOS4Hucpc81BDsHK8oe2DfW9z9QScMeEtn12TQnJI4n/twLwF/ZcWVHaKXUeNXJT+2Gmbzivqcfw7vBWurtFojxB7Wi/cPCoSR1SBfH+pcSufbO0NdfgiuP4IhilK2YJ4qDO1d6OhZQrdmFfKjPmbf3wC8+w92ZdoihhonNcAOHed96AeT37Aq7jpTp4EikS3tVZavYU/819YDMy62G7dgY7hE42NxxhbDlnRLT/jafGPDTrTr5lXonwh8nE1tyA1Ckq2VUnQxiBm0dRnmb4A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(136003)(366004)(346002)(396003)(376002)(451199018)(71200400001)(316002)(478600001)(7696005)(110136005)(6636002)(53546011)(6506007)(5660300002)(52536014)(26005)(186003)(9686003)(33656002)(86362001)(38100700002)(122000001)(82960400001)(55016003)(38070700005)(83380400001)(66946007)(76116006)(8676002)(4326008)(2906002)(64756008)(66556008)(66476007)(8936002)(41300700001)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mwtlNUgum6i4UctT9O3FvJKkWBY1ltaqWb7UkK3hARVME/fmuG5gq29jm8XI?= =?us-ascii?Q?gIQCLotaJlB9hl3Mw6XLYFmc5FErdAnxEeMdcz+qqb8l5NKjUAe2D+xN+jm1?= =?us-ascii?Q?TlPcaFe1LPKqFTxdS+dTmcxK8klV/f1sgr/uEEETRzunRHHjDq9VYDnDIqZO?= =?us-ascii?Q?tAld30CxJYUy/Wy2SWr5aSc8dl8N5Vhw5VcfkphgrKZz1Knv9rQad+KfwJL1?= =?us-ascii?Q?fAk2Fl5F2lEMfb6RBYLrTtQDvrHvUBe7K85F5UvlUZUebrOWEMKM4dGVowlW?= =?us-ascii?Q?kTdY+E4AYEeoZe66PImq3+P4tjQByQOFYMoSb+xBtW2itMpmk4OaQZtaJmIL?= =?us-ascii?Q?eUNBzRSv4SWjSxU6kwwMz+c3ZR4hWxH4e4R9GufK/WWY1ZDnHE013qosMvL9?= =?us-ascii?Q?UD9567hgbMwaGN37JKaiXxphadCWmNAAS/P+MKMK/5avNpeBk6nVpQkNYuBs?= =?us-ascii?Q?5LhL7UipL/3g23flwCPryvCqG4RTi/krQuYvcn5J04rDp5WbdS/ZewA212CD?= =?us-ascii?Q?pux3h/9WiGHuS2SVTT1vT/blcQAdzJfEiMu0R2TM+k6GJ0n2hVH4oab4RNfk?= =?us-ascii?Q?mb450KOvar9WqS1Ij9luPy7KEF+fjWBID+hgxVHoQZLcyD6PHCRSVyKTONxj?= =?us-ascii?Q?jaU2G6qXUH9RVSLTPFbGFm/3Gq5vXczkDT0h4WkPP5qi1PiTEOLgkurmxX/o?= =?us-ascii?Q?gmPTUNPDxt3bJIu6pXgGnsSy7NaSzxJdJUUc7kqUfZgkD5HZnQJVbKMFwA4g?= =?us-ascii?Q?W/6dwQk0UCvzNdVqmtVLZXvPbqXcd6+1KmiXLKKIZIAMW5MmOPrWzsH340VP?= =?us-ascii?Q?HU7ui91N+WnQsgxPfb7UmUjVaJtWkMMGrEPAwHppvaK3TQY/GxNK48EA7Vzd?= =?us-ascii?Q?b7l5ItwjYnyeugubyvc0bDUGtW1oET5Nichqy40SXRQ4P5NlxxB32cH/Y6US?= =?us-ascii?Q?0ONbvhT61pDOVIQeJeF9CfNU0WEKDBSgGIGIMnEDOrwVxsyY5OmFp7/7wWx5?= =?us-ascii?Q?fDRicqapxB/Os05EyLbI61FBcJj3XH/eJY1hcqBrkCzjsWwelsd95Xlp06yB?= =?us-ascii?Q?MggqxzkVrNpuk09smrAZRy6qmSOjNSUIqxKx2fjqCc9FuMS8z5zJXbMY4dw9?= =?us-ascii?Q?laXOnIQ+y0cFNsprz1cOQv6S6Zl7hdzI5CLS4iKhrrAFcjUl3qXLGl7331qt?= =?us-ascii?Q?Ra3Ses0NPQ3E5g7ycTKCUYHeUzmNsObFe5nDfchpwDrOd4+Ea4C6jWoOpOyo?= =?us-ascii?Q?tGLUszPPQfQSS2oibUBdruMSuTtSGReeMMTq2plKg0OxUStK7JZQ04WIAFcW?= =?us-ascii?Q?IfaB0amio3N98LWdy7XzkfhGTDcP5r2KASan0ykut7QDOOLiQ4Nh3g/NQHG+?= =?us-ascii?Q?eieAZS5OLMDXRIYgB/LY34mXHaaGKPkjytwMZXwtpuwtNTjvlXkDXHhYPsBM?= =?us-ascii?Q?IzG7V8Hytub4Y0FYJ0Zo7YTkqRCa97Qmj+P5LZZV8lWGrhHn2sG4jROOmazF?= =?us-ascii?Q?kj7C+mVBPzWIuuCIqA7dKX76ip53d5q3wtlpWOzUpqzWBjpUYK+nKAV7Y8t/?= =?us-ascii?Q?YqELFMI0WtTv2vkrX0yNJisPsvBMeyfUsitIXhRq?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc946cec-6484-4aa5-d139-08db07ee0e77 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2023 02:58:42.8776 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r/gPWJIdV013Dn6mfriHHdWPyltv2tI/+pWRrUtkQqafqFWhVZ0WhcQzqB81CaDEYjBiK44DZomuHBu0WxOupQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4865 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xing, Beilei > Sent: Friday, February 3, 2023 5:43 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > > Subject: [PATCH v6 00/19] net/idpf: introduce idpf common modle >=20 > From: Beilei Xing >=20 > Refactor idpf pmd by introducing idpf common module, which will be also > consumed by a new PMD - CPFL (Control Plane Function Library) PMD. >=20 > v2 changes: > - Refine irq map/unmap functions. > - Fix cross compile issue. > v3 changes: > - Embed vport_info field into the vport structure. > - Refine APIs' name and order in version.map. > - Refine commit log. > v4 changes: > - Refine commit log. > v5 changes: > - Refine version.map. > - Fix typo. > - Return error log. > v6 changes: > - Refine API name in common module. >=20 > Beilei Xing (19): > common/idpf: add adapter structure > common/idpf: add vport structure > common/idpf: add virtual channel functions > common/idpf: introduce adapter init and deinit > common/idpf: add vport init/deinit > common/idpf: add config RSS > common/idpf: add irq map/unmap > common/idpf: support get packet type > common/idpf: add vport info initialization > common/idpf: add vector flags in vport > common/idpf: add rxq and txq struct > common/idpf: add help functions for queue setup and release > common/idpf: add Rx and Tx data path > common/idpf: add vec queue setup > common/idpf: add avx512 for single queue model > common/idpf: refine API name for vport functions > common/idpf: refine API name for queue config module > common/idpf: refine API name for data path module > common/idpf: refine API name for virtual channel functions >=20 > drivers/common/idpf/base/idpf_controlq_api.h | 6 - > drivers/common/idpf/base/meson.build | 2 +- > drivers/common/idpf/idpf_common_device.c | 655 +++++ > drivers/common/idpf/idpf_common_device.h | 195 ++ > drivers/common/idpf/idpf_common_logs.h | 47 + > drivers/common/idpf/idpf_common_rxtx.c | 1458 ++++++++++++ > drivers/common/idpf/idpf_common_rxtx.h | 278 +++ > .../idpf/idpf_common_rxtx_avx512.c} | 24 +- > .../idpf/idpf_common_virtchnl.c} | 945 ++------ > drivers/common/idpf/idpf_common_virtchnl.h | 52 + > drivers/common/idpf/meson.build | 38 + > drivers/common/idpf/version.map | 61 +- > drivers/net/idpf/idpf_ethdev.c | 552 +---- > drivers/net/idpf/idpf_ethdev.h | 194 +- > drivers/net/idpf/idpf_logs.h | 24 - > drivers/net/idpf/idpf_rxtx.c | 2107 +++-------------- > drivers/net/idpf/idpf_rxtx.h | 253 +- > drivers/net/idpf/meson.build | 18 - > 18 files changed, 3442 insertions(+), 3467 deletions(-) create mode 100= 644 > drivers/common/idpf/idpf_common_device.c > create mode 100644 drivers/common/idpf/idpf_common_device.h > create mode 100644 drivers/common/idpf/idpf_common_logs.h > create mode 100644 drivers/common/idpf/idpf_common_rxtx.c > create mode 100644 drivers/common/idpf/idpf_common_rxtx.h > rename drivers/{net/idpf/idpf_rxtx_vec_avx512.c =3D> > common/idpf/idpf_common_rxtx_avx512.c} (97%) rename > drivers/{net/idpf/idpf_vchnl.c =3D> common/idpf/idpf_common_virtchnl.c} > (52%) create mode 100644 drivers/common/idpf/idpf_common_virtchnl.h >=20 > -- > 2.26.2=09 Overall looks good to me, just couple thing need to fix 1. fix copy right date to 2023 2. fix some meson build , you can use devtools/check-meson.py to check the = warning.