From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 690A342D94; Fri, 30 Jun 2023 11:08:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4231E406B5; Fri, 30 Jun 2023 11:08:23 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 718FB4021F for ; Fri, 30 Jun 2023 11:08:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688116101; x=1719652101; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=dGE8wvnreKER5bi49IUo5jMzAbmL+DSIPGAOlg48R1k=; b=HBfofiZLcOvG0q7A6s2Vq/yjb9DQEy7ild8+Q+GQhM6PzI6nxDQHzk0J Q3+QpxHhLVszIB8kTlxBze7+RIpyiRiW7J/hReqbuxyIu2u+L4qVbW8Sf 8U3GQ5M/aqihDoIFZgUTVP/ozZy9eE5aU9piS04baabVh1Y6JdU96LAIV /NUHhL7bdnaWXSu4kNQpMA1a64NWy7rLfoXOsgZClgI6M/mF8DARvcFQT BeON9ISs15698MUOzfl3f9/H7KADNnuHv8HLb4G3uEgBCiLAqhVHdqGST f6Ed9cP01VknhBNGS6MS6G9Ic89JqH6VhVM9Ol91lDG18/2eIwsyikOeR g==; X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="362392293" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="362392293" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2023 02:08:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="711759588" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="711759588" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 30 Jun 2023 02:08:20 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 30 Jun 2023 02:08:19 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 30 Jun 2023 02:08:19 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 30 Jun 2023 02:08:19 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 30 Jun 2023 02:08:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q5xrIkCF2WRu5fIjf+khbvW617mhgowbHM+fBGcjgzwsXVDbcOrZutl4ZfkumVcU9JhLts4FBZmFVqC4JA7DOC34MiIkSBk7onfObElVf1WYvQebYbx6d/OcyQva/qW1arFtM+TyI6XRqbSvHQJD1f1HqPmsoi1QgjI2VLoUYTS1VT7MB1ssT6OgZVkBS0WxsPGajWsK3Z205YaMchQULI4YeOriF0u3hGQevkqmoKFLAi3K9RAbWKn1BilGs5QeLNJTnmIoILl+J4M96ozKghSa/0tgdYhTavE0AWcbV6cQZ8vuwCpI85YxZPkevWOHf6tNJ1lPkhNaFFNWooRSyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q4yWRWaJ34moJn7NHdLzNx5YFClXtyrVoopo5M5KiLI=; b=jG1QY98RASdZ7iwg+aXW5Ldz8sBQoQMkunU4+tbxAJFVELQw6WFbyraNNZpjeh+N6Y1IKfmwBz4al+OGFCLwIL1lvh48AjPQg+xw4evOYoSUh5DS/OOYMQI5K93G/yyD9JD7H3m3nOjyOZ/r9LnH0+r0i8LI7uO/suspLaAepBs3Fve1/O2HVkIVSSszWv9Zeldhp2+ZvtFeXlxXzqDWataJMjwcYzpvQtupwdF88bdyCxUBkdveLYjGckOBLSnnTIW9uDpcActDVcWcRX0CCjsRgIMDnlI8pwH8LGc0JMxZxQcuvWCk96oURTS9iHH2D56+6snenr/IEEy/Kl6K5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by IA0PR11MB8379.namprd11.prod.outlook.com (2603:10b6:208:488::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Fri, 30 Jun 2023 09:08:15 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6521.024; Fri, 30 Jun 2023 09:08:15 +0000 From: "Zhang, Qi Z" To: "Liu, Mingxia" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Xing, Beilei" , "Liu, Mingxia" Subject: RE: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF PMD Thread-Topic: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF PMD Thread-Index: AQHZp/HrxF3oXO7Zx0Gzkmx82Ht+XK+jD+SQ Date: Fri, 30 Jun 2023 09:08:15 +0000 Message-ID: References: <20230626140626.490896-1-mingxia.liu@intel.com> In-Reply-To: <20230626140626.490896-1-mingxia.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|IA0PR11MB8379:EE_ x-ms-office365-filtering-correlation-id: b0fc0b4c-35f9-42bb-566f-08db794989cf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q1jZRN+ZDPuqY9osTcvAb24+z8FrkHguXraGrBuvkfC5fiX+tb/7o5+FR+nv5Vt4IzvOe7aaDUrRnAuCy5PelibHyBYbw42VCdWYaYuvmyUn1ApAMd+B/x2swRsQHYTL7CRNF41IxzHeRW85aBuwjHkJA5fL8PBixgYtTRGTdjfSfVHsXe5IcgFbNPEDLG3eG3K92N/ZGZvGCWzHjeyuqwoVsVL4sJC04alQ63TSETztZ+bwJKOLuW1/VJq82c/g5jWYH0DTwXy93BzxjOjvUskaKomlGfGw5DHBTKaT5EhdTEeleNQQjPXBd8R/HC1YiiBRBh3jk6sllN1MtgnwshOdJhROtlT7xvK+V/QLTxCwqJUzlZZF+TlAZaxfjBMgevLKHGrI6/KRrenRt3ZkCd3w5P74DuMjK07Q43is3bPYUP9scfzBEMZyXy2COzTf1T7UxZR9cfXXHr3nxCUwUYI9y3byN2fHoiu/MMOjq+FNZEL7FjI1dpuMXNPH78q57kcA9aJbvczTn0mAodacw6PpWwetam21uoJCg6X+4ALDRJB1ckdN6daw/k1/smXB5/O+ZZ6sDrhE51q7mZ+c5ncxC+XGqxgHDWYxeAE0zxqeraHKQkhTTaV647el1Mfh x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(366004)(346002)(396003)(376002)(39860400002)(451199021)(7696005)(478600001)(71200400001)(33656002)(186003)(26005)(9686003)(53546011)(6506007)(83380400001)(82960400001)(38100700002)(122000001)(38070700005)(86362001)(107886003)(55016003)(4326008)(64756008)(76116006)(66946007)(66556008)(66476007)(66446008)(2906002)(316002)(5660300002)(8936002)(8676002)(41300700001)(52536014)(110136005)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d6wcg0SSxK/rKGytxbwFVnz4EfuBWWUNHW2EPhddtvJlq1J7eStytCh7ruUM?= =?us-ascii?Q?ILFkGvaUnzeel8K+8wSSZD2iET1cbWwzi6rdegE2dBX4bQrMTX41WfikXzjh?= =?us-ascii?Q?yFWX5kJpVv9R5VBYNT4WswvFPy0ZWHopX7uTe0J2k8r2K/c5xM7SgtCJeMUG?= =?us-ascii?Q?zSoFkJazmoWx2EFNA8CR/ACZnZawpojtRRoL7lXvAwJ/SOTQHW3KcWLbEJG+?= =?us-ascii?Q?7AhgwlvUVfATEibJruH3+mzE+KCphjDbcPvi+Z170jE0oF0TGFoM5dwE92ah?= =?us-ascii?Q?yErb9rvF9144v8sxFeBBDlgOtUwFNOkpUD4veqm/inROAZsQKS5sTx+Hlyo7?= =?us-ascii?Q?AZZI99mjBfIQsilO/zZsjTxe0BRaT6eJstPmV1cfJA2zjShBJxTbZGJvNTfd?= =?us-ascii?Q?NdLltbspypgimFP7SVgo1N0LAP6ngrKBLO1+zPtNSmSypj1hrrAypPEoqIkE?= =?us-ascii?Q?Wh3Uz0FPtXkK9gyvQkWacXsWxASjvFb3FxRVnoXtC3yrGG/yA+3HRIkxYaJk?= =?us-ascii?Q?B9xxxQNbyqTP0APjAMArPCpCma70FKrjgpwC05q+mL3/W7tB+GKbmMyLm8p/?= =?us-ascii?Q?t5kFm7aLAMasw4c9Hp12TSXStVockUtP2fjpjF3tOAFQVTfiUpGTLh4fXnwo?= =?us-ascii?Q?9LMAf0UhOgYal8bzx4QgobINZr6NfB9abUpJIxMX/LYCNPNSNCrnSv4pdmaD?= =?us-ascii?Q?Ensagjmkp4Owl8N7mKdHFubvc4nqSBsG2uG7rs3JhbgVNzxwbLlh4CMt7Yw0?= =?us-ascii?Q?vNtTdPOyMFA8jHe7Li03FUYt7W84TVE27Z2fbPT7QmeKa3qqn+7+Bq9UJ2Wu?= =?us-ascii?Q?vuvjR/QjzWbqGx00BOLeIyGqwoPTYZhaCm5kGdOpVq+A3Sql1HrAp0pw2ccG?= =?us-ascii?Q?0XMipoNrTcR1MPDcWiJkG4qyNVDjp4GoM91QKb++gTmusrzBbnvLkI7NoWzn?= =?us-ascii?Q?W5kGKb0eWTCAE7dIj0DreJFeNlREnoSmBpwm08vi5Uaaj5YgTgBZA2Ftlc76?= =?us-ascii?Q?Gqe6ovpn10TGHuFm+kt43Du3uEwD0sDNh3BDO8Iz6oKjqVStroRi1BLVZ9xe?= =?us-ascii?Q?aEOK3TikLjn4dKinz61hNEC+JKQ8du3qEpTlgpwhKHp1KW4GOHff3O6o1TK+?= =?us-ascii?Q?zuiQxvsVYvGnrIF+PIPdE75OW0io5hHBWe+Sm13X55saFtNo5twDrMD2idRP?= =?us-ascii?Q?GyIZsANN89pSn6FD0ytCbP/Y46LAIUq68MOJA7xOdb72Vc6HtZLHMIjzHj5Q?= =?us-ascii?Q?iChT3McBTKm4zTG4JiUTakY4JRy1P1tiAMGbHy0Xn2BND0nwr8rUqYeEc+4G?= =?us-ascii?Q?XEvV2nXygSVx2y+ZAtcIJHb0JEWtzsL8QTZTVfNyDWGvnMhiT0KT6cpgdXxX?= =?us-ascii?Q?9RjeUfm9Ruq0PfLSnr2zE0EnXeQ5H5+h+U+QAe4NlzOKMin1P7ITUEprywob?= =?us-ascii?Q?2jaC/zWL6qwCH4+z/eNiCXilxs1hDFnKoVbVylhFqnygGeNOzS7LvF4DS2Pi?= =?us-ascii?Q?3zCYzh9gGeuScW1kVyfeVYl6rZXzW4DTKbnfm4q3Mk9jbA9P5iCDHBKstgu2?= =?us-ascii?Q?+fzIs8MdK4wbQO2bxHK5Z/TtBRnTMWGtLCqHScN1?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0fc0b4c-35f9-42bb-566f-08db794989cf X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2023 09:08:15.4106 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EX+/l5YOafdR89//erhACLzXonk9vR/AxOjhWJem2YjnFxSLREL3/xVakOaMsaopJfc6yFo+3TsdGVxoHTDOSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8379 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Mingxia Liu > Sent: Monday, June 26, 2023 10:06 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei ; > Liu, Mingxia > Subject: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF > PMD No need to mention the PMD in the title as its duplicate with the prefix. How about=20 net/idpf: refine vport parameter string >=20 > This patch refines 'IDPF_VPORT' param string in > 'RTE_PMD_REGISTER_PARAM_STRING'. >=20 > Signed-off-by: Mingxia Liu > --- > drivers/net/idpf/idpf_ethdev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethde= v.c > index 3e66898aaf..34ca5909f1 100644 > --- a/drivers/net/idpf/idpf_ethdev.c > +++ b/drivers/net/idpf/idpf_ethdev.c > @@ -1478,9 +1478,9 @@ RTE_PMD_REGISTER_PCI(net_idpf, rte_idpf_pmd); > RTE_PMD_REGISTER_PCI_TABLE(net_idpf, pci_id_idpf_map); > RTE_PMD_REGISTER_KMOD_DEP(net_idpf, "* igb_uio | vfio-pci"); > RTE_PMD_REGISTER_PARAM_STRING(net_idpf, > - IDPF_TX_SINGLE_Q "=3D<0|1> " > - IDPF_RX_SINGLE_Q "=3D<0|1> " > - IDPF_VPORT "=3D[vport_set0,[vport_set1],...]"); > + IDPF_TX_SINGLE_Q "=3D<0|1> " > + IDPF_RX_SINGLE_Q "=3D<0|1> " > + IDPF_VPORT > +"=3D[vport0_begin[-vport0_end][,vport1_begin[-vport1_end]][,..]]"); Better to use "<>" to wrap a symbol How about " [[-][,[-]][, ... ]]"? >=20 > RTE_LOG_REGISTER_SUFFIX(idpf_logtype_init, init, NOTICE); > RTE_LOG_REGISTER_SUFFIX(idpf_logtype_driver, driver, NOTICE); > -- > 2.34.1