From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17FFB43802; Wed, 3 Jan 2024 03:22:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE20E402EC; Wed, 3 Jan 2024 03:22:31 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 69BDF402A3 for ; Wed, 3 Jan 2024 03:22:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704248549; x=1735784549; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fW14biD+b5+01cT6md+IKusDZe3/Kl4HiHIEl1/AHDo=; b=Q5VoAthxcN9cnxkCFPrQ/DdpDPkU1n3/3ZMzVt+hXbUlbgFQMONRmMKA UY+R7HkFlXHqyt9HdhzHGw35UgTsplqnRRJwg0yf949S0MgHQELQX3xHd WeV/si3y+BhH84UjCxIAFalnJpIvXeCCMIWu1wbjTUPg2N9KdROs+eVbV l6iRkEozd8ExMajucn0smmzP1tiIJ6xYLuU33aI4Iqxv6LevtJvtCjflk 4AB0hP01yl7L8kGjp1iVRE8BCGEL+u5oHECcvIhJ4RNSlhmekknBFZ4pd CfEP7b1afm6Jb7z2bUM4KEPdC2D7Pgv1CIKYEmVuCV71PzI1qkLItxb1I Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="461258954" X-IronPort-AV: E=Sophos;i="6.04,326,1695711600"; d="scan'208";a="461258954" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2024 18:22:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="1111217290" X-IronPort-AV: E=Sophos;i="6.04,326,1695711600"; d="scan'208";a="1111217290" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Jan 2024 18:22:25 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 2 Jan 2024 18:22:25 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 2 Jan 2024 18:22:25 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 2 Jan 2024 18:22:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cNkrl6R1BR5/Scyw82XlsyQ4fmH5UojuhzjQrkPbWyUm5FRhV39LgNVY2DaB/QgaKd3ACYw0UL4XHX7LurV/HaYM1Y6nxpF1Gh+8hnOckiC0H/o+wFRDIBq85iidzJpzDSsQWP8ic/HxgbLevwYphm7FZXkZr8Oofl7FKpDFess/EIUIa7rR3b/e4ZVTeDHKa11+hWeloyrGZXV+pkBTO3hKSFSCnCQuYhd55a/ZrNMaGmVJTNTUtuSKYdKtD9ks3bLr08pbvER9spLeSbVpqdw0ZDtQChhHb7vG02iJwQGg5FAS2dehqGfqJT5qsLXU/vI6j03jvNrz1vfOBFqxUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CzdYdebrHoe3Wt6sbwVbAThs8SNkTNXcvY/a76dSZIg=; b=eSsOa9Asc4zzTUgP6yMWvFcbHsstDW3wlxtQvOXuAn4dg7ULokvAKPvE6bNvaPXtkD5yRIqDjfTcHXZOsiymR8CiFGHCUZSS5GEweaghczLgI529lgB0xgNuBge+5YABKp89C+krP2Fx9PFb+ptH82S8z9tieHJyEjPHH6tAlSlvZCMpmZ96R6ZjHnwMNfmL4dX3ehm7IVzC0xlzA7u6VzrLVxdb6jr8ciyOuqYPVLoQZkFSzYCJBO67lTMmHHcz3UQLNsL0WhY+NikX1wHQ96tkfYIyJ3XtKzof6vnSXfFJxwKrCgkIMc2wx33lf9/UvBh/Ppyw+V4NugELoiwXdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by MN2PR11MB4583.namprd11.prod.outlook.com (2603:10b6:208:26a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Wed, 3 Jan 2024 02:22:20 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::fc91:526:bead:4f73]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::fc91:526:bead:4f73%4]) with mapi id 15.20.7135.023; Wed, 3 Jan 2024 02:22:20 +0000 From: "Zhang, Qi Z" To: "Ye, MingjinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Ye, MingjinX" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH v7 1/2] net/iavf: fix Rx/Tx burst in multi-process Thread-Topic: [PATCH v7 1/2] net/iavf: fix Rx/Tx burst in multi-process Thread-Index: AQHaPWx9e5o2oy3vxES9xvY/bNxAQrDHW1ag Date: Wed, 3 Jan 2024 02:22:20 +0000 Message-ID: References: <20231229101104.2167028-2-mingjinx.ye@intel.com> <20240102105211.788819-1-mingjinx.ye@intel.com> <20240102105211.788819-2-mingjinx.ye@intel.com> In-Reply-To: <20240102105211.788819-2-mingjinx.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|MN2PR11MB4583:EE_ x-ms-office365-filtering-correlation-id: 3d68f8bf-61e8-49fb-8f93-08dc0c02d06e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OuS2JFoQxjFG+Y8lic05ExabmJjOVDJsxRnEjVN0zYcUb835o3kL7LQPCYgFgO4+Uc+YxViqlmiTbRbxZZnAINhXBIuHZMxL5SFLRXWe8tD2aqap9BMn7z6+u5e/7mP/AsQkvAhV0VET9HbCkRaVphBcgBasVLCYO3QgjdLCJBQeClWXolK4ds2ySVVD+V3U+71XNFfmWCZGR2uIBag+wF+hvmxio9M1O9hu7vc1IuJLeZAAcbgB/cHDeBCwN636vTCdMkPsjim+N0IsSxgF5Z5NyWhD33rGNfd6vuBent8q00d8xZW/5mvvLetjT7ENLDbZDb9IQ0bWNDr4f9XPwsQw4EL0LiaEyoEDU2vcXyqal+9DtdbBlbn4sFAiTlr5GU6JZVIafgZYU7KvheLRWhTpXhakBZQEXRDu4N3LkhV/nnI1SucF/RY45KOXhacXR6fl/Rm0rtJYqjkVpuJAaOW1H45oloSvAMhuz5wuv3g3oPsMg/C109dF0gie9PUsPA0Tf6OINfPVbAa+0r1U/gM8WYMpwGUo3YQgijgCgxPq3h/HRvj8Sfbwik3iJN1DisnB6ttFzORwXdz7fnDaRNCpZvtgC3o+VnKVc5IfuJo1bGJeebN0Qp9KmqhMbKe7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(346002)(136003)(39860400002)(376002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(478600001)(53546011)(26005)(107886003)(82960400001)(38100700002)(122000001)(8936002)(52536014)(110136005)(54906003)(5660300002)(8676002)(450100002)(316002)(4326008)(2906002)(71200400001)(41300700001)(7696005)(83380400001)(64756008)(66476007)(66446008)(9686003)(76116006)(66556008)(6506007)(66946007)(33656002)(86362001)(38070700009)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BHEdXKAoOX5Z3CzJOGEGLbxvU1hiByudaP9ijRJxioUPIZTHNvvwwX8gFss8?= =?us-ascii?Q?E2m01gI096wgi0zOhImsg2HUbyujA9yYqsPWnwQfv4BzKp4hHy9sJY0oEK6q?= =?us-ascii?Q?1xMD76c+EFq73dRbB/2kTGcVtIKRMxi+8ckHj0a6tS0nsftULY2WHLKtSw8S?= =?us-ascii?Q?sUUOnbE6JM4iYeImm5dLQCAimDvwJ+PlE1vZncDH3pNE3kC0pmkCqYSf45j+?= =?us-ascii?Q?409G/onWSLk5ZbBa5uBWOvf9I1ClCbvfu9RuTxkfmuMDqwabOATg2eH1+9IE?= =?us-ascii?Q?Nh6EEnCmuslHUXjYH3mWuGbbwmFf89nhTZxQCqE8ZGMFoFVKTckABYfAGMob?= =?us-ascii?Q?KcSgDhR2Iuul0CdgXqxQ/uO05iFp2Uj6hTHI82bpVy3vrmgZxFvg73cqoZ9t?= =?us-ascii?Q?bD6QEwKgRoJ0gwFFDMzeUoNXE1Hs1aJxtqAOBABLENwgBNUkytPD4intlzJU?= =?us-ascii?Q?Rt+U7Fg+2soqh3zuzRl1N9x1UrCgdRgywO7TzzRHgz24L4ZHlEf4v8sID+M1?= =?us-ascii?Q?xHvuQ26aFeY2X2opSYY/zeOzcAsU0VpgLu9Z7qXaptLSfU4naaajPJrsWIZr?= =?us-ascii?Q?zSgJK/txeYRUqDe/qySLioaKMab/vOcnIb32qKjuMI7AE76phkjhmUV0HU7e?= =?us-ascii?Q?uJHHJWH39Y9VyxTpgwqxJDwYK/E2T7YL6EqqMdyCOc4/ssmEAvzbRmVQw9hJ?= =?us-ascii?Q?TIJfJ/qVkYSUwRUmdMBx9L6hvqcrUciA4im7d4UXmYB/l7lV1dBmTZKipkIt?= =?us-ascii?Q?48EcGSL2+Ylpl4auGvaht1Ha/pYGPv+oyH4lDcSckh/n38tBqr0r8ZF7SByH?= =?us-ascii?Q?CHy1jZ9fvIZHqMqC4h3iTo9FFuAEbMD5i/KOKH8os1HKCD72fn+NIn/XcQLr?= =?us-ascii?Q?dNA2qYpTaoKOCgxtNc5NXc/ahIpP42Xe+WGEYMC1OAuZfiouPb1+dNdfDkwF?= =?us-ascii?Q?C0mM6N5V/G9+BPqWM5EK1kYXeVnYkghAmtNHkK2REZGxUbLXiEiesJBhqTrM?= =?us-ascii?Q?P4R8j976KwDTWxq0X78AXq0Hbq9mtMfcGtUCQdfbMOn3O3x8sY2q74UOoZYU?= =?us-ascii?Q?l4O3aLmPYHxYbfkoAdI20sLPoYo57oKB68rLFS2TbpWgPYuXOeUomKNnqHfP?= =?us-ascii?Q?wXzdwOfH01DLBrwS7090m4PG6Mss2nHOUfMrcJ+AeWD6T5/IkjYf8CxBU/SU?= =?us-ascii?Q?DoSMgj5dqPybRfL9U1lsJpHlCgN9MDiMEPWPH32W3/AS7X6OVeRyM+cvzndY?= =?us-ascii?Q?JjczMNF6OTdkBTZMJLUvqz/fL37KAODrB2bAoUG7Vr6sjdlxyRpKp8+pIVhG?= =?us-ascii?Q?/g7P3ElqpS7qBAoygz1gRukst0lX3WA99sLMYYXNLB4yUi5rAihml0LeDIWP?= =?us-ascii?Q?ThRbrnmBad22RlOsQ/DtcTKiESTSim9DwbZtUjCKeNlyGkCBuCeoS9k0DK2F?= =?us-ascii?Q?FDDA27A6s6CyZFWCgVelL6MU1tXpOt/NBbFsNmT1+HRGa57I3rSncTBeE1PP?= =?us-ascii?Q?3kH7p9zO5vlIb3fP7SifmfjAsERBHKDd8gnXSkIyPwYegy3NvVnmjJZ5KvE+?= =?us-ascii?Q?bAZ7n+t95Nmn6latYu9NuoKmmFkUT/Damg8xG4ma?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d68f8bf-61e8-49fb-8f93-08dc0c02d06e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2024 02:22:20.5630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4l8PbZmjMitP63p4hynbt6m/Jvxy6ENDrUkGNvdqRAaegPFqyL8yKU3Dy7/DZOPOq9ioEejcZ0BhmLKhp/DcoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4583 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Mingjin Ye > Sent: Tuesday, January 2, 2024 6:52 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Ye, MingjinX > ; stable@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Subject: [PATCH v7 1/2] net/iavf: fix Rx/Tx burst in multi-process >=20 > In a multi-process environment, a secondary process operates on shared > memory and changes the function pointer of the primary process, resulting > in a crash when the primary process cannot find the function address duri= ng > an Rx/Tx burst. >=20 > Fixes: 5b3124a0a6ef ("net/iavf: support no polling when link down") > Cc: stable@dpdk.org >=20 > Signed-off-by: Mingjin Ye > --- > v2: Add fix for Rx burst. > --- > v3: fix Rx/Tx routing. > --- > drivers/net/iavf/iavf.h | 42 ++++++++- > drivers/net/iavf/iavf_rxtx.c | 173 +++++++++++++++++++++++------------ > 2 files changed, 157 insertions(+), 58 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h index > 10868f2c30..73a089c199 100644 > --- a/drivers/net/iavf/iavf.h > +++ b/drivers/net/iavf/iavf.h > @@ -313,6 +313,44 @@ struct iavf_devargs { >=20 > struct iavf_security_ctx; >=20 > +enum iavf_rx_burst_type { > + IAVF_RX_DEFAULT, > + IAVF_RX_FLEX_RXD, > + IAVF_RX_BULK_ALLOC, > + IAVF_RX_SCATTERED, > + IAVF_RX_SCATTERED_FLEX_RXD, > + IAVF_RX_SSE, > + IAVF_RX_AVX2, > + IAVF_RX_AVX2_OFFLOAD, > + IAVF_RX_SSE_FLEX_RXD, > + IAVF_RX_AVX2_FLEX_RXD, > + IAVF_RX_AVX2_FLEX_RXD_OFFLOAD, > + IAVF_RX_SSE_SCATTERED, > + IAVF_RX_AVX2_SCATTERED, > + IAVF_RX_AVX2_SCATTERED_OFFLOAD, > + IAVF_RX_SSE_SCATTERED_FLEX_RXD, > + IAVF_RX_AVX2_SCATTERED_FLEX_RXD, > + IAVF_RX_AVX2_SCATTERED_FLEX_RXD_OFFLOAD, > + IAVF_RX_AVX512, > + IAVF_RX_AVX512_OFFLOAD, > + IAVF_RX_AVX512_FLEX_RXD, > + IAVF_RX_AVX512_FLEX_RXD_OFFLOAD, > + IAVF_RX_AVX512_SCATTERED, > + IAVF_RX_AVX512_SCATTERED_OFFLOAD, > + IAVF_RX_AVX512_SCATTERED_FLEX_RXD, > + IAVF_RX_AVX512_SCATTERED_FLEX_RXD_OFFLOAD, > +}; > + > +enum iavf_tx_burst_type { > + IAVF_TX_DEFAULT, > + IAVF_TX_SSE, > + IAVF_TX_AVX2, > + IAVF_TX_AVX2_OFFLOAD, > + IAVF_TX_AVX512, > + IAVF_TX_AVX512_OFFLOAD, > + IAVF_TX_AVX512_CTX_OFFLOAD, > +}; > + > /* Structure to store private data for each VF instance. */ struct iavf= _adapter > { > struct iavf_hw hw; > @@ -328,8 +366,8 @@ struct iavf_adapter { > bool stopped; > bool closed; > bool no_poll; > - eth_rx_burst_t rx_pkt_burst; > - eth_tx_burst_t tx_pkt_burst; > + enum iavf_rx_burst_type rx_burst_type; > + enum iavf_tx_burst_type tx_burst_type; > uint16_t fdir_ref_cnt; > struct iavf_devargs devargs; > }; > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c = index > f19aa14646..13b932ad85 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -3707,15 +3707,68 @@ iavf_prep_pkts(__rte_unused void *tx_queue, > struct rte_mbuf **tx_pkts, > return i; > } >=20 > +static > +const eth_rx_burst_t iavf_rx_pkt_burst_ops[] =3D { Its will broke if we insert a new type without change the ops array. It's better to explicitly initial an array with index [IAVF_RX_DEFAULT] =3D iavf_recv_pkts, ....