From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DECEA424E5; Mon, 4 Sep 2023 03:15:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6B1D402AF; Mon, 4 Sep 2023 03:15:36 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 69AB4402B0; Mon, 4 Sep 2023 03:15:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693790135; x=1725326135; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4xNyr93s9TPpTBcscevaSzO7HfStjUO5xlJ/qKADPP0=; b=mBQ31jT1bmVrBi2EGFB4IVv4v+HKQacBUwoq7Ky7dI3kJWDq9502RJp2 j5McQ/EI6Tpx2kZAXL2+kBSIU6okvs1kqCIW7BcIQeiDeG/cF772Mc6UA rnZg0aCuLzLZg7t2pvKo6ACSmW6SkFtPR1bzRgc9N8nTPwH0z8bxl4A9x CuIBQDXyDZjZhIQBb/hUo1CDXXTs5q5w3eEc9oDi/wg2FIHEuOMlVS2G/ r1RwwQzMAZ9CV0M9DBTnfU1iIimcranSE26S+TuEIiBDVn+iNmrgBTNBk QCeLWz1jR/OAB25G20QR4QrrU0B50BsILSb2aK/gUfRdF50VWinhVX6MT A==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="376425898" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="376425898" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2023 18:15:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="864163702" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="864163702" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Sep 2023 18:15:33 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sun, 3 Sep 2023 18:15:33 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Sun, 3 Sep 2023 18:15:33 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Sun, 3 Sep 2023 18:15:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GC6agyOKzxquUrYPZl+NjneHk2lfx2t05Mc442PhmxHPXWirYmG0o8Ctzgo/ZWddf9K5jv39oxnh7xfRnCeqGrqWOjatxDvmZzDZRT1KlLiIO00QBkpc0uE1w0+P6fFCgzdekivmBjhS1dUvoSA7yITdESKTESqtlsqqksE9SopbPn2wy3BRa4IKwycKxInABS5tUFrJA/LtRd93Yj0/mGuUgwTI9R7KpMg4TJP2fU/pAv5zTMoMWCAHrSbgIKAZmcGV9F3WtG14ZDEY7Mny06Dp+EeRRsxicqBoMI3YtDKpTvcpAvZUGxX7oIB+H5GcKIPFMliTdHSk5kpmCKcnYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k6tT4PfDpZd8C78nsm3EM6QHIqT7EvnpT44FNGJSazc=; b=lb3ov02aIkG2yu+Rbq/tlxg5Pf3U9lFx30Oi+vEhlj9vPLgU+jDur9QDvrZ5S3gFWxLhJoHvJSyMt8NeCQrouU1Bu2n6eyL4FXy7DA+b6Q9j6hi2UICLzr/1j0W7MDEpF8J0GBYQncu0M4zIXDC7ZuhycmN9OKWMo+TY0bYxF922XxuKeO77S9IFCN3K2bzuDd+O5Wv9oGDRJmRFD8duFgmgNsYCl5zkiFC9EYyrc9eMsoKjYeR8wziK3s6XVdZneuU3IHsaJhkpoWD3Yom+1HiOqgyTw5wto2bcydJLlRuwAFvFpUjl16xHttDxPvrnpoRxvhEMXu39z8txLsh8/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CY8PR11MB7010.namprd11.prod.outlook.com (2603:10b6:930:56::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.32; Mon, 4 Sep 2023 01:15:29 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::8a49:15a2:ab69:91c3]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::8a49:15a2:ab69:91c3%4]) with mapi id 15.20.6745.030; Mon, 4 Sep 2023 01:15:29 +0000 From: "Zhang, Qi Z" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Richardson, Bruce" , "Wu, Jingjing" , "stable@dpdk.org" Subject: RE: [PATCH v2 3/4] net/iavf: fix restart of Rx queue on reconfigure Thread-Topic: [PATCH v2 3/4] net/iavf: fix restart of Rx queue on reconfigure Thread-Index: AQHZ3AeWJq7GXzbeGkGF7Hk/PNZdzrAJ4LfA Date: Mon, 4 Sep 2023 01:15:29 +0000 Message-ID: References: <20230830155919.592390-1-bruce.richardson@intel.com> <20230831123337.871496-1-bruce.richardson@intel.com> <20230831123337.871496-4-bruce.richardson@intel.com> In-Reply-To: <20230831123337.871496-4-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|CY8PR11MB7010:EE_ x-ms-office365-filtering-correlation-id: cde60f19-3c99-4f22-c0f1-08dbace46dc0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4T5PYF5IjLAYsddgZfPKAi0DaqMxUFR01lZ3mCsw+XSiwpDtnnlIIN3EUGzhnF+dKuJ24k76JF3RZhAV/Ot4I/OUXgAUHIpuDi1Xxmjxaco/BdLI8cQPwfZV8UmEx78j+1PVPQ1WxdUQ7tAA/vEJ6Nll0xObl6nNEVUj7LYjjSsmNtdT+nHUoDTK1T+kmDqZZLvQYCqci6dOvOLOreP8OinTVeUVR9NaZxAzpE9pYX1+0Ag1q7UofQXirC1KdTRwt2alGwjnmx/2K6nHgnSviWNnBqkfvIUhitYYk/hbY0CNyYjdH9qX96VlODHu3OXMKeaDF1NSNlmope8IfbFUHdz3fZ3LjTwbQ3rcLN0NK75GX9UWh88JjJyeSEpyHwOZdPf+jsRdpj3r9XmCmlm+cCd34LrwCKreP+xv7G1eSXcOII6wr1L4coSVklch4hIy8lhelkG7xoXCV17KTeTb5Lj6AJU3LhlPs/zuN6tWVYI9clAis6jkEpjC3NTkiDfBxZD2CF2HeKXVWaDHFmkZr7IwuB/Y0zXf33JO03lVPCkFhtfW0YcCJ6mEtG/h+V5RgU4OscL88H/25tvkaVKWicyMv5NYUSdgIRPPH9cyvFzQocCsVlVnBvfe0I0ZgL1l x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(346002)(376002)(396003)(39860400002)(136003)(186009)(1800799009)(451199024)(41300700001)(122000001)(82960400001)(38070700005)(38100700002)(71200400001)(33656002)(86362001)(478600001)(83380400001)(26005)(9686003)(53546011)(7696005)(6506007)(55016003)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(54906003)(2906002)(110136005)(316002)(450100002)(8936002)(8676002)(5660300002)(4326008)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z59yaHxPVMEr0/AejD4sKRzM1XyqaaH7WpQ3YmR+rNoAqIfZj3ugf40zY7d2?= =?us-ascii?Q?flXpTOssjmBeZSxNjFKLZUpnoTbbtHfXz4ibMvthcVGCJ+U8jiYwcEKNFzsb?= =?us-ascii?Q?cCBfqxNwyE8Nf3qV/EC13sFDSxp0MP2AcT3VRwGKELXTFLaVdyxdpXuQkH/b?= =?us-ascii?Q?1FqI/SeI5rj9AU/O0UMx8rjB4VNTWKtqoyYKIo3Nx7Gqjoo+zCd1fWL8l4mv?= =?us-ascii?Q?NkoMvhCxTMkJUpKwvSG1RzJTjxbwbK5l9ubybKPd7q2VhbQ9OGeTss55cJvj?= =?us-ascii?Q?IhFTKcG/hFkjyayj3ED5Zl59hx6Oo7tZWv2GNu6DI+8B5eISZ28AZD5ir2BG?= =?us-ascii?Q?8XEEUwbagU90BhdXSCT8ccf+HEVwMTuGsggMEDrhfj15hkFAjPDe4Xq4JMgT?= =?us-ascii?Q?IZHLn5JjmT9QRw9hjrIEBJxFz1Sd8oS4X8G8WBVf1qnK9MwBCi6+2qQ8wmFp?= =?us-ascii?Q?hvTwPfZGzu4ASEJeBTZP7otUzgmGHY6ycINpECpWH32kQqd6kNkgEUuvtySr?= =?us-ascii?Q?GJ0QfX2B9hkSfS54R7SmWBfj66MUN9uNSy8QZ54DAiCRugmcQVQLa58R8iVP?= =?us-ascii?Q?zEMT30UPkuFTX264Ajy+POrs5WvUiBtkcBAEEug0yW/Q4NWfOSwK5rYzXpcy?= =?us-ascii?Q?/0AIWAC0r8D8BBRbLctoP79KQvYFMk4n5+9V/Uu/Z3TX4CadyCZWrFS6P4P1?= =?us-ascii?Q?X3FWmexCfMEuNrnrV/PFG4NFwNzD0qLScZgn52PlEdsvrV6OXuvtIQQMpua6?= =?us-ascii?Q?kmRH41zDSF9ayL26S7cnpIFPU8UXGeqBw26mkus7oY1yOHGvmHpTr7y9NmXj?= =?us-ascii?Q?AxkmFLj2IaqPgM74iSljpm3ge2i3aeAuCUKOicBDkjeBG0mS9lpTcDUz73hy?= =?us-ascii?Q?pd6iK2PR0LSbszcF7mxv3hd6wIoQcvyRoyRZ7x2jGiUOt4aC1ALum6iAf2Cd?= =?us-ascii?Q?lU24GdVhIOdWA4KT0R9uIXRwfx0I0Vs4crnx3tfldYj5+s9y0CaIK7F3W2St?= =?us-ascii?Q?6Nu8KiqmmsBLXfNZoxUntVmvJUUt0ArsIIq3naEz3+OP21f913nQlCwanmO0?= =?us-ascii?Q?3Q25eVxc7bVBbLaF2TUj4Onkaedn4bD/ourGwkhKUxY4I1GlqGTKc3wZJDFz?= =?us-ascii?Q?q9EszZYLCB0vyKsRb2imc0vuQknjsLTaGfb2mKFWbbgMYSwhj8StXzG3qHyC?= =?us-ascii?Q?6ijwKACkMBzYCbiJsNumofOzLxDT2RVEnNog/S3jGWi/WiYG9Dj2pwFsYG/P?= =?us-ascii?Q?ikflRgZDDsqWMTFHsozddUveeDPfNsNLohle3EBMrJ6FDSh3ajMZ4/FUJfKZ?= =?us-ascii?Q?Nf0J5lMHEj5tbP4vkgbXqG5TekTBJv2ay7IkO2gc9YF+e9f6X4x+dX3STTOP?= =?us-ascii?Q?zWEU/3HgJnwZvINaSZPrqWy7rbyGViUY7afFREPbhHCyDWLy9nspRMwt3rrH?= =?us-ascii?Q?5lEJ1+NkM4aACAlBgsXJrfDgpCiRTt/oSN+FD/qgsUCPmAXTfZ0ldNQE4KYV?= =?us-ascii?Q?cXx9uaq2A0/WZYfzSSYvrXuwBI14iUQIVAqDsqPCfBuP16BVpLDgqbpsCxu5?= =?us-ascii?Q?Y9WygHTxefWf0N3Yv2VHXne2dUEDeNOJBKygGLAp?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cde60f19-3c99-4f22-c0f1-08dbace46dc0 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2023 01:15:29.6459 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NO9HohaZfwsqi0P9bZH1Wkvmr+oiLX8J49PXyWPho/yLMFrznD/R74qeK928TPRnUYAh8OzC5gJFZzyRt+wXHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7010 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Bruce Richardson > Sent: Thursday, August 31, 2023 8:34 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Wu, Jingjing > ; stable@dpdk.org > Subject: [PATCH v2 3/4] net/iavf: fix restart of Rx queue on reconfigure >=20 > After reconfiguring an RX queue the mbuf_initializer value was not being > correctly set. Fix this by calling the appropriate function if vector pro= cessing is > enabled. This mirrors the behaviour by the i40e driver. >=20 > Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx") > Cc: jingjing.wu@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Bruce Richardson > --- > drivers/net/iavf/iavf_rxtx.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c = index > f7df4665d1..797cdda4b2 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -755,6 +755,13 @@ iavf_dev_rx_queue_setup(struct rte_eth_dev *dev, > uint16_t queue_idx, > if (check_rx_vec_allow(rxq) =3D=3D false) > ad->rx_vec_allowed =3D false; >=20 > +#if defined RTE_ARCH_X86 || defined RTE_ARCH_ARM > + /* check vector conflict */ > + if (ad->rx_vec_allowed && iavf_rxq_vec_setup(rxq)) { > + PMD_DRV_LOG(ERR, "Failed vector rx setup."); > + return -EINVAL; > + } > +#endif Bruce: May I know more details about how to reproduce this issue? As the iavf PMD does not support RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP (= i40e does) Which indicates before we call rte_eth_rx_queue_setup, the device must be = stopped (the flag will be checked in rte_eth_rx_queue_setup) So if we do below steps rte_eth_dev_stop .. rte_eth_rx_queue_setup rte_eth_dev_start the iavf_rxq_vec_setup should be invoked in rte_eth_dev_start -> iavf_set_= rx_function=20 anything I missed? Thanks Qi > return 0; > } >=20 > -- > 2.39.2