From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2F48A0C50; Mon, 12 Jul 2021 10:05:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF6DC4069E; Mon, 12 Jul 2021 10:05:37 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2066.outbound.protection.outlook.com [40.107.93.66]) by mails.dpdk.org (Postfix) with ESMTP id 87F2C40685; Mon, 12 Jul 2021 10:05:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PZvEM2Vo/PsP7xBe5by9cds02cR8rxuOzj3dgHiVVpjLTVIW0NxgD3TKLmGQchFuQwsOSoVhbIG+/mZqL4v+1F75fxV0FAE3ivIB7pw/C68Hmux8K9S/4qy2mrsXb1bO3HHnV39pjLE9jXPF4DtySBOiTXc0cRTL5P+Nc33qDWD+pAd+IEBE2fVxl8s335sACjKnXzKyXKbLcAmvvijQgk9ODfqJdz9EuXovnYxvy+p2yFkw9e8hoH2I0RcNPdO15HcCd60ZAXIvmOuFyu8eboR1tyNsMyTrCd9yRwloE4i4mdvFORW6W7qNnfHuZLnDwZ1vnHS2ZEYN/d2F7TMxCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3zYDE4pgDVTEkM8Bcpx7WxyC2RhpEYn/vK72md5OzIQ=; b=b9dWrBW1NZ0BKOHosV0bQ8D6wi8pxXmJksrFXWLTxgwmP4bmU0Ra1CpmHlhUEuxmPzrscPSG5UvOE5j2UaHsraXEcXusOhoguuC9vWwtD8AKnm2bp3iw6cT2P3BC9hfVzO/RAPCMsEucN7E6bYDBPpj4CusiFIOmjaktjUf6RYVkjCOqNI+477tmNpgsA1JEFKZlA/aIMgzZkZOFmFk+lOm9wyKHSGKtG9yAOHNmdssmxwZqks+fgfvJ/rdPYDF1OfV6MBWpNaOn4QnGFzvxYoM+YiXkPdL7nXoR8ZwavZXg+vYyC2WDDtEwrpzEJxxkBinC59lCej7FdgVKhnUvfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3zYDE4pgDVTEkM8Bcpx7WxyC2RhpEYn/vK72md5OzIQ=; b=rygE3SHNpVRahDAZMu6y5p6i/7/RNcZ60TUvj6vi6Z5tmmrTx4HpPx0QEa2xggF4XeyAzq8Nsb+GEV6nF1yRF/gzJB5798B6+2/tUWkoO62bU9+tMYkSwgXhJgPeIGEvapKtoqSWANSS/+zaGNBwi/spcwuWLcxcGSu4ZcjRqlxEo16yXpInFTm2/PICGjo/pAUCxur3MqpqaUfCPLACKzqWGXY51wuqdMlvGqmdFC3cNLevihp9r1TIqVVFLFs1PsQ5wiFqEzWHQWYUZb5QdcNgHhEswWhPPXMh/Cj93jo35PzxpsISDf26NxXzJW1VsZ+G3ebOEosOht8N7IMEoA== Received: from DM4PR12MB5054.namprd12.prod.outlook.com (2603:10b6:5:389::24) by DM4PR12MB5039.namprd12.prod.outlook.com (2603:10b6:5:38a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.21; Mon, 12 Jul 2021 08:05:34 +0000 Received: from DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::584f:2720:1100:666a]) by DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::584f:2720:1100:666a%4]) with mapi id 15.20.4308.026; Mon, 12 Jul 2021 08:05:34 +0000 From: Raslan Darawsheh To: Jack Min , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , Dekel Peled , Ori Kam CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion of IPv6 frag Thread-Index: AQHXcth3s4JsdayidE+FYnlxegIebas/AvWA Date: Mon, 12 Jul 2021 08:05:34 +0000 Message-ID: References: <88ccba94f213b6715f34038b6b400a5bab889aa3.1625624590.git.jackmin@nvidia.com> In-Reply-To: <88ccba94f213b6715f34038b6b400a5bab889aa3.1625624590.git.jackmin@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3dfeccc4-cf92-4334-41f4-08d9450bd349 x-ms-traffictypediagnostic: DM4PR12MB5039: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V/nwtcoHhMllIUUJYjzoqytm5c+FlWWlTX2r7Zc+dGQnJNyg6AQpEKmRIm7myRQiuuC4TZ6ECFqfW4fvIfT0CZZxIUHDcAGA+fsH6axSw24p8L/gKFD3inaubnatkJQxPOsKcqk0UqDwAvLnVgHiylvMH8WGRicVGglOwB1GRrYIDITzpDMvX34Qjg90yHVeASfLBX2tXrrwDcCPxc/vmFAKJtb+uZGlTDWb92gFZaTYuHaLIK6SSQmqpZBDgemer/itKfuZyu/wAeU+6lW1srgzreIm+nSCHFHiPaM7pxk3SyME+HhoQO9/pnWhFyBSkZodt5AvRLk0YAilbnTYA4gD73olGVuBm2BJEXAfs303iF0YugQnLTHiGtOTnV/Br87q3IZVgqjFA/v0yzxFvmIHy7QW2rhBfpT7urHnjktmlb/4Dp2BEX/qCnJgbzgImO6aZtoE5DGiR7qPJKx3MrBH1o3i4caOZG05J8QeUbBKzhZfj1mYUz6Y0bckueytSf55PntJEKAwjuJDU/qWZiAQsxHgR7E6K/rlmP6HZYHzCezNyWGW5dyd0IHfgznG97c6kBbai01qOE+gvBBZDr7ZRsg46Zl7mpW0QsjODD/UuKimscJJrxGa+YLIPKJRY7uGExrj9FcPu7LrJJUeFg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5054.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(366004)(39860400002)(396003)(76116006)(4326008)(54906003)(450100002)(71200400001)(6506007)(110136005)(38100700002)(8676002)(52536014)(86362001)(83380400001)(64756008)(66556008)(66476007)(8936002)(316002)(122000001)(66946007)(6636002)(66446008)(53546011)(9686003)(33656002)(5660300002)(478600001)(7696005)(55016002)(186003)(2906002)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QEJqfQQCwe0XekLEurSInNHlV/sx0OXde/oF0pBWxyS5E28ZAJid8MJYeHFg?= =?us-ascii?Q?CWcFHzRWutgY2gDXCsNnYcVZ3aa1o+bbjWhJg+zoS84ZApDloF9mae77U59J?= =?us-ascii?Q?3e3BXVQYd4Agwyt0m3LK4nzOTA2dsUIQd1JoUBYpc6Tfj38yg1k3YZ2I51QC?= =?us-ascii?Q?f+8yLSzFZJW6gVh+Ouv3Lv8DkYKK+dQ9K13b2vJCvbXzA3odKTlJqY0Q00wD?= =?us-ascii?Q?1Ahe7EZfDV2Knjw0CZ5a/eRKdMrTGD7FaKROD+h5JYS3miF/7FV/2K6NrQfU?= =?us-ascii?Q?mXaFz5Wf5UCUOg5eula7oS2QTpCQ06kMlRZC97Y53rBA6YpdC1deYpibjfDe?= =?us-ascii?Q?eky8FtqvXHde/Q9pF7ibGnKv81TLoZ+SXIk3pj2e9EMQDT7WCXfy0QcJ9gpK?= =?us-ascii?Q?ewCGQxOf3PvS07C550RTAfQEpHvQ6LpXomb4dwVaEqPzly42fl2vfAb/yCqQ?= =?us-ascii?Q?hWkBaBjh7bY0zzxy6cdk1vzSBf4JU5qHJ3Fyi1OdIAjqFT0G4ftvpube/Ji8?= =?us-ascii?Q?14AU3fW7bhMUYYZ37tRU058LVSA4+8ZWPyVpeW46kprzrAPSsJcUNojaaDUL?= =?us-ascii?Q?MinyKrNmvL+ZE8qhLVSRmynYh1IpSYLOgMUEU3c5h18g2eJbF6JdmV3qi5kq?= =?us-ascii?Q?CCacyLphy2av7O3Xvmn8qkYBpJ79dfCaylvUYTKokYF+dOHvwTPg4hYx7rLx?= =?us-ascii?Q?3uLWWcAaQYgJROTU8sf40YY9UEOta39PbK4t/K2hNhS05voTzpXePFoj6cH8?= =?us-ascii?Q?57jeLFqgDEA9oOK9Z9YgDpWSO57Ll44Im2KHk7XMkQhsA80E5J2BzVFo8Iid?= =?us-ascii?Q?hU9UbSaqd9UTIhUyu7r4N8oNsbJYZpKZdYLJLHuCNgc6GJ5CC1hgO+DNpuUJ?= =?us-ascii?Q?l93eCEkOvCdl9lIk1+5hkbUEHGbgvWFnP0/wKTIFsn6Nn2MV4U1PZgqQgscK?= =?us-ascii?Q?zWsfhkqeMYHI1jdsZaAWqV6Eeb1M102V0XL4c32NhGmw/Q81YPuxsqumSj63?= =?us-ascii?Q?o2XjORxZ8IfmwORZKI3IaIonnn57MgFCjSzlAjxchA1j6ypQB6NiW7DrzyFK?= =?us-ascii?Q?PVJFsaAw++DaVwcuXGffM1s8+boOSTg04vs9O4OLV//2rXXI/SZEcwPHxUfA?= =?us-ascii?Q?3qTy0OW8hWZ6bf5t30q/D9yvynJq3NunskdhR94oiu4304RC/Yfzn663DH03?= =?us-ascii?Q?Dv5cLrn+57igsOmRQnakqqAg6z/M7kGnwrj8HsG/CKlBH/+b5Wc3EbnVHJWM?= =?us-ascii?Q?/hyaYH/Hphj1QCbDmZKvgo+0LR5fv0YLY1qF9hk2tY9PN+V9abtX3GDuLdbH?= =?us-ascii?Q?v+lbPvcUanKKRekB93ytPvta?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5054.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3dfeccc4-cf92-4334-41f4-08d9450bd349 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2021 08:05:34.0261 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: goNyip/CAhVIGaWFKnnewy5ufTfOruKeC8wa55u3Aj8+BLHtHIjyS0XpICwQL7SHXgq+rAl0bRso7pIdo171/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5039 Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion of IPv6 frag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Xiaoyu Min > Sent: Wednesday, July 7, 2021 5:33 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; Dekel > Peled ; Ori Kam > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion of IP= v6 > frag >=20 > IPV6_FRAG_EXT item is missed for RSS expansion which causes flows like > [1] are wrongly expanded. >=20 > Different from other items, IPV6_FRAG_EXT hasn't next field because HW > only support to do hash of UDP/TCP for non-fragment. >=20 > This MLX5_EXPANSION_IPV6_FRAG_EXT node in RSS expansion graph only > helps > RSS expansion function to locate right node in graph from which start > to expand. >=20 > Fixes: 0e5a0d8f7556 ("net/mlx5: support match on IPv6 fragment > extension") > Cc: stable@dpdk.org >=20 > [1]: > flow create 0 ingress pattern eth / ipv6 / udp dst is 250 / vxlan-gpe / > ipv6 / ipv6_frag_ext / end actions rss level 2 types ip end / end >=20 > Signed-off-by: Xiaoyu Min > --- > drivers/net/mlx5/mlx5_flow.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 1b682ac8ed..90b8cf6692 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -134,6 +134,7 @@ mlx5_flow_is_rss_expandable_item(const struct > rte_flow_item *item) > case RTE_FLOW_ITEM_TYPE_MPLS: > case RTE_FLOW_ITEM_TYPE_VXLAN_GPE: > case RTE_FLOW_ITEM_TYPE_GRE_KEY: > + case RTE_FLOW_ITEM_TYPE_IPV6_FRAG_EXT: Adding IPV6_FRAG_EXT to the list of expandable is not accurate, Assuming HW support matching on L4 info after frag - which I think it doesn= 't. It will lead that the first frag will get different hash than other frags s= ince it the only one which contain info of L4 header This will lead to different RSS spreading and that's not correct. Kindest regards, Raslan Darawsheh