From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 073B9A0C4B; Wed, 14 Jul 2021 09:47:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64EB641224; Wed, 14 Jul 2021 09:47:41 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2062.outbound.protection.outlook.com [40.107.95.62]) by mails.dpdk.org (Postfix) with ESMTP id 1A6C340140; Wed, 14 Jul 2021 09:47:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZD2gN/2lyigl7b/gIlbk9Amdy+CzcQS/5Thwn0l1Fa/073w1IZuVcbwnAqpJ5X1FnzQHkiUMV7PZswDn5ym+7xB1VFBWTNHcmXndy/v1meufgXXuBR0NfWuaYD/YpDjP3dniHGiCQBkTImBG5N802zFqF7Ipq+a3hN0ZkuGwVdVFPBXNR9Knot+srvA3hWS9BoY3gW5kbYVvnNgTLfEhJ95zUWpZdFJ1GLhy5xyQf+n8NGeBepX3vi8IJO4OSvq1phc6JSZu7Pwq5uvfqYhJidfE/4YnAdLQm54wshe4wLLG843x46g2StPVexo1gafC7gd0mYx26YcwiRz3Ru2OgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cdA9MtG5xOHrGKlH7LxLl2j0htV6BMqMbe4Ducv/K/A=; b=QEcEeGipI8myAYfMrgoXhb/uq+U9VuZ6rDSgOB4LB8auZV8Jc4SpJCCt/pWazkVnbnn10co829xmw17FSDqM3Hi1HMiT0YU/6xlJpYAEOmEnPjeh2xWfzLfGOSBnn2C20Gb4J1eMZGizGrZoNMpXGDbohytYMK28RiyjlM5dIFvwE3uIAJlW1MH8u0R1YRWKChPpbDLHepC0X0cMfsAAFTUkZYcYKZK+njvtn77e/18r0ly1cri/rcp6N92VHlSLnjfB1HYcrpEmfXW6vlVSqpZow8TF1aTUAn+oRWTTsKxxIKXfAxqLpAbNWQLCblBlqPwkJFCQap8ti3C92o7dRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cdA9MtG5xOHrGKlH7LxLl2j0htV6BMqMbe4Ducv/K/A=; b=gaXtK/CgweNvke8VHPIkObL4kTdMjMWOxkiXQ8/O891+LzzbZBp1B6uRniE0VmB2rRappnVTvGCGeaPRii0vrK21CdLzMXQitp0vj2LhDMnIUVjd5d5g+fju8bd+gMdklRMLQlb7R5rodCyrZDfFdpRjCSRCxdIkR43wym+4cDdF0KoJ+maGxVl4giWtV6AR8yTiKGRraBUbarz6ZOLSuy7JlbvUSuhUdHekuHEmJn20cE7tCKIB7CBS5VT6t2FdiZBkWWCjWn3XKAAeWSHBvPLSJv1mC5m3J1/IUj6ZTmc5hxkh8ccgr7n+SwAbNcdB9QhXOrTBS9VA6E24nZA1hA== Received: from DM4PR12MB5054.namprd12.prod.outlook.com (2603:10b6:5:389::24) by DM4PR12MB5264.namprd12.prod.outlook.com (2603:10b6:5:39c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Wed, 14 Jul 2021 07:47:37 +0000 Received: from DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::584f:2720:1100:666a]) by DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::584f:2720:1100:666a%4]) with mapi id 15.20.4331.021; Wed, 14 Jul 2021 07:47:37 +0000 From: Raslan Darawsheh To: Jack Min CC: Matan Azrad , Shahaf Shuler , Slava Ovsiienko , Dekel Peled , Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion of IPv6 frag Thread-Index: AQHXcth3s4JsdayidE+FYnlxegIebas/AvWAgAMbx4CAAAR7kA== Date: Wed, 14 Jul 2021 07:47:37 +0000 Message-ID: References: <88ccba94f213b6715f34038b6b400a5bab889aa3.1625624590.git.jackmin@nvidia.com> <20210714073029.7lw2kpvk5gdjlq77@nvidia.com> In-Reply-To: <20210714073029.7lw2kpvk5gdjlq77@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 116b3f91-481d-40c8-f161-08d9469ba68b x-ms-traffictypediagnostic: DM4PR12MB5264: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eEApyLtcgfmOMrUhDICmxEC0vD+15IF6dO7ylhfEQ7I9KKkL6Fp9815GW4QF1KIcAKS9KZNExQcS5UaKcgGZU5H6XPSByaWwAk8YVUOpMHsiRb10obbeYAP70NnnadCNwnKnBFPx+Kzae2KFb6BNm5qTKYRVrLrHTtp+zSj/HXAANRfGeIQT/Tcl14lFeUKlaKC8nuT9fm9KM3hZ+Rorej8hmdit1S/ctT0DfUJEcLWpe/Pm13pBFjlHrXk94z1OijLGz5FigA6BHdq1dMEA2XfpEux7A2BPnPtGNRjxe7x7l0tQCiELOCHNYx+oKjdY4FHDJ9/oPrmbJuvWgfHUYey9KkjHB/fYF8PWDzav1UyB/SNjmdVq0lv7LdvGkj3KfxDeScwnRwrxBJypDgAFqJAPU6cYf5ltYUeCMs8IDs6G+8nfZq+SJYmIcmWLV0p2vdJkMrpfgs/6E1wZ8B342ox9lc8qjcfXvObzSISAwujZ+Ua88+nod/0b0MX8zgXOnLfohAlTS16/BHzFdvA2/XlPkjlZOofD+SSDcKnON4ry5o+skLJJdaihUW9U9o3dfMOHbs7eSVrykt2jxQaO/Ski0GsOPVW7kMJLsc2WzxeJ+KALIbWuyPC9kGkAiFliNaXl8l6ogJs3zeZs6M/yph3xDDrC/HbCMNyOImYb69lv4shuW2rSFw4jCCfDh88VThntWqJZc3GpBgeEanrAkw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5054.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(39860400002)(376002)(346002)(136003)(450100002)(8676002)(7696005)(6862004)(26005)(4326008)(6506007)(53546011)(122000001)(66446008)(64756008)(66556008)(66476007)(83380400001)(38100700002)(55016002)(86362001)(186003)(9686003)(71200400001)(52536014)(478600001)(316002)(2906002)(54906003)(5660300002)(76116006)(66946007)(6636002)(8936002)(33656002)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yowlAGi3WOYq6opAiXRnihTz4749izT7wGg8Y542y17Zhr7OBi6bbWyAySZA?= =?us-ascii?Q?HnURHdVwJDwDVP1ImuexGxKf3UqbSm2/lAGbFqODYWXp/KsbOyPPCmMfGNDU?= =?us-ascii?Q?NsMUq9LeMGpLnyGwSwXInv9dzFppuK+7BjvPqX1FPJkzRFM0L5gPhLB6KBIA?= =?us-ascii?Q?GBC5ZB492UVbgn4kCOhR6MQz48/cvygA7Rh1Uz6osJldDUHLBVlXPHYYvSAE?= =?us-ascii?Q?S5L/vglP56pPatYsfUX7h6fpR5DwOBNHn6G3km4o42ULO9RnZ2f7k1Sl9S+J?= =?us-ascii?Q?grUzwvASrsinxpIll1OWvNZ74GgXqKdOcscJznMRveuNvRrRPTCb0Eb+WIdG?= =?us-ascii?Q?/WHDlbtTHSvncikOr8vEhf2VSEId9CXtTVK375v/fWplhMimVOb+KdAGcngk?= =?us-ascii?Q?JS2Q4+e+Tgfiry0UvQ2mzHTAJg4DWfCC9UNW7ezBsU9fwGroVuIH6fe6mrbp?= =?us-ascii?Q?xh8aL2/coMLOj+t/kX+lHDSMYcAHO6rYJAt7Q+KfNkWawF0SNgoHe0edwjpc?= =?us-ascii?Q?0FKBfavTgTFCxJXBnrqzq73hFOpZ0Sp5Wl7sz+ZVUIrWiPOG0UR36e3rt6d4?= =?us-ascii?Q?ACnWzE+1bvQML0N64OAf19y/o7P6HXEM+KhdPmi5cOOtPD1LHH6Urs5/IYgm?= =?us-ascii?Q?FZTATAk/0uK7Si9YGJthUgw4shTVDVw4+PQuloFa955MeGvMfxdfde5TBkCg?= =?us-ascii?Q?InUVKbOa1sg1u4pysdEkjy5/IVUw3GkG/NWJYIU0rTK7mWzJeW0EI0V8ChF2?= =?us-ascii?Q?I5tPOCCwFbbn8lWgweh2H2VWS5CUKWajjA7V3kI/O2oTSJS3Xc3iBRCDvjl/?= =?us-ascii?Q?kMWFed1cN37mPRdUvgUfCG56YLF1rHJCG+CP+CkP0XEgI7KFnJY11FomYAtn?= =?us-ascii?Q?Me53wg0xZpL9K71a8S2b+4c2S9IiJi4Knq9tuScpRhwilooTz6t5kc+OZQnA?= =?us-ascii?Q?ZuAkG9DzbaFPdPjttivRAfjSPKLtjuGp9Uv47ESIk58wpj5m29L9jt1RWW6B?= =?us-ascii?Q?c1vbS+bxc1vCM+nnChdZJHQQ1wStORKNyFxK0lHgcGR187lIQzA8d07htPPo?= =?us-ascii?Q?TtBKbhabtokbUTLmTSK47Cy7eWrhG2nNJVKQN2F/Gsr7t68i9oXcxXgofavw?= =?us-ascii?Q?5dCtCn/JHlYFAAz78lORUKN1+Xsa3g3ZMwQ+/OsXbf7bAlJen0997x46n/yM?= =?us-ascii?Q?kKkjRWmxAOWlzk5/uOzX7ova5uTieTjqoau8MDrxCBIpVPrfa9T9yLWbF6DJ?= =?us-ascii?Q?V1m9XBhFM+EoOnRI4YhKWZL33uBQ8zREtJGHYUrPFe0nz54auw9FtR1CS5JZ?= =?us-ascii?Q?wxds5phLuvcaWHrI347/wR5D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5054.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 116b3f91-481d-40c8-f161-08d9469ba68b X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2021 07:47:37.6376 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yoUGgNqkpfqJGLeb/czqUsCEdRGCPYhGbtEcij49RVCMzoX9zh9qv88n9Bd+1BgckvZQBxP9cec+wpn3kSyvvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5264 Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion of IPv6 frag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jack Min > Sent: Wednesday, July 14, 2021 10:31 AM > To: Raslan Darawsheh > Cc: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; Dekel > Peled ; Ori Kam ; dev@dpdk.org; > stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion o= f > IPv6 frag >=20 > On Mon, 21-07-12, 08:05, Raslan Darawsheh wrote: >=20 > Hey, > > Hi, > > > > > -----Original Message----- > > > From: dev On Behalf Of Xiaoyu Min > > > Sent: Wednesday, July 7, 2021 5:33 AM > > > To: Matan Azrad ; Shahaf Shuler > > > ; Slava Ovsiienko ; > > > Dekel Peled ; Ori Kam > > > Cc: dev@dpdk.org; stable@dpdk.org > > > Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion > > > of IPv6 frag > > > > > > IPV6_FRAG_EXT item is missed for RSS expansion which causes flows > > > like [1] are wrongly expanded. > > > > > > Different from other items, IPV6_FRAG_EXT hasn't next field because > > > HW only support to do hash of UDP/TCP for non-fragment. > > > > > > This MLX5_EXPANSION_IPV6_FRAG_EXT node in RSS expansion graph > only > > > helps RSS expansion function to locate right node in graph from > > > which start to expand. > > > > > > Fixes: 0e5a0d8f7556 ("net/mlx5: support match on IPv6 fragment > > > extension") > > > Cc: stable@dpdk.org > > > > > > [1]: > > > flow create 0 ingress pattern eth / ipv6 / udp dst is 250 / > > > vxlan-gpe / > > > ipv6 / ipv6_frag_ext / end actions rss level 2 types ip end / end > > > > > > Signed-off-by: Xiaoyu Min > > > --- > > > drivers/net/mlx5/mlx5_flow.c | 8 +++++++- > > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/mlx5/mlx5_flow.c > > > b/drivers/net/mlx5/mlx5_flow.c index 1b682ac8ed..90b8cf6692 100644 > > > --- a/drivers/net/mlx5/mlx5_flow.c > > > +++ b/drivers/net/mlx5/mlx5_flow.c > > > @@ -134,6 +134,7 @@ mlx5_flow_is_rss_expandable_item(const struct > > > rte_flow_item *item) > > > case RTE_FLOW_ITEM_TYPE_MPLS: > > > case RTE_FLOW_ITEM_TYPE_VXLAN_GPE: > > > case RTE_FLOW_ITEM_TYPE_GRE_KEY: > > > + case RTE_FLOW_ITEM_TYPE_IPV6_FRAG_EXT: > > > > Adding IPV6_FRAG_EXT to the list of expandable is not accurate, > > Assuming HW support matching on L4 info after frag - which I think it > doesn't. > > It will lead that the first frag will get different hash than other > > frags since it the only one which contain info of L4 header This will l= ead to > different RSS spreading and that's not correct. >=20 > No, it will not expand to any items because the .next field is empty of e= ntry > MLX5_EXPANSION_IPV6_FRAG_EXT in mlx5_support_expansion[]. >=20 Great thanks for explanation,=20 > -Jack > > > > Kindest regards, > > Raslan Darawsheh Kindest regards Raslan Darawsheh