From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2630E43337; Wed, 15 Nov 2023 13:54:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0567740294; Wed, 15 Nov 2023 13:54:17 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2045.outbound.protection.outlook.com [40.107.94.45]) by mails.dpdk.org (Postfix) with ESMTP id 5867C40285 for ; Wed, 15 Nov 2023 13:54:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AX0Mk1sVE6RnsMEKjq+iWbAW9GhAXxxVWvU0WuvHVIH28h8lySD/ovhZWiFbNoFyP7BI5gfLdhWsa8xzuB3P+F2Dr/bHQRN/K9l4WNDyaPvD9TuWMLPrSCXLNn8mLOJBlUrWHNZhM3D38ptD9qEvjCcBJQQUpoE+98JQriIkSqtaaNW4E6Ib+LMNgEHzsCXBRPFpUuMzYBFQHyH53QdNjRPoquC7NL7Hh58nE1Zn1QgXjuf+RMv8kvQhtv0xPidHcOQknnyBbyDLfHGgYLYKScEf0K/ZveGq6cT7DCGwi8tab7O8dZhiaok1N+FvQzeg5zYHsUD2zxEC3iJcBnEQXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mfPBylKDeiXxXvjZJqF7pYjaEfM7EWca9BMr4nknCeA=; b=Jf28Z3dDZHhcQbDhuWB9mVpQqVuHS/Eolr1qtKLMH9YIXxkqrmRnWoGzOS9aN8mWGi4FMqMw9OJEbtlOMpm6ZYl63G0dvMbs6pPuUBXlywAmMWZ3LfR9sNYC4cxtYceylXIhObocuJeko3xkC+mSSQhAa6iAUSo737bq97+RH7TMuKxkV+5aU9//MOjR8osqmZ4DZn4/iLLFKsGamPxCJwqUBmv088rAvA5tYa0FhUHEI79+lq0i2dIGg1Z5/3ZZvZpxQvssfPP+pna9p1NIDJDeT2fptk1pRlYx7hbaY97Rg/+vT7N2aKlxQw0M8LTXk4xOQEb0DVqcF9NQryXHdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mfPBylKDeiXxXvjZJqF7pYjaEfM7EWca9BMr4nknCeA=; b=OJa0qaWh7x7646fDM9Uk551ioaG0bGnzpozjvayh0f2I0F97Lb3PwLqgYL5OhA5uYpaDjD/mMXVN+eeb1dTN84JT5XpOue+txqGzGx8vVJNbfQ0RLZfohsnHM/QzPBWlBg6eHcbaqkfO7x5iaiBf1ppZzcaKoLp1bQ6FWnDRyu8= Received: from DM4PR12MB5055.namprd12.prod.outlook.com (2603:10b6:5:39a::20) by BN9PR12MB5098.namprd12.prod.outlook.com (2603:10b6:408:137::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.20; Wed, 15 Nov 2023 12:54:12 +0000 Received: from DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::e61f:406d:3cd4:150b]) by DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::e61f:406d:3cd4:150b%4]) with mapi id 15.20.7002.019; Wed, 15 Nov 2023 12:54:12 +0000 From: "Sebastian, Selwin" To: "K.E., Jesna" , "dev@dpdk.org" CC: "Yigit, Ferruh" Subject: RE: [PATCH v3] net/axgbe: invoke correct API when offloads enabled Thread-Topic: [PATCH v3] net/axgbe: invoke correct API when offloads enabled Thread-Index: AQHaF4h4GEdlu5+ZPEqsvZ8mDjg75LB7VWMg Date: Wed, 15 Nov 2023 12:54:12 +0000 Message-ID: References: <20231115055604.583724-1-jesna.k.e@amd.com> In-Reply-To: <20231115055604.583724-1-jesna.k.e@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=1865d115-2227-4cae-9ad0-82eeb96867c4; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2023-11-15T12:53:22Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5055:EE_|BN9PR12MB5098:EE_ x-ms-office365-filtering-correlation-id: e3a9334f-3816-45d8-1696-08dbe5d9f74f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DtT9YGNDWFasLOs3p6C0XKUa8+GySL/8FFrf+/TQ6Om8Inh/5nCH8jl8SwgY1eiLqqybkomQeCRrwthjWQwJnN/tKoj8nG5ZOyAdmG4UO4YjiAAjZneoxK/NPcVvIlFnMQqSPXdZ9jVKZ99VHWqpLWCq93HExHym/+/kX10ujIeRIoBp8Vx5+3Yk6IET37BiohMMhShWV2Aw6JjPKnIOVcvKBXyclV5ATATOLAjqPdL9n/sjXb4BhSCOqLAYmU5ijawCevq2mmoLwT2dWupF1nZhUHDWwVDzvcBgYeFFaaHDPkb5m11JvLdFCrwZ88niqT/rKtsM3bgAl/rc+lv2kM5G3C58+0RBww1Axxls0PMxNPUs4T93fVR4n6jmR3njWZpJQb+Ye5d4L98izDaBBZahG6FebJezYY4QFhGasaAJUtLPc+UJtlekpoSb/qpptxnpPFIAocDblH8LC2DYFMTJYNF7+c9IuhEp15oxmtS+m71M+ntoIDyVEMabCxq0fBHgzUD1a2GGw9RUxsUsFV3Ql+rYBw+EISpYhI4BBRtjkl2SAezU6e5B8dKnTTPs7kVJfYr/2Mz+vUN0ECmHEX+rC+/030toeZoDMDE0oM6vl9EEZXgKuKJm94q5DHX3 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5055.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(136003)(376002)(346002)(366004)(230922051799003)(451199024)(1800799009)(64100799003)(186009)(38070700009)(55016003)(122000001)(38100700002)(2906002)(86362001)(33656002)(5660300002)(9686003)(83380400001)(53546011)(6506007)(7696005)(26005)(71200400001)(478600001)(41300700001)(316002)(76116006)(110136005)(66946007)(8676002)(8936002)(64756008)(66446008)(66556008)(52536014)(66476007)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/PjAga0qBIoxkScPtnAmsLBeq6zbpYm7keKaoZmOM0eYDj+tyY34QZuDzi+D?= =?us-ascii?Q?JGrBBLH2ISL3JuxPBRZapcW9rOSA2qSYVB6zn60TEQhOJBfWGCTULWwfVF15?= =?us-ascii?Q?Hm9MZCLD43b43cSB5BEjuKkOvTNydZzj/bBj221SjGHjidQLetot/27Dkxjr?= =?us-ascii?Q?q5FHge7UfM5W0TFm3OG6H8V7VzOCE2ufTsgz4xr8e8a5OsqXL0o9qDGuqBTb?= =?us-ascii?Q?K3/IdDq0yT71K6IFtqDZPtrQVj+osUMmH2Bguea5kJZoEMtDAjpy4nLnk80e?= =?us-ascii?Q?FO39iB8V1ZQ9l1mbO38DoGNDWegQzOfnsskD0kbS5Fye2QozDvLqNFM5NX9M?= =?us-ascii?Q?NY1SssgPUEg7Er6uF54YlephoTQENgTBiWqH2olO3noDodpv1oC1BOj6F1Se?= =?us-ascii?Q?OG+9Yz45FZ0YJxmIJgLrJk7X3YyxIravqxcumbrNE5Ts45UJLYKuugARcMJh?= =?us-ascii?Q?4aSB6Ue1i1+YzwDIUPuUa9O4ZXyEyTlriM+WBN8qOb71+jPA2vw3L2DtoBxX?= =?us-ascii?Q?hmoUHhC4GAIEhDojAAKN6m81UzEusUqEog4qzCMDsWj8688Zk2pVJ0LfltbE?= =?us-ascii?Q?aFSirD42mPUKHiGz6299pGQs/4J9/zFYyiR9/q/n+D/ECJe0CKyJ/d4k6NVh?= =?us-ascii?Q?sjzEMTLXcZg3Xy5+Pwy4ZGlfgasAFv2jbSgcqMLCZ8qWR+pkiI5/HfLnvZZY?= =?us-ascii?Q?9sY8UFlqX+eELJidUF3N42osLV3AfE3TN7pnMcsADE115VUJJ6FIN7GUK8KD?= =?us-ascii?Q?tlZ8L7vZ9rSpkTMn3vPd6WsHGPyXmXsfeQR8Srzl6ALpvUd4qTlW0i3x0yLX?= =?us-ascii?Q?C7RpWkCh8gXnjZ/T3JyYOxaVdKGmJYW64mmPaxf2KKfPNnEMPwQHYmwasuqZ?= =?us-ascii?Q?wAqE5zHJ4EUVRGl4Zlc4G27KmOy+2vhFs1XYLok1xL/AroDs1JagTarPynwY?= =?us-ascii?Q?LW9iaE2spb9ejxqT9Hn32nqBEDd2o2ugoRY6GZrxon3HW2PBC0iFteJsU9L+?= =?us-ascii?Q?ViK38m4oLREzGwkwocReumoNc0sVB9wIIFkifduDgRiISO9OJtR/nUdc2XhT?= =?us-ascii?Q?VQcEuJWfjqbP8Fqc2SOsLWyrgshcXX427qvGWMldRcyY5dUlJxkgHTGqmSQF?= =?us-ascii?Q?Vc4rmMuLL6YnSbboIVfR9wckiPaeprPJCZpqgrqeHHB8HmXDwr8rypwHr3BW?= =?us-ascii?Q?g+uVlG6KfN6j924q1rqCPf1b35aUVkD59kDZjgB0t57kuNeEbbCjL4djAGhY?= =?us-ascii?Q?ekK8j+NGsD4jDZPWorcHTa1ehkBGEl0Cw3rFgCl+wU8oJ7JI+KQtXUH5Khjy?= =?us-ascii?Q?eItgVbZ86NTuJUr1QtDECaUt48Yvh62tcxqc0WW9UW9jaAJgXTmolNvtBNCm?= =?us-ascii?Q?OzIYoYsrw2zwXXAHSE2DiZrJGnsxnVhKaiGhszrficdCE9zGC6cS/zzPMR3S?= =?us-ascii?Q?J5hwZf3NHoD6SpfIMR2At591b0IR8WCDLLDlyEuYcMQhnRgRl49VigFEY8/b?= =?us-ascii?Q?KZSspv287po4u/MttWJDmysbWOXNwEubVrRiJKRaoryp8tT+VRICz1D3jj3X?= =?us-ascii?Q?sRP978MPPxDjKq/5eX8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5055.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3a9334f-3816-45d8-1696-08dbe5d9f74f X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2023 12:54:12.2303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cS4wPo4WtBT0Ev3+g7lXB0gkJOI7BuMzuuIryynyaHZ942p1MCVV0WX5+cuAi12RTiWgLvDj0rGCn7selJySXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5098 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [Public] Acked-by: Selwin Sebastian -----Original Message----- From: K.E., Jesna Sent: Wednesday, November 15, 2023 11:26 AM To: dev@dpdk.org Cc: Yigit, Ferruh ; Sebastian, Selwin ; K.E., Jesna Subject: [PATCH v3] net/axgbe: invoke correct API when offloads enabled A bug was introduced with the recent fix that when an offload feature is en= abled axgbe_xmit_pkts_vec API is called rather than axgbe_xmit_pkts API.Thi= s patch fixes it. Fixes: 9963b5131af8 ("net/axgbe: support multi-process") Signed-off-by: Jesna K E --- drivers/net/axgbe/axgbe_ethdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_eth= dev.c index 3717166384..f174d46143 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -12,6 +12,8 @@ #include "eal_filesystem.h" +#include + #ifdef RTE_ARCH_X86 #include #else @@ -2137,6 +2139,8 @@ axgbe_set_tx_function(struct rte_eth_dev *dev) { struct axgbe_port *pdata =3D dev->data->dev_private; + dev->tx_pkt_burst =3D &axgbe_xmit_pkts; + if (pdata->multi_segs_tx) dev->tx_pkt_burst =3D &axgbe_xmit_pkts_seg; #ifdef RTE_ARC= H_X86 @@ -2144,8 +2148,6 @@ axgbe_set_tx_function(struct rte_eth_dev *dev) if (!txq->vector_disable && rte_vect_get_max_simd_bitwidth() >=3D RTE_VECT_SIMD= _128) dev->tx_pkt_burst =3D &axgbe_xmit_pkts_vec; -#else - dev->tx_pkt_burst =3D &axgbe_xmit_pkts; #endif } -- 2.34.1