From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2741344077; Mon, 20 May 2024 12:41:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8912640687; Mon, 20 May 2024 12:41:31 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2088.outbound.protection.outlook.com [40.107.220.88]) by mails.dpdk.org (Postfix) with ESMTP id 1E201400EF; Mon, 20 May 2024 12:41:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dR60nTZqCR2WUgODjqFscT90oSr/VLWcWPtuPNk+RAqrrFOryP4wx9Sn7MyuYtmrl+bUbyC9ViNrDgad6283e9IuTKcLq5Tc1h2X9Fv+p1CsLE+ge+y+u9o+KxtKYiSZeqZQHKe7BAG+pT39QIhjNZXlO0fJ2nUtEgeKqXsBldV6nIpLfniyA/bUmv46y8rQgB/rrLx4MSpJnHpHlPa8nisNyL9zAH+3EbvXSdCc1Ms4q2JBPxw2ly5ErgbYxghS5IeLLw9vGAsSJfbxyNsnlVHc3efi1UrOeRU1feKx6FwevnnNre/WZMVjjmWDSdUXUZrMxYppuv/hQ2ML2BtjvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Eh2IoCRwZ4j9L6Gg5buqgSh4aPefndNfKi4f4J+YRb4=; b=gkHzLULCTzNKbRXDNVaUVGTLh6LErFnR76bH/TvXZVzwcJyLSOuJflLcAzwGo2Ja7QzTTU/hsrK7xgbQ46hRNoiZma2NHY4sReUxy3cWXe7YjPQ9BvG/crpUPV90BXpZu9s6bOUpZEZ8cAsxP4PNQJmA4NSAl+N9pqK0IVOvV7JEb262P6syGkH0xxhcv9kyva6eeICvm+ZR2QbbPdrenUH+C1CrXg8TPsqYlbKZkwe8kqXWTOcT6kGoIABva8omcSbG9r80Aq+zikcjWAXGwdS9YsS5HwAEIuZNuHimwa+iPuArTFn4irntfjnz6dK4MBDaGKdgyeot7bpFYVVIcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Eh2IoCRwZ4j9L6Gg5buqgSh4aPefndNfKi4f4J+YRb4=; b=M7A5y9RiwOFTCOGvNWDLgrlx+rjlgXoHlu3oAwl3NJNgmG2xerDlp6BP93na5Bfle4OUS8M/hWLtUQ0V17qVX+Ny+q4qEuPYGEfZXVuC54Yx8aQEN0bMIbGbDPydlr9BlPC3YYD+1qIK9pxRI3DzhmvItOJ0yq5dWnYss7V5jMU= Received: from DM4PR12MB5055.namprd12.prod.outlook.com (2603:10b6:5:39a::20) by CY8PR12MB7123.namprd12.prod.outlook.com (2603:10b6:930:60::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 10:41:26 +0000 Received: from DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5]) by DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5%7]) with mapi id 15.20.7587.035; Mon, 20 May 2024 10:41:26 +0000 From: "Sebastian, Selwin" To: "Ande, Venkat Kumar" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH v2 05/25] net/axgbe: disable interrupts during device removal Thread-Topic: [PATCH v2 05/25] net/axgbe: disable interrupts during device removal Thread-Index: AQHaoHw0Mbcjrk8UsESyy8IgRs9DPLGgA4mQ Date: Mon, 20 May 2024 10:41:26 +0000 Message-ID: References: <20240412125013.10498-1-VenkatKumar.Ande@amd.com> <20240507124305.2318-1-venkatkumar.ande@amd.com> <20240507124305.2318-5-venkatkumar.ande@amd.com> In-Reply-To: <20240507124305.2318-5-venkatkumar.ande@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=3739fe58-8119-44fa-938d-74232d0c8113; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-20T10:41:21Z; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5055:EE_|CY8PR12MB7123:EE_ x-ms-office365-filtering-correlation-id: 664777c7-64b4-4c41-c426-08dc78b966a4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|1800799015|366007|376005|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?INtioMthT0xMOVJodshzca7WhO58EJT6wyUU1YQQKCP8w5ZWCKfZSgrH9Wz4?= =?us-ascii?Q?rLtGUF19prkDrJI9EjHzrx0+yxhOpNg2HsdLFb6X3IWyGJr/NlD8LHhJahlc?= =?us-ascii?Q?NQcGaDyXGENqXuuyb34t74qkJ5/3eO0VrhxL11Qlxagm/z/CORvqjOt1ybxb?= =?us-ascii?Q?85iyM3fQx40FLjhkwb5zosmd2x3sp2Ff7z1d98GyTMmQv7clZvHKCU0TKU3e?= =?us-ascii?Q?Xfub3NvONSB38Iw7o77Rlc7LTmsQRQoiVChpI4kZfOk0YbH/TFMIJAT5/gHY?= =?us-ascii?Q?F2hcvVP7FG8P2Kou5liE2BdbYENpdaNNdESVd2jbi7ZnMGdoLwIMqiGndvFC?= =?us-ascii?Q?gHd33ApgLzEWOVi2Bl4M0iDzCamFrrWANASlF9LySEDcao66nrgbpUtHpKkv?= =?us-ascii?Q?uouMsUAuVde91ZB5oTaWH9+uu0vHdXgKHV9C0ckkuZq4EFx9gfiQ/csKHwbO?= =?us-ascii?Q?uP31E9kaMHEdByYQQVlaQpoOh3W68bWqXYMtANa/laGqDkplgpUquj5KNhea?= =?us-ascii?Q?fjS2jkkOQDWaG3tGiPZFVm7ezwKX8yMPvXS0I4+urdvn0h/+6mG3QXUnKEJJ?= =?us-ascii?Q?5ZKhq6Z4CuxImruyKw/+tKXMeaw0WrVlne94qPddkRvWYUSUPGk188C8SeNv?= =?us-ascii?Q?5Gt32S/AMTfBDvdNwh7jyTbmSKgT90ZoDKaXkV/Z8LbjGLZMBxWUxQ3ywz1B?= =?us-ascii?Q?aTU46yp3TK9HEEWibsy8Vb75pDcKP8/MNm3V/CkRAjbKKK1uXpsB6pT8VLs0?= =?us-ascii?Q?ruAEwI6g/uiOrUiSiKYBMF/snFYM8vAvfXj6jJGYszah2zeKC1GrLBuE9Kp0?= =?us-ascii?Q?vAyKUohwMLPtQNGvuthoar9JZ8NoXL/Cbb4eoqT4knZ7gGR/hwuicvf7go5A?= =?us-ascii?Q?Zv5jkFKG+1mqZNtsJE+nUSMHDxTnzKPLX58CyHqfIa/vL+zWa0AH1/fUESTe?= =?us-ascii?Q?p4pCfNSHUkSCEZht4JUDuIZMVE94GrTMNoKrQrDdZgmc3t5Ax1L2GKA+8SBV?= =?us-ascii?Q?W/EJhY1BXpLW13YAuiAi4ruJY5o0A/0Xe+OAbxUHkv9TdMo/SFnTdjfAOyZp?= =?us-ascii?Q?dwYCjavsXzgir+EzjIziX4UZBD8ZnWxVuAHlZyVYSA5sRhm5lVSDYi+8aQLD?= =?us-ascii?Q?R4JLc+IyT9wyJf9eGSVqI9s+VcLHogcx014Nd7YQO+Ic09yRvdkTN5fZVuYf?= =?us-ascii?Q?tbWRlpR2rAU/qw2x8XUlrUxs8pHzuEpOKDKcoO6SXBjbzCOtgDvFeAdadCQZ?= =?us-ascii?Q?1o4UNI3t10oG+kApbSBkSsaZDD4UxF8kH+A0PzJZtSTZebzm29NzuD2AxEPw?= =?us-ascii?Q?M9LYuakBftVozR4LsagZ2Z6CFwpN+eh0Nmtx/qcAmOCsag=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5055.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r+GxKXgTP8HunElsRfDWeil95c4t/G2NvjNMOA3/FSGnodT0tUB5vXDgkTJk?= =?us-ascii?Q?WRURUCCMizovG7X9wTpjEmLGa1vElIGnzv6p3A9tiOyMxZsxEvUOP6ZVsD/H?= =?us-ascii?Q?Tla7a+aIwmeLl9A+cIa6i1EE84fBmcY1aXwwuDkn/MsmyCDXVQzgdzMjMxWU?= =?us-ascii?Q?Mh+X72m7BpmsNTzlVqBSi0O9CV/aYbYo1U3qyMuxsf9d3Y/EVmaFf+sdt8we?= =?us-ascii?Q?rSHuCY7v0s2/67OKSw4STc0mzs4oasm5sjzdfs0CR3DQt6eA6Yx/AnZkQ2Fm?= =?us-ascii?Q?lWi6HpHkYm7HnpH0XSSjRvbvPsMFfs0ZrmyEFZKPOkO2O8ycovowJRfoUaN1?= =?us-ascii?Q?NyP23CxitBLR65LI3VJ6i08ZWSJvPK4jMN4Pbr5l5mXC5to0IyXQT8/jTmwz?= =?us-ascii?Q?1t3ZTuCYp+qA5H//7RHsG/CT533f/vLHIdsbzpbOpL5I4jahkF74Wbz1OcOQ?= =?us-ascii?Q?Sowt9j7+BRmyonuGAX7KJcdYaMYQmQZFUrTkwEBCE2tSuqZ9RRvWK0n/2oZ1?= =?us-ascii?Q?EuQaFsBG2bu49Sr1LtRIBCi5YtO0jufZbube3MZjze8D4X8ZQ2byW6udZ2H+?= =?us-ascii?Q?Rbz9rG5SLUi0/UPckaS0YFocRG3gxwT8Vqm7OoyUVmmNCV5ZRKK2w5vjW7ZB?= =?us-ascii?Q?njX+v7VeF7PGTd9X3RDXguGoqj+r/ZtJWOajHnS042FX5OQqziNSMuV6RCMk?= =?us-ascii?Q?7Cc8qtCcXewVUgaAKABZ0bNz4qhqj7Zj/6y7tv4H5DchUOGr9d+oKeCGzB8t?= =?us-ascii?Q?8tLBt+1fK42+sUvm+HFg83SncGnJJibcW6is2oUe8rEypSix6xIL3P2VTPJW?= =?us-ascii?Q?ayqu0qllrB4cYWxaH77SAZdmTwx0MM8PDhfQkMRY+HO2uR5o7DuHpnz+eNI3?= =?us-ascii?Q?vWQ2ZsmrPIvCMhlQSJnbyN2hyL80e74oi8+9awzH3MR0rcev8ZTkyp+eEBOF?= =?us-ascii?Q?89OXld2oZtYRfmzvSMxPKuaBftlUTYnvszEY9eQo4Hr6HCsyFShcUQTevvZT?= =?us-ascii?Q?KO++xQyCZpE+SpR6yJ6QlfDjxhTpI31Poo/y/aOpcTK9LxptpIq2ptdYA7+D?= =?us-ascii?Q?bhD0/Y5QVnyluuxoYVt1lAl89fIGYuODoaMw3ignNBK8hNEI0mSqRnKAy1Oa?= =?us-ascii?Q?0+we+ZP5KwURg0ml6BE5e+mxvpstU0Wq5i8r06zmSbdTUrHEzO6xiSdi7gVL?= =?us-ascii?Q?Olxhqoyr42JD+/XY+kUU15gSrEmKCo4h2nri4InFcDgZEbpq5we6oHj9R8t9?= =?us-ascii?Q?5BF25Fp2pvIkyWgR2Zw7q334bN1RNjrQHaOx9YmVyTF+8hTBnsWo+WKKWJRV?= =?us-ascii?Q?xwwF0LLVuzfsxU31l1OJ18vKaDZWKfvG8+koPpKadr73Aeq5HMwXxfZMitWy?= =?us-ascii?Q?vHKBfS0lIGZneLiBesb0paiu7WVzTkip+ynH+gCfZaBIMC5pSq6fvcs7Nbit?= =?us-ascii?Q?a8J7MV0HG9C1TWaY2L2qZFJHqNlFf7DIRloN1kliyQfIiJYov5IiGj1I9lMS?= =?us-ascii?Q?XOLXEw2IlhuPgxLnow3OnrEekiAf0NFj6NqsWrbaUNcT7tb64HXfKAXo5TB6?= =?us-ascii?Q?mhzBXGoFNQudxcLDgxtYy33oQ5RuY8YW5kmO6ZLa?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5055.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 664777c7-64b4-4c41-c426-08dc78b966a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2024 10:41:26.5630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sbgeLD0/GK9wUIhDGGDSZ0XpO3iW387Ft1iWs6STvcJ2wUFNJMyVb5s2mu7fSofIl2f56jx02Cuf4XlTXb/qjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7123 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Selwin Sebastian -----Original Message----- From: Ande, Venkat Kumar Sent: Tuesday, May 7, 2024 6:13 PM To: dev@dpdk.org Cc: Sebastian, Selwin ; Ande, Venkat Kumar ; stable@dpdk.org Subject: [PATCH v2 05/25] net/axgbe: disable interrupts during device remov= al Hardware interrupts are enabled during the init, however, they are not disa= bled during close. Disable all hardware interrupts during close operation to avoid any issues. Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup") Cc: stable@dpdk.org Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_eth= dev.c index dd681f15a0..e5d8f7db02 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -2411,12 +2411,14 @@ static int axgbe_dev_close(struct rte_eth_dev *eth_dev) { struct rte_pci_device *pci_dev; + struct axgbe_port *pdata; PMD_INIT_FUNC_TRACE(); if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) return 0; + pdata =3D eth_dev->data->dev_private; pci_dev =3D RTE_DEV_TO_PCI(eth_dev->device); axgbe_dev_clear_queues(eth_dev); @@ -2426,6 +2428,9 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev) axgbe_dev_interrupt_handler, (void *)eth_dev); + /* Disable all interrupts in the hardware */ + XP_IOWRITE(pdata, XP_INT_EN, 0x0); + return 0; } -- 2.34.1