From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB5F9A0C4A; Tue, 6 Jul 2021 13:02:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 248774127D; Tue, 6 Jul 2021 12:37:42 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2071.outbound.protection.outlook.com [40.107.94.71]) by mails.dpdk.org (Postfix) with ESMTP id 00AF540688 for ; Tue, 6 Jul 2021 12:37:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iEO2uf1KZ3C/5b+y6U4f0tUUtJcTFQDd2zKqD3kZQPX2BwDO0ixNfNb0EozafTiUqfzd8t2mJN/GvedznDyqo6G/MmErSm/WlnFyJrHgs2/FO57GraHvyhxR+dgLl4nPcjLE5BNeVzTV0zTkam82wYgEm2CJWqwTz3fBfoOlb7hvjMeN2Rpbo0bAhLuM0llZml4onsLaTdRukt8OGT/DADorizKmV5VO+sA7ixB9ta02x+OjRXkSRCVgvr0V7y/H3KiO9OQ2fLB5BSvVJPqk7RTzRE2tiHGBF3RwvKEknTCU3nK/AQU0h0Jl7vyGVjF4u74OFXCEeleAiUSPrcPYdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Noe2i7MSs2aJlWDkGMGIQl1o9jLyeXClxeOJ9l25mfQ=; b=YKpJXTKtIsc+Du5JdX80AgRR8CQNbz/J9o25oEOgIxyRp+oVDqZlajquEq90u2+k6NOFcPMREBT1gGwoe6fJ1YHT8BZYWpsfv1HOGaeiYBhwIj/Fu6ctMtgz3/M7YRfBxbkGl3zw2vTxkSicu13btk7EPjoZ4f1WWA/YcsyeyAhzMrcoaQAbaNrhQtKL6aZvDFTHn8Fl5qjklN8PdTJ/obOd4QuzsaRm2XxT62cNHiHWe1pLaECGz4VO+0Zef49qRQOE9g8YKsmMo8O/HoA/gEYdion5L8EmBz/1QmNsYjsNrC8ZamNJxA1zpwFisBSoiOBrNfCAT3pWEG/G/SmYIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Noe2i7MSs2aJlWDkGMGIQl1o9jLyeXClxeOJ9l25mfQ=; b=OsLB+weVNrG+Vh+VDhTs/2YvY1sDdNBdPdT7sRKM9zAEj4f4s+tU+K/tMCgH4+8KwfxK/c/nTfYRw2Qacp/to7HYpsbCu3H4ZJZqEpS9pnGhvpfVroodPigzjaT5enxUd9gQ7OprpbbB4IXuNe4t1I1arGh/+1q43K2PXqw1VHkas1WvtKTrY/7W9uKNbHhgHOzxBnf0DNCzZqOTvDPDJzUVuJlcwmZfIBXCsuYllPUcSjBFfHGMG0NVYvuVIyYm6A+0EP1SwxpOPeiZ1MZ1HlxDdmv4WTOFaGqid/Ful41YroyqAT+dWueEl2Bp2MT1P5VeZFyBxzD7+FxR9jFjlw== Received: from DM4PR12MB5069.namprd12.prod.outlook.com (2603:10b6:5:388::6) by DM6PR12MB5549.namprd12.prod.outlook.com (2603:10b6:5:209::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20; Tue, 6 Jul 2021 10:37:38 +0000 Received: from DM4PR12MB5069.namprd12.prod.outlook.com ([fe80::dc28:25fc:b5a8:6a97]) by DM4PR12MB5069.namprd12.prod.outlook.com ([fe80::dc28:25fc:b5a8:6a97%7]) with mapi id 15.20.4308.019; Tue, 6 Jul 2021 10:37:38 +0000 From: Shiri Kuzin To: Akhil Goyal , "dev@dpdk.org" CC: Matan Azrad , Suanming Mou Thread-Topic: [EXT] [PATCH v5 15/15] test/crypto: add mlx5 multi segment tests Thread-Index: AQHXcjtBDGttttKbh0OnQNh8ndZbdKs1pBBggAAMrACAAA+O4A== Date: Tue, 6 Jul 2021 10:37:38 +0000 Message-ID: References: <20210509160507.224644-1-matan@nvidia.com> <20210701132609.53727-1-shirik@nvidia.com> <20210701132609.53727-16-shirik@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a692bff7-b4a5-431b-5f11-08d9406a137b x-ms-traffictypediagnostic: DM6PR12MB5549: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ta26D00grqCOleOQCHFwuGpCU3bgqHBljBuW0bTTXnmzRGYo4ahe/GCSqDL5NHpVBAk8/kw8eBofn5iQu+HF5BllET2RHzgixIQIy6oKIsIGpdVjA/nyg9smG2Udld6v62V4gtObESQiWgTvjGaTnwfyGtfnMxgY30NqOcq49Pe8PTazPxPBbt2ZgawHBsM6Pu77qnRCnqQ5Q+HNJxZD7s+h+iKSdt/PKbLbY65nzlQN21vG0wvrO3hc5dTS1hMkMgLW1mitUZvRfHKk22zwTFV6gFMwRht3Pih3hXvtm4wjWHZ8NM555Q9PujQX2fOHidfJX6KVAKmYebwcq7SEBpWixksNutYl4BnAbLBBqpb7LX6nK4sKv8qLx7787RasbvCEWpFZrknemTw82Q1B48To8U2aeIvtoQMRrPAl0jbhED210atw+AL+4zv/dTMyNHV2QrUC6sv/yw2Ly9c48f1H9sxg2M51AjEb2MGpvEccUvj8VXEjKEQz4TTW5hSlCpMHxn+wRFxmnc6NGCu21U9iTGkv7o6XS1HyLfk75SIAtchBe9AWJBieGD14+Z+1ikByEWI/yKgek4X6MByCgMgwwHVM9GX9RA9qEOkILG3fq5UQn8IJeNrTREi5cEY1vwOmF5/7Fw7WuBN08IF6bg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5069.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(396003)(39860400002)(136003)(376002)(53546011)(55236004)(316002)(8676002)(2906002)(8936002)(478600001)(107886003)(52536014)(122000001)(38100700002)(55016002)(83380400001)(5660300002)(9686003)(110136005)(4326008)(54906003)(26005)(66476007)(6506007)(76116006)(64756008)(66946007)(66446008)(66556008)(186003)(71200400001)(7696005)(86362001)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HyZao8N59Nfz4AtQg8mEUKBewYXAbVzdokgO6djfSodWIGQdcTEvgr/cWfI4?= =?us-ascii?Q?TXoYWrd/kBmb4YvhHtO+cTb7EOQZYspUVbiPhlsLSHuLqYpgEMYlPPdSmPM2?= =?us-ascii?Q?NKN3J4KFri35c0XU3g5Xmps5zg9KgeAZBfMF5+8NDcisY+oASUs58OYHjiA7?= =?us-ascii?Q?8e5bkzeB949fS1i7jfUvrliTAqStOe/hp6JmdTiWtRH1ZbRm5MONe6m2VDW+?= =?us-ascii?Q?mR6COW1RwFewrl/H7SNpKlE+vr84rRMa3G63pw23HsBBv/qQAerHLftufTEQ?= =?us-ascii?Q?i9ieq5qikwhYUsd2xrXUvC20VxZ8wh3stbnQkmeRnGBh0E4pJCpmEs1ukCMC?= =?us-ascii?Q?nkn7OvggPU4t5aREMI3w1Z+iQGGAu1wuGxLGHt+/1aCmy4ZaXPEYD0fY+Upa?= =?us-ascii?Q?696EDyGe93EzOX0oP+8AlapnHuLQlnVLUzFCGmgZ+Akd1cFigYF5kJCdMOvu?= =?us-ascii?Q?v1+od9m7FaMfi2cCOz6OeJTr0ixvWX+wa8dbwjxQLWrcdW+Cnm+6pf/lxarv?= =?us-ascii?Q?XTuhR2xRQAe3T2MbEsHx3LTOkk29nlhuuRbJks13ZO7AW01AqaoSm4QIfJ3o?= =?us-ascii?Q?VaTXwWJ/FradM+uQ0a/KlSuj20buF4mHtm4bqyPD8xie9uZil9qiZ2DbizT/?= =?us-ascii?Q?/ABzgTVSr802wqxgabnVMgTSywacCYa+j2TGjWq7B5lZhUOSVjBDzDxk97IG?= =?us-ascii?Q?1PYpZj+JyjlmadXrX39iRka3LRPH6TP51DIjyKHpb2I8kQOZlJ3vPee4+muR?= =?us-ascii?Q?ROP6ZvksORgQCDyoZfctoGKr4mqTS9DujCbBi3bwm0wUSAQzX/fVYx0ozZdt?= =?us-ascii?Q?T3OEmbkQr+9jxSjjQsy5E+GVh3ejU4/gaH1Fmcoo5+lF5hS+pO6argNWkfnO?= =?us-ascii?Q?2LJOgxcnG4dJNNIQngssXE0wvL6kqsQHnbuye3URpqIdkzd2gV7H52Yt0/7h?= =?us-ascii?Q?Fx9dIXRSfh6ZXEpygLwjarVVUOalZIGTk/2Co7Qd5r9AMSSrwnYltpizlggD?= =?us-ascii?Q?o2djNRtbU7Erv7nAh58bn08PLDriYiabFC/Dm0K3PUAqOXvMGeTb268tTEEa?= =?us-ascii?Q?jftoAg37eLVg5BPuKst6LlYNYe1Tz7lEg0zFylgTTa86olaK/t/pUYuC1XhJ?= =?us-ascii?Q?6kHb3JZbmuFgwIxFjEPxMWsEkjr6qDjiTIDjs/Y9fSPxnctR9v9LbVV8hVe8?= =?us-ascii?Q?ecEc9RuCXWebEn7CacU58X0po+r7BrIqEKzzokomLGRtV2kVuTNgp5gHj1eY?= =?us-ascii?Q?ZEnpBSfiOooMbf9RgkqbtQQuQRk9DcLxsF925MrTT+ilF/ihK36ZuEaFLvr6?= =?us-ascii?Q?Uns=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5069.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a692bff7-b4a5-431b-5f11-08d9406a137b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2021 10:37:38.6203 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: urKEYLN3+OADYrD/3lnvGMxKWyAFxxHxIpPU8k+zaNd3wna+qN0r/QL0PdKRe+lz3PzmLuVKc9p9MKEDsvaLww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5549 Subject: Re: [dpdk-dev] [EXT] [PATCH v5 15/15] test/crypto: add mlx5 multi segment tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, July 6, 2021 12:38 PM > To: Shiri Kuzin ; dev@dpdk.org > Cc: Matan Azrad ; Suanming Mou > > Subject: RE: [EXT] [PATCH v5 15/15] test/crypto: add mlx5 multi segment > tests >=20 > > > > The crypto mlx5 driver supports multi segment encryption and > > > > decryption operations. > > > > > > > > Added mlx5 multi segment encryption function and multi segment > > > > decryption function that will both use the mlx5 vectors. > > > > > > > > The added tests will test both data integrity and correct stat valu= es. > > > > > > > > Signed-off-by: Shiri Kuzin > > > > Acked-by: Matan Azrad > > > > --- > > > > app/test/test_cryptodev.c | 277 ++++++++++++++++= ++++ > > > > app/test/test_cryptodev_mlx5_test_vectors.h | 3 - > > > > 2 files changed, 277 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > > > index 8dbe324b81..4d27a9444c 100644 > > > > --- a/app/test/test_cryptodev.c > > > > +++ b/app/test/test_cryptodev.c > > > > @@ -6681,6 +6681,219 @@ test_mlx5_decryption(const struct > > > > mlx5_test_data *tdata) > > > > return 0; > > > > } > > > > > > > > +static int > > > > +test_mlx5_encryption_sgl(const struct mlx5_test_data *tdata) > > > > > > The test cases cannot be specific to one particular device. > > > Hence the name test_mlx5_xxxx cannot be accepted. > > > > > > Moreover is it not possible to add aes-xts in > > > test_blockcipher_one_case() and add only the test vectors of aes-xts? > > > And probably, you do not need a new file for test vectors, XTS is > > > variant of AES, Hence the vectors can be part of > "test_cryptodev_aes_test_vectors.h". > > > > > > I don't think there is need for a separate function for XTS right now= . > > > The current function test_blockcipher_one_case() covers all > > > capability > > checks > > > And feature flag checks so that the test is skipped for the devices > > > which do not Support a specific case. > > > > > > Hi Akhil, > > Thank you for taking the time to review this. > > I would like to change the test according to your comments as follows: > > Use the existing AES-XTS testing function. > > Since we require using data-unit and wrapped key I will add two new > > fields to the blockcipher_test_data struct: > > XTS data unit- to be used by drivers that support data unit. > > Wrapped key - to state whether the key is wrapped or not. > > I will add vectors which will include the needed data unit and wrapped > > key to the "test_cryptodev_aes_test_vectors.h", which will be generic > > and could be used by other PMDs as well. > > Will that solution align with your comments? I believe this also > > addresses the comments you mentioned it the other email. > > Please let me know what you think. > > > Yes this looks good. >=20 > You should have 2 separate patches > 1. for adding mlx5 crypto PMD in test app. This should be minimal similar= to > cnxk PMDs. > 2. adding aes-xts algo support in test app. >=20 > I believe SGL is already supported in block cipher, you wont need that on= e > separately. Thank you for the quick reply. Working on these changes, I will send an updated version once it is ready. Regards, Shiri.