From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9219A0C47; Tue, 6 Jul 2021 11:11:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BF9640688; Tue, 6 Jul 2021 11:11:40 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2041.outbound.protection.outlook.com [40.107.220.41]) by mails.dpdk.org (Postfix) with ESMTP id DF9914067E for ; Tue, 6 Jul 2021 11:11:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LIC3YsGmtSNhVHJ6l04PSU43t8JPK/cAgIUBcWc4cuSdXWG7xgcrfb6i4oFefWVtaJAqUA9myQvCyWotLBB9EoXJrZqtKUMBHgrui8jmhOid3HW/zpLfTmnx/mBYMV2OXv1il9bOA+XEcFmy7rgbvCNcl1DjNl6Cs4EBN2wbieeOBCSp6LO2v8g6qAb4SWwe2jaCSlkelqbNv8jYZen3zCSSYoaDtcgyYycYQsSnMHqwKoqIKylsM/pvHkM5QiV0VxPahITckZr3Bh1P6RbYGai1GKMSwMEBvCYawe6KpjpPOc5JLiOSTVrYDEbLnSM0bMbPWtK4vr2IVy8OeCpKWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aj89fJsMkKvYU4P3P4U7gR0Av4dxq+GJ2uff0VLPc3E=; b=cPChFASI2stb8BFMdd07CGOiQo6dMRplqbB8gOHE9J1JD2rpSVswZ7cz1O2BD7JbJTw9HN7MtMyeL1rmkn4CtCzv2/TC5/R7uDffQW/eHYHDQa+sz5FpnC9efeTUyf9qlpIE3d1ajwDApS01fAiq3Kl7wa3z//GBOzwHCnCcJW5pYFDXBGGm1uF3q3hiHypGvug/5w1c3eK1zRrfrsuD5ulwjkbk/L2ytbAzH03harbeeEt9ywJxPsUg5rfdzBe8KI5MIzTCfLGuDxMzye3Uqlh25SlgTnGW0C/wU78CwZV64bTJF+DtDCZL2fbBSaE4uN7ZKGW+YYwDIqSEIelEWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aj89fJsMkKvYU4P3P4U7gR0Av4dxq+GJ2uff0VLPc3E=; b=Yp+RveF3f6gQyTlHzLLOht9UVOodC4sakRjeeIxdXQmtW0AY6IJJanQGuGWCySDrSeeSDino91RxE1dXBIfAxmL3QOpEdRw9ZCgm0lwdRgRwuJEldNaDEDToh5kd8RYI82EP8L7IaHSmIQ3s0YXyfsvTYTABQp0LRKKGdRqrHEPYb2PJ34coKAAsMMewJcIo+a0y4QtbKgMFGJoZxF0mfMpW1i/CfViBme8IDRV1puZ6Snb++mxGPEIQ7ORxX1VWVZodxbyAFKz0xRpUaHmz5Xm2DAyJ5JfoqChkvBFGYztxNmgaXcRRsWnpyEVVO5pRo+W3s2QSNU2+9SFxDbu2TA== Received: from DM4PR12MB5069.namprd12.prod.outlook.com (2603:10b6:5:388::6) by DM4PR12MB5087.namprd12.prod.outlook.com (2603:10b6:5:38a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22; Tue, 6 Jul 2021 09:11:36 +0000 Received: from DM4PR12MB5069.namprd12.prod.outlook.com ([fe80::dc28:25fc:b5a8:6a97]) by DM4PR12MB5069.namprd12.prod.outlook.com ([fe80::dc28:25fc:b5a8:6a97%7]) with mapi id 15.20.4308.019; Tue, 6 Jul 2021 09:11:36 +0000 From: Shiri Kuzin To: Akhil Goyal , "dev@dpdk.org" CC: Matan Azrad , Suanming Mou Thread-Topic: [EXT] [PATCH v5 15/15] test/crypto: add mlx5 multi segment tests Thread-Index: AQHXcjtBDGttttKbh0OnQNh8ndZbdKs1pBBg Date: Tue, 6 Jul 2021 09:11:35 +0000 Message-ID: References: <20210509160507.224644-1-matan@nvidia.com> <20210701132609.53727-1-shirik@nvidia.com> <20210701132609.53727-16-shirik@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [62.90.165.98] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 31e3a1a3-bfe8-4d88-c7dd-08d9405e0e5e x-ms-traffictypediagnostic: DM4PR12MB5087: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5eASitrlKyUXo4wNuhEkeLzLsR0fXfjyVkRq21WVrsynPGBLdcctJDmKMLdtrgi1owslHpMrR07gAI4uyXBvg/Sk9ZoAox+JeYBuaLjUWTKKbxDhgdWLWKhisti0CN40fbivDcBTFtpirIy590MmSrd57C1TXgxuS+xnpPWGVu9K7BDYwN+OvQ0DCpBdO19O2pUZycaeaHdchkiD8GdgZ2cGYHTc1XRp0Anccmp8ECrQlgfQyRRpgNFvYoz2n4yy1u71t1l+lBJBY/nWw/eMXtCnEsy09v5seoFgsQfclaZGpSr6uYTvzeqzi6Ides7MU2nppm5BuO8B7mSyJnl1yiDpN8XvlWtdIJDfTzVXdNmknWs/ZCBQMMf57RMipW4i03VrfLUANZzQExT3KUIWMemWMVRRfLbv62ph56eUF4McctU5hWLdBTo3zyZdUhqPKImD9mHJFXNnp9MG4wwMRms+d7fP5Fpy+1UJk4zjPHzJV4yXmM59efZJcmgiyG0oRoEOALWrWuR0/esS7K1wjtZBN0IQLtMf2EkwU89kXPWzPP+OD2NmOeUL+HiPcfs4FKW7FPtEeQCZ56NtFDNw+ynzrcPxoE8+4teujWdWz92RFuwWUdnFBL2nU+8maEXtdnuuprOcdgj5HO8MoO/KNw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5069.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(136003)(396003)(366004)(39860400002)(186003)(64756008)(38100700002)(8676002)(5660300002)(66446008)(8936002)(83380400001)(110136005)(316002)(76116006)(66476007)(66946007)(26005)(7696005)(55016002)(122000001)(66556008)(4326008)(52536014)(107886003)(54906003)(478600001)(2906002)(55236004)(53546011)(86362001)(33656002)(71200400001)(6506007)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3rhqv/gMwHARPipjkOaz0WqwwcG77PWBpFRWftrq8m3QDYjPalWV7JrKENTb?= =?us-ascii?Q?2Yx8SIxIaFps6Nktk8+hEdJGCC8PnkEvmcLUT4NX465J6maDJef6bYHeYTyT?= =?us-ascii?Q?DgUbGVoruEsge/QzxghUqbc9kxSKckq3rVYpfs1hX0Az2RneiOJw/295nR/F?= =?us-ascii?Q?zG2bdQiDo0W8y8nQq/hjACO8mFfrgz0Ff1z9BgMd3qz1ya7/s8/85nMMm6eu?= =?us-ascii?Q?X9Szpmdr/OyMIynIHpZJzRiborhg3OmW5WX1L1aLv2Nc2ILBmIG2qPZX3Xpv?= =?us-ascii?Q?vbxaIj3GW3nF5oC0cCozGDU2vVfXVx7J42V/2LOtEjX9FoKNOaonWrJiJpqR?= =?us-ascii?Q?jVdtiYFraBlMZWuNdnq2guJO+h3OfUB3Ikkv3yAP9HHKHb32NE7sDemnH8Nt?= =?us-ascii?Q?ZkHfeqL1APOrYngfOD5ZeeEKgc3q6c35dr7cB8a4WXjROTmscctGQacG7Gip?= =?us-ascii?Q?Ve/6doj39XqkaXFQhSTkmySt0MV2+DdrNl8WdZrKz4+2ec/c2Xlra6DQE46Y?= =?us-ascii?Q?0mldxTuPGJEdQ7PbTVKbO+4vjDZDsufIqBqFXVaQ2++VcQYN7B01i0UDndvc?= =?us-ascii?Q?rXibJhfccV0lIkN3uA1u0Wr4vXx6eCQ+8M6cwXyfICylyVPMqBa4g3S7LHpE?= =?us-ascii?Q?IL4TyyP36Onxvn34loaGya+LwbXnyFiNsMcwqzrRqQ3EHMmfW2VvvI+dhYEm?= =?us-ascii?Q?FMrfSSrTR+kBTOG8DBa81hjZr7Y74iwuV3vdQA3a9K2efmyw1Xjr3lRZ49ms?= =?us-ascii?Q?Fgp8RTtUjpi7iZm2lI1l/2vc7/GpIN3i2N8PT8EFrGByaYc37kmDY6f5GHR8?= =?us-ascii?Q?f+35nIyVsalzmq/5AxOEugFdKn70XwFsvKyb44SngqLFjI5QfTnzpRjHu3Hm?= =?us-ascii?Q?EWmiR5lzU9KJ00tKbFT/fExxckrbbgfaajT4Sm5NxzUgvs50pKoqtPR9XOlm?= =?us-ascii?Q?psA4W5pYh/ZKvOkpHujXjGOl4IpKZ9sppu9E/FJsPu6gcMvF8+ytHLhoDFJ8?= =?us-ascii?Q?rh2xPq4C2FCWDSh0G+JkFAPlN4PFeHwZ6K+GSPrFrrkAF8mmUrldZUpZ9eFe?= =?us-ascii?Q?kD5jzLDINqztNBQjwHr827TbiyfuRC71239oRRX15QtGaJRrNL0a8HwbjIdU?= =?us-ascii?Q?yU9fg39FiAI3Y2gLV4j6GJDdkWn0Br566WWskmZmfhgd+lSilPX2smg5AJ6R?= =?us-ascii?Q?KroYyo9o5zvEjUaldQkWySldZS7wMZ8FKdliC477wxv5n31ApdklocDEv6nf?= =?us-ascii?Q?nBkQV5vymh3lFXs9GXJ+Qnroh/WNmlid+K0VDmDVOk76jmxg42t+MH+ZRIQf?= =?us-ascii?Q?biM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5069.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31e3a1a3-bfe8-4d88-c7dd-08d9405e0e5e X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2021 09:11:36.0447 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EHiFW1nSEM32ee+QzEh3eyQzG9Og/MMA1FH751qFJNJnrtkB4084LuT/1vDiNBaOIgcW1yesa9sE8h5PQJTrLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5087 Subject: Re: [dpdk-dev] [EXT] [PATCH v5 15/15] test/crypto: add mlx5 multi segment tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, July 6, 2021 10:48 AM > To: Shiri Kuzin ; dev@dpdk.org > Cc: Matan Azrad ; Suanming Mou > > Subject: RE: [EXT] [PATCH v5 15/15] test/crypto: add mlx5 multi segment > tests >=20 > > The crypto mlx5 driver supports multi segment encryption and > > decryption operations. > > > > Added mlx5 multi segment encryption function and multi segment > > decryption function that will both use the mlx5 vectors. > > > > The added tests will test both data integrity and correct stat values. > > > > Signed-off-by: Shiri Kuzin > > Acked-by: Matan Azrad > > --- > > app/test/test_cryptodev.c | 277 ++++++++++++++++++++ > > app/test/test_cryptodev_mlx5_test_vectors.h | 3 - > > 2 files changed, 277 insertions(+), 3 deletions(-) > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > index 8dbe324b81..4d27a9444c 100644 > > --- a/app/test/test_cryptodev.c > > +++ b/app/test/test_cryptodev.c > > @@ -6681,6 +6681,219 @@ test_mlx5_decryption(const struct > > mlx5_test_data *tdata) > > return 0; > > } > > > > +static int > > +test_mlx5_encryption_sgl(const struct mlx5_test_data *tdata) >=20 > The test cases cannot be specific to one particular device. > Hence the name test_mlx5_xxxx cannot be accepted. >=20 > Moreover is it not possible to add aes-xts in test_blockcipher_one_case() > and add only the test vectors of aes-xts? > And probably, you do not need a new file for test vectors, XTS is variant= of > AES, Hence the vectors can be part of "test_cryptodev_aes_test_vectors.h"= . >=20 > I don't think there is need for a separate function for XTS right now. > The current function test_blockcipher_one_case() covers all capability ch= ecks > And feature flag checks so that the test is skipped for the devices which= do > not Support a specific case. Hi Akhil,=20 Thank you for taking the time to review this. I would like to change the test according to your comments as follows: Use the existing AES-XTS testing function. Since we require using data-unit and wrapped key I will add two new fields = to the blockcipher_test_data struct: XTS data unit- to be used by drivers that support data unit. Wrapped key - to state whether the key is wrapped or not. I will add vectors which will include the needed data unit and wrapped key = to the "test_cryptodev_aes_test_vectors.h", which will be generic and could= be used by other PMDs as well. Will that solution align with your comments? I believe this also addresses = the comments you mentioned it the other email. Please let me know what you think. Regards, Shiri.