From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A56AAA00C2; Sun, 30 Oct 2022 14:34:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4844A40693; Sun, 30 Oct 2022 14:34:01 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2053.outbound.protection.outlook.com [40.107.244.53]) by mails.dpdk.org (Postfix) with ESMTP id 6FDF340151 for ; Sun, 30 Oct 2022 14:33:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IrwtLKjFjae30vAziGDMwOionVQhwUQcWEQ9mdjZGpdXbRAQDzR7ksKfDErtwgX6uHniTSlFrxYeJCwAIMkVGrtVdjNp7mftYvta3aEvksIM7jiLd7Mgzrkc9IcCDFOWAXzgXlYWJafK94nArpCzRn4xMxVb8NdI7tqOJnJA3yYjcojR68mbiNPkoLXLI8HcZW2TdiiIJg6ObV0gHpqDzxf+hjPV8ckP5ixx6ijn/xTIJMTjvFZcOXonohcl8RXNAVxVoPwrzVsOhHc2vasm7GLy1IQxeIPiRuJoMrAiiNOBECZ5ofVxp3W8tfMiNklQByvUt0I4B92yAjueWLreXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m3yxh7peRZmL9GdhjhWIyiYm7o/Q3JPNofEMNqoDLGc=; b=gyFhq0VvDqOmtg7KxxsXXHrMmOBUgn4dp87TtFWMBvF/b/jixugyh4Ep4pMwI8S9WnmSFe39J8nfuHbZmC6xxo7OmRwC3+YfDaHJD/yqU58Zsn+tuVLj2tyyaxc/JjFOp9At2sHKi17TE1pIncCF6w78CJMUBrD9XRkPCis9xTemYVDwdyWOMZsD8HmXOSu7VSU5VVm4ti/ppWhKCd7nmbzjE56yVVD7Ks36Gua6/e4dOwbDgFVhPjns9rkRJGv9RlYxWiESPGcvHbkTGcD9XkVsg8ChaAzuZNOEMkxTRKv+2KXjCdtByvbS7UEuCZ6GSQAqYNMiDvI4PSxBqRBUsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m3yxh7peRZmL9GdhjhWIyiYm7o/Q3JPNofEMNqoDLGc=; b=h86hrGPdz2pUk0YyPTlWnzRT3Y/D/C4Gxu1g3oZY0r+vFv1Y34sZud3jsfBOSP+q1K54fY/WqFPgIcOVPPkyvZyklCVaxKlKInyvmqCXqO+7w8PLP+ta+5rOvVBiURAv3qBsr0cAZVBvK+KD2bjC4/7mwo7OATRMiIzjfe0Km7jXaqBhwKscqs95Jk+8Wx8aWfaJP8IPm5C1EaGwvtQOcWCURL8v0Snle6HchgNZdnT4ieiKwzZfEP2xWdaHMy421F+72qgdEIMdz1JTpW52GhXy3dBx1Awb85E85/dbI6o5rUnHNPvCZRy4Lb7k7+9xZidbJbYY6xP3ilqvpgrLZQ== Received: from DM4PR12MB5150.namprd12.prod.outlook.com (2603:10b6:5:391::23) by CY8PR12MB7561.namprd12.prod.outlook.com (2603:10b6:930:94::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Sun, 30 Oct 2022 13:33:56 +0000 Received: from DM4PR12MB5150.namprd12.prod.outlook.com ([fe80::67b0:c86d:6345:c883]) by DM4PR12MB5150.namprd12.prod.outlook.com ([fe80::67b0:c86d:6345:c883%9]) with mapi id 15.20.5769.019; Sun, 30 Oct 2022 13:33:56 +0000 From: Alex Vesker To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "dev@dpdk.org" CC: "ferruh.yigit@amd.com" , "andrew.rybchenko@oktetlabs.ru" , Raslan Darawsheh , "david.marchand@redhat.com" , Matan Azrad , Fan Zhang , Ashish Gupta , Slava Ovsiienko , Ori Kam Subject: RE: [PATCH v3 1/2] common/mlx5: fix build disabling Thread-Topic: [PATCH v3 1/2] common/mlx5: fix build disabling Thread-Index: AQHY7FAMbL8HjoaoskOjTvefoAzWwa4m78Pw Date: Sun, 30 Oct 2022 13:33:56 +0000 Message-ID: References: <20221030110827.1994953-1-thomas@monjalon.net> <20221030110827.1994953-2-thomas@monjalon.net> In-Reply-To: <20221030110827.1994953-2-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5150:EE_|CY8PR12MB7561:EE_ x-ms-office365-filtering-correlation-id: e0eb1146-8f0a-4a41-2bac-08daba7b6522 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 31RVNtDBRh6oaRe27vvH1Mmef1yJL0Sam5sUVVKj/MtWi5oxts7wOxaTgTK5bF3Y8hGBY9p/XlSTfDK6M6DupIusbnI+xexuIyb0yFepCN1g8PUb0qFuwdWH3Jw5g8gokmV6kAHYC/dma0oz96VAyobsXGKlr4MfgFFGiSTDMFA33P6cCiDq0VVBSuKIxGbk/nOp/5HJFmf+RaJP5NddtuTdnV9hPYcTQ8HziHjCoLdriysDi/Ha22VneB14swjLOTXQeWXd+B4NSawXI2o/cph2M0tUGGaCsQSa4YIkrzTrIPhqskv8cMqE+jzHJRrO1r0XtdQsRPYftx+Cuows0KDoEWv8xaRYFrYM14uIQYj//KTZB7JX2Y5VlgwYhgcOevMLCVrFjzTiWxujwgjWMIlDlZnpjlb4Hau6pw6uIlFuWUyg29vopasYfrJpxxQlWW9wNZtbp17l6K2tjo40JlseL5K7M/yflm/FCe04/QHDBhU6n+nDFsL4vHgmEgl546FIyndUjIb31xa2zcvhzyQ3N5mCIEDkjElc5Enbdj8gb/xvJ67NccGVOWech/4meiPiSn1gtu7PkziSuHy+WyPadpZ1c7aDOhpEnGCnf5bmCKqUtkEOlzNpNDjj5elui+toXyFlYDglP81onGe5mQ1UvSvld6if4kzrJ9lqJbMawjupozhnqhH+VfB7aW9lZ9jJCenKTPnhVjlcfe+3hWXjPPvkZ8vsSjOR2harLXzjxAPx93k1hdEnukwkIoGSY5xYdENeHTSz+Lavl3/rTQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5150.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(396003)(39860400002)(376002)(136003)(346002)(451199015)(83380400001)(55016003)(2906002)(54906003)(86362001)(38070700005)(5660300002)(38100700002)(52536014)(122000001)(186003)(8936002)(8676002)(66946007)(478600001)(9686003)(7696005)(6506007)(64756008)(41300700001)(66476007)(66556008)(33656002)(71200400001)(110136005)(107886003)(53546011)(76116006)(316002)(4326008)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VF6rEg6PfPpEXamEZqJfgajzDtNQdNGrDdTE6zQRhYVma67B0uBmtVgruOIq?= =?us-ascii?Q?Y7OW9zN5xJyRhotLJyrle9VGHJbBTVE9Q+fjrKGT76/nQG4lMjIrfs89o468?= =?us-ascii?Q?w5neBuhiaORyw4KrNudmwSlAcT4iqOUlYU03tybkJcMeUxxyinJ9ubCtiLh9?= =?us-ascii?Q?gQphVY1rWqsR2EwPEVtq/v3IpaEYl4Al2gjrG/w6H7zSabE3U89ztgWnoWdC?= =?us-ascii?Q?erSa95miz8cVOpGNqTXpbJSo0h6uK4vRO/oNt3y1fOYEwLJw8jNu45BvYvmA?= =?us-ascii?Q?WTz/eIfF7gMP+J+dM3cnpLjDGzsEyqEWXIHm5FRi0K//T81L67IAeBJ0bed/?= =?us-ascii?Q?ZFb/oQdU+gE9LwE3KFh0Y7xl03C7dxKk0SgWSGrzfAyrRY4/wSJmWgiQk7/g?= =?us-ascii?Q?Je1NFauSzJyqBqXG7wyCQHua5EzEO9M0Mm8bzkcIjWfbKhyYmtr8kaLWxZGA?= =?us-ascii?Q?x5WnNKiG0wj1tevzfYIaDMq/MzyYdp/hmpn1D2oc6Pma8AmB4HxME3zRoh3M?= =?us-ascii?Q?mWSdMEAouZHaU/NXemkSxwMF/BC7dKvRn/sC+nO0Tv004ioJlaMFQnfMHpQM?= =?us-ascii?Q?QtV4kdcVN4o5sfb2idsXnQ/iI7VWdEHO91YMITHLb30azx3t+QXx12cFdIub?= =?us-ascii?Q?r7YuHGgfbhqZpbs1d/8+pqn3RP8G7P6nyR6lrSUPPU78KUDpKE5xX7Lv9ENB?= =?us-ascii?Q?vDkASI7XbV9q/D+AVnlYRhwlRONF2cSE42uuQw9Il4W59QY2MK/tz/MiUfpB?= =?us-ascii?Q?HNypRc4f//HYQjrLrNlX4CZSut6t3Nzr4tnS5pGnlGSDZ9YZzSRyV+bwmJKd?= =?us-ascii?Q?djrTZ5ReyGYgb/+PQL66N3Iv3ef8uhRaCpTj0T+bY8W9WVkY2lQXuCyMa4bX?= =?us-ascii?Q?fxYPS076/SP6cE+K2E03AmIST4d0rXQiGPkKpDpYJVjz1kmJfT3jS7kCQ/ji?= =?us-ascii?Q?vcPnnP2dJBeMEAgBThyD5L63M0b+8EX3AugHBGpx44uGoRnbW8fSWjTZJVr9?= =?us-ascii?Q?QmhsaqzkqdNXN8pdAEqWqABvD8gOl8Y9ZLAGgFTBU5Qs70kpFcjWJUuVV8P8?= =?us-ascii?Q?ZtOzXvSgY2Yvpu5TTHDRtwUJZHKdX4E8U0Ym8ZL7+77Wc42yKqidB1WjYfkn?= =?us-ascii?Q?3ogtaPQR4iedNvZ2ELtxJ7aczk4murri3L+Mpsdjn1VFP7qOc+o02pI8KJkW?= =?us-ascii?Q?6nAud5vGIjry2x+kJWOwtOOAVvHBPReL/xOba/j3f/eKTG1sLqfWyiDpHCBh?= =?us-ascii?Q?QqGSGU6w0Fy51sChR1LqYaP3mtPVeO3klx9TYdi4CFY2ykZLbvNFBBEn1Aso?= =?us-ascii?Q?/V9xBq4X9EVxa6ED/tevisn1/EPHW8y9/pz4Qa6kB6+/fszBMdx0DK1dGoV+?= =?us-ascii?Q?qA4bd4y+y+gOMgTwJlJXT3yNaFQTViSg4nO3Nl95OgiPrqSZmMmEzaAuGEV7?= =?us-ascii?Q?QTemQWhuUDD33GcI8f3aLU7V9BCy8RZO0KRS0k8ROmTD511taAUdUn8y7QUS?= =?us-ascii?Q?T2+IahoEHDhp9T+AA50OQXIjDVYZg4jkloSgWC4dyjwO0u7nVImwC1u/evuV?= =?us-ascii?Q?MRIKwD+Z+rWvjfFSqL26EawH/+WMPGE0AkRezc8YuKQqXxPhRn9CUhtS4C58?= =?us-ascii?Q?MeL4Zcq7l/WZayQ7/A/eg6cGmqdhvM3FX8v9HJFGLYz7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5150.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0eb1146-8f0a-4a41-2bac-08daba7b6522 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2022 13:33:56.6515 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aKcN1wWfhX83aDOBNrokusXiMEQIZLDVYatfMJqy0DTBD2qaEhFON0UrSmuI7wmHltoimuROxKTF0HgWMKIvtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7561 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Sunday, October 30, 2022 1:08 PM > To: dev@dpdk.org > Cc: Alex Vesker ; ferruh.yigit@amd.com; > andrew.rybchenko@oktetlabs.ru; Raslan Darawsheh ; > david.marchand@redhat.com; Matan Azrad ; Fan > Zhang ; Ashish Gupta > ; Slava Ovsiienko ; > Ori Kam > Subject: [PATCH v3 1/2] common/mlx5: fix build disabling >=20 > If the dependency common/mlx5 is explicitly disabled, but net/mlx5 is not > explicitly disabled, Meson will read the full recipe of net/mlx5 and will= fail > when accessing a variable from common/mlx5: > drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable > "mlx5_config". >=20 > The solution is to stop parsing net/mlx5 if common/mlx5 is disabled. > The deps array must be defined before stopping, in order to automatically > disable the build of net/mlx5 and print the reason. >=20 > The same protection is applied to other mlx5 drivers, so it will allow us= ing the > variable mlx5_config in future. >=20 > Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") >=20 > Reported-by: Andrew Rybchenko > Signed-off-by: Thomas Monjalon > Tested-by: Andrew Rybchenko > Reviewed-by: David Marchand > Acked-by: Matan Azrad > --- > drivers/compress/mlx5/meson.build | 5 +++++ > drivers/crypto/mlx5/meson.build | 5 +++++ > drivers/net/mlx5/meson.build | 5 +++++ > drivers/regex/mlx5/meson.build | 5 +++++ > drivers/vdpa/mlx5/meson.build | 5 +++++ > 5 files changed, 25 insertions(+) >=20 > diff --git a/drivers/compress/mlx5/meson.build > b/drivers/compress/mlx5/meson.build > index 7aac329986..49ce3aff46 100644 > --- a/drivers/compress/mlx5/meson.build > +++ b/drivers/compress/mlx5/meson.build > @@ -9,6 +9,11 @@ endif >=20 > fmt_name =3D 'mlx5_compress' > deps +=3D ['common_mlx5', 'eal', 'compressdev'] > +if not ('mlx5' in common_drivers) > + # avoid referencing undefined variables from common/mlx5 > + subdir_done() > +endif > + > sources =3D files( > 'mlx5_compress.c', > ) > diff --git a/drivers/crypto/mlx5/meson.build > b/drivers/crypto/mlx5/meson.build index 9d9c9c00bc..7521c4c671 100644 > --- a/drivers/crypto/mlx5/meson.build > +++ b/drivers/crypto/mlx5/meson.build > @@ -9,6 +9,11 @@ endif >=20 > fmt_name =3D 'mlx5_crypto' > deps +=3D ['common_mlx5', 'eal', 'cryptodev'] > +if not ('mlx5' in common_drivers) > + # avoid referencing undefined variables from common/mlx5 > + subdir_done() > +endif > + > sources =3D files( > 'mlx5_crypto.c', > 'mlx5_crypto_dek.c', > diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build > index ff84448186..fa15158039 100644 > --- a/drivers/net/mlx5/meson.build > +++ b/drivers/net/mlx5/meson.build > @@ -9,6 +9,11 @@ if not (is_linux or is_windows) endif >=20 > deps +=3D ['hash', 'common_mlx5'] > +if not ('mlx5' in common_drivers) > + # avoid referencing undefined variables from common/mlx5 > + subdir_done() > +endif > + > headers =3D files('rte_pmd_mlx5.h') > sources =3D files( > 'mlx5.c', > diff --git a/drivers/regex/mlx5/meson.build > b/drivers/regex/mlx5/meson.build index e553dcb83d..70edc5b6da 100644 > --- a/drivers/regex/mlx5/meson.build > +++ b/drivers/regex/mlx5/meson.build > @@ -8,6 +8,11 @@ if not is_linux > endif >=20 > deps +=3D ['common_mlx5', 'eal', 'regexdev'] > +if not ('mlx5' in common_drivers) > + # avoid referencing undefined variables from common/mlx5 > + subdir_done() > +endif > + > sources =3D files( > 'mlx5_regex.c', > 'mlx5_rxp.c', > diff --git a/drivers/vdpa/mlx5/meson.build > b/drivers/vdpa/mlx5/meson.build index 9d8dbb1a82..54a4eac6f4 100644 > --- a/drivers/vdpa/mlx5/meson.build > +++ b/drivers/vdpa/mlx5/meson.build > @@ -8,6 +8,11 @@ if not is_linux > endif >=20 > deps +=3D ['hash', 'common_mlx5', 'vhost', 'pci', 'eal', 'sched'] > +if not ('mlx5' in common_drivers) > + # avoid referencing undefined variables from common/mlx5 > + subdir_done() > +endif > + > sources =3D files( > 'mlx5_vdpa.c', > 'mlx5_vdpa_mem.c', > -- > 2.36.1 Acked-by: Alex Vesker