From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96604A00C2; Thu, 3 Nov 2022 15:16:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2966242D03; Thu, 3 Nov 2022 15:16:58 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2079.outbound.protection.outlook.com [40.107.94.79]) by mails.dpdk.org (Postfix) with ESMTP id 78E0E42D02 for ; Thu, 3 Nov 2022 15:16:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iADuYTohrj9035RLwaBTAWfV0LhjtZ4x/iJAdIAaSxWP9XBVkGrgIiibTOPJc5806HGd8g7VyrfRo95UT3bii2mBP4f46dezXINfuv73K5LL7h5aSM0E4EPKUwwQkgOpB9H3O977uarufEZa8p77h+wVcl0PMp07kysqWopDijEwWoEtJT9STAugqFsIOOPQ6BnMi/DMQSq1wIRuMjqoSxRcTVusgGaUfKCh/uGU/bNklSUx2uCAtC4O/djFrAxFDvJkkdOv1xCoP9Do7aHZA2i6/KaMhNbKYW9ykuD7X0bMeT9frZm6Gm3ttel/YjJr9t8yWpjaiPeelKFcIIYhHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rKCJ3oEGBTPlfwSvsmuUm2x4nLYDI9waunQvJ/xtC3w=; b=mumwkoGLCPCZY9EP1q+JPtuFetUb0NVKhvs/RAi2cy66RVEoY736oBhmShW8bynOQpk0vCgcK32N1vPL7LVfKooi44qhL2CXe2ilLe4cNOxPdQm2IGYwHpJbmTnxrSL104iyWSy3rUjkyPIcXJfFMQK6dVvuh7Grp1w9EreWg8VZW/H3B8G+KHts63i/VezfX82KcNG3Eu1qRqw6PjD0JAduTUxzyizm92kk+TWQqfa1hO1hiWjDS9Xr5Bj0eojFpMLTLiYwgcBT5hMm6GjoyB8VUJYUCwcPWMavAbL5D8LmgY0moVCs0daGsi42dHXE0ROd7TfLwxuRXSmgsMYaLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rKCJ3oEGBTPlfwSvsmuUm2x4nLYDI9waunQvJ/xtC3w=; b=ZjzAhb6Uk2kVfXTrj6WA6f35vYCCYskuYKOdI3+kyPw3rIGKymMlet+D95Bp9GNgQQOg9bbtGhKiceBq2oP9PjiAuLmJ13Amh308IXrfQG+FocZGqyY4ACj9cjy7E6rXnVRfikvx22R2csIUHgNa3bM/ab79pdmyJfkrafNnN7QYGiwAnAUXXgH8gMGxBuh97BywW+8kWBsQmZCCzw9XvidSNOBJte5pqPB80pvE62TN4Zk2ouL8VSJhWJYvYO6aKlDNQg5zqITyBuDUuIWBKIQ646jcWVp6F++WwM5YoarSDpsTLAGkW0mP6NpTkq5Mr+/vhKr7cNRQxOw+rZfdwQ== Received: from DM4PR12MB5150.namprd12.prod.outlook.com (2603:10b6:5:391::23) by MN0PR12MB5763.namprd12.prod.outlook.com (2603:10b6:208:376::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Thu, 3 Nov 2022 14:16:54 +0000 Received: from DM4PR12MB5150.namprd12.prod.outlook.com ([fe80::67b0:c86d:6345:c883]) by DM4PR12MB5150.namprd12.prod.outlook.com ([fe80::67b0:c86d:6345:c883%9]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 14:16:54 +0000 From: Alex Vesker To: Slava Ovsiienko , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Suanming Mou , Matan Azrad CC: "dev@dpdk.org" , Ori Kam Subject: RE: [PATCH] net/mlx5/hws: fix possible negative return on sq create Thread-Topic: [PATCH] net/mlx5/hws: fix possible negative return on sq create Thread-Index: AQHY74MY6QgHGWC6ikukhSCGnLsgK64tPl9w Date: Thu, 3 Nov 2022 14:16:54 +0000 Message-ID: References: <20221103125146.7291-1-valex@nvidia.com> In-Reply-To: <20221103125146.7291-1-valex@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5150:EE_|MN0PR12MB5763:EE_ x-ms-office365-filtering-correlation-id: 9f104b8e-4741-490c-813b-08dabda60f1b x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7Vz1twii1uVonTjIcPfGotesZwQL/rBoys5NBiuWvxYPmuVWUaBZgNP2vZMuNQb6sYoi2GpYq7PhTERkX0I5YGemc1xXGCsvjTUr1MbJOpoX1zqhFgbehwszJAs2U/4a54WAHZNXE7GSkUHlPn7kvm+AZbZ0I7i2iTarVZHyld8Wkes+gXnm+RVEfDKs8OiUCh9Lq50pk0nsgf/XMD4fyV0I+hNoXK5iLU1V9qzQ9B/tkJqsF05DejIM7A5jrczSivs0r+65uvuRL0Qq7SPCzKANTnNhPspNrvl32shfXTrfnVAq+PUutOTotnYBrv9Q1DzXamgYhoYEhUqnj79xBX5vKTNVg7raAWLGZCFf8n0phqfF1aqYHs7RATIg9qxpgW+PCT28TmIrhx/hUIMz2d179R3z6t1q9LfnyeL7N+RVeHAvQM1It75E0OmlWn6eLX8UzhIISLaCkdk2I2Yck5y2s20YgvFrM+srJ7rbXwwhdqVEs1ArYFXHXzZo2idOGm03pNAhapnhctPAJ+S453mvusZgey9cQs9XHSDecDfOOIFuWOObudKqOdGBSwlNFP3b6stu2PN7tFrDfebL9ICbBEm0kw0QsXv4lx5EeA9PE660JsJ66xAxcAgbrVtvdAqIceS45ZYx9sWQ8Lt/Vm9ccdECvqrADK/RgrivaHD18Ue3AA2BOWU6W0urRbDB+uOHOVR0SIrkU6yMsN7W2R7ptnekTDLbHP563caMi+RHDE90TkDTb8hgxOYbPBhPRBC3h890Kjyx4n1nft47vA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5150.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(346002)(376002)(136003)(39860400002)(366004)(451199015)(478600001)(86362001)(6636002)(71200400001)(54906003)(33656002)(64756008)(53546011)(66556008)(4326008)(38070700005)(110136005)(66946007)(66446008)(6506007)(41300700001)(8676002)(76116006)(66476007)(316002)(122000001)(38100700002)(186003)(9686003)(107886003)(5660300002)(2906002)(52536014)(55016003)(8936002)(7696005)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+Y2I9ZLZ6vncXEuFbc4PZhvg6KT7kLE7cL4KY/BKrsbP2yzWRI8rgWwLw/Mv?= =?us-ascii?Q?2rr02FTfv2qVLtYtYI3ueULUYi24LH9v2CwaXGsBzdsOY75c+2STz2kpcJn4?= =?us-ascii?Q?ALhAvxaQlLAOjWKVujGd3ksivCUq6CUaIhX/u4EOy9Kl7ftxur4EcsepRFZt?= =?us-ascii?Q?KzvpVJq2DkUtDHQbGGhBIK0KYWJNNrwQdM86cp10jL9eTB43LTE5LcJo/6jK?= =?us-ascii?Q?km/tsv0z2R1P/+FYV9AGZfJTv/bcoF9nO9/JI4T+TqbKr1IcWtJvgD3uoU51?= =?us-ascii?Q?g3pBgVgtecy/GMIRZoM0LpKeqspp9DH7R1VKYHwgCIurQYcpVUUipVnXxlhU?= =?us-ascii?Q?sFAetiZhyt18Ug6jSffzBWAAi5Fe4HewEXL/OJFh7wpvY3ZEZa+dORt4Lo0i?= =?us-ascii?Q?FXCBuTM3CJzIYYfg44nu7Y5O0j2lTufqLMm6wLDFYbzkAAFqWB1+Huq8TuDD?= =?us-ascii?Q?Rj0cvqCJ7ltd45S5SScC7gQiM40oz2FmmhDNesz7QjG7K2pBO+L+KFu1tObx?= =?us-ascii?Q?SiLBT4CimaOGjI+pXHGf6VjCKkUV6bTFEZ09XzUimn6A/uvW5udogAqX2mLP?= =?us-ascii?Q?Jxkr24Xlc6J3myGdbdQNT2hFbY/hG5ZK/epqXqKQpewFxquoRiRjQApaCqTN?= =?us-ascii?Q?WofzJ2NXsh5A43fNe/ynpVfIfGVYWeNu0e89mT2JoUg17tRBTu9IsU29/GQv?= =?us-ascii?Q?VYtEO6SlxWagQRLwONKjZIsmHtLT8LrFzFBqD23MVmVSLSIZJbWCeXAp+xN+?= =?us-ascii?Q?dbDb/eA5uq2+a4xHN4o4ES7PjBTv2YNgVOK361zPNvFXAv1Xow4ZF/GT85Z5?= =?us-ascii?Q?rKRxJVDvsWCIs/ab/7YOJM9Q15sfwRhAHZ8ehz80gsHL642FmB3aAYgPWaXf?= =?us-ascii?Q?qsnAAU9WKernlVbxVx4s2NGhCHKZHBDZFf808dxfbOSYvaK7WBgj+CEk5v7M?= =?us-ascii?Q?V6mK0EHw7FZAKY90Q6Ozl7+2Izq0GdHwXptibaH0w4z0xHv2/LT2UKWivmw0?= =?us-ascii?Q?ydAbQXxMz3UjcvwFUIBtnVU1Kn3Coc/mNsghkDgytorJyiiwU5KD081D5QpO?= =?us-ascii?Q?/FlLTht+rMOdD0clIK43HTybmHAGAr1qNT/fqK6yq9qZjHzoHTFkljMupsAt?= =?us-ascii?Q?LnUSbfSBuVkyUQ3pTJkLAut5LOd+4AMxBkAgQikXbFf9gljLNAq02/Dgksl+?= =?us-ascii?Q?Tt/iV9U7jg1WJb3UTSNQnvoAaSfuY9D/m8+DgU7arh8dJ1JHn+PMExrPLZrM?= =?us-ascii?Q?yUtbUxEE6ulvBT0eyMheSCYmClFSZqQzTSffUrWDb7BmYLfr6X4SICYItiSt?= =?us-ascii?Q?Of/F62LwCTaG7abdRzzRH4hV5Ow/HSbK0rOzaMW3ROQ6Y4j3a4EsJi1Xu+R8?= =?us-ascii?Q?49LbGjKfOSPNuu0Zz0NUXUL6H529Nt0+A6H7OrCY3R9uFsh2Jq/taGDiKAZe?= =?us-ascii?Q?F/GiHe4iHnOncHQ5FWGL9qzJp2gi+0LxFllxJsM9zJYMxBrW+l5I6Hmx6/yX?= =?us-ascii?Q?qasUalfr9RYytxCPXMMGqTavufbwiJTtB8+n+vwAjIygLrTaQSkSIe7bd+fP?= =?us-ascii?Q?BIn/T8zTPHjIKeYm5AJShs7eWz6wc6z2RdWkKqznATpj6d+9OvDGeKkNnthG?= =?us-ascii?Q?6Rln3P4rwGXeyPTWDv3x4CU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5150.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f104b8e-4741-490c-813b-08dabda60f1b X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2022 14:16:54.1559 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KP/O1ub9bwtbhRW+GIL9alLvEd19iTK2953SrhNvCwMZbfUJwxdX+SfjRrRpyfFmegnJnud2gO0/B1zLXQnwTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5763 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Also forgot to add to commit message: Coverity issue: 381674 > -----Original Message----- > From: Alex Vesker > Sent: Thursday, November 3, 2022 2:52 PM > To: Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; > Matan Azrad > Cc: dev@dpdk.org; Ori Kam > Subject: [PATCH] net/mlx5/hws: fix possible negative return on sq create >=20 > The sysconf call can return a negative value (-1) on failure this will le= ad to > posix_memalign to fail. This is not a realistic case which was found by t= he > static checkers. >=20 > Fixes: 3eb7488 ("net/mlx5/hws: add send layer") > Signed-off-by: Alex Vesker > Reviewed-by: Erez Shitrit > --- > drivers/net/mlx5/hws/mlx5dr_send.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c > b/drivers/net/mlx5/hws/mlx5dr_send.c > index 26904a9040..1e9953a38f 100644 > --- a/drivers/net/mlx5/hws/mlx5dr_send.c > +++ b/drivers/net/mlx5/hws/mlx5dr_send.c > @@ -524,6 +524,7 @@ static int mlx5dr_send_ring_open_sq(struct > mlx5dr_context *ctx, > size_t sq_log_buf_sz; > size_t buf_aligned; > size_t sq_buf_sz; > + size_t page_size; > size_t buf_sz; > int err; >=20 > @@ -532,8 +533,9 @@ static int mlx5dr_send_ring_open_sq(struct > mlx5dr_context *ctx, > sq_buf_sz =3D 1 << (sq_log_buf_sz + > log2above(MLX5_SEND_WQE_BB)); > sq->reg_addr =3D queue->uar->reg_addr; >=20 > - buf_aligned =3D align(sq_buf_sz, sysconf(_SC_PAGESIZE)); > - err =3D posix_memalign((void **)&sq->buf, sysconf(_SC_PAGESIZE), > buf_aligned); > + page_size =3D sysconf(_SC_PAGESIZE); > + buf_aligned =3D align(sq_buf_sz, page_size); > + err =3D posix_memalign((void **)&sq->buf, page_size, buf_aligned); > if (err) { > rte_errno =3D ENOMEM; > return err; > -- > 2.18.1