From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3425A0C41; Thu, 30 Sep 2021 15:30:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8013A410EB; Thu, 30 Sep 2021 15:30:03 +0200 (CEST) Received: from AZHDRRW-EX02.NVIDIA.COM (azhdrrw-ex02.nvidia.com [20.64.145.131]) by mails.dpdk.org (Postfix) with ESMTP id 056E1410EA for ; Thu, 30 Sep 2021 15:30:01 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by mxs.oss.nvidia.com (10.13.234.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.858.15; Thu, 30 Sep 2021 06:30:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ie9o8tdQrEy0S4wQs3G9gBh50OBFmso9VvHsAzfnmGJp/iTD6C2cuhlwM1TmZL/aDOmGxi3ZbmCIRgSzRp2kQ042jQYUXFQViyOY0Lsf9SIJkN5NbyHnPrH5J9Dy98Gi4+QZyUJ7stTgMP6fp2HZfhkHf3SIhvXka0rYJSUpMNmXQQgJu0E/PkHjOK5e/6Q2QK4QiLWeM9tPBbCq0eZ1OM5yr5lqZUTfVx+scx4fuTXHk6OeVWJRJRySqzq7yegMVXydfTS6evhQpz4HFmCnta49zZbwEOk+R8I+0XrLWTzJPqsKkBJzCGjSKPNF+oTKrFTKKWS6UBSqjSdXIvtpPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=tBn8nYYQtpFY/MOhOQffIFyjs1VW7x/mTE2o08cFJOc=; b=lWwnCsqMOZLnJM0Z9hoA2pJ/RpLC6sHw3Fkcqp7Wvv9fKDCHQgPxxUPtdyvL/TrKHYabmDhdEUUneIBLwsVUZ9uVGguhwxW9o/OKRzay2lhWjk/fVMrY39LcSMCgEj2wG5CIjEjR6cwr6AOiFDz+bCGJVGZduOPOjoDb0apoUjDmNfOym6a0JEYJiCvu7YNl8meyMhdT8fCvArrR0wPz68o9U9q3c7qf1LY3kOgz58LuY13sOq6Kz7Q1SiNR/v8H01JupEDEXQrK/2Xu+TJjlO1GD2PxCcPyT+OSZ7qc8NJk5wJOKNKAQDy5c4gl8oinmRPZBcKbix286YN2iygD9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tBn8nYYQtpFY/MOhOQffIFyjs1VW7x/mTE2o08cFJOc=; b=tD+rk0zK6BBXEjxOgkzNIGVLZazh5D34QBu4nLoOsCXL5cmYQoOU1Z4rURm1yZ3vkb6P1+5QKwtqGzWIsj8xfWoSSa8iVr+Ysc3DEORpB4yC3VqCZUuI7NY+djdmrj+EH5i5m3D5uwGqYXMd5AdGsU1qRzlkf4he2CR/9mM7qsd3qU4PPe3QfmaCuftwBk+7EzINVtGFnPxY3g9WWA+GjtMpGiixBg4kLuFKoj+7/GcbSGMvRCHwgXEyHzxyupoug4zMbhIsTHnSHf89r3nazVjpcKCFuDK1hBNSxPeZQz29htp8NEqOIoO32yooOW/OfTozgp6goQybckZliEU8lA== Received: from DM4PR12MB5167.namprd12.prod.outlook.com (2603:10b6:5:396::10) by DM4PR12MB5374.namprd12.prod.outlook.com (2603:10b6:5:39a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13; Thu, 30 Sep 2021 13:29:59 +0000 Received: from DM4PR12MB5167.namprd12.prod.outlook.com ([fe80::3c73:8e07:c9ba:f6db]) by DM4PR12MB5167.namprd12.prod.outlook.com ([fe80::3c73:8e07:c9ba:f6db%3]) with mapi id 15.20.4566.016; Thu, 30 Sep 2021 13:29:59 +0000 From: Ali Alnubani To: Olivier Matz CC: "dev@dpdk.org" , David Marchand , Alexander Kozyrev , NBU-Contact-Thomas Monjalon , Ferruh Yigit , Slava Ovsiienko , "zhaoyan.chen@intel.com" , =?iso-8859-1?Q?Morten_Br=F8rup?= , Andrew Rybchenko , "Ananyev, Konstantin" , Ajit Khaparde , "jerinj@marvell.com" Thread-Topic: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free Thread-Index: AQHW6bAGcPdnNJWMgUmYIFaIdvkI4aoougMAgABAexWABHC5AIABPKQAgABczACBI/kQAIAJrgkAgAAhNACAAAUngIBd4DmAgAAI6ACAAArjAIABdpQAgADk3wCAAQTuMA== Date: Thu, 30 Sep 2021 13:29:59 +0000 Message-ID: References: <20201104170007.8026-1-olivier.matz@6wind.com> <98CBD80474FA8B44BF855DF32C47DC35C61945@smartserver.smartshare.dk> <2065212.rItNS1eAF1@thomas> <3491197.H0bSahjnX1@thomas> <98CBD80474FA8B44BF855DF32C47DC35C61ACA@smartserver.smartshare.dk> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c8aad62d-228e-4098-768b-08d9841666b8 x-ms-traffictypediagnostic: DM4PR12MB5374: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E6kpN+WetqhvY+bFgYHLI0h2LyiZUlbIzAnRbZ5BfXBJNRje6VCmXn8JAmZM6OLBau6wr1iAiZj0V630m5FPn3TWKU/KVf7YCtZupgmNXLAIJP24KvH2KigBzbagjqxEML30hbXELT3Juaezd1HAW3fX6fk3UkhjqrtOIWVfCWTgq1hEzbrv8AmymxcZ3osnokigJ7RQSf1mWh7T0AP3hnmKjQxQw9gNkOuN9Nxc1PXyyKb1ukUUp8TtySr2DfJTU0qkvZDntKbEm3EfpJxpHWz53j+vCvVKF4sfsLq2BC3tlEuZHVr3PcA8bSKDwZzDoUrnXo9Wvylwj4uDLJtljyDzx731STGXgW/Q/4KgkqoBMZfNfcHy4G8KRzMyxGKC7yuNTGXlNWW5EoiuW5OsX+nQfEbYAy50kW5MYo6ZRBNMxapu/gxTqP+sd+rHHHxoxIGtJRRqm+s4/Tz4dO1PXOTxhIhgAiUK29+OJcys7mdEVi8hlQc2yM2DrLDrkVXPG8Bi8K/1+Oi7dlDHe/HeB4xSEc+y+3jPCbW3rrwdkjOe6HlJ07AROUB/FkgfxXjH9P9HSXQwKBpxwamvxiYMzMe2xyX4+z/5EwNnz39GCBHnKdojfSpT8Sg4tLKZEhA2VAGaxs6+XnlK+/fVVhsAaKTgz+fxZxPEsCqDJZE7kazEJb5KcF4+60lJbPMISuZz47RMPHUpLCEYIQoa81Td8vBhSalkbkYqUO9H52uIpf8X5Pu5yn/pKUl8AGm7ds7NKayrRSNlteMROvhrZOik4AZptcM+IkJXaZMEFGUS3h4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5167.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(52536014)(5660300002)(6506007)(53546011)(7696005)(8936002)(8676002)(316002)(66476007)(966005)(508600001)(66946007)(83380400001)(66446008)(64756008)(66556008)(76116006)(2906002)(26005)(71200400001)(38070700005)(186003)(38100700002)(122000001)(33656002)(86362001)(54906003)(107886003)(9686003)(55016002)(66574015)(4326008)(6862004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?GUb9TneXnoDbsSv/W9Ie8D1EjK0QLzNgW2ARV/6g2SVQB7vdnWmyAvs8nC?= =?iso-8859-1?Q?hABiELGsniajd4hjAenN+dMbUn7BNvmssbAKxTIbR/dbL2McJDEX0Ionoa?= =?iso-8859-1?Q?9AsW+KhBFL1LSGhOoDjUBRZBR7lieBWM7LbUkF0TskeYeH/KU8kPZXfzWH?= =?iso-8859-1?Q?2FBxxJZXI/B3Gi8VW6gweSBlpJN0SytzoG/agiJLsaBazTUOrxo8xP7yNd?= =?iso-8859-1?Q?AudiOM9H0/XnnQfHnMeVEmu9yU1TcRDUU4Y7/eWrg99FZMjiXlJ2JXOsgk?= =?iso-8859-1?Q?RwAnHK1d1SZaYAKj5DFRlJ42HNuV9Ot/dqD8JSh7PfoVZuJyFdk8roZD7N?= =?iso-8859-1?Q?8CducZbRnjoCqEj/dniG1sq9GEN5r2CUjAaUum3tIPkhWwWFtPv5bCYllU?= =?iso-8859-1?Q?NWhbUtnY5ckvqb5hosCcLYrxv3RKSFkgf1eqDS6PJJRADF/95JSK0cbCiM?= =?iso-8859-1?Q?GdlQrOVoJSkEB5AJTnUJDokQGofmiWK8SnmPsPE+AEXcRcjsrv61v/gRZ1?= =?iso-8859-1?Q?mFVGVbDlDg9p4czWHSskH950gUQAFzvd022ZQSUBXvncDSpkoWmjdamwCk?= =?iso-8859-1?Q?3pt4CaZ6liu7ha9SCuFMOMpwem5YCAOX8YXXjwiDsdQMCFbk8kSLaWZBrX?= =?iso-8859-1?Q?bI/x27J4HIN9HK3UKscoPzCo80ji58UuAjsk1O/LfwaMSPM0bmKbFzq/xx?= =?iso-8859-1?Q?NjVy6+RvsWvIEtxBRBt5MdEeMtjJ6XvR/40bUCm2DTUVbq/rN7bMDyS2/q?= =?iso-8859-1?Q?fa/U4un+HQ1JwneugQ93Lekvi+VATWTVVeTg6QB+v/nfAIiJJr9Hqow+Ju?= =?iso-8859-1?Q?v1WnKllPaOc03g5p5fOsvBuRjwhrJuChQ4wqd76GZ7SCuyjWw6hDI9ucdP?= =?iso-8859-1?Q?bpmOoC/FViHoeMNosRCfFC7G1NcsdGJH2iSzFhf38DRnXGo9zs4fHu5jvI?= =?iso-8859-1?Q?fQoGApYPGmjiN5uGOtIQ8atRbZTfRQm17mETVZba9cLTyVE53tmr0xQMis?= =?iso-8859-1?Q?xlEXCRi++bqTD/5lVr49AbyunXNh9S6Sa8IozRz/zvWS0xKAmKMrpT75pi?= =?iso-8859-1?Q?7dPKdkB2B83PwDkjtJ2TTG8XzkIbDPE/r8uLM2Netbz/q91JuqbWN8opv1?= =?iso-8859-1?Q?iikylu4ons4NQoV669bEo1vTP97py/llRGJw/w+jq1sL0CzN1W8fPbrqPV?= =?iso-8859-1?Q?Z7PMsVfJX9za0KwX3rXcx6BiV4fVT7+HTdKfpUcTFIK7AgGo+BnQ6Q0hIB?= =?iso-8859-1?Q?pxKuM0uLfM3flUFXIek2p3qSY/0zN+rU353byrtJEpThKDxLbLfHWTf7+B?= =?iso-8859-1?Q?SX6KkGhjdTs8dVDl/k357Tc9BsJpP1OCmNBN3f4q8iuaiXI=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5167.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8aad62d-228e-4098-768b-08d9841666b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2021 13:29:59.6022 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BFKJuCKZ+kcMmbhD3ON4yFQbyoDhlZlcZQoW/rmWtlYP1PBhdbXNqPZGhzAY67O1wgc/arX2Q/LIqxO5w1g1PQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5374 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Olivier Matz > Sent: Thursday, September 30, 2021 12:39 AM > To: Ali Alnubani > Cc: dev@dpdk.org; David Marchand ; > Alexander Kozyrev ; NBU-Contact-Thomas Monjalon > ; Ferruh Yigit ; Slava > Ovsiienko ; zhaoyan.chen@intel.com; Morten > Br=F8rup ; Andrew Rybchenko > ; Ananyev, Konstantin > ; Ajit Khaparde > ; jerinj@marvell.com > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf > free >=20 > Hi Ali, >=20 >=20 > On Wed, Sep 29, 2021 at 08:03:17AM +0000, Ali Alnubani wrote: > > Hi Olivier, > > > > I wanted to retest the patch on latest main, but it no longer applies, = could > you please rebase it? >=20 > I rebased the patch: > https://patchwork.dpdk.org/project/dpdk/patch/20210929213707.17727-1- > olivier.matz@6wind.com/ >=20 Thanks for the update, I tested v5 on main (84b3e4555a1f) and the regression we previously saw no = longer reproduces. Will the patch be backported to 20.11? I can still reproduce a 2% drop in s= ingle core packet forwarding performance with v4 applied on v20.11.3. Testpmd: dpdk-testpmd -n 4 -a 0000:82:00.0 -a 0000:82:00.1 -c 0x9000 -- = -i --nb-cores=3D1 --txd=3D256 --rxd=3D256 --auto-start Traffic generator is TREX with pattern (Ether / IP / UDP). Drop is from ~50.5 mpps to ~49.5 mpps. OS: 18.04.5 LTS Device: ConnectX-5 MLNX_OFED: MLNX_OFED_LINUX-5.4-1.0.3.0 Firmware: 16.31.1014 Regards, Ali