DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ali Alnubani <alialnu@nvidia.com>
To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "mdr@ashroe.eu" <mdr@ashroe.eu>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"techboard@dpdk.org" <techboard@dpdk.org>,
	David Christensen <drc@linux.vnet.ibm.com>
Subject: RE: [PATCH] eal/ppc: undefine AltiVec keyword vector
Date: Wed, 25 May 2022 11:08:49 +0000	[thread overview]
Message-ID: <DM4PR12MB51678F6D685C71333B4DC582DAD69@DM4PR12MB5167.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220525095307.675312-1-thomas@monjalon.net>

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, May 25, 2022 12:53 PM
> To: dev@dpdk.org
> Cc: mdr@ashroe.eu; david.marchand@redhat.com; techboard@dpdk.org;
> David Christensen <drc@linux.vnet.ibm.com>
> Subject: [PATCH] eal/ppc: undefine AltiVec keyword vector
> 
> The AltiVec header file is defining "vector", except in C++ build.
> The keyword "vector" may conflict easily.
> As a rule, it is better to use the alternative keyword "__vector".
> 
> The DPDK header file rte_altivec.h takes care of undefining "vector",
> so the applications and dependencies are free to define the name "vector".
> 
> This is a compatibility breakage for applications which were using
> the keyword "vector" for its AltiVec meaning.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---

Build passes with latest rdma-core master (36395896) on Ubuntu 20.04.4.

Tested-by: Ali Alnubani <alialnu@nvidia.com>

Thanks,
Ali

  parent reply	other threads:[~2022-05-25 11:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25  9:53 Thomas Monjalon
2022-05-25 10:01 ` Tyler Retzlaff
2022-05-25 11:08 ` Ali Alnubani [this message]
2022-05-25 11:10   ` Ali Alnubani
2022-05-25 11:48 ` Ray Kinsella
2022-05-25 15:40   ` Thomas Monjalon
2022-05-25 18:02     ` Ray Kinsella
2022-05-25 18:34       ` Tyler Retzlaff
2022-05-26 10:18         ` Thomas Monjalon
2022-05-26 11:02           ` Ray Kinsella
2022-06-01 15:04             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB51678F6D685C71333B4DC582DAD69@DM4PR12MB5167.namprd12.prod.outlook.com \
    --to=alialnu@nvidia.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    --cc=mdr@ashroe.eu \
    --cc=techboard@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).