From: Ali Alnubani <alialnu@nvidia.com>
To: Jie Hai <haijie1@huawei.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Shiyang He <shiyangx.he@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"liudongdong3@huawei.com" <liudongdong3@huawei.com>
Subject: RE: [PATCH v2] app/testpmd: fix invalid queue ID when start port
Date: Tue, 4 Jul 2023 09:16:50 +0000 [thread overview]
Message-ID: <DM4PR12MB5167DCD6848F550F6739116DDA2EA@DM4PR12MB5167.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230704084507.12788-1-haijie1@huawei.com>
> -----Original Message-----
> From: Jie Hai <haijie1@huawei.com>
> Sent: Tuesday, July 4, 2023 11:45 AM
> To: Aman Singh <aman.deep.singh@intel.com>; Yuying Zhang
> <yuying.zhang@intel.com>; Ferruh Yigit <ferruh.yigit@amd.com>; Shiyang He
> <shiyangx.he@intel.com>
> Cc: dev@dpdk.org; liudongdong3@huawei.com; Ali Alnubani
> <alialnu@nvidia.com>
> Subject: [PATCH v2] app/testpmd: fix invalid queue ID when start port
>
> Function update_queue_state updates queue state of all queues
> of all ports, using the queue num nb_rxq|nb_txq stored locally
> by testpmd. An error on the invalid queue ID occurs if we run
> testpmd with two ports and detach-attach one of them and start
> the other port first. This is because the attached port has not
> been configured and has no queues, which differs from nb_rxq|nb_txq.
> The similar error happens in multi-process senoris if secondary
> process attaches a port and starts it.
>
> This patch updates queue state of the specified port, which has
> been configured by primary process. As the secondary process
> cannot configure the ports, make sure that the secondary process
> starts the port only after the primary process has done so.
>
> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling all
> queues")
> Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet
> forwarding")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> ---
> app/test-pmd/testpmd.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> --
Thanks Jie.
Tested-by: Ali Alnubani <alialnu@nvidia.com>
next prev parent reply other threads:[~2023-07-04 9:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 11:02 [PATCH] " Jie Hai
2023-07-03 12:33 ` Ali Alnubani
2023-07-04 2:01 ` Jie Hai
2023-07-04 2:22 ` lihuisong (C)
2023-07-04 8:45 ` [PATCH v2] " Jie Hai
2023-07-04 9:16 ` Ali Alnubani [this message]
2023-07-04 9:42 ` fengchengwen
2023-07-04 10:59 ` Ferruh Yigit
2023-07-05 3:16 ` lihuisong (C)
2023-07-05 8:02 ` Ferruh Yigit
2023-07-05 8:07 ` Ferruh Yigit
2023-07-05 9:40 ` lihuisong (C)
2023-07-05 11:41 ` Ferruh Yigit
2023-07-06 2:48 ` lihuisong (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5167DCD6848F550F6739116DDA2EA@DM4PR12MB5167.namprd12.prod.outlook.com \
--to=alialnu@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=haijie1@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=shiyangx.he@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).