From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5860A4555B; Wed, 3 Jul 2024 10:00:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 350954029B; Wed, 3 Jul 2024 10:00:13 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2073.outbound.protection.outlook.com [40.107.220.73]) by mails.dpdk.org (Postfix) with ESMTP id 9B4664003C for ; Wed, 3 Jul 2024 10:00:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K4h0KHlHFh6GlgvcA9HFqytZUdnTLeMQotpi9cbFbHhFQ+YyBnqqPo4vpLiWX3+2rR/RbyOUMFQg82QGvwjkrYGg+ThgZkenSsw7MB4vJJUqdbmG4PXg9kVmdzeg6hzrePwlw9wm+QFV59gxElWg0zVwBnfIL3+c+1PaI4Nyg0k07bqzBLd9g6lCqG3GuwDfrve4601Og7Wnc+/44CinnpHdd1Mbsuwz80AlSeMpmjnRkX9liBDRYA2xB0FWArILK0vDbTLx9r4e2q1tGBFBQTpiFCE1D6XywSsanf9F/O6wv09wcV1VAD1+7q91T7YKPkWVZCmn7HZcA6OGhGAVSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JclrDRP+H7l/GlMfoGVRiA7FWKL5F9WOBCXItB64q/c=; b=N/PZGuJCiwknhP12KTsOa3bzH/v2R0Ryji1+LYxP0/6QmGPYP4mlP34qKXKqGm1o3n+ltgcNjCo5t35bE/PwiALCB4GieNSAiwb/3W1qp/PwOPC9HIOctv9YR+xKaDcE5ygKv2kRW6gEEZOA85GDblZLI3ohUMYL/kXotU95wWcj4ueLz2GaIw1TSxuWIqgusozJnxBwJsGS4ASIeiPneISyBRyvHt/tVqLzzCOiAPqhvbuhP7q97J/mJY2Mj2s+py4af6dh13ilmAsYEznaMsbqfFhLUClkVMhq33F2IdwOeFV2AqAJdZyiMT7Aaduzg994JZ7pC9KuQzg+57Ug8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JclrDRP+H7l/GlMfoGVRiA7FWKL5F9WOBCXItB64q/c=; b=FWX3kG+80uzw5vqZ0F+PglaMbp43rilQCKpB8JgL6jDjgoW1BTNVxut+sgT/sEcsD69UX7FNVb72PrAP8zouZ1Msyv8kR5jQx8UNl+vTylDaEa5qu9vwd7Ju8ZsVS+EDxKy7I0dY+k7ChPuSaVXJleCiOHbghf8r38SWi4Sq4GxBJluU6gZ5icj6KEbASCuSowlV9LdN00qQ1OwsgALN2DdmkvCrIdA1i6oRYd3+hYEZEDQzv4bbc3JtOyvm7l12NRf8fCAjfxVtU4aRNW7YQZfeRhxoAugZUSBkAxW431z1y9pOfOr2P/ewmG8pwiiY2GsG2KbI4lOJW3OkAgF6Tw== Received: from DM4PR12MB5184.namprd12.prod.outlook.com (2603:10b6:5:397::18) by MW4PR12MB7239.namprd12.prod.outlook.com (2603:10b6:303:228::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.25; Wed, 3 Jul 2024 08:00:08 +0000 Received: from DM4PR12MB5184.namprd12.prod.outlook.com ([fe80::c8eb:eeb9:cd73:b236]) by DM4PR12MB5184.namprd12.prod.outlook.com ([fe80::c8eb:eeb9:cd73:b236%3]) with mapi id 15.20.7719.029; Wed, 3 Jul 2024 08:00:08 +0000 From: Bing Zhao To: Mahmoud Maatuq , Dariusz Sosnowski , Slava Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad , Maayan Kashani CC: "dev@dpdk.org" Subject: RE: [PATCH v3] net/mlx5: fix matcher object memory leak Thread-Topic: [PATCH v3] net/mlx5: fix matcher object memory leak Thread-Index: AQHazLySjY55YP/WC0CM1DbmW8fiLLHko3ew Date: Wed, 3 Jul 2024 08:00:07 +0000 Message-ID: References: <20240623103539.1690600-1-mahmoudmatook.mm@gmail.com> <20240702201450.349991-1-mahmoudmatook.mm@gmail.com> In-Reply-To: <20240702201450.349991-1-mahmoudmatook.mm@gmail.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5184:EE_|MW4PR12MB7239:EE_ x-ms-office365-filtering-correlation-id: 7df6dab1-4205-47a7-5308-08dc9b3627e0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?eS8cHI6QNHDPNQDDDV1pZupxVPAeTDjwSr4sSsOrvLp9FOqXaXgPPT8EQtLn?= =?us-ascii?Q?dT9dXexuKwGbvV3fTvQ0Gx2VSRJtm0TSJ6xwIKgXWZvicAbErEMMooGUhn6C?= =?us-ascii?Q?BDqjNz25mg6Sfr5Rw6cKA8GdBfDxRH9Z5oIVEFNlSviIckGuk1XrgYLu7D+U?= =?us-ascii?Q?m+IbNk22HQy+WupCzs6gZThwo4HN4hv59Rv8QyeP8q+GfVhqhEmS+9kyRR3n?= =?us-ascii?Q?Z2aJyUkWB3n5pwZWF/Y+d60QsLOihl/BQGPfI3N7kKgZTPDcCp33Fev/k+Lu?= =?us-ascii?Q?3mTU2WhS5BM3ajmd8RDcvZVN5HuRVKGd2bGAY6GUOnqzCO4j6U3SON+vAANn?= =?us-ascii?Q?HLui72FLumgNN0FH351yMYgyVV3GrRw2oEEZcl7Xh8oLQtaxCvjP4dXDleTZ?= =?us-ascii?Q?zOdv5YuvpMzprAljOXBbz5mFco/7iOujEEtooy44QMiTRTQxj2MLQYV7Xnf6?= =?us-ascii?Q?QZstog8maCEejEw5cL+vYPiUWnDVZ9mz7UjE4yy7RQ1nrQzlUpmdawy1YTu7?= =?us-ascii?Q?HuYBZmWxoh4Lxabj+aB7EBUyee232ZHJih/aiA7qXAmXxQEHz+gTLA7fOsto?= =?us-ascii?Q?aWwVmY90+nWDv7Bzadwgxt8H44rms47JSUOHfyci2JB+PFbxcUVWDCU/1zFl?= =?us-ascii?Q?Fh/Oh3tIyNcKujYgonCQRLP+4G1TjQmNWgMMWnaGLsQ2ysrdFLoZmOilprmM?= =?us-ascii?Q?OS+iQCm939SRWJhI0V1qlipeS+lnKlD1qV64oO/V3PwSlBwtWEi1aamsqno6?= =?us-ascii?Q?PraSl8ayd1JvRPUQVVweotOVwZzoWkD42G9K8ZJWzOEtoF8LMFdEB5jyIel4?= =?us-ascii?Q?MmEutLTXp8WVfJfEMt8MIUSh7K4VfGA6synnpG5HpnigriPTHekIr6GLKdRp?= =?us-ascii?Q?KqrwABmVj6Cp4lgyiMkwHFo8cC3CfwgwaS6moTTz90QlC+KHrzdufb9au8pG?= =?us-ascii?Q?jv/lhNEX1f3o6U7HbR2xZs2Zv4dlRrZ2WRjSlocEq/brOZcbggIIYr8l/w7a?= =?us-ascii?Q?eImhGwtZdmg9uZSj8NQdloorUqCElNAeYZRTHMOlk6xEzSyERnl3vIqzVh1g?= =?us-ascii?Q?ZjcVVMuwQaOG3GZsJ9XEJbZOcW0uCwt82PfhJAepNTlUtwk0/qescThuueLo?= =?us-ascii?Q?bS3C2gpEtLOh6jzxe4pqjwkBKZUgs5XVZqfpmQBt196xtjfwvnwAOQk0xniR?= =?us-ascii?Q?xjgfkcBK3TiDgfJm9kjcb+wb/uT3yEH3mn+s4z7QNO5mm69czRxToP2hEEm6?= =?us-ascii?Q?GR+stFSSbex/MxaNds2B40+loUK28g0Sc3aFPUrkgZOFt8KHIrnx4LaxQ+XM?= =?us-ascii?Q?ejhc93UeJZ4F8QvHJUNJbyK22lPC2PmFERKxnbAwtfqjNGcgQwsOeX7PSLDG?= =?us-ascii?Q?Cur4SfIVj2LiD5/7aiUAMQvjmwqoZQd72GGuCth3XnY5+8VcnA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5184.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CAVwj5lqz3f/mJvZTl6AyFcf7v7OHBiJ+V9S+W7s3FQHiCj1chI6kXC13lwN?= =?us-ascii?Q?keyamivYKraKNOT7F1xUKcy6Bk/PxXFoKBgxAIw8tbLcC0ytEhNVHSJrIWdc?= =?us-ascii?Q?hUYT5KU5dIKwyaNAkCPJ6icvuhBXXfYbhUhOYQ1Clu9tpvugLa2vK4VKdNbT?= =?us-ascii?Q?1a/WtoIy9dUhkzPN3IfWdBcqAWmFEwP9t9rbr/XBiw1OYyf5GXoxcgY2G3zd?= =?us-ascii?Q?mVNyA9mvNFN+XsBHB6QjhatSIDApt4UQpTfDTpyUE8qj0+PXWsJLhBTvAR5A?= =?us-ascii?Q?Saobrm0TgjoNf8ZgZiPL89A/fi2ysxTjrDKW+1vfyBdrjax2fLP/8JFYESK3?= =?us-ascii?Q?7XnowRt+oOIy4M2RX4osx4ElzFJWk9srVCh8/fPpjuDnpRMsBWCMvMlCL0cP?= =?us-ascii?Q?uNOAO4v7k8y5APa3KiX7kYJzW6mbRtRbdTV/XYggiBHNEdaKu12mryj8CfHe?= =?us-ascii?Q?/H2oDXVlsKHpRkSIgc5Wpr68TSYRHhLyBcPMH2VfY6JQ0TzDvBW7o1vWIJHP?= =?us-ascii?Q?xavbnNGqR0dY5n0502tbmoxggztqor4NODEScEky5zlJrO4bpfKkDvrRH2w7?= =?us-ascii?Q?Y4i3V7p8JhEiAfhzdZVV+vvt86PIsdxOjPz1nz2pddDctZOyV1lgwYoUzGx0?= =?us-ascii?Q?ytZoj8RiC4UnQy3aONBe4IO9lccBzW6bGNQXe3CGq8p1vRP3edLPMVJGiGbq?= =?us-ascii?Q?ueNRzJd0EBIBoopQolNu9bm2pPhHspMBxOY98jtXrCXY0VUcors5ldtRU3WX?= =?us-ascii?Q?l/MJBJ3ilrG8z5ci4eMC3ADtGeMSd5rdhu3AaVK4pAYO6ycpBFCaejgtK7St?= =?us-ascii?Q?CBN6JM25Qxd9EyWvMNq257FBqKYs0uCq/kJBeSIA5d4/9SK5K0A5k65pT3Vn?= =?us-ascii?Q?Mq8lST4PAewUC5PXBF4Bi3zyUQckASHg8u2b0+iFyqnOIkuwskccYe3kkvqg?= =?us-ascii?Q?cRmPMw5iodKWoaCcQXHP7i3YAPXp1/kTG6vIF61JAUJi50/Qkpbp2UDpOaD/?= =?us-ascii?Q?fHX0ML37pEHn3YdURcdt6qOEDCxd5u5eGMNixBTNN7Hia+ejdtrXLb+SU1Gp?= =?us-ascii?Q?dCBidh7kXZLd84k/Efr3Lt4t4m1509k0PbNuOeJhAT/gSVSBw0SqGzNyhJh4?= =?us-ascii?Q?Hx02jW8HIolbSHLMXRpX1y4DRF40t7wRiEBV++PiySVfk7X+WIs9vV6TeQ+k?= =?us-ascii?Q?b2HIcc51R3PQDx4b4UN3LrM78z1ehySDXvYc9K+yOVdR2cLVkHgU5UXrhkj3?= =?us-ascii?Q?lB094isEQ7l/sTkkpIbIEQJWlUzd0PzohI84TiCBaCtmr4tXPM8NKmrLcdaR?= =?us-ascii?Q?TG2GQsmcjuLO2oTypTq5g5gr3S5LAETCSAgRNg537hVDwfQ152z04RiayDxT?= =?us-ascii?Q?4NoWj4Z0JH9Fa8UR+zBS5xiDCdQtlgIQg2OgRfsGhfPpUWuJRCrXcKO9ftGu?= =?us-ascii?Q?Nd4wBl81M4K+uv9gaLI/PmwNTFXbEYanb5rqfODE72KowpdbJBDK0QYYWxdy?= =?us-ascii?Q?rWi3CnSVysAxxJ8pmjZV+83GFet17/h2UP4TbcLtbMqWPiUiQDqxCO+nwCsU?= =?us-ascii?Q?9K0RSkuaohBTr3mQoJo=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5184.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7df6dab1-4205-47a7-5308-08dc9b3627e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2024 08:00:07.9101 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xFfs89LHYah0BfUHi7RkU7PZxBV8uOaL5Et/2IbSQFb2fYroDgm6BezCe2sDDrAmfeQDDsf+0NEjRsnA1LDOrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7239 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Mahmoud Maatuq > Sent: Wednesday, July 3, 2024 4:15 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > ; Maayan Kashani > Cc: dev@dpdk.org; Mahmoud Maatuq > Subject: [PATCH v3] net/mlx5: fix matcher object memory leak >=20 > External email: Use caution opening links or attachments >=20 >=20 > This makes sure that the allocated matcher object is freed for all > branches that return NULL. >=20 > Coverity issue: 426424 > Fixes: 27d171b88031 ("net/mlx5: abstract flow action and enable > reconfigure") > Cc: mkashani@nvidia.com >=20 > Signed-off-by: Mahmoud Maatuq > --- > v3: > * changed commit message. > * fixed typos > v2: > * fixed Fixes and Cc tags. > --- > drivers/net/mlx5/mlx5_flow_dv.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index d46beffd4c..8a0d58cb05 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -12010,9 +12010,12 @@ flow_matcher_create_cb(void *tool_ctx, void > *cb_ctx) > items =3D *((const struct rte_flow_item **)(ctx->data2)); > resource->matcher_object =3D mlx5dr_bwc_matcher_create > (resource->group->tbl, resource->priority= , > items); > - if (!(resource->matcher_object)) > + if (!resource->matcher_object) { > + mlx5_free(resource); > return NULL; > + } > #else > + mlx5_free(resource); > return NULL; > #endif > } > -- > 2.43.0 Acked-by: Bing Zhao