From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F368A0032; Sun, 14 Nov 2021 16:28:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C493D4013F; Sun, 14 Nov 2021 16:28:05 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2070.outbound.protection.outlook.com [40.107.220.70]) by mails.dpdk.org (Postfix) with ESMTP id 34CC240040 for ; Sun, 14 Nov 2021 16:28:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GgKhNCp7Uqh9ZE6a9ekCksqJ2cvJZ1tSqK/+G37r/+mRFTKioLaWkxCPYSl7LhvtwjvG01W0zGV3T0DSYOiOA0aIQzYepqv5T7u+6gCqqBgGN2Su/RQdLWZL29ALC42wxVWbSw5rcB3ynMcBVNZcqLIm69F/NL2K2WJBcIUKYvbAa4TItCaSe1JLWFZ42HUqYoLzadvmmSMvKvYlUm/6sFgtKnDtSeMNmLJZa6yAiOgIIpJJjia8gbevhbU+tOrO0wxUFhVVIcCia/Y9KMAx35yicGkHvQlb/66jEOnp8G9isrQIlgKpKl0eU9ZegjNUuX58SE5XlVibzYoW69aL8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SRlbPEFPSBP+IjYqbS6ZVDUCdmebZ7Z7lanlq6zg20A=; b=lb4luZcc3D0sKnpIOTw5Ca9iCG+SgPEJVN2U+j0AsxCuDBdclCiVJY88bhiH9jz5hQRuynkY3Rw/EBQV59q9Fl4r/IjleiRLy2ZxludaPRz3Hxa1VIAFcsHM2PSh+Gyvs9l4dPiwPtToQajkEJ3IkPRJRaoMRra1eG4tRBHHLTNd1lCVvocUXdBXZ4+C3i1mJR1Gnl330ZeBPYfuGeVucd+Dter8OcJTbAph2bdLJoJklCKHDVTo0NN67XtkkP1yLniQaHR9t5tdSXqcg/CNGvAIaeTiD4DMs4Y8aQmLxiVQWxp/jW35/KKIGHBsHR4o7Nz3JHNOsuoGoDivhSDU6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SRlbPEFPSBP+IjYqbS6ZVDUCdmebZ7Z7lanlq6zg20A=; b=eicACjOdLG0FKxt5GEHwuCipPS20zvmENNEK+80dffaMtnfC5NeJ602dawYI7zacdIiLvMg+1tOv2fuPKTjJdxDFTtIPkT8C7KOMfQu+lzpYnUXqDPC2ycrFljVxU1APD5Y0QcILEJZbobEa2tMKU4giH5hiHP81LCy8T73VA6DaIEwSPiMNnJ6gKVcCF7KV6m9jhhpziqcgLacEkfC6jqFpbRBHF9SZrXyHUfGYK6FRlwvCPNqg4GQq2xuvqiP6I7g/q7nBonoVu8VPPXZFOfiwlMAXTxEww5BedKFkQcsBFC7r5lYyCyxbe85Ye2fUm/T634fcQ0efUmRjPjDpug== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (13.101.61.52) by DM6PR12MB5533.namprd12.prod.outlook.com (20.179.167.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Sun, 14 Nov 2021 15:28:02 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4%9]) with mapi id 15.20.4690.026; Sun, 14 Nov 2021 15:28:02 +0000 From: Raslan Darawsheh To: Bing Zhao , Slava Ovsiienko , Matan Azrad CC: "dev@dpdk.org" Subject: RE: [PATCH] net/mlx5: fix the delay drop bit set overflow Thread-Topic: [PATCH] net/mlx5: fix the delay drop bit set overflow Thread-Index: AQHX19MN2a1CMNlGH0K0gFtH2pgkuKwDKKFg Date: Sun, 14 Nov 2021 15:28:02 +0000 Message-ID: References: <20211112143842.9290-1-bingz@nvidia.com> In-Reply-To: <20211112143842.9290-1-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fbf8c584-63dc-4cd3-36d0-08d9a7835921 x-ms-traffictypediagnostic: DM6PR12MB5533: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iRhS+vmD6/TztHug8HwM2xIQ5FQ2QaBAdR04keYgS5jNeIhc+ZhCLJBxnFmaCju+U4KIFCHAL+MeUKc9hQkJjLQYfYZ6xrbmPnB3crkBXtvoksuPNGQWHKXdvWq44lRe8WeBtl6s/A7s7wpjJi0h0yTbwcKzIvwv681+w/USk0WLK5RZq+/RyuhTMP6Cq6n/OmPWjtVyC3r/CvTsbAueiS+BH0eoZ0by67ECUL1X5oPs6r8U7ATIrpGN+7XZWnqen6ErQXU4/ICeceX/eQryyWK+S8wf5ic9MsoRhJZY4Fg9lgjDm9SwyQQOUDztreXGilr6Y6GTLQ9pWwmVtbl++NxrISvTPxatsyLDbKRAc9BEI0aStFDk8AE0QS5nm/i7HkcPSyEsi0JBGwXdQCyEW9leLFW8spHcztNk/ssomGOYi04UQPy2VCIP/ubKCV5r9ge6m3W+c3Ms1mq+cNJ30hvqLeckEgI/iH3kOcj1xxBCSEFuZ7wWTH20bcErqF27JbHKlH5vRwJNJBx89FyfeCFgkRvVPVhcWurA/IIsvMjJzVWQQmv2F2Tg5oaZRinQUomQVDvqdnMrPwDEJ+KS6vaPuRExj8GcP6+teZyljRtoA2PGiuU4YOzglco96OCecHvc4mCUiTYUiTBfWn8DzXMBCkkhq0xl5527Ixv26DEjO0mS7RIoevu+TQL9NsZkYJeW9jenwWPPmsjbxkShrw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(4326008)(55016002)(6506007)(6636002)(26005)(76116006)(8676002)(66556008)(66946007)(71200400001)(66476007)(110136005)(8936002)(316002)(66446008)(64756008)(38100700002)(2906002)(122000001)(7696005)(186003)(38070700005)(83380400001)(9686003)(52536014)(508600001)(86362001)(5660300002)(33656002)(4744005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BHecAm+CPdk1me7kcnKd7W1ynJvfoX/1pdG5LKbnwDLF1yXFXU+vlqVs/2UN?= =?us-ascii?Q?ZQCVpafuuMoAot597OLgtKnpaykDxqWHW7pxXW5T0nme4OAlpuDLmvTQSewS?= =?us-ascii?Q?8q7dsUQRQy4rqsmM81o3jGC4nWJlVSxxeGRhQ7U1LXJgsSAOMZZ7XmOl7S6E?= =?us-ascii?Q?utscNCbmlKETUHav5lkPG6ijY8fujanTl7noDyWkBygBQXqiff30lUtjNZuK?= =?us-ascii?Q?mZfMgdvFpoZ/+qYxjZ/GPXwTdAsMTosqJWfFWSFPZlPXvTstmmgKNtVqdSFP?= =?us-ascii?Q?+n0S8aa3FEZnOiPhGSeN7qo7Q9cTbPrzygd5mKgNjue6gQ2o37pu1B7uLaCn?= =?us-ascii?Q?h1ZF+ZTdmu8XgQfej1hByhUAYjkZlbE6F1OpSoOIw/FX6pdJmHyJp3tNmQGY?= =?us-ascii?Q?6MVi2W5maLI0UwAXaL0n720MLwc49T5uIr62rsamDoudRVjKeDZPSltYqBLA?= =?us-ascii?Q?vnv192OVnk8rfcB1wreMt8HhtslA8bBwOWKZ5AM9AnCS0/aRvwbI2IRaHX3a?= =?us-ascii?Q?RX4lOLLSDgUDXoYmOo853Qs93SVDsoUxGmfm2/yT9CMqhIrOT2FAaebW/3c/?= =?us-ascii?Q?4FykW16ChFmek0mt5Vxfw3X80qioi026uB2UFElpojLilNfGunqmy5WrgZYa?= =?us-ascii?Q?ggIEkJ9Mw7jmt7AulxJyzhmA8sTgG1dmkL/WTb3FdGkdoNst1slsOf6WkDIC?= =?us-ascii?Q?uS08FAUfiKthZx+DmcTyFCeW80IY7k94TFaGXFwg3uvCjW434o+aOKfyslti?= =?us-ascii?Q?rDfHKDEte19cs1yW0asGZgFByjfWLu6TrMD23cRbKzOkHXm2NNR8xIusV0xt?= =?us-ascii?Q?dS425CUIFXHNB4mott7To3sUsup5p7SlJfcA0IRzCBpFc8chvnQqlWkG2dn2?= =?us-ascii?Q?RuO3ZsGsKHas2aG9yh4x8tuub9NuQt+Mi1FqgkZLiY8AEr35/oqdFKxImsw2?= =?us-ascii?Q?RWyOehC1h9SrNIkkYXJ8yIeH3D15s2rInqn/PwNS6+Kdry7ZfAVUWRsNIRhQ?= =?us-ascii?Q?TBwjSUKpy/ul6F8IvMgjHy3hAvGahswpzAQvQQzPtNywbYUl+YszWtWbb4dX?= =?us-ascii?Q?6xOrZ+80SG6iD+1yidrHrU0zVKZlH4kF4S4xlZa9LPQaL4h4Ft+mQx9RPmCs?= =?us-ascii?Q?FpsaPOmNu1qHWGaqmCxZbX8djz6mlUFdVp/DbBw57PwYXtXSYlt4XuL3nAUU?= =?us-ascii?Q?2l4savRmSO2SgbKdv94JfkpfSAs/U8taX0gChJRQjipstqZPNylEeudxXe4H?= =?us-ascii?Q?itjUw365HeQ0m5qdezvGAQKmtfyTUSxglQQekBepRlFJ5CY1yvadc5KFbeVd?= =?us-ascii?Q?3spyyMuF0RNpbrWR2WkuOluIObZDejQNHkozB72Es2aoO8uAhLg6bMIhPsd/?= =?us-ascii?Q?EbA6Fo6VnDGjykdkFZqKzwpFwg/9lRL92gZI9WPT77XtcO6B5KOPqVOC/fNT?= =?us-ascii?Q?TGvzR87/JSJVmT+xJEsuL1JO7xugObvXDsjx9HqZmCqWbTt4+SD/zNVw3TV2?= =?us-ascii?Q?FGmqZ6C41ZX4v5FZc4xxXJHB+5RrxqHY0crj9c6zCNb8Ui2XSwo4OhV+ZIrW?= =?us-ascii?Q?+vp7qpMXlEVhZPx7j2iJmd4YByOL6XUhcSnQwS2TmRIdE71MTVyqiyDRBmlH?= =?us-ascii?Q?pFoEy3HejUVNeVNcepBePHM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbf8c584-63dc-4cd3-36d0-08d9a7835921 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2021 15:28:02.6025 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 42YZz8cJ+R3NT3jlb/oqRpogMTx5MtPk+ToHvinx6xZfAqlyoB1kV8f5TxEsClGwGMx7iGcX/qrJJ1e5fvNnWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5533 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Bing Zhao > Sent: Friday, November 12, 2021 4:39 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: fix the delay drop bit set overflow >=20 > The attribute to record the global control of hairpin queues' delay drop = was > defined as a bit-field with one bit, and the intention was to reduce the > memory overhead. In the meanwhile, the macro was defined as an > enumerated value 0x2. >=20 > No matter what value inputted via devarg, the lowest bit was always zero > and the higher bits would be ignored. For hairpin queues, the delay drop > attribute couldn't be enabled. >=20 > With the commit, the double logical negation is used to fix this. >=20 > Fixes: febcac7b46cd ("net/mlx5: support Rx queue delay drop") >=20 > Signed-off-by: Bing Zhao > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh