From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1052A0C4B; Tue, 23 Nov 2021 23:39:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB9BF40E0F; Tue, 23 Nov 2021 23:39:07 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2079.outbound.protection.outlook.com [40.107.237.79]) by mails.dpdk.org (Postfix) with ESMTP id 5657940040 for ; Tue, 23 Nov 2021 23:39:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oa7uuaKUM/+yWFW66YY753Ci370Yd37tPfNcE6htF0zzQO7KYHk5AAsfHgwgqCxf10zKzbJng53rcquHyuE9wjk3B9ZwQzKkztqIEiyBZ75/7AfgVYYNJ2NHIQK9z7sVGK4qw9t+WtDrDgz8ilwWb5g7wjDo2MYEn6wM1qQzCBNJXHbISc1Zq08rjRZwKi1Pnwk4w5da8OJHFPAUNuKeYXC3+4dy2OiQEgc/ms3I8ja5xrcMP3UO03d1BeLJNFg48HXTebhciNLpbd8NOFdSMqo8+XIVEv9ln6sI/otnGQSHjoe2imgwubLZNA/42lkZGHHrOTkQQ4Nud2wXCdMWIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fiEI2o+JCK4VhpQU3C58n5G4XAdR716/03HwvSYTd+c=; b=De09xeMqQBLg7zi8imkqJVjdDP7X7dI3kLDVBe3rEadSZ4nQGhYPTyjENLHpmSz3YQ0aDPgewIHG6cQEV42wGGc/kCTBQoLUJ4tZQBnQPrVhLDdtRJJshJh6SyX+oNGZwM/Ne8smrSqokljlOWnB0kt56/PoQBjvjvYBw6BQ8npNSZoUOP0sCa/16/x52139TutVM57ZWUqTdL73ygxm68rH1+mcAl1zlEcAfjWEySMK2UNCBXYrVUH/pIGxZfFVkNeju6x0QrCIMyQnzAXmxB8+Yd/zzFfZMPHf13XFzucZRUTDVh+khCZnQSA0ePPQRM0aABiUhctJArzNt/5UZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fiEI2o+JCK4VhpQU3C58n5G4XAdR716/03HwvSYTd+c=; b=qfC33Z/vgxjS43/vAC8FJQZig+DKbLeJ/UtmT1x6Iy9oHIfve2U09c1rkjw0kJ4gTX3Xc0e0cFtEmqJiZ5k6AE8OUFL3mrjXmtUk8f/Fpx8iXQef78I0culj7rj1XuAK3WL+8GDBzlatCV9nI8LvVGXG3IoT9zGnp0qEFTyKpkuV5fCo8aDN4WTS+kgB28T5v5fGbFpq/mBox91I1UpfRS5LksLpULJvjgmZHy1SJJrijc0wBM77Rm9Fx3/BAAAb67CEjkyH+H/rw+OliyUKHsB+Ipc2+aQA50/gh7PM8dgarg4HG01sYB6xjhfw0yJ/sEeHF2nJfb+eWB+GcwTxnw== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM4PR12MB5133.namprd12.prod.outlook.com (2603:10b6:5:390::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Tue, 23 Nov 2021 22:39:05 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4%9]) with mapi id 15.20.4713.019; Tue, 23 Nov 2021 22:39:05 +0000 From: Raslan Darawsheh To: Dmitry Kozlyuk , "dev@dpdk.org" CC: "Xueming(Steven) Li" , Matan Azrad , Slava Ovsiienko Subject: RE: [PATCH] net/mlx5: fix segfault on close after failed start Thread-Topic: [PATCH] net/mlx5: fix segfault on close after failed start Thread-Index: AQHX4KfgfZLK1ufhW0250xwVBKobAKwRtG6A Date: Tue, 23 Nov 2021 22:39:05 +0000 Message-ID: References: <20211123202227.3318001-1-dkozlyuk@nvidia.com> In-Reply-To: <20211123202227.3318001-1-dkozlyuk@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d990aef4-79d5-4b33-ee3b-08d9aed20e25 x-ms-traffictypediagnostic: DM4PR12MB5133: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JVC/SeqivtYFjlr+/gTS9fqc8Ffk2ZPWLmNeWMGOCNKSVCM5hH17iG56mcRxIO+Kf0zzc5pdAGWZjUO4n7PotL/zNDgHS263ehk6cOgiT7ZUGEWnMAFUWfwW5RYExd0k5pEhLvjmPC+MrKkugQD+pX9yQBui5f3OQHg0BJs83zUaxJi0nAHBauVu6HfypoWkshqEjJKmnxIZRWw1jVgSQxgtZklLffIC/wQFyEDpq9A6KxEqFVcJQbLh52cY0qsvA9eYhsUeUAKW4aUO5KxHWYg+31Y02EOkYPOWsEBpkHHtBri4gtQPYX+QtTeJzY79gkySa2eiEZncJ2CS25nui7UZ2ENAFTqsrzxpBWFyI+cfFIKafvzrmgc22Ks57Yu3/X0qPhyZKKuonpWaUIqiC2AfMTBu3uiSxFI++9PvDHaRDLtu/NbKP80swjgSgy81MfCOzVqMC+uvoPblL+3tC7rw7c94CGkn5ovbB6QadP1KRQ8cAMjYrEMY/oRCbQczNB6xRuWP0IyZ6MVnbA7mIjf+99J8M7iMCJLJZn9RmfdYk/Y1O4eNf6Ev0lE7eGGjR+HDK+4SjKkGNodhBN8x3oNKFQV3gZJ7VhIW3kyHdXQ7McX7BlnC4h8CawXAw9JByjvcDtOd6irMUgT77wNM3IbrUcRx1ydKluiLIsWtCogJt53leJ+I08wbPwidfwZhllEaGlZ1ePFcekPuSr1+ZQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(508600001)(76116006)(66556008)(66946007)(64756008)(66446008)(54906003)(6506007)(122000001)(110136005)(33656002)(83380400001)(66476007)(4744005)(4326008)(107886003)(38100700002)(86362001)(55016003)(71200400001)(7696005)(26005)(38070700005)(9686003)(186003)(316002)(8936002)(52536014)(5660300002)(8676002)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RBAI/W7qFEp8pzBwQKEw35f7/BwYFQoguM9etqxURJ5zWPoOefuXFlly5nRc?= =?us-ascii?Q?euxikNjJS9Q8hc9pEH4Ke5r8TfK8RG3V6e8ZDp+1/rQXcq2NSN1wARnb6RcF?= =?us-ascii?Q?uOx74q46lp35kE6bP6TI6aViXX25DzdmlaXOSca5Mj3jCo55//dpf+E4DPfq?= =?us-ascii?Q?WAxElewH0RIZi77fHSifAPdv+TiZIHhB1/BLcBjwBD5VtiUVgxaa7mSFbO6j?= =?us-ascii?Q?hR8yR+HNU4oYG/P7YGUajyWjcMaEwotftvEQzzqtZUePt1k1AmAvU5DTxoLi?= =?us-ascii?Q?OQkNHTi7FtjoIXMDDtQRjCtcWhHT0JhC1So6oUdYfhrU8aZtMMd7gSJNOAXH?= =?us-ascii?Q?8MIOXa0ifwCgc0E18sAhbj7Yh8/VayB4sMuPFfYYF5gLBTWcPvLSnNVyvGk0?= =?us-ascii?Q?t/rIBba0KT7hDCQ1K06V0Lqb22Yh/OB7X84rfia09RsbJsM/fHBvoaQ0tc/R?= =?us-ascii?Q?Vf/2ENuedPjZ/uStHLEmZZZEyb5scbWTMqjvjHMlCn7Z9wOPhXAhj8j8GweG?= =?us-ascii?Q?A7NrJkfoHTN8as/Rfs6Lyr/GJIVPDbfzGeaJ8A0vDnavBYEq7inTcc+rGO/i?= =?us-ascii?Q?e8wAaWYpF6gbDxmTmxITl/HJ3Vg0SP1R3wRk1h8PkOvjaAiByCz5cnLK1o+m?= =?us-ascii?Q?DS2Vl20odFRrlK4bQoibhAZabeZwci656SUiYz6adHRn36ULqPl3oInlpQwh?= =?us-ascii?Q?X8aFNjc51CtJ5ODggot2lYIhDhCq337gJyQHiwGaMorYBr1xqdtUzzz43XlP?= =?us-ascii?Q?l1L+Hp3iBw+VXq0V7EJCBpvC/3QnONzqMfQCzyIhmMKOOEBLnsCRavQDKtAk?= =?us-ascii?Q?yTmL0FhHmouYnruhPB7pmwFlJhX8spLX6qLYSm+iJb9VbAnNTlqk3goxsSxd?= =?us-ascii?Q?KcsMFuJPnQWvrUVcp3cEAQzHVz1qOoVelVDE1hXUmskQPD7wN2kZsv8vI8N8?= =?us-ascii?Q?Pzn1O9/2+shEyDuTs0spWY6Dg5VTcTUKMvxIKDxsKgEzgKdtJFxPDSuier+z?= =?us-ascii?Q?tg0sitRVXCC8xP6HvVovYROv3ItjIBpujFHnUc4+4VykrUDlU+B+/OEERWA6?= =?us-ascii?Q?tIDrnze78DIQrA7Pp5MAlIbMxl+1x75ZG2qQRnqPHXs+F3FhskQEmUihdTLf?= =?us-ascii?Q?bmDMA4dHUJuq7ev5pG9N24N8sD8vvnlWUdNhYJiilo5VU9GIKJbeVKMpxqhQ?= =?us-ascii?Q?CMJP7f01uAwVYzRImbyCJ6F0G16cQCW9YESmKInrnqFtSItlCLR6Oknw8642?= =?us-ascii?Q?nsX0GyvvN7Rx7LPP7EL0+M5NpL1imo1nszr6pNLT3zenLBrAHQDcYFqDz7iz?= =?us-ascii?Q?VqMxBmqOlFFu+T8VDLDfWQEuAwvCNYuIFizhiB5H1Rq4ssnWl0//d1oy5ZPr?= =?us-ascii?Q?8D0g6HtrsLbipDMSsa0Q+L5Bb9Kg1H+fU05akgr3/iBu8J6LtmUQ44UDOVPc?= =?us-ascii?Q?/H3PY9fnWHKq4y0vNi6/ko+kiAp5YEYKf0/xYTpU5tUyEzK3QNprl7RWsbwJ?= =?us-ascii?Q?KHmo04YhI/99nF1bSLLswiDOd3Nq0a3npxuf1UcqK9kdqZks5bXHJ8sJgYni?= =?us-ascii?Q?VMoS+ewzQbmmtVEUxqtIlXCISc6Wsyx/fCvAmJpzZnbxHYS10NwOXP3yCix9?= =?us-ascii?Q?ny/iWXv2AVMd2jdKiBd3ZrM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d990aef4-79d5-4b33-ee3b-08d9aed20e25 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2021 22:39:05.2621 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1XnPeSQ27r9lEkTzsvkvuA1N7qx9+YjyMou0Y3rlEgvPFkSEKGKXT4V6bZoKbLjMoFH+TmLyCQXJL22h65RBxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5133 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Tuesday, November 23, 2021 10:22 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Xueming(Steven) Li > ; Matan Azrad ; Slava Ovsiienko > > Subject: [PATCH] net/mlx5: fix segfault on close after failed start >=20 > If mlx5_rxq_start() failed and rxq_ctrl was not initialized, > mlx5_rxq_obj_verify() would segfaul in an attempt to dereference it. > Add a check that rxq_ctrl is not NULL before accessing its members. >=20 > Fixes: 09c2555303be ("net/mlx5: support shared Rx queue") > Cc: xuemingl@nvidia.com >=20 > Signed-off-by: Dmitry Kozlyuk > Acked-by: Matan Azrad > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh