From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB54BA0C4B; Tue, 23 Nov 2021 21:34:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 650F740688; Tue, 23 Nov 2021 21:34:13 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2070.outbound.protection.outlook.com [40.107.94.70]) by mails.dpdk.org (Postfix) with ESMTP id 5DF1540040; Tue, 23 Nov 2021 21:34:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VDW6hd8/AcwsfCKwd6wYCcU4VqvASZ+e4yiN8ulXJxhCCDEDE6c+ckplJ67Nl2Tn7ahdnp8dCJRCt/f58wCZkdMWLrzIg91r2y4LPpw7y2BBh+87rRIFTkqPoT9DAoL4AKdtaQHmJ2uvAA90mQWMc5XjUVsZz1tIrZmJpinZ8AcXRwpVSMHuLF10Zxw/N5gwvEF2Kf2OzRzrq60Y0kh/tGUwjPPUW72r4mE/hBivJww88p+2Dbx5arSOltyuxuK3VKeQnC+ITgw/7M7JDlVIePUTJVZbnvGsynPQP7b81QxqVLvxY9/DhDM0UNyqPpiUqkTT8qPbKwML6HLM8f+ybw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tu5AB5Ic22GX0VTFqYwYT7m4A721MvkMUzdoCylhHh0=; b=n/AKUaK1k9lxBOu6eq0BOL1R7T3zb+VXHJZjR6S6MrU2rCYLR8ZP7mG3XXx81poK+ySSp3qB0qRVyvTSDQObCUZzRWqOQ+BIqf6ce3FeDrGAKwGZCBQLyGSr0tdjce5lhvx5XB33GZoGdnZTj4yCOU43/yooANHVaqyQhXw7cfC6EdcJWnlCxEuAmmwFCFJgM03/yWVxHJw6zScCa4yudJoLQOr7bsl1jsO6ufYR3TyWtXA2WqMvUfvKm2sXg1bC5ixx9QWiGk6JqmhcylsPTESMZc1dJ4eh8fzRUwQxJt0m6MPjxAqIKNvpB77nZI3A9eKeVbCDUv2+HusF9mf5Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tu5AB5Ic22GX0VTFqYwYT7m4A721MvkMUzdoCylhHh0=; b=Cdmb8Zo5DLGdMURdcCPdCxSKZ3gnkJO46GEVndw6YJhh7LlzwWlIpFgexRSGYC5g1ZavlXcRdjzmN7ssHZIeitZ7vdNTw/+qfwEMuAJI22eJdRLPA5vHRvdhuAWdAFNIIop7MsH6zs32GLdhKyEE7AprZpZ/m3MYkjyN7XnIUNU3wgcB+JHdw/KzlpVi6b85h04Mutiwt7V2GSIzvf0qWq0+6LGZZ2X8NfdyiPzXgcqHOqCh9XDhL1HC4XQCw2QXWnhwBbeDlj7p0usHJT18rCUEFJCIp/wpKV34joR8bURZliQlWpU+9qlFGFZbd3SUBItRuuTrwEWUuOW6vvt2zg== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM4PR12MB5088.namprd12.prod.outlook.com (2603:10b6:5:38b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Tue, 23 Nov 2021 20:34:10 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4%9]) with mapi id 15.20.4713.019; Tue, 23 Nov 2021 20:34:10 +0000 From: Raslan Darawsheh To: Bing Zhao , Slava Ovsiienko , Matan Azrad CC: "dev@dpdk.org" , "stable@dpdk.org" , Li Zhang , Shun Hao Subject: RE: [PATCH v2] net/mlx5: fix RSS validation for meter hierarchy Thread-Topic: [PATCH v2] net/mlx5: fix RSS validation for meter hierarchy Thread-Index: AQHX4IQGgiwxwTCTR0KfM3d5OEtezawRkc/Q Date: Tue, 23 Nov 2021 20:34:10 +0000 Message-ID: References: <20211123160011.79219-1-bingz@nvidia.com> <20211123160519.79511-1-bingz@nvidia.com> In-Reply-To: <20211123160519.79511-1-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a032836a-ce80-4bf6-10cf-08d9aec09b09 x-ms-traffictypediagnostic: DM4PR12MB5088: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BZ/bClpPe44/cF6aChyJuCQeXunasWQrSm+oFdUwZaU3OxYAw1/Kna7dCn3QD7Rlab79yeZL5rbLGwaZde4b9e+ekKin71NRtn6FY8Z1d/KbHpbGOmR/RHxkMx4J0YTF5OZy0N6uBDwqhlu3PkSWo1j1hNEL+3easpV7aEeW4iZ8aVBBjZuOHmJhNZd2DHQvEIR6Rmg/eq0Glla369Tsr+1n19TYbVsieWc2SZIFE6owBOTCUVkuG2DtlAK00M7XXHr2RjaN4Fc17A4eBG7NSefMkx0ioBHg/2JpImRiD9+cdzckQDDRENH6gnwurR2IHGD/iLANWHUz7yC9cc27N2r91zS01ijVvjhG2rHsufz/BMB7WHBWBaeDrNI86RVWjVQaFduUEgIKDsApi5rpvhUDgxWsb0+w+GeAom3DYPBplB8axzJ/e6cxnopQQtNokiS6zxta+srvMWfH4Whgb/YRmyEe9Ll9LoMOvPAg8WVgs0rQrE9Q0/EnCgtFVyzfXn0zQR4JdTnVySLr1VYnv1NSh1rngYv1mm2cXYFL++u9bDsyy2N95JRqmCGzSZs5om7+HnfWPRWdMIec/jU70ujGP/zmb4ObZSyADKU0MPnnvFPHPik2Mi6Us80Hs5oaDtNVd+MhRik7Pk23OFtW+P+EWpn4lNDe7qPGare4cMT7fxQiQuogbwwRCBDxHaMYL7dBX0w57o4kAYs6BZjrsQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(52536014)(8936002)(508600001)(38100700002)(5660300002)(110136005)(54906003)(66946007)(83380400001)(7696005)(8676002)(9686003)(6506007)(2906002)(53546011)(186003)(6636002)(107886003)(71200400001)(66556008)(316002)(64756008)(4326008)(33656002)(26005)(86362001)(450100002)(55016003)(66446008)(66476007)(38070700005)(76116006)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?17kASodQDuNqz59bZ7xh1T6WooX+A8KaYwYZ+/97Kcg31aJ2HoZDhL1Q6LV3?= =?us-ascii?Q?H5tOqS3ambL1UhaYurWm6n1RAkYcMeqJ0qUURun4+3R/+u2DJIuYVw1RyRU6?= =?us-ascii?Q?y/9++lXx8C6aAvbh5MNcdv4mv484lQbAiprY1/pR7nDVufTfbDZzUCoP1VR6?= =?us-ascii?Q?chCTLfweN0l0wUbm91MuoRjzg2s04bm+gVANET3N3bO12R31jpNUlbMYU7eJ?= =?us-ascii?Q?IhtBqnatez4x0JcjOgvxLIbkLtWMaHgtUQEoCfQ1TSD0esEV9qTep7SpUphm?= =?us-ascii?Q?ct35hLyB7FIn+0nAPJh5XAQP1mV+AL17FuksRuN0JjGjOZbQhWnBYY51FHz3?= =?us-ascii?Q?RepZlE7nUiNxvY6zeVNRLrVpZB58BfsGXQJ/QGaIY5qi7+c6+8EyJM0tQaLA?= =?us-ascii?Q?9U5uPgLAMU8V0TUBlG0sM746eUDkCSEaDSbBu75CDUM1+acpNoKwRVQ0F0zd?= =?us-ascii?Q?J0XGqfduTm1kSwcsnG8K+NEdkmk27HTXeXDPX0P0Mzng6nCzYgdJLXKgFd4k?= =?us-ascii?Q?9mwwWfe6NfKKJcpnqQ8+rX2wo0JZUZuiteHDOEM3ETyOZAqa2UnkG2kWl2eQ?= =?us-ascii?Q?t9nxWQrmc5StsGFJZc+U2VRxrZ2Ew7qJB5Bn6so4/eEdR0erfp5QLTPr7zLY?= =?us-ascii?Q?a3fwr4XFmbZ1WBrGLAFtjV8BFsII2QkXfMtw0PDQ5v8vZXUrrMMPZzZSJelC?= =?us-ascii?Q?8mBMmy83yyHB5DinJHvlJpy5NKctqm5wuc+N4xZx84kZYV+eajHCgWuPlnPk?= =?us-ascii?Q?P4kp2uX1wnKV/kwl4Hviow/BBOWZj17BwMpEeXSKIBcHkR3vVipGFsGWB21S?= =?us-ascii?Q?c019823ouj6rlzD9tYzcBVJYKiGmEwf7uMCiJRF3/bGk63y2C/SO92+ACzlp?= =?us-ascii?Q?rXgqz7piS2tRJfywl407zXRASTBlSom7oC9hzhw62ssTDFW41aqfAGjS3dbq?= =?us-ascii?Q?AF/b8ijGtKMfSiZi2V5YIV7Q3hQm9xbZgetrCjRKNGNflxXhZiBLvqw0SyPO?= =?us-ascii?Q?h8PWItTiIW38ljA5tL9HdYIbjaB3VqLDwI5XAUEDtVnDGXbEGr4kN9/WYOkn?= =?us-ascii?Q?wk+nCmqEUAXPc9OtHFEvVZNgMW+4um/R5NNibTNjCMEvd+9pPc8BCqjp7MMs?= =?us-ascii?Q?mEk/lMJ0swuGyfoQcAkeGZ3lEXoQ52gyVRJTadF6nEsqlQhsl4DSzhTagv2W?= =?us-ascii?Q?dAXsLQj8/jCbAqmeOT+NhptxNTczA2OcPz2cewkKeFXVOWc1bdtkWLx6m+gB?= =?us-ascii?Q?IXRlkuzmFzxVLiUx+hhYa/3ZAU+56Vjnz45R3cxEYwG23Ih42v9RmixkpZNX?= =?us-ascii?Q?shgzw2HkUJ1qo+8roNYLJ/dSSh9uRINaFAWoc+/qMgb3FuAKFCwVY9aUnDbp?= =?us-ascii?Q?d9fYK6fGX2KZIMMeU3xdBynx7lgn6O9z5wlkGbyr4DHJVm9Xg+y5IT0yg69b?= =?us-ascii?Q?v+SUdQL8jfNEcpbo9azoEsXvxtxGUt1r+YTU2wfb4ynDNmmByMdFbBMhg1r6?= =?us-ascii?Q?wySMKzOsyVW9cJh3fqXnI51A8tTRbGmdrzs+r6uU6ulcyBq7KarYwgJqQW5k?= =?us-ascii?Q?K8J/30VqQfuK+l5EOxU8IBA2NddonAv+1s4vPwMau7QaXRYCdXIDJk/Q4lLk?= =?us-ascii?Q?dw1Gbp21dEORrOsHcgmnU9M=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a032836a-ce80-4bf6-10cf-08d9aec09b09 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2021 20:34:10.6377 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GntpJOiqU/pyTotH6ZfBsS8kkZXmMOUqdVmqNKCqFXxNkucaTkY/scWdV2tgj98pURvXfK8uRI5mIlfvCRmzJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5088 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Bing Zhao > Sent: Tuesday, November 23, 2021 6:05 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org; Li Zhang ; Shun Hao > > Subject: [PATCH v2] net/mlx5: fix RSS validation for meter hierarchy >=20 > In a meter hierarchy, all the meters are marked with having RSS if > the final meter's termination action is RSS. >=20 > When validating a flow rule with meter hierarchy, the RSS action > should not be fetched from the current meter if it is not the final > one. >=20 > The fate action union is next meter ID instead of the pointer to the > RSS action. By using the final meter in the hierarchy, the flow rule > validation will succeed without any crash caused by the invalid RSS > action pointer access. >=20 > Fixes: 1ce19ab1f43b ("net/mlx5: fix RSS validation with meter policy") > Cc: stable@dpdk.org >=20 > Signed-off-by: Bing Zhao > Reviewed-by: Li Zhang > Reviewed-by: Shun Hao > Acked-by: Matan Azrad Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh