From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7842AA034F; Wed, 10 Nov 2021 09:47:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 096CE4068B; Wed, 10 Nov 2021 09:47:29 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2082.outbound.protection.outlook.com [40.107.102.82]) by mails.dpdk.org (Postfix) with ESMTP id 8002D40683; Wed, 10 Nov 2021 09:47:27 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TNonhRkRZOwshUB+nbH8mzvlt0dcYvwnVy6vA2ft1agdLei8slwnD3Jvl+PMtpqKCI6oRrh95tOVxV2DU3L/y1b2bE08YYyf7/RvLNX2ErHDd4bwDwpV+T0oGSy1AthLc05fLg7d+oZqWUTLvv/5D/3N/n91ZFE/ihzA9228qr+/TNvlnTW/2VSV9erbPj7UqggXQtb7tJPm0wFNh+8oCkC0WO0vLfjaKkzg91ob3TlGSq+j005B9f4AME+NDhwjpvjU4BU7sJMQ0qO0g+LrG3Tm9e7RQ1kLGm0FC++T1nKsea7aUzQP1c3zuG8sVy3SUR5JhSvjtMBDJaYkzg7rRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hlYaB2RloJJjGWEXHNYI/EZG7e8hVQBVlBDA1D+S3SM=; b=d4Ex/hDSUeEqfw+va49IGNSIwu0oPYwQ8FZA8+lfDbbRPSaDEBYIlL1ZegUob7MLByD0RHu499gsEmzI7m6OseD0icrCXQFfYDND+4OVamKzSMwSOJnlNQAIEukVuebkSCCgpLHw4qLGTDnzyJfme2NFCCmO+0sXDlic6nJ+lV7f3cZPbkuyFDLwn4KWCwPdyYv7enjUp3YbCiA5NtENzMFPe5tafgFkxguHvymt9WRPMDJLV8U0ZS/0xtnzwsWBHhnGjXmgGV0qTlKxEM+Vv+7VsH5OuLG3HoZf5kiDztXWeO9d65akId4AlcASpl3PL+nCpf8snRWfLzdknsOe1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hlYaB2RloJJjGWEXHNYI/EZG7e8hVQBVlBDA1D+S3SM=; b=QAHkRIOyVo5Zjig0BN0bHXGUy8B/7lNoi1V6UUejp0xY8NPITts0DTyX5cqTukmHKPFvs1Zdx9ReZy/HZle94h6/roY8/Iklld7Dri1ZD7/Sk/Xew5jJZsttGcL5ywrwf7Hg4b1wkUY1PoGDXyj/F5M8Wh59k3G6ZrtEcnK+E1KjIlcNa3w/bQLuyL9Z61aa20l0o5JAtRKOlHxtKMfzEU9O1VLbIaGMW8WvV96MlwhxgRpI50RdiwzlSPmstR3tnrrGURK67dmL4ePLN/U0pOpNNU+63HGUQFT2D7ZD6obbLfUFlldT+3F23aMR6Ts1w3glSFp2MBSzNFjE7zT0zA== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM8PR12MB5496.namprd12.prod.outlook.com (2603:10b6:8:38::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Wed, 10 Nov 2021 08:47:26 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4%7]) with mapi id 15.20.4669.016; Wed, 10 Nov 2021 08:47:26 +0000 From: Raslan Darawsheh To: "Jiawei(Jonny) Wang" , Slava Ovsiienko , Matan Azrad , Ori Kam CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix tag ID conflict with sample action Thread-Index: AQHX0LPxJDsoyRDotkyu8AVKnUWgGKv8fZrg Date: Wed, 10 Nov 2021 08:47:26 +0000 Message-ID: References: <20211103130759.44457-1-jiaweiw@nvidia.com> In-Reply-To: <20211103130759.44457-1-jiaweiw@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c2469ab0-afdd-4eb9-a69e-08d9a426b8ba x-ms-traffictypediagnostic: DM8PR12MB5496: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EsLI2PSEHHjy1Zavd8FvzXMYic7i5Dkck9i4tIDbknFqgEH4C6GB82IizRb+rtOTmgRi1fPwF0aBEEakOPNaK2rwrrpgbtYt7uwhRfbUmphkf0Wg9Uuoday2SnJN6KIUb7vsCF/SLNYwRw0L5p/OcLLt/gYZ46LOfE1N4jO/49Mw5Brzaos8khGy4HNLrgkdC9Nm3F9ikxRVVjN8hKsa8f25RSTQd8UT2cq2hLNnXu7g/K9F0+p3uErKBLYz6xlzS2NvcrPrXE2QtOvLSOfuz2/jKshh6TruY+T2J2jXOatmsQ+VjGEW+AhqkhRESpzH4ZqPFvuUp/WS5Xi2Lvb/jLfPFOPvoQwPEd/mFelrwQ3cbM3Akqei+MQQuMpoD4QH8hngp3SInMg4erVzetHceqXRqBkWZSWFFhVoc+x5MyYmpy/muJszf55R06aV+YqjRf0vrO/mhiamF00oDBH3sCeg5iOz1gbVed3jft1Hi5p2bgW7OJEwDmc3LV7M6Z7/9xOupqSpGLb6o712M2uA5dWxMNbOj8plUTbZT7ywXy8VForFNHrlQ8ly4LMotyhj5h6AXic7ZIZJ7nJhChGJ73bV7JqCqInlekBD7sXB0dNpTPD18AcQI2Ofq47URVF7Y2TkfAeYJVm1yDsjnvMBCVeFv0+QBW+NbUvEVd9jmzuDPAvhZ94tHyVp1lrDuQlGUQF65/sNv6KoKKWJLc3X1w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(71200400001)(64756008)(66446008)(316002)(8936002)(66476007)(76116006)(66556008)(54906003)(66946007)(7696005)(2906002)(52536014)(450100002)(6636002)(83380400001)(55016002)(8676002)(508600001)(9686003)(4326008)(86362001)(38070700005)(122000001)(186003)(26005)(5660300002)(110136005)(33656002)(6506007)(53546011)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YrEeRPfjtvWBBX3QMXkhJ9pPBGTmM8zMnyvmMjkDfMfd35zjZNYjhRAm66mM?= =?us-ascii?Q?LKkRRndKejWanmWHiu3wsOYIgR7j0oIpCF3soTA7S874fsfYevFgJvvAYr2J?= =?us-ascii?Q?jF0FFqMmICfEnyzFKufwVAmIkPO+ztLwwOZ0n2Sj/GoZ/8aQxoFDBBXYe9oo?= =?us-ascii?Q?hJI3KMk26HlSH7OCHW3L5e5rRa/Qbi6x4adsVM4zM+rmx3mKwCGWTirY9tHa?= =?us-ascii?Q?GVeA217ClOh3uBsSpcE0jik2dbXAUKEGk+KPiKoawYT0nc8jJdjbEk8O52X6?= =?us-ascii?Q?dD625er80L+bsmOMykjN6me+ihjlyuTbAEZifUid1tp4pJrdjnmU8jyi3GW0?= =?us-ascii?Q?0DiXdYdRtPDCX+osIGSN44OGrGSz8wessDTPS4DpQ7cK7inRqSyIQzXB8Yo4?= =?us-ascii?Q?pW+axq4Wp4T1APOdjxX7973c9FQpPY2ipGakTGgJ7UU2K7rNKuxL77Gl0HBT?= =?us-ascii?Q?qTQje/ys7NxCSCNQpRLmnDbshjQPvGg1198dc5Wwqa5ZJX6a5+kHoAvfzW9s?= =?us-ascii?Q?+fkzS5qmAYmxITK3PIwwTdQr3NiJO08famgoxE8gzbBTzd4nnyYWtFKqJDm5?= =?us-ascii?Q?oGiSaIlV8ODEBXUrnQqqrOphRjFB3Jn3WSfkUJzWnrJHSVMIifZEyLf7Zaxq?= =?us-ascii?Q?GUZF5WFc48rimVzNc0ucw+xRnpnREWI6N4EUmGVUOIa1iLXGigjETgTQ3Uql?= =?us-ascii?Q?vEn8NBCh1xKN56Lkrc8YyuMgVMrhLXTLLPHbyujXzGVyQgL17BpHZ1nz4Ydh?= =?us-ascii?Q?jO54rphr4Vb8PrW75vRFLG2f+ezJxGJb5tnXibpl2cAbfPiDo7roZ5ydxW2W?= =?us-ascii?Q?69aZwR9Ed6NMzoXeFwSBhg9EMp9MUT3ARLCpuodk3VWM0ENr/xMO17r02Gza?= =?us-ascii?Q?PNIdJhj6ibffihf0ajCPw6EpOwhJcvQwiOJ0f8Qmk1jthX+2pacOSzbfqHf6?= =?us-ascii?Q?aCpkjVsV60dbip0wJ4sTByuKzayGrZkHX2IsztHxgQsxdT3YEP7Ts2jcm+CZ?= =?us-ascii?Q?eFd5xnBvMn1gkcSbCRoQIt9qYg0ylGVFoRquTRq6orNLcdFk6Idy5qitmA7T?= =?us-ascii?Q?e60rmVRdFL5qu2x6XQly4qYe+DXWNzTxrfJZHKYGkLfucueMknyzWaUzjKij?= =?us-ascii?Q?a9HhfbcbBzT5OaEOYqjs0EWAHCfrQqk1RDfAq4bqqedrRA8QL1++4hD5y5Fo?= =?us-ascii?Q?nYvF31nEAyUcwQ72Lin4DxKkxTdDGaKHEylm4Cnq78MMFBhzv3usvZ36gWy6?= =?us-ascii?Q?43/sOzoxh3o5l+eewFpMpOsXQUbKz4SotIKY+uUktAjbM0fHUdeRv/jcQkwY?= =?us-ascii?Q?ZJaj1wpFnozbzpfc2vooCN5Ei05RyuPFC+S73sDN9DI5evlaENv2FYdPSBvc?= =?us-ascii?Q?cQjTXfemHkh84Rlqwg6OFYN1o52UCYelLoAE+JE4l8jTEO3NUakzOJRIM+Rx?= =?us-ascii?Q?5bVPCp5yezOKWGbqW4SBhgKcMwVuSTR6jw/NhsfEN2BuV9sp2QNiZuTQSXqS?= =?us-ascii?Q?jiFJTXB3zi1feaH9TOnJAgy9rHn5jOa0vyHYNFyuvO+20PI4b8RCwOdMNpd3?= =?us-ascii?Q?V11tBInIc0Esbh3ioFb76OnI08/Ia8rU2l+uXsNZpZmNiM3TNpH+gvbNvMBJ?= =?us-ascii?Q?r8LUe86IXFYfRHrC8562G6w=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2469ab0-afdd-4eb9-a69e-08d9a426b8ba X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 08:47:26.2836 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iYF2D0GXvzJhkOqLY1wVRX9Un/AHlQIvUEK9CJH+kZv6jpYCC9iWxPI96Pj0zZMY8jlYpc/NcIaSS11+t1gWLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5496 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix tag ID conflict with sample action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Jiawei(Jonny) Wang > Sent: Wednesday, November 3, 2021 3:08 PM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: [PATCH] net/mlx5: fix tag ID conflict with sample action >=20 > For the flows containing sample action, the tag action was added implicit= ly to > store the unique flow index into metadata register in the split prefix su= bflow, > and then match on this index in the split suffix subflow. The metadata > register for flow index of sample split subflows was also used to store > application metadata TAG 0 item, this might cause TAG 0 corruption in the > flows with sample actions. >=20 > This patch uses the same metadata register C index as used for ASO action > since it's reserved and not used directly by the application, and adds th= e > checking in validation to make sure not to conflict with ASO CT in the sa= me > flow. >=20 > Fixes: b4c0ddb ("net/mlx5: split sample flow into two sub-flows") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jiawei Wang > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh