From: Raslan Darawsheh <rasland@nvidia.com>
To: Dmitry Kozlyuk <dkozlyuk@oss.nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Michael Baum <michaelba@oss.nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Matan Azrad <matan@oss.nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@oss.nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix RxQ resource cleanup
Date: Wed, 20 Oct 2021 19:35:54 +0000 [thread overview]
Message-ID: <DM4PR12MB53126A01FFC5337E806C2B9BCFBE9@DM4PR12MB5312.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211018172456.3335320-1-dkozlyuk@nvidia.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dmitry Kozlyuk
> Sent: Monday, October 18, 2021 8:25 PM
> To: dev@dpdk.org
> Cc: Michael Baum <michaelba@oss.nvidia.com>; stable@dpdk.org; Matan
> Azrad <matan@oss.nvidia.com>; Viacheslav Ovsiienko
> <viacheslavo@oss.nvidia.com>
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix RxQ resource cleanup
>
> mlx5_rxq_start() allocates rxq_ctrl->obj and frees it on failure, but did not
> set it to NULL. Later mlx5_rxq_release() could not recognize this object is
> already freed and attempted to release its resources, resulting in a crash:
>
> Configuring Port 0 (socket 0)
> mlx5_common: Failed to create RQ using DevX
> mlx5_common: Can't create DevX RQ object.
> mlx5_net: Port 0 Rx queue 0 RQ creation failure.
> Segmentation fault
>
> Set rxq_ctrl->obj to NULL after it is freed to skip resource release.
>
> Fixes: 1260a87b2889 ("net/mlx5: share Rx control code")
> Cc: Michael Baum <michaelba@nvidia.com>
> Cc: stable@dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2021-10-20 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 17:24 Dmitry Kozlyuk
2021-10-20 19:35 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB53126A01FFC5337E806C2B9BCFBE9@DM4PR12MB5312.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=dkozlyuk@oss.nvidia.com \
--cc=matan@oss.nvidia.com \
--cc=michaelba@oss.nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@oss.nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).