From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B748FA0C43; Wed, 20 Oct 2021 21:35:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A408540687; Wed, 20 Oct 2021 21:35:56 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2073.outbound.protection.outlook.com [40.107.95.73]) by mails.dpdk.org (Postfix) with ESMTP id 4A6A240142; Wed, 20 Oct 2021 21:35:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ut1c+oZW7WliXY/15z6mKWyA3GfdyiFA3AOS8WOIpaQ4jZ7xHgNy/snTRXAhiyT3ig1aliPoMfm+uK1f8JsnamytJE4+ltkBcBmGshDa9pC8A+B833Ta7znsayq/9Pa4OSoSMeYqeyjo5u9hY6EZPa+fnE9Yl1NhTs9TpI7iO3tk64qjtnDvMA+YMhXfkJwCLyHaO0xxQI4Wqzz1pqHrwzBGr7tufRc40ropL9cKzsNPciOBijIrF3m6ENjbCJGlFwCWTb4CimIWSnPILRvThmUlOa9/dd2bDF9qc3Q9VReYpLXN3lLj1SnSWFhZ/HaxiHS//0NcQSsdAIuIraQijg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z7J+OLmXR6PeZZPqDZC0gXITD8gYxoYVLonnw4vogig=; b=LoY6gPcvV1/HoZUTBBPI+5uz7P3KvKcGeh0376TtBL3TIA63s74kViAZqQBlPms82DkzFZISSa8wbymVLCT8c2qMOg6HysWN+Dq8MNqWEdWUKGppJtuB8Gr31FQz0kcS0NOgjDKwXrwXzR69glLFqvHy0TOlLuceKjxS+5rac9nz2HScT/mnECbiZS/VrBObnQMt2HbpFgoYDkPpBGCLDg8ynQ0V+HJoZrSlSUYkM014SoTy3LonstQj23aYft0EbXx0ZU2AntEKsAbam6OS6HePb83q56LKHuQnw+u20p46v5Mc/pSXqSOG7vCmel1XudvFZp/qRKzhwTQ61RZh0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z7J+OLmXR6PeZZPqDZC0gXITD8gYxoYVLonnw4vogig=; b=EvkJiDQOfGqGK67Vu+4g8jdIbE9AsRtSPlhSAE/eI4EgYopoZ9UPRt2Yk1lGYzSU0HWypwSMuPYhiGkaO2R76nF6bdy2vHuXo2S+CjaUc8265EoqrRopwWvVASAivmLlVK3trU+yBPwodh6TekDvXfb62eCYmwA01sCdqpyQHEK9LHHRtFpljRQTRqB/3i/TjCQ4FoS0I7fHvAz39m53sxpuD5nkArZr0qzt0i6hZFS8NVwe7IH3Fkl6A1WdLVd300xcpwv7i/CeQhfjwWD1/0gcWvk6jJHeQECE4G8NvJ60eFHoFshMhMOFfHldwhhj6Nlzf1+6lUCxPvPc47Gs0g== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM4PR12MB5200.namprd12.prod.outlook.com (2603:10b6:5:397::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Wed, 20 Oct 2021 19:35:54 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::a4bc:7da3:32e5:1665]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::a4bc:7da3:32e5:1665%8]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021 19:35:54 +0000 From: Raslan Darawsheh To: Dmitry Kozlyuk , "dev@dpdk.org" CC: Michael Baum , "stable@dpdk.org" , Matan Azrad , Viacheslav Ovsiienko Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix RxQ resource cleanup Thread-Index: AQHXxEUk0ry3lqXYLEq2eEsnK5P7YqvcSr0g Date: Wed, 20 Oct 2021 19:35:54 +0000 Message-ID: References: <20211018172456.3335320-1-dkozlyuk@nvidia.com> In-Reply-To: <20211018172456.3335320-1-dkozlyuk@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: oss.nvidia.com; dkim=none (message not signed) header.d=none;oss.nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e52baac7-37ba-47b4-c93d-08d99400d501 x-ms-traffictypediagnostic: DM4PR12MB5200: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1v5M2jl11/Wp+Bq7Q3htbEGXvvxDJzmMuvV0n+ZkKMvzFQDMXKCGPGNFJxbtQUHRWWjhvhFsnmHi7en226AbpuMalml2RCfOspGAJ1LB6oGCLK9ELFpSXslwWB1Gjc+xIuGqjdHHoDTv98y6W+wKhPlCRd9/X0pbSQbZOcGVORjNYP0UqiJzxJHCsH0y5d8L9h8EjSday0wnZDkimvph666YLmtI7O/e2T9iKW6OfoV4Aw2RZLMfaKv0WOW66k2EyHb66Vwl0W84cSUWZ4QhWsnqlolhYqxJDXgZ6o/u6+SL7Y0Zakk+v73dhGImwnxMEODlxiJVu4Z8InDugvLpnfjNFm5wryZRkNO52HaDegtwKEekVVYVLYWJUUL4PrRhaQKXrcpabdahH6NQr1UAnq50jNgvyrJcieqDyn33qrKj455rOjvv56PNeGImCzgz4JFDMrkc5DJO08NnAHly6MicsrFYwjSd5AchX43fs3e/tV5xo89Ix6fanTvJaoztidf5el9/kfMRZ93ge0NKjxGu57uz0EJSZODWKaGJrlMtnuT0jG9HcAtM/2Jj3A+d0Xqfi25wF2IdeJR2W8SsW3FM2B0b6sc3eAhbkXsi4BB8Tn6VttG7CSUZ54Ea4UbgbKvHVx6RlMs26pYbt0NUv6XZe/ofe4f3afhS8FViNLr3YR8xvbmwElb1zYktrysjFb6f3qv2xfAY7RUurjbRQQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(38070700005)(6506007)(107886003)(9686003)(54906003)(7696005)(71200400001)(66446008)(508600001)(186003)(8676002)(83380400001)(4326008)(76116006)(64756008)(450100002)(38100700002)(110136005)(55016002)(66476007)(66556008)(8936002)(66946007)(122000001)(26005)(52536014)(33656002)(5660300002)(316002)(86362001)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ykwMfLl2yP7Jj15Aj/wIDpZP2qxHFOrOulIL13Sxmmro1Q2fGYj0pMf4ZIqn?= =?us-ascii?Q?F1Ult506aQp2fCRbebOrRFxeKn0/Vad2R9j/1gkacR2OEAXbkbrdiakXfgTO?= =?us-ascii?Q?hJb91NbAPl412brKZAiKDAH4dZyO8Jo9Ys5rfTKbGexTZDZIpvV6YHdCniCH?= =?us-ascii?Q?XJ8xi+z0gx75WJVZPSM79PQeHFr99fyn6ao1wCAH/S7Klcelhp/6UGngc3a3?= =?us-ascii?Q?7psCJlsU3H5D0IKRmHWAGm+eHD3jRUtlYfOcvTMN2kHAuyQZt2ujQ9/y4GEv?= =?us-ascii?Q?ZGjnLvhU7hCiNg1bbQZbzvgEu0ea4hrnaMUlGBTq1Rnl+H9imT1tb4yWtRp1?= =?us-ascii?Q?MSFBGB/sUp685iWZ1Ef4DkqGl17GKC8wVbI7mqoKZaQjMs7rXI8g+iJ5DZHB?= =?us-ascii?Q?4ujN6uSyl8xQJw0ra1GLMRSsctoiNuKr+gkXPgzl8MheRxPvxuhIZlGlIYT7?= =?us-ascii?Q?24oX4x9pYz8G7+9bA9hHWT8qWFPc4no0gKwDEBWtwrApP3x2zIBwL9+xYrEt?= =?us-ascii?Q?ijBWJBd6to+F6LcmtdEMXVxsuVl4KkuzUAbwuOZeqK+kC14x/6m5Jq1Sbo0o?= =?us-ascii?Q?io2nW8S/4G6P5wn/6+eA0QEjtvkZDHH0T4nsiepKAxvu425DoedGwb09TGY3?= =?us-ascii?Q?vLF4CteNF4Ekoeon8oSWhcK5sfvwHve7TT0yEArKj+tpKgvYvtDsl+jW0Pvu?= =?us-ascii?Q?RKjtZn6+vxyDLUO1gw2fdtkCGeTJ0zeNJZ6qOYf29koJzx7wYRfBnXPAR0F7?= =?us-ascii?Q?bn2dqs0nstrq0DEPYnCyQGUpTbVZoPrj8KXkVAJTYJXkeTSuNaC5CD1gR67X?= =?us-ascii?Q?1PNA7MPl2iAL6ZVa3RD+t0YDrFBFNFSZn4+I5OuNunxBzOOmUfdcK1aT9UjG?= =?us-ascii?Q?L81fczRvT52UXFQQvAZNlns8YkrZm5I09HoP6/vOH3zaHafeVRf1c++747no?= =?us-ascii?Q?rMI/ole0M6j1T3FkLrfZsgbQ9e92Iv1qH7GvZv28r6YfJ+kNkIye5zkx1dsa?= =?us-ascii?Q?bPrMomV8w0wZUJMtO/ksOFJmst+lAfxmmKuCL6fsGvTpZvrlt/hspajvI92j?= =?us-ascii?Q?2Dj/3jXjZz5X9G9Bw9IeVzZj99i6WYnFL51CPDnkNz2jySL824nMF4ZD+QlA?= =?us-ascii?Q?7zuTEGTXkCJqQhSOFLLskbGqwygsxNAh0m73XhQoUTKQKPEdUM+XcvMaEhLp?= =?us-ascii?Q?/ZAhMkBo5rpXmOrndqlD5y7zdovRRTTcvSVuT9KsU1/PL5lJlPxTaJKbT+YW?= =?us-ascii?Q?jMMxNi6vtj9LclWVRZlxTAw31cRM7YGJCRo+CqTtecmVKEnDuGiMMiumgU5T?= =?us-ascii?Q?s6+eqJEMVZ4AV7tVFjRyeeGo?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e52baac7-37ba-47b4-c93d-08d99400d501 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2021 19:35:54.3693 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@nvidia.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5200 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix RxQ resource cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dmitry Kozlyuk > Sent: Monday, October 18, 2021 8:25 PM > To: dev@dpdk.org > Cc: Michael Baum ; stable@dpdk.org; Matan > Azrad ; Viacheslav Ovsiienko > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix RxQ resource cleanup >=20 > mlx5_rxq_start() allocates rxq_ctrl->obj and frees it on failure, but did= not > set it to NULL. Later mlx5_rxq_release() could not recognize this object = is > already freed and attempted to release its resources, resulting in a cras= h: >=20 > Configuring Port 0 (socket 0) > mlx5_common: Failed to create RQ using DevX > mlx5_common: Can't create DevX RQ object. > mlx5_net: Port 0 Rx queue 0 RQ creation failure. > Segmentation fault >=20 > Set rxq_ctrl->obj to NULL after it is freed to skip resource release. >=20 > Fixes: 1260a87b2889 ("net/mlx5: share Rx control code") > Cc: Michael Baum > Cc: stable@dpdk.org >=20 > Signed-off-by: Dmitry Kozlyuk > Acked-by: Matan Azrad Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh