From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF1FDA0C4C; Tue, 23 Nov 2021 14:26:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E330C4114F; Tue, 23 Nov 2021 14:26:31 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2055.outbound.protection.outlook.com [40.107.223.55]) by mails.dpdk.org (Postfix) with ESMTP id 63E5641145; Tue, 23 Nov 2021 14:26:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FH1OUx1BjvZ7zDUY/CuBwwHgLWI/WLdyhCUnBMwph5Qapif97HZzvR6i4vemVeJxa5yADv5qFxRLPgM5GoSh+gV7cXQBqJAg/3D7KN95jaSEBjpKFzbAucQri4Z5f4Uh3mcdwU4PXbEldlWsn5A+J13RYLLUJcWhUTapBezWSpnyTYQXDcOGaYxvQ+X6M1ognMChIT3JP/TqsdWlngpmphnSzjW6G8AimgPNuhHmimFFHHEpQn8UVMv4+NJIVcbMTix+SK8ofpeIzRIQl3qSvB44cNxzp7jIb0Ejwn4uXDSCrflRiufiUnBfD/kmteTif+u9k0eTYSW0HfAMqomErA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fBCcJhycKTOIs81yAFNIyRtskNz2EPX2ZZ1sqWMPcX8=; b=mOMK0i7JJuKJfD0E82T+CulbiwD/3RRHd7hl0vYwZUiCrzgvVFXvGWSds49IrDeacgom8mCYkR/GMDT31PdYG/8Zp2istB+HC56M1/CTiGN2oWPzjhVCMG4ZfbxXsyDrqB38gccNHpCgPegQ2hALoSWg1UjUaqwQu2oLGchP1RGaYMjQNKe8BgOS9zc1J56yYEGWajCnEReYjQvpuXS3D7udhca5kQQah6QuEsg5XV8Ds1mwL2rpocCtHytqT/dFG+wVadvvn37WfLknbv96fduFrrdeMzapLvoCYNkgjfFtg4/IuBPtYK3Eb7RLfy3PVDSJCa79VnY4NuSpvrQpLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fBCcJhycKTOIs81yAFNIyRtskNz2EPX2ZZ1sqWMPcX8=; b=OBIjImF11zZIlXJCmdxAKD/pXLdToEo9R7+VbEpvkEyendpDovKu4evDBTMZJllCyFmysymmGGNWNLIiPumhgjW9oApZWoa08MraRtpq8Yel/w7nj+FU5pGhdhUT61zQWemPPuR1qoxaHZR7pgA2m3Qa5w7qFdoMg9ACemCxi6zXwI7mzqRMBCg//W57wXqZwGOxtEkcX1u5MAZ9FyHIrM/rlmW8NwRtsYFK/NPb08PA1yYGLz6X3g7qzwkP/tRSuyREGtdbYAl3k0D8UsUjUnyB5HR5gfKD1rxc6clSwMafuknScrdZyOv2mBYdZiqxbcfVxgaWDIiGJ7OZzUR/gQ== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM6PR12MB5519.namprd12.prod.outlook.com (2603:10b6:5:1b5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.25; Tue, 23 Nov 2021 13:26:29 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4%9]) with mapi id 15.20.4713.019; Tue, 23 Nov 2021 13:26:28 +0000 From: Raslan Darawsheh To: "Jiawei(Jonny) Wang" , Slava Ovsiienko , Matan Azrad , Ori Kam CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] net/mlx5: fix flow mark value missing on combination split Thread-Topic: [PATCH] net/mlx5: fix flow mark value missing on combination split Thread-Index: AQHX36yEB67IH8XrwEGMcXfOPxvsIqwRHAYQ Date: Tue, 23 Nov 2021 13:26:28 +0000 Message-ID: References: <20211122142252.20374-1-jiaweiw@nvidia.com> In-Reply-To: <20211122142252.20374-1-jiaweiw@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 51692cb5-7a3e-4a99-ee17-08d9ae84db68 x-ms-traffictypediagnostic: DM6PR12MB5519: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JHA0KhGgkxQxecIKqXCUJTsyltxl8/nq47hDPk14ldkKcKP1l2wMm++riW5D9JHUjJUemHLNnSK6M4QO/C6yJ2a5xbK/Hc/SHT2iT4EQMDBXS7ZiXsATDsi/7zJHayF+VngHS3GDj9Q9RAasojJvC0TyT0B9ai0n8PEJYjrbTd8ntPI8KAzpz4IuYdZ16B+ZtUvFsYQOCMehpr2p49yqW1S9/kXPHj5MvKp1sGUOsiCnpNhFYGx14JFYgCsHM2GgsF2KTW/9x9hwKbFksrOJFEYumNIn7NSt1jBnxJ0qGOZ9d/Dk4bZ2h8SI7MGzlxa8477GffdX6RJevK/HcBkIKAcJii2rQGMHRiBNL2u9pttjQD7L4gM97EOhdKNKZuByQlxlP7zueY78hhM/m6ghuOebA/Gp4dpmBKCcHx1eZB0aDDzAf2y8fSIKAZTf8PE7Nz8GvZ8whW4zFVUlgkO3GRsTnj6RhNlAh8VNxG67CkYIBx20YUtYWifA3tDiJSIJVoU2ckHLMTXb3tpxI+QXqTh6EMeRq6sh+3u2iokRGKDQyLvW3jziLVPFOr939UJnuflAIoP/ctS7HatD+U8okV/MyrF5R47iSbJbEVrZ6PlIp03tvHCSe/iEWIQ3WQrf6i64XOGgUGr96uerXwcmITe9FMv9XCIz01yOud/aviH3z+F5xViBleYKo3+1QrAdcLE6ba5/OPo+E5ZnRd8SYA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(76116006)(33656002)(6636002)(53546011)(186003)(122000001)(110136005)(54906003)(38070700005)(64756008)(450100002)(9686003)(6506007)(83380400001)(38100700002)(66556008)(26005)(8936002)(66446008)(86362001)(508600001)(71200400001)(66476007)(4326008)(2906002)(8676002)(66946007)(316002)(52536014)(5660300002)(55016003)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?txTRHaUocv0tbPM73Abq68VjEZnq8KjImkLFcK1YbI0faio7JXUyNOoFxEZO?= =?us-ascii?Q?DOWGgfqwuEkvctdZJ8xWA2H0ZDJxn9oevS243USY5/3U06QBc4TSlFT6u3QZ?= =?us-ascii?Q?6G5BzX94fticqDlJWxOL49v/ybRvnC1VsWMtgN1ZR8f79diHiCKubabvvW6x?= =?us-ascii?Q?Bd9XqGmdLH/RGa0R9L54sOO3mrbnNSL95mpdEjta86aOvq/EQVBQ3+I1AbLX?= =?us-ascii?Q?kjUnWIOMOSGhKN+2atCYEOyxrMTN0oYr8nx1pIU6AI3PdGd0TbysWvY17r2W?= =?us-ascii?Q?Zggz5A1xjqesRi12TFBJxMpMEl/0cG0M1VGRu7VplCs2bsJ/zoGOgVf/FJQ/?= =?us-ascii?Q?ReOYLAeLZ4dEcz3Z/DlbR05HHGmPxGGYTWSL2zN9b0VyjmBopSm/PzPdGYMz?= =?us-ascii?Q?U8eT3a2g6pkDiP7d+MoWpjsD6mJ0C8zxoI2cXFQddRt3QU/SEP32G72sf0Jr?= =?us-ascii?Q?03d5cpJDX5JuPIDushXehXBPs7SGWkYg0lAy2JHyjcWwr2rQw6jGqcgzw+1e?= =?us-ascii?Q?vcTz3ZMXCLvg+bdpBvuZRV/mkkMzglbZzt/idAXoth1RYX+BDrYwaEI1SvT0?= =?us-ascii?Q?i1JBjLZeBvwLoJwIgK7lIsf5SwPaXHyXC5Z27cJSYX9MtGgfEkvfmOpipGJt?= =?us-ascii?Q?AkjhaEUXqpDDLFGyV2nt2dtqs7MMZ/U7OztH1iQJHBsgZqWxdQFAe8Z94TTS?= =?us-ascii?Q?HfDmvQRoDqX0i1wP6Fok90GOetquTNU4ZWZVc2o9FrllnhmPPgT9QBzZ6y9h?= =?us-ascii?Q?B8sLjzVQnz/QAalPg0c+q5XQMHFN6U5ttIa8PbonXKUDI3o6ugOnPBZcwHlW?= =?us-ascii?Q?DMrv15T/SMs1JBraMJejP04twAczPUEq3y5r66123IJIWHkF1vZ6zJd4ZGRk?= =?us-ascii?Q?x0RL9eaRz2HzyDjli5aFSUYKOrkn6d5TdIneypo5puao6/JL1z0nHEFAponx?= =?us-ascii?Q?kbO9U1yu3n+MtKnbTZmxsjkdzUEcG5rBNeBDDe9HYWXVOwvZJ5aG8/KmR4im?= =?us-ascii?Q?OoJA2IrsfzFu5KIznIn15Tfwpy5Tt3seu5n3IlXX5TfFuL73BPWcwj82mFBL?= =?us-ascii?Q?BG2R98CwX5LQVlsdTmqzq+YyetXO2mtgjYCVxCAYgDxX63yLOzZ7Nocv4M/h?= =?us-ascii?Q?OOi9Wl9XVVub5p30Q/SfoD9EP+e0LXdziv04lPyLhj78essFFtyJg1eC0bzZ?= =?us-ascii?Q?xRx6v5lZVePwS4FcTtaOVDZlrMs1je/bW8cBHSUETXX717PO61ulpHG70Mzz?= =?us-ascii?Q?oE4N9RcNpxiPY5OnUE0A5+wr2jozX6rYnmcFpnC58Yp4NGzu5sPk2GQrOakc?= =?us-ascii?Q?JJdG00tkeXv7hEykDm8ffPCJAUbXkYQkuOHewY8hXif7rMn3JJc2JKQu3Ktk?= =?us-ascii?Q?OBBzyxpKx4iNk/+UIMcX/TIE5LhLb84szNrdYe25Ox/lihqJD+O2Q0KPRQ3i?= =?us-ascii?Q?/xBZ1rmI31rJ/ewM+vH+JmN5sKnnstkyzlhCPyi1l9hnG9xtOUXLOtsX5QTA?= =?us-ascii?Q?eo8ZLXlXskamAwMIdL6/6hxSJa9/8QEGyiYL4BGzHU+2+e0Y07qES6n6nD/H?= =?us-ascii?Q?04OZ7HgjrkyznhX5LuI42Wx1JO01wmwtUaatoKqcBGL2U8UvhMmisYa6k5Bb?= =?us-ascii?Q?o3GFJygNBmgucC+G0XgLFQY=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51692cb5-7a3e-4a99-ee17-08d9ae84db68 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2021 13:26:28.8782 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2KmmZoYqfmHR9+WKaY8cFACPf3wJ5ysMcF6xJf7vGn31S9XovSO4r57/7PKcJpmHmvLfC7xMbjgCdjz5MEWQUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5519 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Jiawei(Jonny) Wang > Sent: Monday, November 22, 2021 4:23 PM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: [PATCH] net/mlx5: fix flow mark value missing on combination spl= it >=20 > If there are sample action and the meter action in the same flow, > mlx5 PMD performs several levels of splitting. For example, sampling > feature splits the original flow into prefix subflow with sample action, > and suffix subflow with the rest of actions. Then, metering feature > splits the sampling suffix subflow into its own meter subflows. > If mark action was added before the sample and meter action, the > flow mark flag was kept in the sample subflows but reset on > handling the metering split, causing the flow mark value missed. >=20 > This patch keeps the flow mark flag of previous subflow, and then > the following meter subflows handle the flow mark correctly. >=20 > Fixes: 9ade91dfe85d ("net/mlx5: fix group value of sample suffix flow") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jiawei Wang > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh