From: Raslan Darawsheh <rasland@nvidia.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Dmitry Kozlyuk <dkozlyuk@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
"Xueming(Steven) Li" <xuemingl@nvidia.com>,
Jack Min <jackmin@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: do not close stdin on error
Date: Mon, 1 Nov 2021 08:55:42 +0000 [thread overview]
Message-ID: <DM4PR12MB53129B221E14FDD112013415CF8A9@DM4PR12MB5312.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211014113718.12487-1-david.marchand@redhat.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of David Marchand
> Sent: Thursday, October 14, 2021 2:37 PM
> To: dev@dpdk.org
> Cc: Dmitry Kozlyuk <dkozlyuk@nvidia.com>; stable@dpdk.org; Matan Azrad
> <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> Xueming(Steven) Li <xuemingl@nvidia.com>; Jack Min
> <jackmin@nvidia.com>
> Subject: [dpdk-dev] [PATCH] net/mlx5: do not close stdin on error
>
> If for any reason, a socket could not be opened, mlx5_pmd_socket_init()
> could close the 0 fd (which is valid, and has a fair chance to be stdin), since
> server_socket == 0 from the variable being in .bss.
>
> Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/net/mlx5/linux/mlx5_socket.c | 29 ++++++++++++++--------------
> 1 file changed, 15 insertions(+), 14 deletions(-)
Patch rebased and applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2021-11-01 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 11:37 David Marchand
2021-10-19 20:57 ` Dmitry Kozlyuk
2021-11-01 8:55 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB53129B221E14FDD112013415CF8A9@DM4PR12MB5312.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dkozlyuk@nvidia.com \
--cc=jackmin@nvidia.com \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).