From: Raslan Darawsheh <rasland@nvidia.com>
To: Lior Margalit <lmargalit@nvidia.com>, Matan Azrad <matan@nvidia.com>
Cc: Lior Margalit <lmargalit@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion of ETH item with EtherType
Date: Tue, 2 Nov 2021 08:10:45 +0000 [thread overview]
Message-ID: <DM4PR12MB5312ED2A0F13870394FCE8E8CF8B9@DM4PR12MB5312.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211101063841.819001-1-lmargalit@nvidia.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Lior Margalit
> Sent: Monday, November 1, 2021 8:39 AM
> To: Matan Azrad <matan@nvidia.com>
> Cc: Lior Margalit <lmargalit@nvidia.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion of ETH item with
> EtherType
>
> The RSS expansion algorithm is using a graph to find the possible
> expansion paths. A graph node with the 'explicit' flag will be skipped,
> if it is not found in the flow pattern.
> The current implementation misses a check for the explicit flag when
> expanding the pattern according to ETH item with EtherType.
> For example:
> testpmd> flow create 0 ingress pattern eth / ipv6 / udp / vxlan / eth type
> is 2048 / end actions rss level 2 types udp end / end
> The "eth type is 2048" item in the pattern may be expanded to "ETH IPv4".
> The ETH node in the expansion graph is followed by VLAN node marked as
> explicit. The fix is to skip the VLAN node and continue the expansion
> with its next nodes, IPv4 and IPv6.
> The expansion paths for the above example will be:
> ETH IPV6 UDP VXLAN ETH END
> ETH IPV6 UDP VXLAN ETH IPV4 UDP END
>
> Fixes: 69d268b4fff3 ("net/mlx5: fix RSS expansion for explicit graph node")
> Cc: stable@dpdk.org
>
> Signed-off-by: Lior Margalit <lmargalit@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2021-11-02 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 6:38 Lior Margalit
2021-11-02 8:10 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5312ED2A0F13870394FCE8E8CF8B9@DM4PR12MB5312.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=lmargalit@nvidia.com \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).