From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01135A0C4E; Tue, 2 Nov 2021 09:10:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDD174069F; Tue, 2 Nov 2021 09:10:48 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2056.outbound.protection.outlook.com [40.107.237.56]) by mails.dpdk.org (Postfix) with ESMTP id EF55D4068F for ; Tue, 2 Nov 2021 09:10:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BR7AsNiprj/1yQlwY08CiYgsZeiKs2e6BPDJnfWN09bMMK9i2XeDjBoCPS/5rtwRYgf0Fs2zqtEWB5km/knuEwvJzv9EmclT2yOjKhMkK5pf0urMzXOFertjhmFGCIJsUuIwU7H/ET+QaE8vIWFl0r6O+AmL/5LyrM3Km2H40sy9YHgplg0SZZnf+nmeSNBIwffaTH+k+yYBtfkaVjOSPvkuBUTNe1ugFNVk4oBszeFibqweNLbB3Azlvb96AIA/kpE+IvY0b4JKElA2KcSNOWAfAbbc854yI+fPZg2rfwkmnCU+NKOQcNOoHRG3Vlp651XCZI2pXpay9HQ4+3dd+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DlSqjKicM8qaM0VDL4M26osuynsLya4iklXNG7TVVjs=; b=RzMopNEPh6ct71BfzsAOfZOxTTj5qDt49ovpk9Cd3sUXH1x2J5qjWp68S6Fx+9Khv+pBUkCKxUaRO45VEEM8RymYQYKtsULMHFNlI5zfsY9L7UfE0bmhl9GJWA/wrcJaWccty5uBNQG4Tm6ySWu4omUbF5eC2LNP1DJxandBzbPweMkBob2HB6096Az5aWNt7iHAaDTvOlaFvLVEuoUwrb6LYfDmFcwBNQFzrD2e3hd4aCbnumkLTb3aPB0la0VZXXawqWblwzEc+nQx9gChxUZbXb9/z//wE449RrupT4zAXJQTOtB/C/RxFAzSUO17eO3mRjcsc8W93AAmnxlp0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DlSqjKicM8qaM0VDL4M26osuynsLya4iklXNG7TVVjs=; b=Pzg7LLm88aWdQKjnL/AlpAOlOlxk0oz9ENH7UttBXMhSThCLuTVagXF0DvXjGf0hn3qUdRVH+oOwrlj/tvLkFLRHHZX3wEzxNG86+8InM/d4CYpqAWedS/ve0V481iSvTpIitQYrmPbFHWJj+5qyGV7xOJTVW9h29V9ZC0Q5CRDzdVVAE81mZEU4XlcYfTrojjwIcm1ApzTOMXE1ykxjCuDScTAWCtTO8Kld6aEOq2KfHPHMRuaDhBFuCSk5Shyu1sYeZ/0woGfwaSmGi303vUIjAQJaO9p0L3AlmVsI+7BNESPQvQQ57oX1i2K2oBHYBHV4KAb+VJqLTP0tCuIpFQ== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM4PR12MB5327.namprd12.prod.outlook.com (2603:10b6:5:39e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Tue, 2 Nov 2021 08:10:45 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::a4bc:7da3:32e5:1665]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::a4bc:7da3:32e5:1665%9]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 08:10:45 +0000 From: Raslan Darawsheh To: Lior Margalit , Matan Azrad CC: Lior Margalit , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion of ETH item with EtherType Thread-Index: AQHXzussEDTu2WezMUmYVQWNI3AXWqvv5EYw Date: Tue, 2 Nov 2021 08:10:45 +0000 Message-ID: References: <20211101063841.819001-1-lmargalit@nvidia.com> In-Reply-To: <20211101063841.819001-1-lmargalit@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c48913da-ee37-4346-0b11-08d99dd845c0 x-ms-traffictypediagnostic: DM4PR12MB5327: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LQ9xSjh6c/+NIANmWjXRvxNPpj1LzfgQm1Yj7tXIUBxtP/ceKE+LLWEHwwKRSGwFNZYocexG4+Ojs/fcHAjlBskzZjsL7Xrt7bPiEf8Tsii5z1Ayc6+CjyONp+7EhUgIJzTuQWLbSD7wrQF7rqjy2FDV3FsMju/F3mwFY9od2QDL7V0S2LM9iQkU0+fIvYXV2nIZqpx2Hy4w0myx7EJp9aH+ldtSUu0dq6df1j/anQDpwH6OP5xoKW/5nNBkW6lag4OSwjHXtiV8DtCBl25ov0QOVy3FjGdtZu69ixxNSsaxLwG1kia88WY7te5VSfhxpIMvC2A8fsAt/ZDMxMkvgsu9X+MYf66aYu0OlC0dOKrpBDxE/5SuBKOLBOYtRvt1qKfaJu4aVuzuGpVKfLJF3J6bfhKUHa3IuFfh8knPrtrA2Hori1MmQHMUnfPT44nSqh6GI51PIanV0Fg+QV4hbNpwhL/Tri4If8OkHUmucGjBC9H8Qu3NRcoA5c4Pb3FdjsIMkSlQ2SLk8pdvL4gjQp7bb7iUm3G70GmDMNX5xPZDwTHo7GwLhrIHaCG9JIctRS2AThYiVxBfyv5u6JirDff8R+WAqIEE3EBmudyGN/v+QUxunUayYY7zCxVu7ezBACKp+CZm+TW96SNEha/Z5dPaNQn8FYBZ7s5O706K7QTqVPSTfD01frhViW47LeR0gswDN/OfCiJZ2IZhAZYP8g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(52536014)(316002)(54906003)(110136005)(83380400001)(7696005)(6636002)(64756008)(8676002)(8936002)(55016002)(53546011)(5660300002)(86362001)(66476007)(2906002)(38100700002)(122000001)(66946007)(6506007)(4326008)(76116006)(186003)(66446008)(33656002)(71200400001)(38070700005)(66556008)(508600001)(450100002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6pSCPckb+jtdRDnJujuIPzQ1uPLb0UIOPnAVe364qwF6Ip1XylEss08k0+eS?= =?us-ascii?Q?EqI/x7Hoq8D2oVlMaZq0i9BLRezWD0poX7/okPAVbQaytc9RnW0fz7Od+whS?= =?us-ascii?Q?I/aqCPKgix31kzf6aJ5KbYYbf/YwY2dL6KPMzEdpdrcuRjlQZlEaAuNNv/11?= =?us-ascii?Q?Lr4FFYMCsq+wgg8oDW9EQNyttyjlPm8MgwVunV7jWUtYJVTVMAMK6A1HRe8H?= =?us-ascii?Q?dbP2dwdG6VCaVde5isCdplMFldnG4wQcQNVoS1yJ1WvB6UmI102ojf7QDnM9?= =?us-ascii?Q?gVK+eHDDxII8OTjZ3SF4P13pfWhBCB9fy+YpiWhbR9Y4pyVPuL2oHaVvlJ0a?= =?us-ascii?Q?6nQ/+OxZPa13WNaU5QzjS83PPMBuHSxv5znJkKT+5grDyQ3VSSTnI6dMR7M0?= =?us-ascii?Q?PK8dqHEwR7EavD+GF5iSMXOn6nn9Tws1vZU/ZOpFMVR6n7cAX8CcQ+3/jG9b?= =?us-ascii?Q?iX0ufOnrWqJ1eEoTEoti5i4ObQEqz9XEwGqz80kF5cchBn0HG3aKXNiTLRf9?= =?us-ascii?Q?fGCshLB5vJ2dF0Kr6DVdnliR9XWCxAHYQLIdEEK8P1LgRy/HuFm1HLm/+0pC?= =?us-ascii?Q?5ES1T73arP44j9m/A0/9EjYajoSqZFKtRuRdxtuunxztXwjsrXxVDERz4NIs?= =?us-ascii?Q?Akliy8nLZW6GFImqHDGBrXNVpNqBHG5xmdTDlfO5aZVoKN6+ucm2bYD0rsm7?= =?us-ascii?Q?OUrquDIDxKUSn7JqHV4G1HVzc4Db0P4XmZfjjpGJA0ilQGxNB88EGlFypMjF?= =?us-ascii?Q?w27N+yuNA8T7tKgUk1bwcwxK4Xyk2zYO2StmCG8YEHa1IzdrdTfPi2HDllBD?= =?us-ascii?Q?89srBUSN8jCai7SD5ePXUivBfCs/+zY9vJevWWwMpA1gbyDUyyY8zgIlTf/a?= =?us-ascii?Q?TLDxjRWHvowyHUBLcVxlwZ73aiyGXQletcfXmZH9+JOWdspBsSITiFfwbVu6?= =?us-ascii?Q?TuId1vkiOXaCQMViI9kpDoZ6SpFGLhyAXPVI2fMTldHc381ekJO9iiprxAWP?= =?us-ascii?Q?kybTEh13xmGPPU21buVXQph7UqspAyQnePBKsw26smA1Y86G7adPE/dCo+3D?= =?us-ascii?Q?vnyI91Zyjcxvkpk/tXKHJKowAEVOQNkPJhpVcUfzB23kf8Vy3/OqDp8OhkYQ?= =?us-ascii?Q?mlvwje7vK/j7kT2rVcCcCt6fdZCtdMYjrly/tHTmMFYi5PcsQFG7QVFByANz?= =?us-ascii?Q?0Fob/JrxoGh9AjU8gYPSodtHuGZBLCmD3Khku53Q+qKXWW4eOgXrwZizWQWR?= =?us-ascii?Q?0pttUyq82rv76F4odCvBTT1tFv86ff5tkW1S27+y0g1+g9iLGMaZloneKeBm?= =?us-ascii?Q?3GgevK83XhuCzV486GXEp3/gmATsYNeVosOAOkBfoaObGhQ7Bvk/aI6FNy64?= =?us-ascii?Q?Iq76Cqh3uz+aRab7/i5OUv3qTX8MwYi2mqsKoS0ePVrVMp3/0NjGI5VcR7V6?= =?us-ascii?Q?sdgk2EvptLafWjkQ+kUgAqzlG72f/yIKE87FMo0wF6LBL+IU9n6UXzW8tLBL?= =?us-ascii?Q?/JkO42AH0DwhNb42FNSORKeGZBN5LNOWu+DmuC0NTWQQxArD+wLw8wsASMby?= =?us-ascii?Q?E4RxeOVzJKbAndHHmd5hvfbQZ0mzRwKEGZ8Sfbu/qFqLQlBmzuQpCkHu10G+?= =?us-ascii?Q?bVkYJI1SQ5eJuOPaSA/W/NA=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c48913da-ee37-4346-0b11-08d99dd845c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 08:10:45.7221 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CpkbGpjg/6QSJBvpjKRBoie/Wcrjme8jL39eFV5GeGsKB+Itm6Ed66Wb2fJdFM9ovNfM6DLwOQIPOyYGFrJWQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5327 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion of ETH item with EtherType X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Lior Margalit > Sent: Monday, November 1, 2021 8:39 AM > To: Matan Azrad > Cc: Lior Margalit ; dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion of ETH item wi= th > EtherType >=20 > The RSS expansion algorithm is using a graph to find the possible > expansion paths. A graph node with the 'explicit' flag will be skipped, > if it is not found in the flow pattern. > The current implementation misses a check for the explicit flag when > expanding the pattern according to ETH item with EtherType. > For example: > testpmd> flow create 0 ingress pattern eth / ipv6 / udp / vxlan / eth typ= e > is 2048 / end actions rss level 2 types udp end / end > The "eth type is 2048" item in the pattern may be expanded to "ETH IPv4". > The ETH node in the expansion graph is followed by VLAN node marked as > explicit. The fix is to skip the VLAN node and continue the expansion > with its next nodes, IPv4 and IPv6. > The expansion paths for the above example will be: > ETH IPV6 UDP VXLAN ETH END > ETH IPV6 UDP VXLAN ETH IPV4 UDP END >=20 > Fixes: 69d268b4fff3 ("net/mlx5: fix RSS expansion for explicit graph node= ") > Cc: stable@dpdk.org >=20 > Signed-off-by: Lior Margalit > Acked-by: Matan Azrad Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh