From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B766FA0C47; Sun, 13 Jun 2021 01:06:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9CBFD4003F; Sun, 13 Jun 2021 01:06:48 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2063.outbound.protection.outlook.com [40.107.244.63]) by mails.dpdk.org (Postfix) with ESMTP id 091A74003E for <dev@dpdk.org>; Sun, 13 Jun 2021 01:06:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bqo741PJHilOW5xZQ2mDbzO3PsDBZdT5MEC8wErLYvT69SBUH/yqsTF2moRVn5kiUD1UGAexuIQTBvNoULbgibQFdiJP1jd3OMbYIwQ4Ail9P7tWF9vkS/yikNh8B6b6NmbcC8H+4Dk4c0CyOubY3wWhRAbRb/UIlc9ULZkywy9xP/TMlDs0q6zgdPIP0wpu04g1xQUkZUFypy7L68DbUV+3Y0mVROy7G4VJQWP3PV8Rj+YRZedQ7s5hhPx67bsR6POxaGOUapKW+jZXUDsFSoM++zKh5YLGGlgYqeVrtTpZrte8WanseW/bFDyD+2ejckS8jOTpU8ukvXgrUA9+Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4BI0+B9tOScaIOrgSgSfm21k1wV9BrXppkdIU5FI5cU=; b=mIYNnVrIkrnOEhgiTeyNjAF7uSUdOBMY2+leHw16Z/MWmmOi0udj4zLSd2eL/ngbZmYTeHmW6hecBgtDTK7SO1jzMfJZOF0neOhNV7a3lldQkKxDAlMp5kGlsKVvWc454XKD/WFsKk3HGb1hxq2V43c8Q1B/2+Cw0eQIj0UnBHwKJaA6a0W82MGfy1wV2QORJcFHkSg+HXJ20JagjcaBcsf+y+T12bd2Et65w+ker3zgpT1Ow7xjbl2f6hRM9M7XJsTpmv5Mg6E92SrptBYE5VltCSm3xAhps2C03RDjcQDMcbFl2G0JAlWIrit81WUGRBflMGkl17fpTnvfjlhBtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4BI0+B9tOScaIOrgSgSfm21k1wV9BrXppkdIU5FI5cU=; b=PGjb2s5061fU21s/2BGp8tyibRsg/cyRywQVng7uSDh8xPit7U+zyh0RRBj/QrjpoonmqAO/FHAOGyaMySDs6obGVdB5FSqiEoM+WIuScLve74OWLL1Pj3M6txJt2fS7zfnBod3ha90H1gilmtH3+evAk5jw5/rMU4K67q+VI3G4T1lXJrUwL6p0vuMIaeqbkd8BzSrwjKdnMbJBLOhRIhmIpa2xPRHcRXI1GPxVryMa915vR7XDvUJAMggo2a8rdLMINLH8jL+/i6t7ywqOfydDNvCW2Ty5Qg4ZyQvENlS79nRxgle4smLTMbglnLxYdgx2PeHEB89gGM1gjUfLtA== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39a::17) by DM4PR12MB5310.namprd12.prod.outlook.com (2603:10b6:5:39e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Sat, 12 Jun 2021 23:06:45 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::ac75:9b9a:a03f:1676]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::ac75:9b9a:a03f:1676%3]) with mapi id 15.20.4219.025; Sat, 12 Jun 2021 23:06:45 +0000 From: "Xueming(Steven) Li" <xuemingl@nvidia.com> To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, "david.marchand@redhat.com" <david.marchand@redhat.com> Thread-Topic: [PATCH] eal: save error in string copy Thread-Index: AQHXXxQMX76Dz8GHIUqo+wrVPQrXVasQDXgAgADzXTA= Date: Sat, 12 Jun 2021 23:06:45 +0000 Message-ID: <DM4PR12MB537319DDE42AC9B6A288ACF7A1339@DM4PR12MB5373.namprd12.prod.outlook.com> References: <20210611224907.1904-1-xuemingl@nvidia.com> <16401109.pIj2lYa0bN@thomas> In-Reply-To: <16401109.pIj2lYa0bN@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [180.174.129.228] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87766e5a-66e4-45c2-7087-08d92df6bfdf x-ms-traffictypediagnostic: DM4PR12MB5310: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: <DM4PR12MB531088E98BF0173F7FF46DACA1339@DM4PR12MB5310.namprd12.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: A12wxtBO/6bYH5kl1uKxavhPMzE656IaG23i5Qn3islyzbTF4bhhPi+teE5rkGPMfWWw4uykIb8M6sFPoLS6cul4DDstfKP20E3FKDuReOJ529EdEBN33rWTz3BsVQNzrJjLPC8UdpeQWqtBuFQRjnDCgKObz1ClZxJIwxFiqxqfOGavdFpy1ffWZ115KgEt7bmHtDUSp9QxCPI4YlPq9UjlQ7hUweH/b/lcFgWthYNqRt8cVdffseYuLZMvqX3Lyz8WVlp5/kn9HKYinIvD9uo9qHuEjmpI+i0+T0OxGkj8uyyoC4jSwkBkIUHmkMAsDlZolfKOZFekaL3rPXTAUql4wpJldMcH6wqUbAUnsufqvEXxlaaP73aL+NRixkan71EwNY6/yrb36F1e8yYmyzZ5cOolYAC4QFASW4LyCBwSIlycqbrUnMs1NFdEHPWsyEffhbxop3k8TyBG7bGZF0lJAEVCSfVAOBIy2ks1D4DOUNTD0CCXAG7l1hFLuqfgiGLqXz8zXHiMNEZQIVElnxQH97+h/pH1bwHlPXnBxZlw2JG2GeKdjfiLhDmiHwBf1VU+p2YhfFjuE8/nSCvTdfIFx4UV0wfU6TRVmiaGOHA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(136003)(396003)(366004)(346002)(66446008)(478600001)(54906003)(76116006)(8936002)(66556008)(4744005)(64756008)(8676002)(66476007)(55016002)(6916009)(71200400001)(122000001)(2906002)(26005)(7696005)(316002)(9686003)(33656002)(53546011)(86362001)(52536014)(6506007)(38100700002)(83380400001)(66946007)(4326008)(5660300002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JhY7CpPOFAI5vGTBON+mLL4y2s6mHBuG7LeGCtexxYHnSZa9oXIlmZmKGhKa?= =?us-ascii?Q?SDpqB+BWwvpFDD/qHCnCyAQ/8/XuRUHGoXxRGExpvy93phc68fbEpMAd+Ipa?= =?us-ascii?Q?Q9vLFQ10Fgz8RmgOy2oM3aDaoohHe3cMN29PxgMAccUpxrc5TkM6hGucLQAg?= =?us-ascii?Q?+m1HiQ8ogqEGjaW65YhHoj61dtS6ck1/p1wGljvikjo/VZWMT+1QVA7BK1ui?= =?us-ascii?Q?eAxPPNKu2zkxHlLYOZxdvFYh0J1pfth4dmq3/Thy8Oc2DkrFyKTcm61euymm?= =?us-ascii?Q?+ShHK3bl7euLbFj2ftEbZwjw6LpiS3sAMRX41r1nXolY70bgIpmZF37bXIc/?= =?us-ascii?Q?/9qbrONOPzDSUVb+6KiWoJsZI03GXX8lw6QFyYVdG9n6RzTolu45h0LO2XVo?= =?us-ascii?Q?38UYJRqg9tlyGXMSiXDpcdtepweQjLdUuLHdmYzF9yOQfQrn95NMEVgXmehH?= =?us-ascii?Q?2ASEfrvXQJq5bKXGDMdNoh1nteHfuCZpXt98CAJMIr9AfALLNhPuqUKAw6Q5?= =?us-ascii?Q?iRgX9dEzU2Cl1sIWiKYWauYvMf9Yem+Vy9iPnDjwlR41uG+H4xxIgJsV2Vsj?= =?us-ascii?Q?JtM+ZJgi7DGrDm0Z7V9I1+U6CgW4flPz+BWOfuHt2ZY94e/hIravxZIZGOcV?= =?us-ascii?Q?DL+a59mDZVfcxxO0bCDBHFo2GbMtvSCsFtXf8vTGdCnWP8dvlM/bFyXCM1KC?= =?us-ascii?Q?OpJHDxIOIfCcw8pciV9vwG5aR+1w2r0YTnMdrdBe2g0ljz1E66jB7A2m3Lr6?= =?us-ascii?Q?3JH2WkuRz12ojxaU6kakJu1I8edpwOz/5TOuANqFYEyOqOtUDTjcaDmOtSF9?= =?us-ascii?Q?hLm0wSQIRQhoObplMyRI87ESURmsfW+MWcp58djhazM0VHHQx0LrqWKHFUMz?= =?us-ascii?Q?piyetCgxHOLoBEmpThyarHPnH+2mrJS2Y4wFHMH88cj0NqYrK/AWhz6f9QaE?= =?us-ascii?Q?/H9XrPGIGdR8IPlyxEOwFZa5eEXKRwvGAgjQOJ+BUMiMryoQHvLl5bYUpJ2R?= =?us-ascii?Q?b90bIOZ86IWLafX0xSarYBFqIizEG1ZXALXDDC9qtppaxp4JTAI1uG0b6UcQ?= =?us-ascii?Q?MDriFI+lsW/0GE4fZlwiRqhwjpz+q2ndZ3JeOjNFRQ9RzBV6OWhXPsb7Xi1L?= =?us-ascii?Q?ioOjc6+p2rmjfyoOZX9tFVAgb7hjKi9Yg8tw92ISuc+g5qHQN0pydOVBCGYC?= =?us-ascii?Q?BLVri5ep1kSslaUw4WmzxRhhrDMrBckLf3LAXdRcrTXWxeeWoEIB/FRVdY18?= =?us-ascii?Q?p/8th3cRjM5wYaBjwc9XjjqGWka3p5ZvFOuG92vGyDLhjzxg/MXYzheveOL0?= =?us-ascii?Q?q8TYvEuItA6r080bwMlXXyeO?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87766e5a-66e4-45c2-7087-08d92df6bfdf X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2021 23:06:45.2886 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u4npkdre37Yur3FrQ8IvUKt+YB5UfIG66161OWuTqtuIZDmFCZfF9yjnXtwmTgKuwstuzhY08Wz9uSehsi444g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5310 Subject: Re: [dpdk-dev] [PATCH] eal: save error in string copy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Saturday, June 12, 2021 4:35 PM > To: Xueming(Steven) Li <xuemingl@nvidia.com> > Cc: dev@dpdk.org; Jerin Jacob <jerinj@marvell.com>; Sunil Kumar Kori <sko= ri@marvell.com>; Kiran Kumar K > <kirankumark@marvell.com>; Nithin Dabilpuram <ndabilpuram@marvell.com>; d= avid.marchand@redhat.com > Subject: Re: [PATCH] eal: save error in string copy >=20 > 12/06/2021 00:49, Xueming Li: > > From: Thomas Monjalon <thomas@monjalon.net> > > > > Sets rte_errrno if the destination buffer is too small. >=20 > Would be good to mention the function name, and the reason for the change= . >=20 > > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> >=20 > You did half of the patch, so you should add your Signed-off. >=20 > > --- > > lib/eal/common/eal_common_string_fns.c | 4 +++- > > lib/eal/common/eal_common_trace.c | 1 - > > lib/eal/include/rte_string_fns.h | 5 ++--- > > lib/graph/node.c | 12 +++--------- > > 4 files changed, 8 insertions(+), 14 deletions(-) >=20 > Did you check all occurences of rte_strcpy? Yes, looks not too much to modify.=20