From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4235AA0C45;
	Mon, 19 Jul 2021 06:05:53 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B598D4068B;
	Mon, 19 Jul 2021 06:05:52 +0200 (CEST)
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on2043.outbound.protection.outlook.com [40.107.237.43])
 by mails.dpdk.org (Postfix) with ESMTP id D8DE64067A
 for <dev@dpdk.org>; Mon, 19 Jul 2021 06:05:51 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VbSJtc39z6xl3PN/4pFOppzWCpJ2v/DRnh7VJB3sH9IN12ceVY//fsLwvKVk+i18Dexl2iaf9AqmWl24zcSYq97bTiI3bEhO5hE5JD+/DVlnXbPeg75aI5aMG7f8aEwkGV+O6eGV0STuiZI36HmmqF7KNTSpfJp3oPq5uSZQGnkUm20x4tijmaOugApmayXlqlDiVuNxMisYMzF+pzo7Z1h+R7GpmQBIQD52fvI2uj4+2lpektd/ouUUEElNB1kJo4XrqeYIA+K4s/YpgSOvvaGYZNZWFAptsGMq0HGij5g1PekhxB/tJwmVSUJypirm/Jy01R1YYu7i9czUPo4Xaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j4Jt3gK0aXXEUHbPeiTGxzD6hPE6PpRNx4aYefeIwC0=;
 b=iRZmxC/u302we//hBYe4f1vXOA7myKvcrELCCQpp2ZHGTw1KnTQDTbqqj2AxYizakZb2iIqzJ9BGUXGO35ajEvgWf6g04J3vAkKeeuLgDTdXKy0gD69KNhbtAOyJkJ4fKUwIvlr0g7tKFOca55p/5QJkORCS2AzhrFRNe3x84WELC85uwYKAAHixODse6fmf+l+cS3M6EXYt9fh8isXQooHi5b/mvgPVYguS2mrIrgllOvQNIpaIVxyL9FqQxvu8NszPff1r5XC4a8e1CoSbKe3S6Rs42XhE03T+LebevlAvgg3/xw+hhPcJAM8R0Lg/eOjxzGWsQH37xckbE2XZ+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j4Jt3gK0aXXEUHbPeiTGxzD6hPE6PpRNx4aYefeIwC0=;
 b=RVLJMAkoF653T8NTVjU5ljJ3eFLDwTsngabnbamjvCvhOFcjx87Pl6cX+Nwplg4YKJJvfzbZd4KXOnlhY/hGfDniMEHeDHtwaQvNWHpxAqvP5LDu3CiMc2jLLgiff24dCMVd6rznqei3FRzLLZJRvVB/GOmG3CMmraMBlSoV1Pefb44WadAz/47+3dKN3NN11jVy7OoJQYhYasZEPYBOwMzGcw0x4wEGX7cJFiGXzuAiqwJkoGmNobOc8LBtdzF8v40aclrYuGSIqkfm99A2ILFL5B5NootZvAHQuqfH87a3dBByeK9DDU8+WHRnOH0ed069TOQOUjFri0l6bm62iA==
Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39a::17)
 by DM4PR12MB5343.namprd12.prod.outlook.com (2603:10b6:5:39f::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.32; Mon, 19 Jul
 2021 04:05:50 +0000
Received: from DM4PR12MB5373.namprd12.prod.outlook.com
 ([fe80::20f5:dbdd:64b1:617b]) by DM4PR12MB5373.namprd12.prod.outlook.com
 ([fe80::20f5:dbdd:64b1:617b%9]) with mapi id 15.20.4331.032; Mon, 19 Jul 2021
 04:05:50 +0000
From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
CC: Slava Ovsiienko <viacheslavo@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>, Ray
 Kinsella <mdr@ashroe.eu>
Thread-Topic: [dpdk-dev] [PATCH v2 01/14] common/mlx5: add common device driver
Thread-Index: AQHXd+lCfq1VYcXRM0270wtugh/nNKtJFa8AgACg1qA=
Date: Mon, 19 Jul 2021 04:05:50 +0000
Message-ID: <DM4PR12MB53733EB9DDE7656D5E31E324A1E19@DM4PR12MB5373.namprd12.prod.outlook.com>
References: <20210616040935.311733-2-xuemingl@nvidia.com>
 <20210713131437.30170-2-xuemingl@nvidia.com> <3136162.L0fBmL6Tbv@thomas>
In-Reply-To: <3136162.L0fBmL6Tbv@thomas>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: monjalon.net; dkim=none (message not signed)
 header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 85cf5450-09f8-4ef0-51fa-08d94a6a7eeb
x-ms-traffictypediagnostic: DM4PR12MB5343:
x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM4PR12MB5343FC9279189C4389FF3447A1E19@DM4PR12MB5343.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:260;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: RPXb6Dwhnyj7CAGvy3Rt1oJKMo5JY9IwzpCpatOnVpMtjtn36+tYXj5uQiaWo8P9hlps53OYRK4wKskJJpyahWpXmggB0GCgjdX70010VWxhGmxjkmruFrV+GI73+3lHOFuCH5tw7gpR96qRdLx5Wv9nuFz7Yf2yfKnb8ETRpsdQHlkcKAQpFclqOwzYf1zzMOuYjK8cpQtWxE40GbZypz11t2eAPAehmKYTnr9WnvWbQaJcnkU9YeKWZ1+Q3T//TrE0HLYx9evhcApf89OHHIcpH8VNu6Kwvd9LOfkkegnekn2YdmBX7DsaE8Vry31EyoMYYC8JS7LDkizLi6QYEZQHLMOe9ubw0xtgI3eufHesjrosFqOz05l8s7tZHMbtzmwIgexS4eza8wd65kXHHFUKwx6PjObPZXYAMHrMcAbsQ/rV6uFLPc0JBWSiZBWFDIqblNpo0pvDl5/0Tu/WFJ89qfDHoMe202XUIaNvhta2Gl55w5Ui5TPSgjL0ix6VwSONKR4NJnXVtWWrdoQVY5FzlWGu1U7uDbn2YNxo7NXu14HG4tbT5tHifs686ZS6Fd9gEerSXa0tmhhBh5ol3a2uHaJB1TkIAgIgSAU9N4VlDqN8W1XiIyxvbGipPkeO8hfquaerC7GNpkJBcQsSmhrxX7O/Kq8Z1KgXhv9LjRqnstfxU4xRjQj/rIkmaFj1E7Ma+qm9zy1/SJHdXNoIog==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(346002)(396003)(136003)(39860400002)(366004)(376002)(83380400001)(52536014)(478600001)(86362001)(8936002)(53546011)(6506007)(2906002)(7696005)(66446008)(66946007)(66556008)(66476007)(6916009)(64756008)(8676002)(5660300002)(76116006)(38100700002)(186003)(9686003)(26005)(122000001)(55016002)(54906003)(316002)(33656002)(71200400001)(4326008)(38070700004);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tkHDY/7unTdIbosX5kQFF2WA8tzjRhGBUmtXmhx1vCuh74jBuhQKLXCZllzT?=
 =?us-ascii?Q?HORNZR5Cjer1klEZDZ4HJ+g2dtut4l91QZEcXyGmdWMPYylM1j+Mqi97lvcs?=
 =?us-ascii?Q?iFpsdjfjkArTrxN6TYURLXkSrdAuE7jQQMRHaH8NzJzoMlwnsIt6NLXoGK5a?=
 =?us-ascii?Q?b9JV/qPYcvlsUrmHzprxYc3KogFZEflN4uD+vLP3fdOBRJUd22UYuUWuDcy6?=
 =?us-ascii?Q?3A1MnzIgK4h1EvYNlBfO27uO0kf5T78iXVHLCxSRZT8jd3/xi6y6FFN7opXE?=
 =?us-ascii?Q?Ax+CtOow203AY/RMtTJlsSE9DoPkWI7c3eXoBDGWMinA4Dus6Sxczdm3cQcM?=
 =?us-ascii?Q?fUyXdLuVgnMrEySBA3aNeK5h1f8YxdX9OIc7FGASslorBh9maYTuE8eBHCZs?=
 =?us-ascii?Q?F3n1iXapERLr2ti3BwsZv58Gy9pef49vuE/VhRMuOH9CRTmPYoH75j1+nIVm?=
 =?us-ascii?Q?p0bon+7Re0BuHeAqFrJW4HwX2dqIFc6SJ2dL+9aORi9HuY1ZvYrJPy+61kTe?=
 =?us-ascii?Q?pXo1k010lRXV6bfEvJ3OcsNfmgzllnSPLXf41VfEEYxOOxldiVMnnJJdY3QY?=
 =?us-ascii?Q?JLXj9tI3RMn2H+GWTBED7yASFa7dOmfNYcGTCu7ABUkDPFypJzrZ7qV/l5Xs?=
 =?us-ascii?Q?OzNR+s/Kvcb4TlfCTKg6ndNgtxLHf0wvBV88pg890Fb0UBXdGAie7lYhzHbP?=
 =?us-ascii?Q?vmuD36Wb0ERogSvbTZKkSYkkMlgNdH5AKPkDsNxN4wxvdzhBsGaFe2bP5MYL?=
 =?us-ascii?Q?FOj6BS+uqb9dFy/tVAxcoHqIaLwtul6DH75wimPy31RPOMXj2JKF00c9IrrW?=
 =?us-ascii?Q?51wNCz+SWlSWXYRwrU6PHsb9l3JpbkinNw28U1qCWLYqljY7E6Cwp7cJsbgn?=
 =?us-ascii?Q?Nj34DJrzse6lYO6gVm/nm/9JJSoK2JV5E/fL9xJY7BPG0W7j0W+X0/f5zwbS?=
 =?us-ascii?Q?RATI9F7qWAr1dfScRvkmkcydwMhvxMwgKGolEFHbsXU+oWIXlMeE+jmbgfmD?=
 =?us-ascii?Q?cILIQskZik+bmB/iEbZ+1BRCOxAI6AhJMJq9NAs6zJPiXkkwSDewThDNLNti?=
 =?us-ascii?Q?rKi/uexQVyXKG+Z3/C8oG3IOSBDMR6/wuBWxM17pGkSeNLhN0UJ2S831EBrh?=
 =?us-ascii?Q?SEtx1ccnDCi+U8VsCHxPdQ7AdYT5mRzxc907Qwz4ksMt3qnCG+HH8wcUVfb7?=
 =?us-ascii?Q?i6/2JH7P/3yB/o6sDMHsG94yhNEv6i/8LMQri6PkZb1oNnXnSu4vejgFOdtx?=
 =?us-ascii?Q?tzk87vbdZm2kpy9/B/r8NumcKAruvuff/PPJ93k2Pl6NGBvdAcAsVNVrHJ0R?=
 =?us-ascii?Q?wbOEMs8of37eoHQ5gANbajbR?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85cf5450-09f8-4ef0-51fa-08d94a6a7eeb
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2021 04:05:50.4512 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kWgGPgJjZGilJT1XarHmIw23mvIq4CiuD8jg+1hGU8ScT9gC7pbExjCMDDZ83CTdu7UxZCERGWZRNWL3oqYwzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5343
Subject: Re: [dpdk-dev] [PATCH v2 01/14] common/mlx5: add common device
 driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, July 19, 2021 2:29 AM
> To: Xueming(Steven) Li <xuemingl@nvidia.com>
> Cc: Slava Ovsiienko <viacheslavo@nvidia.com>; dev@dpdk.org; Xueming(Steve=
n) Li <xuemingl@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>; Ray Kinsella <mdr=
@ashroe.eu>
> Subject: Re: [dpdk-dev] [PATCH v2 01/14] common/mlx5: add common device d=
river
>=20
> 13/07/2021 15:14, Xueming Li:
> > +static const struct {
> > +	const char *name;
> > +	unsigned int drv_class;
> > +} mlx5_classes[] =3D {
> > +	{ .name =3D "vdpa", .drv_class =3D MLX5_CLASS_VDPA },
> > +	{ .name =3D "eth", .drv_class =3D MLX5_CLASS_ETH },
> > +	/* Keep class "net" for backward compatibility. */
> > +	{ .name =3D "net", .drv_class =3D MLX5_CLASS_ETH },
> > +	{ .name =3D "regex", .drv_class =3D MLX5_CLASS_REGEX },
> > +	{ .name =3D "compress", .drv_class =3D MLX5_CLASS_COMPRESS }, };
> [...]
> >  enum mlx5_class {
> >  	MLX5_CLASS_INVALID,
> > -	MLX5_CLASS_NET =3D RTE_BIT64(0),
> > +	MLX5_CLASS_ETH =3D RTE_BIT64(0),
> [...]
> >  static struct mlx5_pci_driver mlx5_driver =3D {
> > -	.driver_class =3D MLX5_CLASS_NET,
> > +	.driver_class =3D MLX5_CLASS_ETH,
>=20
> There are other occurences of MLX5_CLASS_NET in mlx5_common_pci.c so this=
 patch does not compile.
>=20
> This change may deserve a separate commit.
>=20

Thanks, new patchset uploaded, but seems I forgot to add Slava's ACK.