From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D86A8A0C43; Wed, 14 Jul 2021 16:16:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 722F540E3C; Wed, 14 Jul 2021 16:16:31 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2064.outbound.protection.outlook.com [40.107.100.64]) by mails.dpdk.org (Postfix) with ESMTP id F06404069F for ; Wed, 14 Jul 2021 16:16:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PoP1r806h0dz1O9WPBl8t+GiMN24UzVNX5g3Gxn1CcxsMieq8vh4OQ77BJYJECshC8enpspLKtLq++hUI+aRT3dGClbHe6EwGQjRGys4ILl1QlxlWEO0c4t9ZMpikNjELyJsq4t20+cxVVHFKEfk9ZVhWOD0qIOFBJALOO9htvvg+YhQ1fucT7e+tIBRUlijn2+PILSlfhajXGo80rFq1jjS17wf5msjgr4Hp7agW+cojffdkd+/2lxvuwSkRQSaC7YIdQQefuIc555WhHZBvHi1fY8A+wW/n08wbMlFtBmTgqSX2wjAGbjJAFFU8zVkHOJYWWBlYlQ/9Pfl4QinBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TfSSt2Vms9VTWlkWRD66T4LW0JNMa+3Uk6UyP64aJPE=; b=ZFa7/tzJV+T3+GSrtgWdYuarUjvjGSNpVF0oQsC4iSW2u/3EuqAnBYWvxOrLiJOK/0yDOBytYRQRuiVFTXjYF9JLMYFpYbm7yAa8lZSaH2Q6PtGDDYsgPGS0t3W2a+SpdvUMNIkOKP8vim3+qKsudnlLfX3OTJAPLVv1j+RKoEY75jyJlvhrGeNoSMNgUvHT0e72MCuTi+00mu4x4NNvW/BxBYjfIIjlSBlIssetBr2jP4z7PW+3A13oflq+q3k17p1geBNy/keaK8Lz+OEDsxUwNHzfTafmwDGCrjlqG612d7sF+j3770WGg/22LXjuky+IUFg+FNTFqmTdcHiSxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TfSSt2Vms9VTWlkWRD66T4LW0JNMa+3Uk6UyP64aJPE=; b=iH8eRbmlGKRCBtHF6QeU141CgLzMII+l/2N6ILE8wUfCJa4D7lEIyH3v6axxRFMx3G0rYFJFjIhQ3UOojgDztW9pGn9oZpTla4FMpexiMXzYXtKSPqyF31bip/rtiHI9WwXNXvA0yWJv+N8o1xYS2Dh/3Xkhx7w1ChMCgqFGFAtR4UvDCYQzUGX6k4SqBrlZ/nvCOVNbJnqFibnk7bywor5nv1EvUJ5zaEg+BbcGBAVLhgh210W8DGJ0r3YmUjksawseDKbQ/zK7hMG71pS6hxeGAo8N5ql6ey25qeuWn0ySqoIH3Agei8bRhN5tgE2Wg+Si8KMagnFqLBBpWB+UYw== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5294.namprd12.prod.outlook.com (2603:10b6:5:39e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Wed, 14 Jul 2021 14:16:28 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::6823:63cc:f7d6:dd00]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::6823:63cc:f7d6:dd00%7]) with mapi id 15.20.4287.036; Wed, 14 Jul 2021 14:16:28 +0000 From: Matan Azrad To: NBU-Contact-Thomas Monjalon CC: "dev@dpdk.org" , Ferruh Yigit , Andrew Rybchenko Thread-Topic: [PATCH] ethdev: avoid unregistering a non-allocated callback Thread-Index: AQHXd+lwF6vUIBfc9UuIyi787+gG1KtA6C4AgAFywYCAACipEA== Date: Wed, 14 Jul 2021 14:16:28 +0000 Message-ID: References: <20210713131714.964500-1-thomas@monjalon.net> <2065780.Orf5z9Lfyc@thomas> In-Reply-To: <2065780.Orf5z9Lfyc@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fcdd0def-c92b-4022-0577-08d946d1f8d9 x-ms-traffictypediagnostic: DM4PR12MB5294: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RfeXle/uVrrgrOBU449qd7eBfNy2pga8IJd3vUrdUyO13YGkStCoGUZWk0DsfIZvdZEF/iNQ9IXng4stwfGUs3qvFIifToshDNAOPHRS8+cUKKEXDabi2N0krZXvbs1nbWjdVdJ+1U7bH7IITvy4GctbVKWu5Ctz9IFG8hOcuCudBILtNoFTqguw+uCd6/TaHxmPjLTfxt+6l483VJ+NKGqfmPa+OtQOdj4ucNxXPCujtcKu2yQlQpyABu+5ArQd0fb5/mbZWc4i+DnfPWkBZxfiJRpONrEJu8dXBFF+sUydRVNVxmJD5KN+WP3D3mccyTBQGya/gJrlS0j2hErCT/ppEUVxhhGug4YI/6XJ+yUU5WO/YHmToDj12cltG0JQCjYdImHhTSiWLYhFcbJBonjLO5raO0RvJnMv8EkmB4DYO5jLh6UihK81kwL6McnEjGj2blbIgRJ/Gyuf52WsfQJAOi0zHQyPwyNg82qEygTSoyIiHeTa6f0zXXdgIHFkuxfYL8VHEv8ULz3bRclzBEpsrBePw9VLPostO9v6d8qNcqEJev+BY/4K7TtE+eYhvXjrfC0d9YhKh7hOsELTGl8INe2J6Ac4wM/aHWF1/YqxEWIjUsSyvIe12OrNSkjjw2EOrO5pzx9Okj7zT1qzc+q/yDHPQZ2Xwcl+YQVSrknunh+ggDXzv0CJrMNYnortVE3zt2LeWGz1uEBPyMc/Cw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(366004)(136003)(346002)(376002)(9686003)(54906003)(66946007)(6506007)(66476007)(52536014)(66556008)(86362001)(6916009)(5660300002)(64756008)(38100700002)(83380400001)(7696005)(8676002)(8936002)(55016002)(66446008)(4326008)(316002)(76116006)(33656002)(2906002)(478600001)(26005)(122000001)(186003)(71200400001)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z9oz+hwdtgu1Xte1HZ5W6FViuuKr4AF7OfHZ2btSWlWVziJhA8p63z6Fphem?= =?us-ascii?Q?W0ie6nesUKMwdraZ3t3El8okxxahKaHdMSGTwECwwBTfoLOY0Ou+rnIxqltX?= =?us-ascii?Q?vx3FW5Y4r3L4/DYhM+KunczUAFITAwND8dSboYMDZ7xdgEdYan0MXvGqF+nd?= =?us-ascii?Q?RpSgMelfWtiirx+y3XFYPcbzxsYXEg9KuTFJ15nfsGWgU8+krlro2UmS07RK?= =?us-ascii?Q?qHlKjt964AeO2rwmznjBK+ikZrfL/hudrQXIQRRTn4wNCv1r7X8nO2RUOi+s?= =?us-ascii?Q?bsVPAq8eTTpoqZkftHl6g/ewxDagJp0rWfd6cX4rVYho8u+YBA3jZ8zOPlFQ?= =?us-ascii?Q?v+4NAO+D0l4eSBzpto6nn5Z2Xerab5ijrukYlL4mAdaGcq7BaXqgB5IcTRYz?= =?us-ascii?Q?c0neKpcitVfFGoTXIjfhfpQs8gMjhXuh9XxCI+3MpvYos0a/Hic2JFP4bJtc?= =?us-ascii?Q?84kgiyOPW4NdVm7SYwNvFWsE5UI3u5xyLGQBcckxcdlQsDy7dJF1YYmD5kIo?= =?us-ascii?Q?ooEa02GQxOgh0YbRZtKWlMuF/FRT81LAQ1Td/PRTK2BmPVGQttMrmumX7pgQ?= =?us-ascii?Q?cCnRY2n5q5rXPD+fY/zmaEnbuMKkmOUmP3Yu5aNjGWCJfDpS5AOt4GNGLeWI?= =?us-ascii?Q?sqKKf4H6MO2kJjH62tZJnatZNC62DUPcy6C0Jqdl7h/mkzx8K6n++T/TaahX?= =?us-ascii?Q?oqVGRy4hSyA/qf+3J+9u8c1fbxFiKacD4YPD4OgNYkowVApAW25gpHzHQ7IB?= =?us-ascii?Q?fYOsuS/aTJ60TGpExy0hG96nMImiSbw6k0Sw+DQM790c6PUJLejTsGyEEOpg?= =?us-ascii?Q?q0KurFOcEK2nMf4gwwUB1KnLnH+KGzLkENDpkAsx2YOsK9tBPGV4G33DDgBt?= =?us-ascii?Q?UIrIAVU9SYnDBz1bqDBo13nK3ACcYpDUKL2L5Rd1PCO0zpocpJgXmDGpYAjT?= =?us-ascii?Q?u9EBSLPa3zM2tI00qjXBH0oteDWVGuUGo6Jxqoxneg6L0/wzGCeCZ+Y4JsRq?= =?us-ascii?Q?VXhhzwO9xfI/Sft+C0DT+7THoT92CQKEVNGaTAhzvqqw7arLkrB/UWdC+0hp?= =?us-ascii?Q?3jcAujCoEScg9FkkBEXpjY2njjgC5tt0egtr8thv4LDfEsEO2VGnf8gRM7y/?= =?us-ascii?Q?gcand+yM72OMwBKBCpqe4N3HWqYcIYiSlbgWWjpGJQLkFFOInCYuGvzd6JUA?= =?us-ascii?Q?KNdP6fzYPJ96ux08VdETy7ZubiIqke2OAoUMa6vVAA0WbF5qF1yBsih7BpLs?= =?us-ascii?Q?00JW0UKXhepcsGKW5hUzU99IBd/+pB1veRk0pWZqMYjT6gjaIP68LcJFUN+8?= =?us-ascii?Q?GQ8=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fcdd0def-c92b-4022-0577-08d946d1f8d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2021 14:16:28.5761 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hOz2CHrx4QWIaJGYhvzxJwfYkLR0B6vbMbldnPHQSpqfiAWJ0Wm+iPqkKFZfuXmmGRicAclTykh4RxpvxHuqjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5294 Subject: Re: [dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon > 13/07/2021 15:42, Matan Azrad: > > Hi Thomas > > > > From: Thomas Monjalon > > > When registering a new event callback, if allocation fails, there is > > > no need for unregistering the callback, because it is not registered. > > > > > > Fixes: 9ec0b3869d8d ("ethdev: allow event registration for all > > > ports") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > > lib/ethdev/rte_ethdev.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index > > > 9d95cd11e1..1731854628 100644 > > > --- a/lib/ethdev/rte_ethdev.c > > > +++ b/lib/ethdev/rte_ethdev.c > > > @@ -4649,8 +4649,6 @@ rte_eth_dev_callback_register(uint16_t > port_id, > > > user_cb, next); > > > } else { > > > rte_spinlock_unlock(ð_dev_cb_lock)= ; > > > - rte_eth_dev_callback_unregister(port_= id, event, > > > - cb_fn= , cb_arg); > > > > Please pay attention to the case of port_id=3DRTE_ETH_ALL where the use= r > wants to register the event for all the ports. > > > > In this case, when a failure happens for one of the ports, this unregis= ter call > cleans the callback from all the ports. >=20 > Yes I missed it. Now I better understand the intent, thanks. >=20 > Next question: do we really want to rollback already registered ports? > Anyway, if we are out of memory, I think it is better not doing more > operations. > There can be various opinions on this topic, please give yours. Sure, I understand that memory error is serious, Do you think it is a fatal error? If so, maybe we should use rte_exit? That way or others, I think the behavior should be a convention for all the= file functions(at least). I tend to do cleanup on any error. Matan