From: Matan Azrad <matan@nvidia.com>
To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Raslan Darawsheh <rasland@nvidia.com>,
Michael Baum <michaelba@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Lior Margalit <lmargalit@nvidia.com>,
Asaf Penso <asafp@nvidia.com>
Subject: RE: [PATCH] common/mlx5: fix error handling in multi-class probe
Date: Thu, 25 Nov 2021 10:34:21 +0000 [thread overview]
Message-ID: <DM4PR12MB53892E99EDBD93C69452BD8FDF629@DM4PR12MB5389.namprd12.prod.outlook.com> (raw)
In-Reply-To: <2529522.a978ps6MBx@thomas>
From: Thomas Monjalon
> 24/11/2021 23:02, michaelba@nvidia.com:
> > From: Michael Baum <michaelba@nvidia.com>
> >
> > The common drivers_probe function calls in a loop to all probe
> > functions for classes requested by the user. After it manages to probe
> > them all, it updates this on the device in the "classes_loaded" field.
> >
> > If one of them fails, all those probed to it are remove using the
> > drivers_remove function. However, this function only releases the
> > classes in the "classes_loaded" field on the given device and misses
> > the newly probed classes.
> >
> > This patch removes the condition from the release function, and
> > ensures that the caller function sends a more accurate parameter.
> >
> > Fixes: 8a41f4deccc3 ("common/mlx5: introduce layer for multiple class
> > drivers")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Michael Baum <michaelba@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
>
> How well it has been tested?
It was tested carefully for all the remove cases.
> How critical it is to have in 21.11?
It is error flow issue, not critical.
>
next prev parent reply other threads:[~2021-11-25 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 22:02 michaelba
2021-11-25 9:26 ` Thomas Monjalon
2021-11-25 10:34 ` Matan Azrad [this message]
2022-01-06 9:05 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB53892E99EDBD93C69452BD8FDF629@DM4PR12MB5389.namprd12.prod.outlook.com \
--to=matan@nvidia.com \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=lmargalit@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).