From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09BEEA0C43; Thu, 25 Nov 2021 11:34:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E027B40DF5; Thu, 25 Nov 2021 11:34:24 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2064.outbound.protection.outlook.com [40.107.96.64]) by mails.dpdk.org (Postfix) with ESMTP id A4D2840140; Thu, 25 Nov 2021 11:34:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cw62TkLmJIWLMupRRCbjZxsERfu5QDAjjyUM9rfxwVE1ULw4S9uYrcUu73AbysBj+b+5i3x3EzHpR3qd7jhy2viP7Q+S2ZrSSYNMR/r6QrM4AvCxUCUeAznuc43hGVMKOjWe+fC3XFBKFLzPjJziZbTmKdnSggyBDbBVOCA/GWBypOQpj0+pHfVA6+oz/hx5cW+AcaxbVjhMGkV9Wc/DZDzwtbNh9Os8FzvMEOguVfUyXguUoZ3cBH7Yi/aq5dUXiva1rd9yufFZOqQV9rmYWQ8oA9q9twQqWB1dokkeJMQUX7mIo82x/DtDu3AP9o7kC6NNRGmIj57lIP4YzhU5qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1QIgIcDl1UzCQPb9aQMzy/KXpF/1gmnUbgC866f1bb0=; b=hOVKPNBoL4DbZlo9RSNkaxHBRZ/1RlUFCFskahP6cRCtV++nI+XzR3uqyeLHenx8ofEKz74bf4EeFHSwuhU/uzen/TqFKuDTz3hatSmD3qANvy8b/h/u3KRUrDHHwL62xBRK5FXtd0MY9fOGrUos6lFhKktwGAe7/lOxOlUAAtZt/oYe7JVwLpaVj4qvalTpUXIYzqg2NH2bHm1FqqCtyBjp3x7gl6gvqaGPImQEI2AVQTywyoTXpszW4/59GXfPpeo+QKfpyIjzpk1Ki+gwkylMeRMWS9+OaRugLVEtfsepy7te1PHQm2Bu1K7/bHEOqp2GTxijyOkiHtYnJQF37A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1QIgIcDl1UzCQPb9aQMzy/KXpF/1gmnUbgC866f1bb0=; b=jAaS/e0BHhXRtXstSPXM2097EY2jyNB+p0ckEr/EYJ2niB/KZubmzMQDoHub8wh5wkSbZUOvlLGR4hQesUU2ZIVc2RCFczQXoFeZ63KEic0lXcLZm7n2BYb2Ll99721VgyX1RFq7MzlbRpimF0dJglt5hJ6QhqIByplBZIFNmolH2sf59bAA5BpcjogRqhm1hl5COtlv7UzCpTfZbnEzFO0vu5/a0eiBhGh+sJDUDbLM8QNLoJt6wRSVka1SzLzuCmtKdIhEMJIVuH2Ck/UCTuKGfO7zje3Ha0WjOLqV2iFGYpgQkO9gHDt/tEJfWPYfxwnJFv39ekvMC3azGjC6uQ== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5216.namprd12.prod.outlook.com (2603:10b6:5:398::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.26; Thu, 25 Nov 2021 10:34:22 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::2171:cddf:7b43:3778]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::2171:cddf:7b43:3778%6]) with mapi id 15.20.4713.025; Thu, 25 Nov 2021 10:34:21 +0000 From: Matan Azrad To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Raslan Darawsheh , Michael Baum CC: "dev@dpdk.org" , Slava Ovsiienko , "stable@dpdk.org" , Lior Margalit , Asaf Penso Subject: RE: [PATCH] common/mlx5: fix error handling in multi-class probe Thread-Topic: [PATCH] common/mlx5: fix error handling in multi-class probe Thread-Index: AQHX4X8QSUdGno7oxUe3yfPf6T7tNqwT+iuAgAASIOA= Date: Thu, 25 Nov 2021 10:34:21 +0000 Message-ID: References: <20211124220238.3119860-1-michaelba@nvidia.com> <2529522.a978ps6MBx@thomas> In-Reply-To: <2529522.a978ps6MBx@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bae0f618-446c-48e1-c337-08d9afff24e1 x-ms-traffictypediagnostic: DM4PR12MB5216: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cQ7nU3s/931u7uTLzw+CBSZzZKQDkTyv71E/Vx/x153Ea9oeLTmC8xJ2rUG9fe+iwBEx9qU7OvyW8ySankXXxPwlc9YJiySyoVucQNBdQpTGF01oWzMMlqgWdmA1W8PFUFJz2Zt4dNpI6l61vCMXyTrseucLsGPCbNZ4VAmW5NZSmWj0wDvYK+5nEW7/nG6i0RvrvZy49GF3dq3+Jp1nxgw6RTpIx2gMnCjUplnEJ2ag9gGWcNcAlG1KuZlEjy4NLxCe7ZNnBnLWL7TZAh7tgPfgV7HYnfark+oFUE+aykReXl3xXido5uu1nzGxQnDJY8ceRSQ8sOoCQn6f4Fmvgl7F7bw10QwedBtyAKf4F/civRSqyXCSIMatD8cZ+1Q2VWyMI2qCdhBCIxRan1E09eTTb5ey6MCFs9Mn2gYZ2RSM5h7XDXTM2bClIJj/WLGiIQl35b2Dc/PhFoUyrQyqFFONgwygnxkJH7PgGvTT24DSEyVQAv70jJWvIXATS2cRw4fGmD0hGNAu+HN9P+vYGEWw+a5y03rEdMTECDxHBdjcNSP/oIbCbRgFJ4xgXPVrC7wn5ubMQDUhJ7ljyoNFbnoTJD5rM2d0mo1vQ8wmZqRdJczIoSIDMhtbmHeqA8FUTCXUPzWjTDCjcyRZFDZx0w8zP/Tv5YTJaL0HXhgQvlZMaSYVmU6s465YxGjLrD0kjp5XPSb6soJKJ40XELE+bg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(54906003)(110136005)(33656002)(8936002)(316002)(8676002)(7696005)(4326008)(66946007)(122000001)(2906002)(26005)(6506007)(86362001)(107886003)(186003)(66446008)(64756008)(5660300002)(38100700002)(9686003)(38070700005)(71200400001)(83380400001)(76116006)(508600001)(52536014)(66556008)(55016003)(66476007)(6636002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Iv7noJGQx7YVIJ+ktHYBxFeDNj2EJTzezFbz6rjz0MW5Q7qr4RXfCeMIV+/B?= =?us-ascii?Q?hQrbCYJaFopkw5cAQ4UukUgWgzJWMg3Wu+H8leCBPCajQ5JyxO69zWzAkfwX?= =?us-ascii?Q?Jvb/xjaJ9IT3/H0UdFJy5r2Q2eJQGcKRxxxEMr34qZuE0Vkb7gRcAK8ccL4x?= =?us-ascii?Q?Qkmy0534rxNrFsnnSDy+hSbdttNUB9x62yu4qWoJb80BobKSuTglS8+sDDiu?= =?us-ascii?Q?piKXoRjojrUyFjMm1g+jjViE5yIegxl4EMSx/0GaHKJiCa28G6MjyVTQ4Onc?= =?us-ascii?Q?xDKvAiwbiu/z2Qid46Gqz8DqPBwIFA+MCHPIPHeA2CItdjuttoLT7ATjyAcQ?= =?us-ascii?Q?hX3y0YLzOnqhHhkpKln7uvDFIC+0sf3hg5GhO0Uyst0lQqAXHuQ3+0r+XfJR?= =?us-ascii?Q?YZ9ydwecpNaGl2pmmNjP8SrhEScGc7rI2JatTZbrRM+hsdBKuYnjhUWCt23L?= =?us-ascii?Q?x7wv3Oq9Di3hAA6MYkWx3MBq+ogJR099HEfhxk67fww1dE3obfyM1ZyH2Etz?= =?us-ascii?Q?Bi19FKaVlwZa4VVcA+JV0uY+/pjWo9q8wXGNx266mW9lWat1L1KsJjh+joay?= =?us-ascii?Q?StPPs+hXu2UOEc4fbP555VQ2q4Y9A3KGdQ74SePybm1HqAId7JePa3ur36ah?= =?us-ascii?Q?C/vtsQdD3K1P8srjqyMVVUUUc51G5mwWkmzbmHxpNrobU9OQpJYo/3KDoBtf?= =?us-ascii?Q?M26CLu0rSUBckoljJSPxBU6QnPZJuxG/uG5MDXnUSZgsrX3ubPyYFXyfwKij?= =?us-ascii?Q?xf2ubqDIBAgzBxs66urzobjgMt5xWnO7wfo0aXR8IBZOm8yPtTlq4Jvn5dSH?= =?us-ascii?Q?5e2Q4nInPiKfSsHz3tL9WuvynbLrIq9gdiqxh1HFs+CaEQqoV6TzVQKqcBm1?= =?us-ascii?Q?YidXjO19fb13bnCoi+M0juPWHtxB7AijgE3YlgrF8UU+/j59FKUQJJjdT022?= =?us-ascii?Q?eKpm0cmbJZzIKukGQSTy9v7xY+7r3XYUwtOMR8QvSN42MMADNXdOTTXJenUx?= =?us-ascii?Q?kedUn9l+FSOdtsTq3LMoY9ClUSWneGA2+T5Bpdf89RijGCzYTbRmy4qQMxjS?= =?us-ascii?Q?pV/hT9MM/UbFZtObmQJKCWLQrkTOWsO8HxBgxDL//chHAR2XFNoi8z8yg12M?= =?us-ascii?Q?OUcWRaoBFLcSZ5iaDvoHZ2azbpn3Ct6rIURBcMvja3iMqEQLyDJ9RtUwD3Nr?= =?us-ascii?Q?g/YAq+4qZuJlCJt8820Cd/ctcpTTbGuRtO8Gw3IWImfCQCIvW9teA7cmH8NG?= =?us-ascii?Q?T3jZ4TIp4QC8Jfe6afsn8wog+T4yXCMm9p7WMxFvfN2Ygp5Rx4hudBpN4gPj?= =?us-ascii?Q?V/D2jVTlEW6q/+9sYBgYbGi54JYAvkB8Ow12f7F1cl8uX1bXsuLMR7p4tRly?= =?us-ascii?Q?QskPd6BwbGcqB3mclvOf1pwXfYhwi6dN+KPx33YGYxkIQwAZfd8v1Li3/3+s?= =?us-ascii?Q?7z4LwHBLgjY0htvIY+THq2RreeWmv4+QldEYbwJGFkPOwsbcyAT04vYGZUNi?= =?us-ascii?Q?A98UZfpE7ohwurqyoJTqVKpvbAafRAT6lkptxH6XZJGwSLmp9DFKjuKCZzW2?= =?us-ascii?Q?16VBrAe4e7vpeQZ+7SIad9G1A61fBNNyHVCV49ovfQDhIhIFJjlM7+SVLTqW?= =?us-ascii?Q?0C9YgAkXjidJk16G3cKX0sU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bae0f618-446c-48e1-c337-08d9afff24e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2021 10:34:21.8707 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u7p1vx5Nal/iJrQvQBD9C5E8MAYZ58479LQp5U+RyqTFnDe+qhXJA67hBYuxP0P4FLxYJzW9AUYgw5WgB14eCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5216 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Thomas Monjalon > 24/11/2021 23:02, michaelba@nvidia.com: > > From: Michael Baum > > > > The common drivers_probe function calls in a loop to all probe > > functions for classes requested by the user. After it manages to probe > > them all, it updates this on the device in the "classes_loaded" field. > > > > If one of them fails, all those probed to it are remove using the > > drivers_remove function. However, this function only releases the > > classes in the "classes_loaded" field on the given device and misses > > the newly probed classes. > > > > This patch removes the condition from the release function, and > > ensures that the caller function sends a more accurate parameter. > > > > Fixes: 8a41f4deccc3 ("common/mlx5: introduce layer for multiple class > > drivers") > > Cc: stable@dpdk.org > > > > Signed-off-by: Michael Baum > > Acked-by: Matan Azrad >=20 > How well it has been tested? It was tested carefully for all the remove cases. > How critical it is to have in 21.11? It is error flow issue, not critical. >=20