From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB885A0548; Thu, 4 Nov 2021 09:56:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEF0541180; Thu, 4 Nov 2021 09:56:38 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2089.outbound.protection.outlook.com [40.107.93.89]) by mails.dpdk.org (Postfix) with ESMTP id 3390140DFD; Thu, 4 Nov 2021 09:56:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jYB7BI7bdZYBqieE1rYpxfaV0pNklA5/JZdUw8Hcel/1m7EI5JS9uFKb9ZlXvV7X97Xi8E3i21siusksGc4IjsyaFf3UaRrcZsV3ECDP+nyRGrkwVWeJpIQ2GPI6PS9udCc9MEMp5AYHGmQ15mvri/yRQWa5ZxdXb0LXjdtLEj68gthOiOYtnTf+NWJSdmXBO8LTJN3HHomCVAVih+mHTXmtACSzcAMyBku+O2u1EsGtXI2pNdHLyBRRsMwFGQD8nUZkSLtM7cPixciYxPIp8Th7kOBpGEUp1vS53v1TvVMMOPV/908ys0aXf7o+pvNgTzCfl2vl2ybDlMi6iYPdyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MwdqmCnJkWCLDCZrllJyXzEgzmqxNZ9pNfJUO4X7fPY=; b=OdA61TsRwxIHlq3LCToyhpLrVx6aOqEaTVnJdhHhZpVVZS3mDZ7ziIDcZLN2cdtGuqb2RB+QtTwNLOPeSShgAJr48pGPXW23lQX/O8LgOiWWrdiWjYa228dRg2fF3Y1Df6qdYOaSx269ht7fVYsA0pk/KTAfbpv+tXwg1nT8w9PPRsDksFCwStd/SuSk1s0B4f7Pmd/ufdoUlHoeIz1F/FGxCGPlffh2cCoCkAVX5GZZPcaVpcqvPwq7a7uAcpx78JHIf64BfdxEzjKuuw0bz+xIJS+pCGs3yH0IiejPa5X3S/g+mm59iwwVDJ4OJ9oIT44yVHySniOelsvsbdJbzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MwdqmCnJkWCLDCZrllJyXzEgzmqxNZ9pNfJUO4X7fPY=; b=hByexxgj+MdaELTeMlUQA/CgPfBOLGPT8S0EVjoxe95sMcJa7bAalTIbtmfmUIxJDhxfpD5qURxjHoYZ0rfVvZeLYBtzqSuy564MsVIBADFIFVJpjerzs1dQILDsfafBqV/ZnLpEwJlVfp+oZIQLlsI68Wv9FOhxGJB2u8629Mpa9plUGXOBF/oAPO9Ma7+BJMFsa2Y7lY40OWRHCNxez8XEh9B4uoNF0bw8q4phmiWyEpAHTePRiyCVNq2pjEF123aoIZ3o+xKZlma5kh+Sgw1W1tAtv+iBViKux+Zo9mal4/QQRPN0wlcqWnlkmc9reExv/vXSf+fqrg6GD+3zaw== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5294.namprd12.prod.outlook.com (2603:10b6:5:39e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Thu, 4 Nov 2021 08:56:35 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::45be:2914:19ef:f4bb]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::45be:2914:19ef:f4bb%3]) with mapi id 15.20.4649.019; Thu, 4 Nov 2021 08:56:35 +0000 From: Matan Azrad To: Bing Zhao , Slava Ovsiienko CC: "dev@dpdk.org" , Raslan Darawsheh , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix the RSS consistency check of meter policy Thread-Index: AQHXxC6K8XFQLcrWEU6Kdo3BmQLr7KvzK0aA Date: Thu, 4 Nov 2021 08:56:35 +0000 Message-ID: References: <20211018131612.145215-1-bingz@nvidia.com> <20211018144307.148246-1-bingz@nvidia.com> In-Reply-To: <20211018144307.148246-1-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e47c6b3c-def0-4a1b-7cbe-08d99f71016a x-ms-traffictypediagnostic: DM4PR12MB5294: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ck3iVe0UPBTOwTZWBlzK6Uda1UYiUD4RTW9KdMNmipiAK7VQQF7iAOCqUOJ6YsgcLLdotDtPa1pMQ04ktxVpumhmxPeYdbUcAtZnq7/qeVZc0sOs9MnpoOo9a1ayBokcu3IEZaydWm76rXVsLkMTyGw91w6c3Z0d0rLoOm4j616S3fdvSb5BEAKTvQWCACcRR1EeLZtYUZpAj3SJIWLx0zXRNq4mCyRQYXsEzZDAtCz0e3S0VX/5akhMSUuqdtIkf01VUBLSfwAO8z5Vnr2HmeCFh3XqGTwV24GK6fBv2Q+dBkPtq51Za0oXvuQDzs+NHR1KoUwSs09Dimx/d1NTzVnrKgzXSzZTlm0LLoqsfm3HBJqcioaa/QTanIML/X5cJ2hgsWO8hKfbXYMNdJfU67NJcKpMnDQzgWuNhIwv82ZXFxA59Dd3Y6/yuFjnipVyFlA4hBSg72E08vcOPg4nSpgc0fRyzw3P5YAFD9GLTFx9Clr0rMOmt8dbxlgPk9980b18qDGjmbm/JTDK+KB/PSLI9yqJ/b/JH1ACunL9p8DuZhp8m7uwrwOUHleyfmPBEF7xxmrPdhktvGO9u2NAkMKhR8jUTVUXfb4F1yT0cmvrecM6ei4wCJvg9vI3UvJtSKFxN5IsYSV1ABr4+eqMhjVqH+NMLBtaKNREC/ZArnaFXXeSmI7ysb3G9lXJt66WKP1VFWlEMyRAwMSVha4oBw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(38100700002)(55016002)(71200400001)(52536014)(4744005)(26005)(66446008)(66556008)(122000001)(66476007)(64756008)(4326008)(9686003)(66946007)(33656002)(86362001)(508600001)(7696005)(8676002)(38070700005)(450100002)(8936002)(76116006)(2906002)(6636002)(316002)(6506007)(54906003)(5660300002)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tR0DB/Ip7XmYDQNImEVVcMSDc8ChR1uoZddFmvq1z6xDYE/XmLqoYxjJYU6/?= =?us-ascii?Q?8ene8RL+c2VtDxNG969kFci3/U+ivo7/6OWMHSXZWnAjy4cGe/+J65MKG/yH?= =?us-ascii?Q?/gwbcy5Up7OpX8ViGlJpTxpMy4eIe4QQVgBAo51KPshy/2UbxRLuFKj0Yf7/?= =?us-ascii?Q?BqlgmwqVIiFtfMt+9L8SdNonyizGmDLECqxiVfLTYIQpnRUOkH2zSlLjTgQJ?= =?us-ascii?Q?sQhVwR9feF3GnImhHfwPAsNTnapazveqjSHbirzDpBZjotkHroaftVmnMmCx?= =?us-ascii?Q?3w9woMqnCXRNmO8gI7ACgCkoWn+haltJBLWUGg5oa+xFDD2/d2E+m/sKcxH5?= =?us-ascii?Q?AqOkOd1Tqij3OZLIMrlaTfT0YjDbujc1vpzaxWSiUQhqr3IsB+vG/twUNcAy?= =?us-ascii?Q?6shFLedCXYmYH8Dw0Ch/sInAjzPvZvzY5Jl1HKarX+ceZj0LZctvvI0F9s7B?= =?us-ascii?Q?4tmcUM3wiedvuEKv8Y9kubnT4gnyeQKbTpNRGDiMBc1LouudLyxaWo8S47oJ?= =?us-ascii?Q?3xjQkamYW9Kv4yqMdhMwIXL/HlYv800OG+60AmvTYrAB4Zyhl8NODm1cpXao?= =?us-ascii?Q?jqnoLq4FIFLVELxm1jlTyH2ytQESNWdsA98vQBm7KoCHrBKdpwmR1g00boYy?= =?us-ascii?Q?9d4o8MK9o9k3hOQ1OE4ygIHMhZl6dGq9MyoVbK6qVi4+VzgdIiBoJItcG6JI?= =?us-ascii?Q?qyOPt+kg9iuqUUxEpT6pcRzMG+VtLhs4/ajNMpcX+PS+3AhuUDR4pQbbliix?= =?us-ascii?Q?wK/+LWnYMixkP/WMOkeXSzmJhDJcMXTCHEuqzqsSwD3mHpIJuvNS9Th1JoTD?= =?us-ascii?Q?ZaJkffE+xc9N2UEXPHLnDK1TYB6Q9sowagEGKSYJyUF88Bq8QB060eP8khFh?= =?us-ascii?Q?CaNJV8gfkl71jwd9kuTBMta70RQTRtOqUtXrYBhLT5IzqJ7pt/eiT1mDAt4o?= =?us-ascii?Q?syUqyzdjbAEM6nWPqp5wOdaIfYuqFccND/guA1vtDxKOUJ9nkIPERj8z4AKe?= =?us-ascii?Q?5ZpygRwF7C4cv/RJ+A4mhCspqxecnRJ2pZF/AHEGuP/3ODmZHcA99jn2RLxs?= =?us-ascii?Q?Q7TjnXeHyKKHpvTlEK0+3vozkGhVYtAYJ/S3j1lMiM7S61mZdcQrjANtA1Bu?= =?us-ascii?Q?AeUQLbG+3yR3oxJ0xq1TVwRV+g6n0VvitFD48Du2IzEUG6v/THrH1sknBLzQ?= =?us-ascii?Q?8930Xy3GpId+nU8Mby6/6+Of/nPZK67DKCwp0V5hBZtEAU574zk0N3PMOf0S?= =?us-ascii?Q?/wrUM9j9dhzBIN0ZqA7BfMGevs6J7NvwhIoWa6X67MpsNRUgxtntN6MrVO4V?= =?us-ascii?Q?CesMtGXShMnFdzfEouJ6d5eUJNDyMXs3vCu3HbgWhVZ5wJ9G8rGczvj9VZcI?= =?us-ascii?Q?IGslwObF+G2QymBEft0OM3Qc0v4PPjPpG2TTwuFXif/HVr5lkAu0dJ0qSEub?= =?us-ascii?Q?+nRzScuDBQ1bJ2zfZisNTaukado7uXBl/izIhgV/NDUWaUkqe+Lb/+8dITXo?= =?us-ascii?Q?dsD3TtO/KZiw+HM2Sgc9nWCaAUq/mLvSyGqSy6tYHIlW5g4YgbfznFfrbRmy?= =?us-ascii?Q?z/49is2OqNtfAV2YdZ0idQY1K68qf6EOVXEffoUO7OvY9RbVBm6HuBjv+2Hc?= =?us-ascii?Q?Fw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e47c6b3c-def0-4a1b-7cbe-08d99f71016a X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2021 08:56:35.2507 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W8OZ69EHAvrivy9vmBQzWa++Dx4CdVM9f+H3ANPh5dz6xiBCsilY1xGVrI3LRJfl56C3jHnkJffqnJRThJcGqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5294 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix the RSS consistency check of meter policy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Bing Zhao > After yellow color actions in the metering policy were supported, the RSS > could be used for both green and yellow colors and only the queues attrib= ute > could be different. >=20 > When specifying the attributes of a RSS, some fields can be ignored and > some default values will be used in PMD. For example, there is a default = RSS > key in the PMD and it will be used to create the TIR if nothing is provid= ed by > the application. >=20 > The default value cases were missed in the current implementation and it > would cause some false positives or crashes. >=20 > The comparison function should be adjusted to take all cases into > consideration when RSS is used for both green and yellow colors. >=20 > Fixes: 4b7bf3ffb473 ("net/mlx5: support yellow in meter policy validation= ") > Cc: stable@dpdk.org >=20 > Signed-off-by: Bing Zhao Acked-by: Matan Azrad