From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC9CAA0562; Tue, 4 May 2021 13:32:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5C664014E; Tue, 4 May 2021 13:32:39 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2071.outbound.protection.outlook.com [40.107.244.71]) by mails.dpdk.org (Postfix) with ESMTP id 377AD40141 for ; Tue, 4 May 2021 13:32:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H1RTi2Y8OoEm344UCJaTUMxkFpuqH2rC/Q5wKPu3aYWrlU4UaYAk1IUQG2WUa2yVZ5O/8x9UYTZQvJh+WnxlaVxy+RWCr3Bzy5z8qqb3rQqScnje5mOyPqcdUdvfk4YGRn8EtOpZqX81tSw62me7eUE7f7J/Yh4gebL1vJk4rdtSMIhzlbLOK9IXNChZKrawHf/uveKtBMPBcrDvyqNpipuqK9be1LAfXR//UWx55C4gA3CeQXNINLmRE5NmAvFO7SSeyIwAl3zjS2f41gwzeTL1TjFQXs7EdJLeCqUIga2vB9mcgKzVEnAX1oFx2EWlqQVGGUN56w9XNgzpwh5M4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xYL75JTkKV5RhH3rqF7kiBrh1Uic4sFZOHRtDGwNtfI=; b=U5/1QkI+/N5MaJQFSZ3AqeMXgGeNJgQseApjjNhAop3JKrIkKnJQjEdQ4td2CTAqjEj1wQpwEGlMGa8D3ECIrUnRtuwmmKhNcQM007GDaz+P3pbb6az8SwHFfSWt5cyralPUswlMGP1Y7FK96RxZd/85aMb0DjhRw5b2tgrWFkpaBjCtoxvEbRIDKCg5PEi6UD1sE+gGICL1KxoGrRPEIBCfjGx7Y4cDBd+KtHXyeSkSswocokw85DwOdF+0pxroGydS6PM9smy3h6lDChekXpEC407Wc9ldAfxDHydTYitESTke7B4sBIM5jKaoLme24URJc+Ufj/hE00yPNz4hIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xYL75JTkKV5RhH3rqF7kiBrh1Uic4sFZOHRtDGwNtfI=; b=rnU+CQUjbJBX4xNqsvmx3uP50oJLLuSaRpaM/NUbX6hf97ssHeLoTPxKa55hzRFKKIydeGbWU5697x6rLJ4pZ8q9MVUgJhiDsgMWzCG33zDvV4z0ekhIq8x9+lzLVevkyga7Wh646r4V678l9HhIDCYDAuZ8tyn03u76WPdfj5e/PMQ2ZFWrHlh0O+vdtDr/aszp8hA/FwZ3qQ0N7z16pEF4v69rFWLvMWTb9AVokLKjC1eHu8zSvlFJ3aXFm8GyRsdt4x1DAqmuNsmOlj0TDHDq2kp1QiVtUIzX6ovGEjPruRsAVEjiGCUaSqv6cqcoDAwSUPF2ASXH2SVyjXrnqg== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5135.namprd12.prod.outlook.com (2603:10b6:5:392::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.35; Tue, 4 May 2021 11:32:36 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.025; Tue, 4 May 2021 11:32:36 +0000 From: Matan Azrad To: NBU-Contact-Thomas Monjalon CC: "dev@dpdk.org" , "gakhil@marvell.com" , Suanming Mou , Dekel Peled Thread-Topic: [dpdk-dev] [PATCH v2 15/16] common/mlx5: support register write access Thread-Index: AQHXPQ6maZOfg4avxUuWi1ex5vhNBarTLqcAgAAJPuA= Date: Tue, 4 May 2021 11:32:36 +0000 Message-ID: References: <20210408204849.9543-1-shirik@nvidia.com> <20210429154335.2820028-1-matan@nvidia.com> <20210429154335.2820028-16-matan@nvidia.com> <4051574.U56rfsV2qO@thomas> In-Reply-To: <4051574.U56rfsV2qO@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [79.179.60.21] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a7490a50-30ab-4429-03c2-08d90ef0514b x-ms-traffictypediagnostic: DM4PR12MB5135: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1417; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YU+YSN01mUKqeviNWr8XK7JAR8/kYi+ZWnVCzr5qbZL9hatOy8Y8zeAp9CdKDmLB0NxjoGk0gMZAMgA2d92gfZzKsQIm5x1TREBTEFNhFCVukzIfChV67BNTtzkui51VlnkmKRkqqH1H/KxYMCWS1P0THOWOZbKFaYwiy+Em9srAmLubUPuMqJYj2Qeg9r7zkQuy9gSY7scN7n9QBuVXKMe70tCf4liy1v5Jg2CsZuJsRvwa+S7QonLSv9gcChcHxnY+dFTTOHrF9dAZTtHbGJEePlrNFNA6QqbOZ2LOMPgTciQcNS2QKdxKLv8xkxyjHkvE5o8raitVbj+E2HWxceBfpBaaa+0gQYcGVPAHfIwb/utKnQn0c4PsDRec5pANW+zobz58B5EdSLhT4hpOggZO6ABZtklJLOtl2JDsIgWHJaOGqAnSswciHW596QBwW/+6YYpb387fsNy/a9BoeFeP9qj1yUIGor2ysy45d7ZIVXGkwLWwtd+O8O4uvkxahfEeCGG+gvYw8B7Y24MAfIckBeWuI9Jlagh1LgD6BjzqO8JW6TjdEwz2fnfjQJEUL8O/xOvhKsVHmfhkfvsBSLMyPCu9mU/HomCyP47qXKk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(346002)(39860400002)(396003)(136003)(55016002)(478600001)(8676002)(186003)(33656002)(8936002)(86362001)(52536014)(2906002)(66556008)(6916009)(71200400001)(122000001)(107886003)(76116006)(316002)(54906003)(64756008)(4326008)(66446008)(6506007)(26005)(5660300002)(9686003)(7696005)(38100700002)(83380400001)(66946007)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?L05ktQLQ2A5wz4BOhmM2THot0+L0SHLna4ZsjWiiz0b9AW21A/0R3eM+4Iqr?= =?us-ascii?Q?r0Ig+3G94NkrI/OxIXbTEVKAZrCqzD9XXwbuiNDk/xqYv8LomAklhAYLWkfJ?= =?us-ascii?Q?n9gUZITjNIzuupDrKqrfiSx2/gE1NTaUBSsWKFzhOvz39L1Sqju5AcOe0Avb?= =?us-ascii?Q?tKB/L1C04UoMGGd/ZeaG0Ym1Jkhg4DOnLobn5+xG4ddcarZDul91q9ymR+We?= =?us-ascii?Q?XoaZt4SkhzthVxrtIhN3k2ba02w5hVrazZNYetjLEcmsBecdSVhuS4rzU12v?= =?us-ascii?Q?03zlZ9Ucz7aUf3yMInZK36QBEZ2PJ+sJoWHjsgKTHtNYwlI1GeSuHfpZ6YBp?= =?us-ascii?Q?tsnq+dzOML/KFcgYin4CX+tv90snME7cbX5I6j1df96QvlOa0Xppk2MNcPFe?= =?us-ascii?Q?DGZMs7LXOXgeIq7gYVya/OcHKcURebMOy4r5OugDrpNxwUt2BhWvUozl+MvL?= =?us-ascii?Q?9d9K2YEx1lZJcqZ1CDMbR9va6mnEiIglAGh1VwB7CplL7Ah+R+IRc4PAJJbi?= =?us-ascii?Q?GA0HhpsMW5Y46sqqlbHQMTZb5yzUfykgfHWvHRG8wZRyizrxyzYrzY+2GSiJ?= =?us-ascii?Q?csFJi2ZqV0Ra7CSQhR9y6FSZN86+ykfWISPf60JWDoGkbFEzQUNKuHMntfNp?= =?us-ascii?Q?c3hE/xbTkC1BRZnRKLDH05PwjtfaHoaOv/UZEjwUXlbvZyH/t+Jcj1pglha4?= =?us-ascii?Q?g0BlTbt5+hqCGO+ulTIaIjUwCo815LNW0vbWViouCJp4mCFVRXNdaN+wEwoF?= =?us-ascii?Q?K1pxmTIkmvuPw7UnXlsJYrV47FIHynR9RvtK8HCFnXTg0dc0v0BVZtp77233?= =?us-ascii?Q?ZqHkNpu/dUMZuHe0V3qhCMEKRZoghyMUTbAwrfrucxCKFIG12/B/dk5QYXAo?= =?us-ascii?Q?0bixFCLbX3AMgAvja3rck6o0wa3+9y2KBzfz4SQcnUsjLTLcdqX13Xf//M4m?= =?us-ascii?Q?LaGcsHPG1q6cS7YYuMDePxLrZUj3DtTeZ2u2ypYAxIoM4nDDloUwOF7FppHx?= =?us-ascii?Q?QCw/JVEWtEs8e1A1+de3wo3w3p5JpdPN2tRGR7lJGlfYvzyOkQ+vS4KH3UJC?= =?us-ascii?Q?zS2mT5fsnah9MqTcqusylJ0dpDilzafBrMnzFEU6k8G6J+dy68fpLkgksFiY?= =?us-ascii?Q?cqQQzzdXeygT4PhbdWGzA1WROKjws8ppGqnH/HoTUUObrDhG3Ky06bSDqJTY?= =?us-ascii?Q?FkayS2MlzhbRTbnvRsD14tF1xlK4MXwRa88PIEaiU5PqOuDv81/3ZfTrqPsy?= =?us-ascii?Q?J7QzkVD9gBnP6OLm7NkflLwzJmaI0q9Hsp5zjFO/ejSTIRx4p5yMbR2WsBjW?= =?us-ascii?Q?UQQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7490a50-30ab-4429-03c2-08d90ef0514b X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2021 11:32:36.7201 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TV03gMJT+V5p20Uy1VWmoZc/YALYSVu+12cwmzCGrZFErVlkKCOMU4LAMEMm3ZNm29KqiCojRj/AijYHAc7wJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5135 Subject: Re: [dpdk-dev] [PATCH v2 15/16] common/mlx5: support register write access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon > 29/04/2021 17:43, Matan Azrad: > > From: Dekel Peled > > > > This patch adds support of write operation to NIC registers. > > > > Signed-off-by: Dekel Peled > > Acked-by: Matan Azrad > > --- > > --- a/drivers/common/mlx5/version.map > > +++ b/drivers/common/mlx5/version.map > > @@ -13,8 +13,17 @@ INTERNAL { > > mlx5_dev_to_pci_addr; # WINDOWS_NO_EXPORT > > > > mlx5_devx_cmd_alloc_pd; > > + mlx5_devx_alloc_uar; >=20 > Please keep alphabetical order. >=20 > > + > > mlx5_devx_cmd_create_cq; > > + mlx5_devx_cmd_create_credential_obj; > > + mlx5_devx_cmd_create_crypto_login_obj; > > + mlx5_devx_cmd_create_dek_obj; > > mlx5_devx_cmd_create_flex_parser; > > + mlx5_devx_cmd_create_flow_hit_aso_obj; > > + mlx5_devx_cmd_create_flow_meter_aso_obj; > > + mlx5_devx_cmd_create_geneve_tlv_option; > > + mlx5_devx_cmd_create_import_kek_obj; > > mlx5_devx_cmd_create_qp; > > mlx5_devx_cmd_create_rq; > > mlx5_devx_cmd_create_rqt; > > @@ -24,13 +33,6 @@ INTERNAL { > > mlx5_devx_cmd_create_tis; > > mlx5_devx_cmd_create_virtio_q_counters; # WINDOWS_NO_EXPORT > > mlx5_devx_cmd_create_virtq; > > - mlx5_devx_cmd_create_flow_hit_aso_obj; > > - mlx5_devx_cmd_create_flow_meter_aso_obj; > > - mlx5_devx_cmd_create_geneve_tlv_option; > > - mlx5_devx_cmd_create_dek_obj; > > - mlx5_devx_cmd_create_import_kek_obj; > > - mlx5_devx_cmd_create_credential_obj; > > - mlx5_devx_cmd_create_crypto_login_obj; >=20 > Are they changes of previous patches? > It seems some cleaning is required in previous patches. Yes, this one tried to do the cleaning, I will handle it in the first patch= (of this series) accessing this file.=20 > > mlx5_devx_cmd_destroy; > > mlx5_devx_cmd_flow_counter_alloc; > > mlx5_devx_cmd_flow_counter_query; @@ -51,12 +53,17 @@ > INTERNAL { > > mlx5_devx_cmd_queue_counter_alloc; # WINDOWS_NO_EXPORT > > mlx5_devx_cmd_queue_counter_query; # WINDOWS_NO_EXPORT > > mlx5_devx_cmd_register_read; > > + mlx5_devx_cmd_register_write; > > mlx5_devx_cmd_wq_query; # WINDOWS_NO_EXPORT > > mlx5_devx_get_out_command_status; > > mlx5_devx_alloc_uar; # WINDOWS_NO_EXPORT > > > > + > > mlx5_devx_cq_create; >=20 > There is an extra blank line here. >=20 >=20