From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 566C6A0C42;
	Wed, 12 May 2021 08:07:28 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BBDC14003F;
	Wed, 12 May 2021 08:07:27 +0200 (CEST)
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on2079.outbound.protection.outlook.com [40.107.237.79])
 by mails.dpdk.org (Postfix) with ESMTP id 1BC654003E
 for <dev@dpdk.org>; Wed, 12 May 2021 08:07:27 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=d3k0nNUIJdD+m/Jbk0NsIglCZUvk1ntHPXpzB+YkKV96Q1pKQw3uURwzK9iRf/ljExFArHgNQbxPLU+TOaCkBUhN3odBXeeUYtqVKD07cDXW7LoPFSHPMrITMwuMLZHUGpmFO4eqHgOPFXpkUPlR5dVhzwxDq9T4/hG9LCydVkBqK5yWuh9jGDyUTy+f30dO9juOIGfyTfiy/h3hjsH9CrHrjld9oOYsViKzNMWTO4AEplQxxWfEvrjmFu3d/UeEsYt5C3qp3iXSooUViy+OeUIhBaUpg+s8VH+1/6gYxTbOiArPBe3QjAIVSUme4YFOHCDtkAsWCQX2sSA0WMDxiQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fTiXCTs/LuwFtpFs58DRvmhgYkKX8fIl/jppcZBlRnw=;
 b=CGCQQSZLuFClCQuiA3I2baYTc4svoWIf0JOTWwRM9gtGiT33B9/fl5pKsbnCoL/8M2WQ0dnyDKZixOPjxq6yFjLL+z5LkysBwBEeVDRBAJitUWYnqXONceI4/4omfP01KB52nNHfZqWqnGTM1TOs5g6neD8iDk+Ps0g4tfBLTtiQgDddy3vAnDZjHoNfTKPj52t+r3CXLExDZKXsAkizO7CawgJ+zMzMC0kERJ/ewnNYdHbWnal6qjQtle55JPSrewGKiQlMV/jBBpjB0OB1y3Bl9N3AkWQBFjwWBAo4lzv2DBa/JBTsp+NfAe9CHbggxlWHJuAtCKQhxGmh3aiD8w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fTiXCTs/LuwFtpFs58DRvmhgYkKX8fIl/jppcZBlRnw=;
 b=rUG3sfDAdmC+1My7RGMAkMsK4WAkZadaFFegDFaoxtIYs25BqlS3OtvC7d5FaNzparRAeQkLNWB6MdBt3z9T7vTycQwQZcSuIHBbRVgXQXeiPckbK7t6yK8beDcfd49dk1/UjcWp4J8mk3H/wdmJVjepdpKdlfL6+8/KwOPvNbuiHXVROA+FQkiAWBsSp4aRkpjrPSH/y+BYPxcThFEWYGGkeJzicGqF6mUHF1GdqsRMXxG6H2twucqOB0ZOW4Ov4t/KKmhuzNvIpDJ1U2wuvt4jIlHV+IvRyWYdOt5sm04BgF0TWNskm/Pqcg0BsiHRvIzTPnmAelnm/k9oGcgL1w==
Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by
 DM4PR12MB5343.namprd12.prod.outlook.com (2603:10b6:5:39f::19) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4129.26; Wed, 12 May 2021 06:07:26 +0000
Received: from DM4PR12MB5389.namprd12.prod.outlook.com
 ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com
 ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.031; Wed, 12 May 2021
 06:07:26 +0000
From: Matan Azrad <matan@nvidia.com>
To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
 NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
CC: Suanming Mou <suanmingm@nvidia.com>, Shiri Kuzin <shirik@nvidia.com>
Thread-Topic: [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and
 capabilities
Thread-Index: AQHXQSnWSi9lLLdzVUyIjb1J25XG7arZhMOAgAFWmUCAAAnXAIAAUc5QgANmwYCAAMdlgA==
Date: Wed, 12 May 2021 06:07:25 +0000
Message-ID: <DM4PR12MB538969ADC06BC52C0FB21361DF529@DM4PR12MB5389.namprd12.prod.outlook.com>
References: <20210429154712.2820159-1-matan@nvidia.com>
 <20210504210857.3398397-1-matan@nvidia.com>
 <20210504210857.3398397-16-matan@nvidia.com>
 <MW2PR18MB228474E220013736487E94CBD8569@MW2PR18MB2284.namprd18.prod.outlook.com>
 <DM4PR12MB538977CB2219CEDB77A1E81FDF559@DM4PR12MB5389.namprd12.prod.outlook.com>
 <MW2PR18MB2284A40310C396845DCCE4AFD8559@MW2PR18MB2284.namprd18.prod.outlook.com>
 <DM4PR12MB5389681428CBC9DF25192792DF559@DM4PR12MB5389.namprd12.prod.outlook.com>
 <MW2PR18MB2284F04B9D49D75A606834EED8539@MW2PR18MB2284.namprd18.prod.outlook.com>
In-Reply-To: <MW2PR18MB2284F04B9D49D75A606834EED8539@MW2PR18MB2284.namprd18.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: marvell.com; dkim=none (message not signed)
 header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com;
x-originating-ip: [79.179.12.22]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 45474dec-3394-4a94-727c-08d9150c3754
x-ms-traffictypediagnostic: DM4PR12MB5343:
x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM4PR12MB5343F09A47BFB8F51D87FC5FDF529@DM4PR12MB5343.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: gD1hwjlj+QPED3mDtq1f7oYdcfd96kg8zyfv6z7jGGIZ0z8ClwBSWaLkTSswnweIDPLMxoUPohmtzBbhpiEHKp8kmjNMVBydu+wQqU0RSKI0Kt+7g6nn0icyETz3R9z3ZWP51cWQ5QYXLTDraFhvtZsKowPZQThUq5ut9lLWUucl45MBAGP2paI9WzrNc3/LOvmcYuH4WgpCFK5YTnN0IGdHlhZkU6SaJdNMZgrPwNpCCtPIgYaOfQ5Z/2DGR1u0h3STUDzKy4Pli0St0uVW8gT59IELMgYcQt/8fuN+HTa9naYLjXu7GGWOxLg1Zw6xtC6/QAhwZ84taOT+c1LxZpxowKg9vOeAgT0utyCT1Tw+qYUB1ewZ/S6o9d1eKN6AhXT+IuGPZCVlAQxJDxkYF7F0nPoJ6kh/TRMXNF9jSG5PKzT2JXGJnFG3uh81FQymXeW0wYl3PdL+NSh642kDWRoaX8jcNlPxBOnDJ79DKPjxolnQ6p2OmlGQvxDS6ctcalew97Qk/KPqBWhhViLoB5S6L7iOWO9Xcc0RTYTsDnK2Si6vW5FEuW4iCZDaiapjG8nj/fL1qaNHLAkGdwV6Hear3NIaOg5QqqoalmAGazg=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(39860400002)(396003)(376002)(366004)(346002)(136003)(71200400001)(76116006)(2906002)(186003)(83380400001)(4326008)(122000001)(52536014)(86362001)(478600001)(66476007)(66446008)(107886003)(66946007)(66556008)(55016002)(64756008)(8676002)(5660300002)(38100700002)(6506007)(8936002)(7696005)(26005)(9686003)(316002)(54906003)(33656002)(110136005);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?dpPoqqQNHnTLQUeqOvLkk8ANTd6KJQB/5F87vM9lwKpFx/0AIy3ld9Z8DJ16?=
 =?us-ascii?Q?yE4gVAV0yVx1uYQqzL7+CIWpx2lfiLRt/cVkIKMrIDUUOLFPyE5IyLtYa+2w?=
 =?us-ascii?Q?RuW6ZbibtIUJ3PfGtddb6ejVGUNSy24CFeAtFRlbWScm124ctc8GxafLc0ue?=
 =?us-ascii?Q?aaNsAWT9BxFmTqXyUdj1jNIk8ZZ5LFw62TMsfThY9BgH44DXE4tHmMY8OZ19?=
 =?us-ascii?Q?px+TGdWrg/G/tVh6Yf1UQbxuECJ0eWVUOAP54zVYCSotF6eJxA8ZJgrweLfy?=
 =?us-ascii?Q?kHuYegWeWk8LpuDsUd8stEmKgn4nv/QvrSYt2vbfLNWmo/ig5b+/4hU5n5E7?=
 =?us-ascii?Q?Oyp4P6yLLG+P90UCv3aM2g91bxC/vUO8XTph7QjAJ+I0xP8dNx+Rm1U49xWG?=
 =?us-ascii?Q?jHoPcP+XUqAz8O3ixbzWZWlhvxBbDHlfp8AapwvbSxP9FUt7rtC6FzLM+yn/?=
 =?us-ascii?Q?QxgsQws5poZ/wz+Oj23U2X0J+6BlccF0oMgSIB28vPqm4UEn1Rjumn9FjMX5?=
 =?us-ascii?Q?/BJYf5kUa5R7rhEg7kLoWuPM3KWb8lewW1y3+Q55QaSole7yNFOPEb33GGrl?=
 =?us-ascii?Q?+h4YxxLohFpsEhGVL2aGgsRfGPOWYn0jO1BtP7scmPFVOVmocqxN/htl/fiJ?=
 =?us-ascii?Q?uSzYa2Z6DzbQLwfYdZeEfqDdq7GsUzGW+V7Y/1MWa8W8i0dA/MvCHuvAsc5R?=
 =?us-ascii?Q?Aw0o8cGpsU1i3e0Aei8j+IvTgb5JO3mDkLvimqr//R0NUSBgTnlH8u0gQHrg?=
 =?us-ascii?Q?zXl6Bucb3aizZrtSrSzxiwLpUGLoR1tATpbPSXWKI+ZwgzbcwrteUSeu4Zzm?=
 =?us-ascii?Q?2zM52oz8HV3orE2KY2CZjEe+oCrKSnq3/zMiayNFwufYXbFSQCQdRy5N8Ek1?=
 =?us-ascii?Q?t/5t4B1/smM5oduuhsKZCRQ1pRZPrpmQXRuLpzQbpdNeTIEmg9mWjGQVq90w?=
 =?us-ascii?Q?zZQo2Bl74nbToUqmBh3V3ix2TLQ2WsPPjBqKrPBnGTlMvH5LpKIgMfP8hNZr?=
 =?us-ascii?Q?JNHladzFLPv2fhNs+PoYXd/8le2N1SoEK6G3WMMgZwqPlvD/9xn1n5GJU4Ls?=
 =?us-ascii?Q?lBwelLACVprUwZfZOvOedLtQr2MkJSk6qCqrMEpZzgA5m+adGKrj5knRG/1v?=
 =?us-ascii?Q?G3txv+fjlKZLRG7xasn3BGhtRIVdR/KEMv0tndtfxKY0f0gHz1ZymsDANMP8?=
 =?us-ascii?Q?z+1vlUP69E4sIYVZbr+xM0JM95zfH3ZgW/IS/R03CIfqSwm9q46RvsX+DKP6?=
 =?us-ascii?Q?QhytVb0wzU4vbl5a7TEByDoK+VvPss7XWrEHFzmIlOAQ/FN8cO497UH16e/8?=
 =?us-ascii?Q?QI4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45474dec-3394-4a94-727c-08d9150c3754
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2021 06:07:26.0393 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xns34IhXveGldWpwWi1CQsjt5f7clU1ZiOMr7Pv/cPLFULDUvyhQ1/B22RqlsEN88A170RrdRQLWqYTeSzaszQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5343
Subject: Re: [dpdk-dev] [EXT] [PATCH v3 15/15] crypto/mlx5: set feature
 flags and capabilities
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



From: Akhil Goyal
> Hi Matan,
> > > > > > +Prerequisites
> > > > > > +-------------
> > > > > > +
> > > > > > +- Mellanox OFED version: **5.3**
> > > > > > +  see :doc:`../../nics/mlx5` guide for more Mellanox OFED deta=
ils.
> > > > >
> > > > > Since the driver is by default compiled off due to the
> > > > > dependency on external Libraries, I would recommend to add few
> > > > > lines here as well for compilation.
> > > > > Like to compile rdma-core and set PKG_CONFIG_LIBDIR.
> > > >
> > > > Why? all Mellanox drivers has the same external dependencies.
> > > > I added here link for the doc explains it well.
> > >
> > > This is a crypto PMD, not a NIC PMD. Somebody working on crypto
> > > PMDs,
> > do
> > > not really care about the NIC PMDs.
> > > Hence it would be convenient to have compilation information here as
> > well.
> > > You can refer to other document for details, but basic info should
> > > be added here as well.
> >
> > The link explains how to install OFED, this is only what the user need
> > to take from the link.
> > The basic is to install OFED.
> > I don't see a reason to duplicate doc section which are exactly the sam=
e.
>=20
> As I compiled the PMD, it was not convenient to read the whole document.
> And it is not needed to compile linux and everything.
> I just needed rdma-core and set it in PKG_CONFIG_LIBDIR.

But compilation is not enough to run, you still cannot test if you break th=
igs by compilation.
You need to install also the kernel modules.
That's what we explain in all our drivers.

=20
> The reason I am insisting here is, when somebody do small changes in Cryp=
to
> library, he may need to do subsequent changes in all PMDs.
> For which compilation steps should be easily accessible in the PMD doc So
> that the patch can be compiled properly.

Not enough.

> Hence I just recommend to have 3-4 lines to enable the compilation In the
> PMD doc.

We are not doing it in others mlx5 drivers.
If you insist, we will do.

> > > > > And I do not see any updates to the test application for testing
> > > > > this
> > driver.
> > > >
> > > > You can see update to l2fwd_crypto, we tested with this example
> > > > for the first stage.
> > > > Everything looks ok there.
> > >
> > > L2fwd-crypto is an app which only test data path with no packet
> validation.
> > > It does not tell if your encryption is correctly done as per standard=
s or
> not.
> > > Did you test interoperability with l2fwd-crypto?
> > > All basic configuration tests are also not done, like cleanup etc of =
the
> PMD.
> > > I haven't seen a driver getting merge without the unit test applicati=
on
> run.
> > > Test app helps you comply with the way dpdk drivers are meant to be
> > > written.
> >
> > We adjusted the l2fwd-crypto to the dataunit feature and wrapped keys.
> > We validated data integrity from the packet returns back from the
> > crypto net port.
> > As I said, encryption\decryption with AES-XTS is working well.
>=20
> Do you test interoperability here? Encryption by MLX5 and decryption By
> another PMD/stack and vice-versa.

Compared to open-ssl results.

> Test app is supposed to have test vectors which will work on any platform=
.
> Hence data validation is done properly.

I think open-ssl is good standard to check too.

> >
> > Now, is too late to update the test application to the above features,
> > the driver code is here for a long time, no one ask about the test
> > adjustment until now.

I acked as maintainer of this PMD.

> Can we defer to next release? I apologize for not asking it earlier. But =
this is
> kind of obvious for somebody working in DPDK.
> Please check that none of the PMD is merged without test app in the past =
3-
> 4yrs.

This is not true.

> > We can add the adjustment to increase validity for the next release to
> > all the remaining crypto apps (test\test-crypto-perf).
> >
> > For now, we have one validation with l2fwd-crypto And any user can run
> > it and see how to use mlx5 driver.
>=20
> The user cannot be sure of the basic things of a crypto PMD are in order =
or
> not.
> As l2fwd-crypto does not test every basic thing.
> For eg. Session deletion, PMD stop, PMD close, PMD restart, setting up
> multiple sessions(l2fwd support single session).
>=20
> Running datapath of a single use case is not sufficient for a PMD.
> This is a POC and it need to comply with the environment.

There are only one\ two cases we need in this version and we tested them.

> I hope the doubts are clear now and we are OK to defer to next release.

As I said, we don't agree, it is yours.=20


> Regards,
> Akhil
>=20