From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB938A00C4; Sun, 6 Nov 2022 14:16:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28D7A41153; Sun, 6 Nov 2022 14:16:11 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2068.outbound.protection.outlook.com [40.107.100.68]) by mails.dpdk.org (Postfix) with ESMTP id E08A54003C; Sun, 6 Nov 2022 14:16:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dd24s5RNpqrFVkjatiBeRnI1mjMk0g3uOWIvoQpHstMtTcrhswYTa8Kqrx7rmQjdGa2qT0acvRWDrqVBc8OemsFAJB6wAIBNO2vXjF/UqF9yiO+7oHjvZfhtCQfsi71MkyfU/Onc8l9mdUVXMIFAdYs3B0QR3m5L49vpLHzi1hEyRbSdeJO/txvI96/0r5mRymQ63CR6GZ7SiQ7otZcPFKvr2GDxCw0crvRmMc4ROmyZTydFA0cdg7+JN7VFj7PScn5RNYX/Y6DddrV+7S1f2g6OS1kytqMeVCdjAEpZc8R8Wxcr5PzCIDdYAGkLfQWryU+jHgtLWVDOME3cns9W4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BG/bmfEKiSK/limu6Z6feBUXmb0W4QJ33+8rLqIqHNY=; b=X1+q8sXksTDJ8YwajIeWwB+/Wm1YAfbms7/2qmTntUfMqP2OC/3U+itPYXPcGoPci/hdTTB2aLV80FBfaYtMJXXsV1h/OSSZMO/5KrtxcjfceGC6xU5jap3WnfiQ5QRqTjELTBhYwQOeBHncCiiun0y4+gb9LM6HdzuHrIFANJadEPILX8/NcP61nYee5C3kX3qn3a7UFSGvkELhPr71dAzGOxDbVq+lYPSDnBIrT18ZkvrrrhVI8ebQXrxNZcArayc/cUAy6m+mbs9ZAsMC5TBjxNUXfpjyICjAmf2aHkYTiSkSa5jfzAXpMOZ4FW2jiKt4pi7B3nFnwza2bscwgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BG/bmfEKiSK/limu6Z6feBUXmb0W4QJ33+8rLqIqHNY=; b=KUyOxSOU/Jmup2RRDMeJAILYEvwAJRWYzj+jkS6LSNhoQeaC7ayWoVjVKFvkD088BzulxIl3CBfhjfRhn6n2C/Kn35u4U85BmGiTwNc0ehp7wN8M0exF5kD+oQU5IjmLdt1F0WcD+ZhBKadsD6VtTx1JgSpZHMpW3ZI/cwYMY0PD1kFW4Hp8calwgonPJ10Loo3Ve9JMoV0fjmN57cEwxKV6jIfkGv+yYppqhJ1WQi7zo2lTtYiqk+qaxAfJ6le7hzgeRXqQOVcINVQRjZypQMFNn3Ip633sG43e1/QLecIdnvgUqmbDiwv5gXba/KSmqnBrj0CvVm8AqufD+w4NbQ== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39e::8) by PH7PR12MB7305.namprd12.prod.outlook.com (2603:10b6:510:209::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Sun, 6 Nov 2022 13:16:08 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::415f:9643:ea7c:b3dd]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::415f:9643:ea7c:b3dd%5]) with mapi id 15.20.5791.025; Sun, 6 Nov 2022 13:16:07 +0000 From: Matan Azrad To: Alexander Kozyrev , "dev@dpdk.org" CC: "stable@dpdk.org" , Raslan Darawsheh , Slava Ovsiienko , "Xueming(Steven) Li" Subject: RE: [PATCH] net/mlx5: fix shared Rx queue config reuse Thread-Topic: [PATCH] net/mlx5: fix shared Rx queue config reuse Thread-Index: AQHY7scDgf/EKlXoi0OBNpG/hfO9pK4x5hfA Date: Sun, 6 Nov 2022 13:16:07 +0000 Message-ID: References: <20221102142500.1731495-1-akozyrev@nvidia.com> In-Reply-To: <20221102142500.1731495-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5389:EE_|PH7PR12MB7305:EE_ x-ms-office365-filtering-correlation-id: 4a3d73c8-232e-419f-ba8c-08dabff910ec x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EyTBIBlOgSUIgTqGpMivTSteJRPyX3VGSiXRZr3MuuaZ47ZemWQvFhKhdhPjzz3QFNGIKVJNBgUnojme9bnd+kMAendqwxd3wLUKEDfq/+Xoe9PDQumeqdakMPZzvY0Ap/CCFO+j5MdKRtNtgbuNiAC8Hv5YT/h/nP1EzkMBlTcypuxe/PBHLiE3t6o6kuQwZnIninLPmabiaq12CEKFyBvOLQ27QQJQRzgKHKNaZyfbl5mIj/sOQQDa3HiwLuUag4a1FmniDufaVm94XqETiIchKuZglSgkLJYk9ILw9rAfylXhCIeAaD+6d6QzfDVZHGHC2gtmnBp2dMsCOmJ4HVSxlDe91tnA0xB02azH538QVPHQZeOGoVbs1mtalPDRRzU2OTuq0gTQLeeHOWsa6iihI1RLQtm0yUTKWl06b1qMQt3+jd9n4rdSFlLvcvP8LNV5LHh9jwomtC81LJOSFeFPpgQU7bK9CRm1GNLu5vDrP65T87VjfZv5zAdLVn3SsINxtuZXofxgwLvHN/pTYQHo+lsJLmvoBr2kD3mcOXAhpMiV0FmQfMzJN7WDkpoxQdFDp4b8OzvTbBDZm3w8O20JRgirf5QQdTPkaJvIvaDthoxYCc0kNII5PGgyyc6ngTAE9Dx27+GqT3UihiO7DhO0RXMVR8tpfpC2pVus4vVSPWHDBAn3gVtYOLh+moR3IYNZHKzQ/ro7loXnHDQFA2zdcSVew6ry4SVvAjW4KSQy4gAZwdYPStjoNMB1IRMBrCjGYeZrWVBX19o/uZOSXw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(39860400002)(376002)(346002)(396003)(366004)(451199015)(4326008)(8676002)(64756008)(66446008)(8936002)(52536014)(450100002)(66476007)(66556008)(76116006)(66946007)(9686003)(41300700001)(186003)(6506007)(7696005)(5660300002)(4744005)(38100700002)(122000001)(86362001)(38070700005)(33656002)(55016003)(2906002)(107886003)(71200400001)(478600001)(316002)(110136005)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?v87nQHBV8XSl0VSml8HY+Vz8BwValFIm3aHg3qAo5TWz/dsTjUHQSl1jmPna?= =?us-ascii?Q?1Qhsao+jf8WiMIHJt4gctApHOkxiJROABeZZIz3Uo+QNX5IrgNGoa5md3MHP?= =?us-ascii?Q?C/dQS7cuIx8J6m+pkXCZnfJW7nXpABgRHOnEoBAzXDAYALe0wCoWtiBpACFD?= =?us-ascii?Q?9tW5ZBz9FFHTgqsyykE49BprBQRU+2ak+e9eRnkfoN1+/cQ68hlpSKZgMVbQ?= =?us-ascii?Q?0Ody3P+IgS5jNJ9+w7Xzdhc+x7m/UyTqrbRSS0KOq8mNusvsC2IDIDs88+Zp?= =?us-ascii?Q?mr7455LjUAQhkSFrk9bTmj84r0wHfmNW+iQ4LUixusvNf4VFlNn0TPtN8a0I?= =?us-ascii?Q?BZLQGiTLl86IDPswJZSDk6A2uXUm87g2Kpa18ppJ69ZstUyk2j6tOsfT2xmB?= =?us-ascii?Q?4ITRJwqz/wDLx1J6vo3qleCQj6aczlvKS107xAmCmSwi7z4IE7r3/aEYQHjz?= =?us-ascii?Q?8eXpiLLC8qwG/hTSAqqjLuU6bnT7HZ+969cLirZTlonA5RpZ/CLub/wUt5dD?= =?us-ascii?Q?NYK0VBTm5HzZ4VM4qW+Oc84K3NSwSbl1UqSY3E/V6SGDxtPDL/p77Cf7uF21?= =?us-ascii?Q?TN2FDJA/m1KihHvKtSFo6fBV2iMcSZvudiqNoWhGGFhgK4pidOZ8af5WoJIe?= =?us-ascii?Q?uHx9+AjA/WYFpPWwgNhaXlcHfPj3mrRnlUYC8Gnu3q3nY2IXYg0j885rZ8Sd?= =?us-ascii?Q?odinP2XWzGpswKwsycBYR9JJ9Pa43SufZyuoIHaAOJUwxFloVphAtCcBVqoy?= =?us-ascii?Q?+oXArx1HKhQRGuPfYnZIt7E6AYht+yWFThuQgACmHpywG/2Pgkf/qR8MvYjU?= =?us-ascii?Q?kEl2TULRjIU+NjwzKjZcjDoMSNu7RE3y5B6ADtkG40pFWWgjZqKUZA6C9rq0?= =?us-ascii?Q?4VRN2DAvOCFj3MwhoKDTaz9+xIGys+6nkEirq/42w3hRzsBVPoz6/aKUuJci?= =?us-ascii?Q?3NJlmIf2jFocxBU1PKSczdCZ95Ra7m2xhCQlHE4kHaLajFjfy2rh3eY67UpG?= =?us-ascii?Q?miGQEmm5gwPdtveY6dMnqrGyckFdsjNYoP4EkulQS8hFeyoTlE6yw9vw4iJq?= =?us-ascii?Q?4thkWafEmjRffN6voF7Bb7I8km0D6VVdwyALyBskYq9u7aYkNjZcHjCfIdmB?= =?us-ascii?Q?miLMF/vWKo21rMfNjPQT/95I36GL9qdjEBc8e2y1Jc4nXZgo4U7xqSUmbjra?= =?us-ascii?Q?2ajJpwUpR7L/jyBEa2vsI/TwucHjKU07nISHzojhkE9TWdoz7+wEnlFL0Kxu?= =?us-ascii?Q?dCBT+qMpdLgSWpPOhgCgxcCyoedVfn5mgxPESPhIXVmQEZ36+0Gn1PexKPnV?= =?us-ascii?Q?MSAKiNcpff2irqwSgKJP22cw8Jwqb5XhWLq5J7GtqvKHbl6+jlLbYbhjjShC?= =?us-ascii?Q?aNxeryqY/aGdY6x7V9f2/tqn2CDxoOitfhO7udwAoKkORcmkjGplp+Kb3VTs?= =?us-ascii?Q?Y4hnlyG2xH5rNPV+yyDDL4/8oNEIbIqxTynp94MDVsekzbB4q2mHHy897VdI?= =?us-ascii?Q?joG02+7adIyp4Z6q2/Iq2E2ACgv/QVVGs1i9LJi/3WyJIf2EXoNPcKyAMA35?= =?us-ascii?Q?74+ysf5KZmTZhtQELoldL00ww6HZ2kYcOt9aWrkRG/Y64COZODsm1FtIp6Gx?= =?us-ascii?Q?AAu8XazrRJ/jAw4+UcLuzLU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a3d73c8-232e-419f-ba8c-08dabff910ec X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2022 13:16:07.7588 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VmeOQaWMX75VtpyglYCbGVkxvCsZbEmH7i4PGGeM2Bbk1BPsmGoMH341JcbTHhD8EsF+PYfPckUYEup4HyR2AQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7305 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > There is a check for the configuration match between all the Rx queues > shared among multiple ports in DPDK. > This check ensures that the configuration is the same. >=20 > The issue is this check takes place before the queue is released and > configured again in case of reconfiguration. > That leads to checking against the old configuration and preventing the > shared Rx queue to start properly. >=20 > Release the old configuration and prepare a new Rx queue before checking > that its parameters match the config. >=20 > Fixes: 09c2555303 ("net/mlx5: support shared Rx queue") >=20 > Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad