From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3817EA0548; Sun, 9 May 2021 16:25:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C3B2406FF; Sun, 9 May 2021 16:25:03 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2063.outbound.protection.outlook.com [40.107.237.63]) by mails.dpdk.org (Postfix) with ESMTP id 18FDF40140 for ; Sun, 9 May 2021 16:25:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ddNSy/chilPNsJ1rv7iH1+WEJWyaueszIQuT5Yv3+fFNHS0OiY/fjUhvZhceRcsBoP9GHWxfZG42hFbUGknBm9hBYdLdIoX/L2T94NbNWMMtiHS5sIF1ad9rmeLEiaYXmarQ2k1HaUQVqgNSwQDqjJ7MIBl7IiJUIoRAh3qlmcrTNoiz2T/B+sDtWXJNHhPCOJ7rqxmIhKzN1/FcyOT6nOMc6P+h0j6EKMZQWLLUEk0VFf1g+5suHwJbGLk1iPVBKDiLiqUt9K81qwfduoyS9FvL5htNvnwe5z0wDtaRE0nlU3h0jkAQ7RhuvTx33L73N850mZ1kkHU9AMPQTxtyFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V9QLAWcjjoeXKtDiBe+Ig+6xmYN0V2b3X1JdbHAEiWg=; b=JtF6UNDVB+Eiy4nt8uMu6uiQdHVKg7lOsloJqajuVpjjrR6r2mDSm1aIW1o/8WAxzFivSkaNvcRhs+EB9jAxQY1Ka6yG7Lz8DDv4dZJU17FOLmseLGrsmun+jerJowcca3ZMEXHNjBctyMTSm8O57CP6L5SPPfkgKHZpwrd/92KjPADx6WPKq6IiIqbASiUsJE5OMOk8MleNYE90aQZGfXsBR1yk+k+f/31L2OaTI3QAHeUc5muTwDKXXRKbC4vjQ+gHeEDyyON2Jjd06OZJIi37N4bc4PlRZtZVpRSkUb2CVdl8vSLgJlSdcLqBg5j/TAuidxaRi+W//cl7kjmKCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V9QLAWcjjoeXKtDiBe+Ig+6xmYN0V2b3X1JdbHAEiWg=; b=nmrHeit97kZxRL08xz36sLE4UtokbTCboTZ2hbvGl0GGaiuu6QQUhcU6Oq3+UJNmsxviaFGmQgv+b5B8mDIgQcPIAweoU5cW5tk4ENclDlNdG42UIe5uq4wRncA8weC8Sy1wG9Aa8hCsgcQI25awb7pv+tdFbxTUuZP+Ep/wTJAt/JPMozGg//2xU4jVOrek30dmdb5vAm2Z+6DyhxAyNZbldHz+FxrnEEGSgXsb30sMiS27W47Mtja0SoeLBrPK/pYLp+dK3ZEk+ldaRx4P1TauUGwGCwPC6/N1/J4zQfwKNUOajy+9pY0IUah2sIZP01v+lq+tcjTlTjeckoD6Jw== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5230.namprd12.prod.outlook.com (2603:10b6:5:399::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Sun, 9 May 2021 14:25:00 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.031; Sun, 9 May 2021 14:25:00 +0000 From: Matan Azrad To: Akhil Goyal , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations Thread-Index: AQHXQSnFZsqHi0ROBkyLX1cinh9IRKrZjXoAgAFCeWCAABcSgIAAVLhQ Date: Sun, 9 May 2021 14:25:00 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-4-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [79.179.26.253] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 897f82bf-5900-4758-6ed4-08d912f63a7b x-ms-traffictypediagnostic: DM4PR12MB5230: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jVkdbYmgyDgCyXUX0pwUMj0H847DexHkmw4w6FEgQyVacgN1UK1qqDTInvQ2Ct6e4aubftxxgFTEE91UurNTxpA7ygcv7TeeUWskWmWRT3dTziJr/cK9OVgH+/xYBj4611v6ijkM+LCu1IGouCMhf8lsAKycQKgwojJ7RQCReJduJ6okBnAdTXAL3hA0y8KXg9matZgH4878WXyvoJE5C+t16zWSQ61zbi67yEI3iJcrThNhUANvACSDV3UMAcUbK7aAjZQe59KJcE+HRDBGm+kzyheyTTJ6dI14lmPTX0PdtQj0VR1nazZ+3bZd/6Zo/gdq23SsXLfNUnEscPF0bVva2xe2RQyT8mcknYmgIoWSVSWkNiqUsPTDMKZemCmsJKxkAwaK1bQkOIEReTGItl/W2r6epOaNfmZAGW/dPw/IC4l46K8keRyMqYPI6ffI/AEzdXAXSZEadxU9pz/oEMCO44Xp0KcBf4SHqVQf0Afcy0xFOIefuIy0PfM8xt5fARRTj2BFSa0tMsE+B0wxiRBROLB9KALN3Neq8nZUjDOTlCb+ZaUQIwOHK4+pzzJ7vKVGOAYcERCphjj5HrTMy0sem25pLg4W7e/tewwDXwA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(107886003)(186003)(8676002)(54906003)(66556008)(71200400001)(66476007)(64756008)(66946007)(66446008)(316002)(86362001)(7696005)(478600001)(76116006)(110136005)(83380400001)(8936002)(52536014)(38100700002)(26005)(9686003)(55016002)(6506007)(122000001)(5660300002)(33656002)(2906002)(53546011)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?WGTuIzxslAo8hhU9Cd5rqy02geBp8wblvjk5h0qwvGhufVW23Lz2BmkaPQGI?= =?us-ascii?Q?Oo0CwGIuomEDYmWUklvkm5EaAPfMdMMzqT2b81hk7fZ/z9ME8khqM+P/MFCJ?= =?us-ascii?Q?/hQFCxNa2ryPvdet7iRVFm1kVkp0ayn7KyeWQ+JIli/n+8U10KVu6tGle3uj?= =?us-ascii?Q?pEinwi/8KiIbBg7ozsW6p71DNVcl1WFyePGYVwIzI719OC+K7+xDFXwA/H2I?= =?us-ascii?Q?vNwN1pHXd/UT76TQNZiFrqFhtqM5E5GWKQEmsRpjx8id4dbxNGR61gEOIp15?= =?us-ascii?Q?CkBQWwOE6EMNxWrcjsayq8h7UEyjHH58f9ubCDfNCLyjfiOM6EKikc0pcjsD?= =?us-ascii?Q?HTPK/HMQN3779yDxoM0dbxyFA/FgfL6F/GmG9W+twKTqKicjiakZ7ou07kew?= =?us-ascii?Q?iQhuN21JvYPOnhifNH6YqUowNg852ALtvAhxOubQ7fLgMlOircGoV/KpjIBw?= =?us-ascii?Q?87Qv89GluRmuMkjDcWGEdd8bO0qxMmsguba1DU3hVTH1aayHTG5oc4674AoA?= =?us-ascii?Q?nHSnivSmvAJoXiMySsKJnTlLCmM5uezraDwUpZPIoSxmSTVFzklMMccvaSCu?= =?us-ascii?Q?z+h/g0a1/hAw1sK76iz2M4vT95NKHvpP8rOz7s0l8l184LZwRVyNqPSSeiDw?= =?us-ascii?Q?IrOWWHPlFAeMKUeLuW/8hCmb1CXICcm31saHOHphBxBiarux02sGbulGQ4Mf?= =?us-ascii?Q?IXuCLa2G2kruPN/twvsPEI1/95nMRuQO0uOdC01W3wOlqUcDdEy84CO/kqwl?= =?us-ascii?Q?Oqg5V3WLmCOlT75hjHig8i5tXGRAnxV84JmjLV54hGu0yq6B9wqo1bDZlPww?= =?us-ascii?Q?qmLb1mT2q68Gx96QwTDQe3lFvshCQ6Psus9vi1Gd1Nc3ArKXE2GZh3GA7s/v?= =?us-ascii?Q?1C3IdnXpCgZ3m3MQwy79DXru9wQXCP6sdYKf2l3Y3qlH4mVF62v4tVQleC9l?= =?us-ascii?Q?DnhZYcO4yl2GnTxaDk5HIwnnOhU0WoE9hc0JPtdvcuhWhPQeSARBD/Tr6Sw0?= =?us-ascii?Q?be6c8uwnZn+kxvcjoXhn8TW64VtQPuydcf2LcHjo4lAYmiFdJDUWiji0qd/H?= =?us-ascii?Q?W7muzYvSlfGP31lQQ9N2iBq9zK9j6UOfiZeFsNLPKW58hmTWYYFnuFvalbb0?= =?us-ascii?Q?gfhCR4lPe+fB3F4NPKDm2xY1aNt0xGxLiodA4QctDtqe5nr5MJDDd7PqgeRB?= =?us-ascii?Q?PW0HGjPuN7c7f39Xlo/9QlE0UXJaMXLRcQDpmHWi7Oo8m8tkKAEvoAk3EWCP?= =?us-ascii?Q?UmfsXkBWzzDb41Kktq/sn1kZQwtwJDtZZj4SyGdLkX2Jh3ZkLVIukDyhMX3B?= =?us-ascii?Q?1hmBT04/qUe2lzgM5Dyl+vfC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 897f82bf-5900-4758-6ed4-08d912f63a7b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2021 14:25:00.0823 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IToZVrbc1VkCFckeMTPFepQTpT/5znuz7/NpREOMoU4VNbccATTNhVPJwzSYEIImz/r6yco9M/nm8STbMdO8SQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5230 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Sunday, May 9, 2021 12:21 PM > To: Matan Azrad ; dev@dpdk.org > Cc: Suanming Mou ; NBU-Contact-Thomas > Monjalon ; Shiri Kuzin > Subject: RE: [EXT] [PATCH v3 03/15] crypto/mlx5: support session operatio= ns >=20 > External email: Use caution opening links or attachments >=20 >=20 > > > > +static void > > > > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev, > > > > + struct rte_cryptodev_sym_session *sess)= { > > > > + struct mlx5_crypto_priv *priv =3D dev->data->dev_private; > > > > + struct mlx5_crypto_session *sess_private_data =3D > > > > + get_sym_session_private_data(sess, > > > > +dev->driver_id); > > > > + > > > > + if (unlikely(sess_private_data =3D=3D NULL)) { > > > > + DRV_LOG(ERR, "Failed to get session %p private data."= , > > > > + sess_private_data); > > > > + return; > > > > + } > > > > + mlx5_crypto_dek_destroy(priv, sess_private_data->dek); > > > > + DRV_LOG(DEBUG, "Session %p was cleared.", sess_private_data);= } > > > > > > Memory leakage, mempool is not freed. > > > > Yes, good catch, this part was missed. > > > > > IMO, this driver is not properly tested with the unit test app. > > > > The only app we tested until now is l2fwd_crypto and it works fine! > > We can add it to doc. > > > > > Please add a note in the documentation that it is tested with autotes= t. > > > > > > The next app we want to test with, is test-crypto-perf. > > > I would recommend to run the test app first. > It will catch most of your basic bugs like the one above. It is too late for this, will add the test adjustment later.