Re: [dpdk-dev] [PATCH] bus/pci: fix numa node return value

[Tal Shnaiderman <talshn@nvidia.com>]

> Subject: [PATCH] bus/pci: fix numa node return value
> 
> External email: Use caution opening links or attachments
> 
> 
> On older CPUs, currently numa_node returns value only for socket 0.
> Instead, application should be able to make correct decision and also to keep
> consistent with the Linux code, replace the return value to -1.
> 
> Fixes: ac7c98d04f2c ("bus/pci: ignore missing NUMA node on Windows")
> Cc: talshn@nvidia.com
> Cc: stable@dpdk.org
> 
> Reported-by: Vipin Varghese <Vipin.Varghese@intel.com>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> ---
>  drivers/bus/pci/windows/pci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
> index d39a7748b8..343ef6f33b 100644
> --- a/drivers/bus/pci/windows/pci.c
> +++ b/drivers/bus/pci/windows/pci.c
> @@ -5,6 +5,7 @@
>  #include <rte_errno.h>
>  #include <rte_log.h>
>  #include <rte_eal.h>
> +#include <rte_memory.h>
> 
>  #include "private.h"
>  #include "pci_netuio.h"
> @@ -243,7 +244,7 @@ get_device_resource_info(HDEVINFO dev_info,
>                 DWORD error = GetLastError();
>                 if (error == ERROR_NOT_FOUND) {
>                         /* On older CPUs, NUMA is not bound to PCIe locality. */
> -                       dev->device.numa_node = 0;
> +                       dev->device.numa_node = SOCKET_ID_ANY;
>                         return ERROR_SUCCESS;
>                 }
>                 RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW"
> --
> 2.31.1.windows.1

You should add "on Windows" to the end of the patch name to clarity it's a Windows issue.

Aside from that LGTM.

Acked-by: Tal Shnaiderman <talshn@nvidia.com>