From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF010A0C43; Thu, 25 Nov 2021 11:38:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 614B141149; Thu, 25 Nov 2021 11:38:47 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2069.outbound.protection.outlook.com [40.107.92.69]) by mails.dpdk.org (Postfix) with ESMTP id 7998240DFD; Thu, 25 Nov 2021 11:38:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=az+muHjxaAPJ3Opx2XnFzrPwRBg0jFD9xWoVHO0gfa4tsQL0kZy7kJkogCueKq9iHntYTUKuxG5AF5AlEqgZ1ZC2c8Ohfdp4lxLFriouH4FgBiv/L5UjDuw+UK50tYyIZxdu7MjezXwqkJLyiRAso6jIcV71c4U+nr6vDqIRfN9+fTSg+/9kpQwWsdNRGXxuABL55w1OJ+qirEotdOkKgVoH79OvQjuIE1B3sXnI0Bz4Z5gOoQkezhsqYJ2fP1xTNpmogy2i4sSGVlVN06Y230T1VLf9o8rc7SLqv60Q53fS/Hn0lVwPMMu+mggBGxyhNJhUAY5A6a9v1a5bZtQYDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YmIgIeEDFtse/zBHAbiRpydvS/jz6jrwfi+SmhzylnI=; b=TU+6yyV6+emF7goW2XskJ6ryuaQJDdbMkrtWNnNZ7ncXY6FZcLxfGOVyZ+u10qDCBYC7jBBkwapk6UJOXekPArpeoi4fCvn/D7XDdabOyDepYS7odR+EuyBvIj5lN4qeAfIHA9Bu4KqTbKlzoj9+gaHY56fg2FqyARdPvp1Sd00oY1YANCuj9qW2zWLCXS9/WymHZZHyV1r3RtAOoqSq3Otf0c5s8QxvgXNFZu54IIDx9Y4PLzpHd+M46Bm+pcS2L72INHt1CmCNH0VT2jRq0wxyHRYK0Zv/ApIQyvvLHoeKhHusWkQEIGLVmHDHYsj9rok420io2DVNFEoYCDAJJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YmIgIeEDFtse/zBHAbiRpydvS/jz6jrwfi+SmhzylnI=; b=BAvFIYWOguBtArzSoxiK/A/fYcg/OxO//34v0Eh/6fFVdrPZvDwGuvMXEVHJ+Z6NZO9v2OfNUWIHQDT2oxvANPLFcyG/80Sw0TrKPo/MEKlQbToBbjeWHqNrlLPpGzMj/MgIkqIXC5XRqREPvTZfIdtrK64HtzARO44+EvYDybwz8bfuIyBFuf1PDpwo2A/3aLAsgA7UwhM/hMrJHShLizfZ2TKewkZN+t+YroawXG+wAMWYxuBHkxGOQkDoSdovKwOfpu4BDWrmbZZYwhfPA3PamXUZ9Vx35FEc7YdpH/cxVu5bxg2VhA34h3PBFtMDOiXCwL6g7mmB8xIl7mtF+Q== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5392.namprd12.prod.outlook.com (2603:10b6:5:39a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21; Thu, 25 Nov 2021 10:38:44 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::2171:cddf:7b43:3778]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::2171:cddf:7b43:3778%6]) with mapi id 15.20.4713.025; Thu, 25 Nov 2021 10:38:44 +0000 From: Matan Azrad To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Raslan Darawsheh , Michael Baum CC: "dev@dpdk.org" , Slava Ovsiienko , "stable@dpdk.org" , Lior Margalit , Asaf Penso Subject: RE: [PATCH] net/mlx5: fix devargs validation for multiclass probe Thread-Topic: [PATCH] net/mlx5: fix devargs validation for multiclass probe Thread-Index: AQHX4cQge1rU5i3fpkqAZRkGJU9sS6wT+jyAgAASShA= Date: Thu, 25 Nov 2021 10:38:44 +0000 Message-ID: References: <20211125061655.3143135-1-michaelba@nvidia.com> <2510169.dztEg1IeGT@thomas> In-Reply-To: <2510169.dztEg1IeGT@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aebddacf-a12a-4861-2308-08d9afffc142 x-ms-traffictypediagnostic: DM4PR12MB5392: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EPM107TrXJ7VkQ8YRvfFjb88xn3l+EJo4B3Wq+7IueNyVVl8OzY3UIDpRfMXq6XiGyzKV1gE815M6lOtU4Ex9gs9GGG6Mjc+m+nFovEn1IOpf4HHMGXMYLKaCszJjj9JoaHiEWISr9WNh835K134yiqECi3kMqz15kl8o5jJ2F0Fkef57tyMJeyZoN0z8Lmjmv3TYNIAAy7BFZoqRlGsu4N1Z0ZhQ/UWHKYghwPxVZ38ynmIeT8bP4+Rt+s1FirGzbOjc4h+sUOB8wBIif0JUmuxFiiQ7U68x9XwbsPrFffk9gmHw1uC5PwcMOhM+JqcetkTI8JR2lM+gGUgUujx9kSumIQuMSxWkuwcc8s6uia22LawT/smPXvu/mBR9PushH/gL8O4Ve1OhAEd6D46ZZjQakcwKSZ9oRHqylRN+LoSLV7ZGqB+j2SiSggWPWpoHMBtRoMgWl6uWjbUbYhvrxKSCI1hSTMTjoMfGPem2V9kkcR6oH7CD/GuMtCAeEi2Uou5KIACAhuUiDXOYhKduUajC6Nf3xHlyZu5z6ShnhcidbqTHT5GVyoK0r8ahaPtCZDC36q2zimUVGYn0o029jodGSwNcumWcONSwC0SMoVT4rMrLSb5MhJJU8ksK797PyPmlIxumHt6IAre4Tg3oqwr0PeD/oXR00bHha+TcHt2MenlQsfKAJzkY6uLyL7MXIUcuQQkdSgW0+uzL2uE2g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(54906003)(107886003)(7696005)(6506007)(4326008)(38070700005)(110136005)(86362001)(122000001)(66446008)(8676002)(64756008)(5660300002)(38100700002)(508600001)(2906002)(26005)(66556008)(316002)(66476007)(6636002)(66946007)(71200400001)(186003)(33656002)(76116006)(83380400001)(52536014)(8936002)(9686003)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Bi3mdjVsJQzKoDGKUovERIJ0ichDVgQyiQJvogvBb87/KJ4S5vZ+3FGnOi81?= =?us-ascii?Q?WnHTb/ZoG8u6VIEe6A75ZrlMbVdz52wtCPLoHSz0s0oFHulgLTyKMAbTYhGi?= =?us-ascii?Q?LdZJYGRfqIZ125av3MhgFP3stHpEtpOP8ov4n/8fgA4SxKTj7DIRElqxcJSk?= =?us-ascii?Q?DV54trhuScobOhgKHIZr6wR9/popnP/9IS1piPSOw1QyuOPU6aFqVI0cZ6nJ?= =?us-ascii?Q?LZwR3PWX4GyQhGIrSGxV2UKKcsxCXULtLYdX1wU6FZDzv8od+pGJqzmHulxm?= =?us-ascii?Q?/ODQO2KmAelAzeejUTyJspemYE/GKRx5QwS5xgymGgbfZRLFNWxdiTgwkqvO?= =?us-ascii?Q?Lj3Osyy+rLpzzEwrAwtJQu1P5WHdBU+vJQmMYZv2eLKSy5kTaBltfy4VjnqV?= =?us-ascii?Q?TnqpYhO1+bLv7Q+v0YCmBFusZvLHl8V0/JVuAkE9tXEBYN1NrXEdBPBy0MtZ?= =?us-ascii?Q?iRHD9JdF+5PqSg/lFk9KPEP34jLAfp68qWAbdA+EF+amFKjXiND4y/UG972I?= =?us-ascii?Q?CoIAhwLRwiTDpQqzMIOL/F6FvPJD7bPxZGgz1X4CAEiPgc5pcQT/pIzhCEDb?= =?us-ascii?Q?Qo2PsUoctNrGbjxR2hmRkmKGS3GXtRHAbFEb+MTqQ2PIFVG3x4/L1DjMPx8q?= =?us-ascii?Q?qq7OMZXx3gQtg5rAR0W8mcbemZiIZ00j0TVkTJUkVREzfuJGZZyXQ3D/lNE5?= =?us-ascii?Q?iYd2OVxt80MvKFxvlukX33a0jBlmXJ/XkguRBgjd0iqydebi9h/KhUZPGbZA?= =?us-ascii?Q?kB6SbR5izbMHp96b5/UGU8K/TPtNj5nTLgEiMg6CswGKwtd7qo3zmZIJnTMH?= =?us-ascii?Q?FMs4rH9b7oFDqchW59vgJTAQQo2DZn3DvY5zAfQZ+FfLqEdoC1Ogju4/n2P4?= =?us-ascii?Q?IbEvDy3MWt95Jrl95kmP5xX1u7lrAYk0amkA+DlIoggbP71LMmWUiXJEmMYv?= =?us-ascii?Q?3Zga/xOI3i3trxtAiIC7JxIZIbzCJ2UB/C6lYRK+lKEeyCBcvcVVqk0f8yUN?= =?us-ascii?Q?OknaJSPqsJ6DoF5Sl7hbrvfvau6fjKY4pQpyj1YwleGPI8P//QKFuZVXUvA/?= =?us-ascii?Q?Rn0S8wDFmxg1alBluZvFVbolQT01TQsSM9O3K75tPPX9g/u4/cK+eUwUYn7G?= =?us-ascii?Q?3hOoVa4pnoSHhO1V9xR+KhVnHouMjJRfLfcTV9pdGsfPNFtQzlPHC8Nfajrs?= =?us-ascii?Q?oQU42kVDUnYhjOFPNxMlo+rJ2YMohW8a6ChWnb7B0h9qY1fxdBdNP1VKBR4X?= =?us-ascii?Q?WgEnP3tsuR2izapkPfX+sKMT7zhyA4WyABpZglCG5BA728TgFsQsBZGdg14k?= =?us-ascii?Q?qZIQqYrya5toC+8L4CD+dRDhcjqiR7trXJmQaahLRnwQBPLG7Aclc/p5Tf3n?= =?us-ascii?Q?3Fx7EAa5zLFZibAnhhJaJwGaXdqXv72q85T69utQaB2jS/XTocxTyJcPjKcl?= =?us-ascii?Q?N6ybewJXHK2T/fvnjF5CCVoETKeIRrYKlMlSFWa1bb8hWP6nA2VLEMOl5ShY?= =?us-ascii?Q?DkQjPAJ9uiV0amADxFirBOLzR216Yq3W60mmxZy9Pm5fEuaQFGhVPxuomnul?= =?us-ascii?Q?/rdF5rbMWQOcdsHRIxk4xVQc8JrSHJL5bx5IirTFQzZNnabPIOxwn4E86iq+?= =?us-ascii?Q?NubHPVwVfL15oW3fNxphSOo=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aebddacf-a12a-4861-2308-08d9afffc142 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2021 10:38:44.2000 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vNn1XF0Ecg9DcQYpK2v8/BFhTVR0obuhCeBGISIpR2zO57VxTvlBWlL+2z4wNuN0la7qy2OXXEFmvkqU6HPSBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5392 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Thomas Monjalon > 25/11/2021 07:16, michaelba@nvidia.com: > > From: Michael Baum > > > > The mlx5_args function reads the devargs and checks if they are valid > > for this driver and if not it returns an error. > > > > This was normal behavior as long as all the devargs come to this > > driver, but since it is possible to run several drivers together, the > > function may return an error for another driver's devarg even though > > it is completely valid. > > In addition the function does not allow the user to know which of the > > devargs he sent is incorrect, but returns an error without printing > > the unknown devarg. > > > > This patch eliminates the error return in the case of an unknown > > devarg, and prints a warning for each such devarg specifically. > > > > Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library") > > Cc: stable@dpdk.org > > > > Signed-off-by: Michael Baum > > Acked-by: Matan Azrad > > --- > > drivers/net/mlx5/mlx5.c | 68 > > ++++++----------------------------------- > > 1 file changed, 9 insertions(+), 59 deletions(-) >=20 > It is quite a big patch. > How well it has been tested? It was tested carefully to see that devargs affect the actual configuration= and also to allow running !net classes devargs with the net class. > How critical it is to have in 21.11? CRYPTO class cannot run with NET\ETH on the same device. No significant risk here; I suggest taking.