From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFAD2A0548; Sun, 9 May 2021 16:23:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85B8640140; Sun, 9 May 2021 16:23:47 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2081.outbound.protection.outlook.com [40.107.237.81]) by mails.dpdk.org (Postfix) with ESMTP id C149E4003E for ; Sun, 9 May 2021 16:23:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KqvR+U+lSqp0y5AhyMs/YDaIru1qvdwqep9XPNrEfJ4hlaGsR3WmmO1Cmy9cnL5LFxsZaI/xXThHwMexusFRUUZT4WLeOgbLJ6+sntT/+2WJy1Fb/fFdAN2XPt90KOY5yzQCUnm7Jyd9XcFPz9yn4PGeVELxUn2+QQMHKbQjh5Rv/0hwlb5TRTy/KS3whr7u8B9y5tVLDcltsev1dCiXyppdWKZgK6l0Kgwhpquh1T+i1PYger0XX5REXEM+4ewjNeVZjoqbQR49xDcTk65BITtjKl+U5+tkBI5oTim7x4mcvLnbbtv53VKb8uzUfmRjSqsFUq8aXDRx/8dCj3NROA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1ym69ml9qBW6QBmioxH1uv3byFPvSiYd4n0X++ycT2I=; b=Bhb52TFdao+C3zWLGmQkJ3oCLBmeO3mx+rVJiCOPdqzE5SRr3x+D+Tu1PKPA9QDfFkKTOlp8PYMF54+SWrAeXN2W4LcOTpPq5NTBLLkf7lSjzHKGXrrjBiKjAu72kQw0c5/aZ3M+vmU74oSQfXTC/IcL20LU8Xrixd80lrR/+4e5tMEj+wAHyGQvGtaMupOZPgwvOIL09yTIuDJBsnXhNRjC2XFAkdJ3XfuFTyh/2hAhcNaL9oqtexqb5kqOMeIAfh46ekOOFTrbaEl1kjnT23IAGvL9XiZyRTF6fhyUUQGC0ng0SaRZZ0mDqPE9CfLeOKn1C21xkfzrG5Fv2x4N6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1ym69ml9qBW6QBmioxH1uv3byFPvSiYd4n0X++ycT2I=; b=omT8bRkoi8ISeht2bMq6mnGaR7wZnru9ydX+tKGNyJ/hvE7TuhJP7oxJ2mJPddpLhp/aDGOW5mWwDefkGD4XaEZUfEcYaIznZqp4L0l/qG44AB7T/qST3EAmGCN1h5ABvmxmKU9KLalhLAEXUoJ4jorzNrG5e+2eBfT/bu/RHPgJoJOpvKIONMBDqDx2+vOuo79aSrcug+plCUejfhSDnoShlZ1u4Z4LEh8LV2l7kD8VFs3euTvJK5y3QpSNMdajucmd9cpQgmbqdgOAxP4f36AUynXdv0IM9VIHyEIAwWpBfi+Fe1HZPMNkMkeM+CPw/xt+bOrSijR4VbdqJQcgHA== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5230.namprd12.prod.outlook.com (2603:10b6:5:399::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Sun, 9 May 2021 14:23:44 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.031; Sun, 9 May 2021 14:23:44 +0000 From: Matan Azrad To: Akhil Goyal , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon Thread-Topic: [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument Thread-Index: AQHXQSnSPX12ALWtTU2ZgSHu5s6FNarZibiAgAFLZ/CAABDwgIAAVRsA Date: Sun, 9 May 2021 14:23:44 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-11-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [79.179.26.253] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f31c324c-ec1c-4833-e2a4-08d912f60d6e x-ms-traffictypediagnostic: DM4PR12MB5230: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:576; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U79R9OUD+0ui4jx9PL5e8UgE2F15P7brUwXH3T8c7KWUCA9JjyiyWZw5JyINPWyR7fjw2Xalpxr5ZfOrYM0mZ6hMdi4xheckjJoQPTRbrZJImrZM+aKn0ycD1h1UWtBklth68jO77EvxXdBIsFMVuIIRgS79QPsCIXRM7HBoixMALJHBNjMlqaZUaPX/QNSfTjWcgyRS/XbWVlRGkhc00XM9a+hcyQYYiGBlgTW/VKYxOdubXl4c2sZr7xRFVqps1MyhIkSxZxEPxcLHI+ah6ZfcBdWz86HiKRzw0tLVxdGOLax/UdLJ1YzEPtnYO8xwIauIaK9yeRSoZrl+mHKD8PDWCbD5ypoojVl9uKk0eZvsrM2r4vp917luPc6SXrxjQugj5JmDAwS60Afwwpfn9nivO3LFN0Y0wN0jn2XENV2SEzz5hTOpUqjfPjXW6C+9SIPdaEywrGZcOY859EFjtIh0aGFe8N5Zlf+Y2kcKbtbVEZVBYnIQOAaMLHKHgJxLSmczWX53YIJxd6qyxEpt/wuXPsnNqV9MvAJ8G+VFKeST3RTPjfVNq+G/mVijKbhfeqr1jxNPt9XYJh1CfATQuqM5L/Ocx+7w4z13TSSM5v8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(186003)(8676002)(54906003)(66556008)(71200400001)(66476007)(64756008)(66946007)(66446008)(316002)(86362001)(7696005)(478600001)(76116006)(110136005)(83380400001)(8936002)(52536014)(38100700002)(26005)(9686003)(55016002)(6506007)(122000001)(5660300002)(33656002)(2906002)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?kKVGKratninbRwyWb3onmE8aHiGgiv8BA+HkbLxzJWOKmUtffCIbQbSXidoi?= =?us-ascii?Q?7BiK7krxAq6n6GE9XAVb/3+dK/oc573UGi+WYgQGyRzFZh/bMQ+El0fByGYA?= =?us-ascii?Q?WjiHLP1IuIliFTQaxvxHEe1CVoKMUZ/V4Oy2NNYEegrwW7ilXFB8u5VyKIVT?= =?us-ascii?Q?4UxZkkl//vVBG1dEJ5xdrlsSciXRxMRqSDny9d9vxbOSd20bwHKsLX+IpWob?= =?us-ascii?Q?qM/WaPVWzK85N23WqqXa+ZhfhvLE9YLxJx8iAiyFvSrRuQ+dfIrY6vNCrVrE?= =?us-ascii?Q?M2cq3rNkW9L6K8pl+RBZ/ytpKxEsm/AAMI/b8UwXxTv8vZ4mH/hgI1udpU9e?= =?us-ascii?Q?CsIF10kVcMclNJcc7aiw8rdVY5iatF0pZ58zuEUFx742TODLEh7rXMhh1VUx?= =?us-ascii?Q?j/qY6GnIyN2SqApjQvWxNdanv75TLlVVM8+owqaW+Rn+dBU2suP86NnC7HtE?= =?us-ascii?Q?RPXeRwDVtxya/Gq6HUky6F1Lva5VkX2af/pSeWdLw1HAxnjXKEthKRQjlh/L?= =?us-ascii?Q?XEXRcO9aE34C/hQmvrlmAEa7zkQgrquwSvqgRSWgIt++OwX5hbdiLW8DrTW5?= =?us-ascii?Q?k3r8Mwl3bQCkgNjc18MMazyE0v3bvhKBXJoPYb+AAxbcIfGerFyel1ZdGr/d?= =?us-ascii?Q?yNnWxlAIXq7Voy3dlu9Ad4oVaqz7fapeneAwTeiGFQMlV67HmFL1Qvgqxm61?= =?us-ascii?Q?nhZJR2pon0kMtXeT7/8Mtps3SVYDDokr8CacGaMXG3anC7Z/BOaB66Oj77f3?= =?us-ascii?Q?krEgxljuR7AsDKwEZKeAYzFqdW9oF49H6zcrN1t3KBppvjEd+YsoL3BfWDYf?= =?us-ascii?Q?rg2eGVDQFk12VplcxhFN7Xszb9kicySZGeNYoSWdSVkyAUZyh/jKSMwHO+HX?= =?us-ascii?Q?D/5YFaB2cLGUj7FXcbmdQjcWalIcT0kCz5sTg5nduVDn7VZtEQTBxEV7n7ml?= =?us-ascii?Q?uSmVrDYtwDEiqJ+D3KeV7IX4NslqOdoCHmmbp7TrXBhIZlJxdCxmBt8WTjoV?= =?us-ascii?Q?dJSIcoHR8zO4pDwo6QzznQHuYxCp7hGgWRHwJXShOC9QBxntmJiNuoZQBlMb?= =?us-ascii?Q?xJ6po6KP1zxq5g1E/WfEbwihx5IuBrlidZHThRdCNqmt40dCLPNnNDtcHKet?= =?us-ascii?Q?w0o1oD/BKBPGqMOLFr/0ziSXXpTWn0LvMXSAOyukctWvBtEDPvpkauuBBm4w?= =?us-ascii?Q?wbVnsCwmYldn1jylgK1XpaVIlKadQ3EtLH7SiQd8K2k1h4talJVIfEtikz14?= =?us-ascii?Q?esrk/wmkMvtCcTd+kPx0873o65ML3ezVDoVvyOQXZ2Ia0yjsehm1NnB95l7K?= =?us-ascii?Q?B9wl+YVDG+AJ7eD/LiYE+lF8?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f31c324c-ec1c-4833-e2a4-08d912f60d6e X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2021 14:23:44.4897 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5YQU2xMhuwmoHPpNH37j2laVUniqmvvANewkcTYX5qXgasmZ+zjf5AJiJS6k9URtP/6QpkG0sxJY0dNO09b+aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5230 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Akhil Goyal > > From: Akhil Goyal > > > > From: Suanming Mou > > > > > > > > A keytag is a piece of data encrypted together with a DEK. > > > > > > > > When a DEK is referenced by an MKEY.bsf through its index, the > > > > keytag is also supplied in the BSF as plaintext. The HW will > > > > decrypt the DEK (and the attached keytag) and will fail the > > > > operation if the keytags don't match. > > > > > > > > This commit adds the configuration of the keytag with devargs. > > > > > > > > Signed-off-by: Suanming Mou > > > > Signed-off-by: Matan Azrad > > > > --- > > > Documentation for devargs should be part of this patch. > > > Please split the last patch accordingly. > > > > > > Title can be shortened to > > > Crypto/mlx5: add keytag devarg > > > > > > Fix other patches of devargs accordingly. > > > > As I said before, no devargs is really active before adding datapath pa= tches. > > The option to add all the supported features \ documentations in the > > patch which actually adds the support is correct. > > > > The last patch adds the capabilities and docs when all of them are > > really supported. > > > In that case split the patches in such a manner that data path is added B= efore > devargs patch with some dummy values and add the devargs with > Appropriate documentation update in a later patch. No, data-path must know all the devargs in advance, it cannot work well wit= hout them.