From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57706A0C3F; Wed, 12 May 2021 07:53:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7A704003F; Wed, 12 May 2021 07:53:19 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2056.outbound.protection.outlook.com [40.107.96.56]) by mails.dpdk.org (Postfix) with ESMTP id E87A54003E for ; Wed, 12 May 2021 07:53:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aU+bVJK7sDZT6AU1MnQadCmAevHFY8I1pQNI3gosUIKJ1UHEeTmUzi7zHkpQEMpEbaG5llmX5Ifkq2c02teaPQTDrNDWi0SQr6l4+u8KdFQ9gy9oo+JctB7r2GuYU+OwEL8P/FVFplUBV0+8L6PPAmW62L+O9w83kCMGZ88NeYSwrXtA+D9G3c8nRkNJuLTfy2cM5/eYSzGyaC9rA1emRo4uJ6sRMjqdRjk1wCVkN3zqSzxFUxBTNzBcl1i+p8rjZOlUT5P+0qxUF5w60ktmfDXur5zYAyCDXDHiGjhKi0Ob0yyTqGjuYvyjTx2ZNBabniemVSqyKmT7TeDiKH039w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WKLpNy2f/4hQZ+8GFQ5vbwFgAvH+PgBhNyPY+KA6v1o=; b=kQaHhb6X0rs7qqwcziEkSM5i2uyhSQLx4q7IYPKHj/WXaH4uF3zAzW8D2MYs50Ew/EmaaVZczc0XrB8tf/WQ2hq9C+BuTAaiTPzk9cGRxYM9nP1yizjsOI9s87zsc5bnIL3ZFzK9SyFHfwK9L7RSgaAXJj8yZhZrloIkp1C7lh9wrC3H+gfGOHJ5b8X08X5zaVlJTmCY/ysjbjZ5Tf3X4N30BtclYpFJybCPTBndxRWfZwJC2xpxi97v0JoSrcLeeHm3CzlTAT8OVZRnO7tcDdFsuVr7X0NjPOS+i6hqV2uQMOgdOxwQAQxyUZRw0v+wbzQRhNFkysGbMQULFD7PMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WKLpNy2f/4hQZ+8GFQ5vbwFgAvH+PgBhNyPY+KA6v1o=; b=nXvBGoB5XjL77GRYz+VBcjJcMgY1MyKZ3b6N6tdZeYNFqoEs3oPmd7hPmIX9NCz+R/0/vnIwhQlVxS7PM2hZ69g98T3Nw7+0ONLrg14R9KP1jgrE1UpA1VH1aplAkODU1blXEAuwjQLaClS7cJzbj1rf2AW+O0uvWBEKGeQ8JrUT8mhrPuzWeXpo1uJthnsSo0wWsUPgnskNbhY0CczqCno9TtVO6J70cfqIBigsCYzJ2TWLGyTKh8gW6k7kmM0AdOX5T+anZ0aWqKFsY861RE993ZZGGQww4+pU3hD2uOQJd+s/DP//Z6iBy3yxrlh5gdYRTNBnQHjZG6RFdtwvJA== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5136.namprd12.prod.outlook.com (2603:10b6:5:393::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Wed, 12 May 2021 05:53:16 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.031; Wed, 12 May 2021 05:53:16 +0000 From: Matan Azrad To: Akhil Goyal , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API Thread-Index: AQHXQSnP8YRys76jrE+A2XkRErsVIqrZiLwAgAFIw6CAABT+gIAAVQrggANaDwCAAM3KUA== Date: Wed, 12 May 2021 05:53:16 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-10-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [79.179.12.22] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b45102c8-81f8-4808-cf28-08d9150a3ce1 x-ms-traffictypediagnostic: DM4PR12MB5136: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Kxudx7DNmXCLCxtC8FpP8rMVP9a3dV8DBzS+oJISx0L+CPpE8RnKlMfe+4z7IvYoRXhGVZE7eLZxLu7WKhppjkO+tk4ueQic509fHO6lOHh6Qo82CRJiyJZi+AM5J0l1uKVjJy9w1rm2oT4TdPqpMHfsAqZx4dMbN9bFrHjE5e8FahnmaGzvOZMCDx7OBNUdXaCiSjkj6dNt275aB5ryBrqJYEA7iEwG/AqnAOxQ+W19SB+Mzu+/S+r7+Mw+TXDFT6OV38wRKEQjrbzsP979vm5o8n6fIAa1BKmeCF/ayTmTp1OyCIOlB3Y6Z9neEidvhVFhV9a0Dq29msUWAGfAzAlFlDhTHsKYRN/a6GKxImXIR8Be8QLXXvOKPA4VJmgCH5q+DDYWdOn3F3S2yrEiTKPRXor1XBz6mIsI5xrhuR4P3aSl7e31P577MFMr0Fq1X9jjm9TSyEabzSGQ6fMnctHqESSdodv5ulgj1veo4V3HwrNXo1JEspFN0dg9Vyl+A2pZpLr59lYETNE8M2e0yBLOkxwe63ri+fCcaps8rkz0y30bYsw2PH2gtBj1IuGQFZI4p/uSAcQWrx/AHCAIT5VqGMwpEWS8DywJaCWLTUM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(136003)(396003)(346002)(376002)(66946007)(5660300002)(86362001)(9686003)(55016002)(38100700002)(122000001)(26005)(66476007)(66556008)(52536014)(76116006)(64756008)(66446008)(7696005)(8936002)(2906002)(107886003)(478600001)(4326008)(186003)(6506007)(71200400001)(33656002)(54906003)(110136005)(8676002)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?X9hGL/3sI9V/Ml1CGMhnHAgoz9qlI1PE0/sUJhpRFOIL5L7+0j0JrkpYTdxE?= =?us-ascii?Q?rSvNOh/9HHhuAf1AZOIFDYOcqpQ8Bz0jOdyRPe6XPlSp+/ku2M/l/N9KAF6R?= =?us-ascii?Q?qItB7ndLdYWGzmIJdW0xercOEFmmSb91yuiZnwJ4sKQOsT7pM1O0M+wiDv/F?= =?us-ascii?Q?laCdFscg1Gjd6F+p9eJzBh2f0LwmaGMBaHPgw2a4WiB8XH+cjzLEjwb/vgXw?= =?us-ascii?Q?IodQOXMCfYG9SMCYA6Dn+svP6yDFXql1j4D7LQhGBJWj2ECpvtxcTkndlypC?= =?us-ascii?Q?VTQdwg1muedEYHsoIh1nIzaYP+GM4znpj+qlVN3+poQTWugmiV3gnjFd89WW?= =?us-ascii?Q?UlQXClHeWfg3HygOrr/SdueFmkgzYyQf+GJDYvQnUIYT76mklbjpD82nHq0N?= =?us-ascii?Q?sG3pJqql0Q2QSebOAhQFs9xWxtmcEt4X6KWrIqxA8/sBO760QtLWSLtenuYX?= =?us-ascii?Q?TMZGyccfHq6ln1OpZRDuPYeQ1IkGmR8LusDA1L7ZILDeNt8BA432zb9liEaG?= =?us-ascii?Q?Cf5bdEG8VxfMehOFVKnjSz5gxYZZOkDwzULk7PEH0OYR+8ZG9mS8Bbn08q7e?= =?us-ascii?Q?CT3UrolBVD2mGVGHAMYQFx1RvRCfdLZKoVQg3UJPt9CXjWpTIJR5iQSutKBe?= =?us-ascii?Q?Wc+ICOEpXIE4zm9nR05Xp9rXwWosvFydqKNes7h7VAz3APW2euExni8+rpuk?= =?us-ascii?Q?/Lp7YvawmxIUcF82BH1iax0VS6Qy50tSXab8qk4kyqo8T9JjouF801Gzd9rF?= =?us-ascii?Q?DjEjN3s4hr036N0RSEBbrwZnYWjBUJQOP3OQiDIR1whLY7oeEYdy5KUTtpKY?= =?us-ascii?Q?r3I5lQ9mI9xUQH6wPsuG3RAHmkfTD9OpnrZMEbjJOXm4hrq3/bLpx+2ouH7S?= =?us-ascii?Q?0qxcSP5NNASkVkv3CKfS1obwTgIr5uCM0O3vHOGCq8qXZugZKd9R5lWAZzdw?= =?us-ascii?Q?W/zRuvQEr1i3nxUjiebsoON5DzBka1MRknwCbFlmGXgLrhPV7qlRZIFCrFJf?= =?us-ascii?Q?jqry6qF4+/bXPNl8Swkiz0UZL7m89VJqARxFBAsga0iABLVTWBD6zXrBlhNu?= =?us-ascii?Q?MNxgu2u3tc3xQLw5Ny6oW/sVdP2c/j4/pMf4V12c1PAgrt5lCEO00QBcNQrp?= =?us-ascii?Q?aO/sy8u/mSRlSd7DrLBaTawc8Uw8y37G/+bBUFZ61mx6/zkVDDARJ5Jvzt9E?= =?us-ascii?Q?eWsPeQ+KGJq12JiURRARUMUhGK8F3LJo+quBStX/4q6MPon7z1rIR1cscRAE?= =?us-ascii?Q?x08eB3PdCmjdFO+8gpssvHhFNsN5PDW/PZ3n1JsNQ6lgLD5f4CUKpfO8jFx0?= =?us-ascii?Q?ysU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b45102c8-81f8-4808-cf28-08d9150a3ce1 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2021 05:53:16.3251 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F4mP2Y7wNCxJdQRameQa7EkQqdHAdDh/5n9ENAo9GpgtGHV+Ig5fsehNMEWubvwWX9EJ6zNrH8Y2Ufe4qhR/4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5136 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Akhil Goyal > > > > > Also set feature flag in the code and the documentation in this p= atch. > > > > > I see that you are setting all of them in a single patch in the e= nd. > > > > > This is not correct. It should be added where the feature is supp= orted. > > > > > Please fix this for all the feature flags. > > > > > > > > No, in this stage no feature is really supported, the actual time > > > > it will be supported is after the datapath patches and capabilities= set. > > > > > > > Move the patch after adding data path, but documentation should be > > > part > > Of > > > this patch. > > > > I will squash this patch to the session commit. >=20 > I am not asking you to squash the patch to the session commit. > The point is documentation patch should be part of code patch which > Introduced that feature. This methodology has been discussed in the past > and is being followed now. Please discuss this in techboard in case of > deviation. Not sure this is mandatory when you add a new PMD. For sure you right in general. Anyway, the session commit is the better place to this code. =20 > Regards, > Akhil