From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77E85A0C3F; Wed, 12 May 2021 07:32:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E498E4003F; Wed, 12 May 2021 07:32:02 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2043.outbound.protection.outlook.com [40.107.223.43]) by mails.dpdk.org (Postfix) with ESMTP id 8B4A14003E for ; Wed, 12 May 2021 07:32:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VNddXtuNHeMs/eaxZJAZgnnsFXFjaZx0Dimty2Mp1izHZOokwWpuO+m2H3VW+Xwd+wL9E2KmFCUGz9ptCWZrYo9hpXojux73xZKvQ3lasEtRJZnkERuSKjyYrp223iHTjnQ7pZVAU10ERtnQq0QY0eq7e61ezLLhzZ/OvAxECU9IKA9JsisGYM7WwmTklIuGhi1+hiELEbqLST3ic/f+esrdbQ9a+eWXaobFjGWE0hC+nZdfqOrMLjjHbn4+JIvAXzZuVylnrHGDskXe6FawQz4q6gUCH8yCsdLO7GgcosQiz8/v9pj7m5Oq25sVrR+V8ogcuQWiopPM2VwHByZ3bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EWkar0jCAzPdXdEEzgXhLr2kMyHg/HQQtl+R8mE5syo=; b=AAQKOBfBHbFjxJs4Jh9ZD3z3oRPeIpyB9tBWp4g/xuNb+fDsaE7pusAehNaXOwpWSKWmgyMSR07rAj/OFMZCPW+gKN5I8uDzYXLOR2dJZjJqr3js6Twro1lEV3inZWsav3/v0y7qYGi+rnE5LKUvMIU5BmP05vKX17mM/jdAFcZ+DPObYuJS3v9+3QUMhFok2mo7v1ToAx3NnO9w9jj5RJorUS/42I9V/zM0atpy9AuiwZggKoTliV7SpdoAqoo53wnrgVxd0Mp8Lrnmm86oSOd6PC7C3nhyTV4eXaT7h6d9hh7hHTgGheSAdc8HKsOuiwJsvooR0tzfwkzbOKYa6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EWkar0jCAzPdXdEEzgXhLr2kMyHg/HQQtl+R8mE5syo=; b=QZ55LolaLBBDUvRoZb0HDF+ApQ1C7Kkli4wOk+++AmcCUxflOH/kaBlemOGtc6PbKfyNttubQQyIH+BxIFraplOzAzNTZVdUFiyiydpoXOLSeX63CKJ5WdmcFgF/qZtpVkmFEVYpS7PUt63QdE+y8FulmqOxnZlhkCEvA/WDQUerpsS+fz+tqdAQQi39feGpkcQHh6n1EW4f5AUwGSmWM0o9aSEwtDH8NxSl7agqVla7T0JJxCNDwMWhLVBhOdW8PnbgRjmx2lA21xFPZoNJW0ItDQ8v0t6wh8P74hC1+8F42m6HbNGhWrB/sO2NZtIvza+lMa3wc3yQBa+NIknB2g== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5200.namprd12.prod.outlook.com (2603:10b6:5:397::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Wed, 12 May 2021 05:32:00 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.031; Wed, 12 May 2021 05:32:00 +0000 From: Matan Azrad To: Akhil Goyal , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD Thread-Index: AQHXQSnD6vYVcRj7jUOdKtk8oGg08KrZdOsAgAFWbCCAAB7dgIAAUa3AgANW3YCAAMgFoA== Date: Wed, 12 May 2021 05:32:00 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-2-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [79.179.12.22] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 242e463f-053a-44f0-6945-08d91507446f x-ms-traffictypediagnostic: DM4PR12MB5200: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: R/owhHuk4npC+azUn+sfj0+rHaXPP5je/Z68V7S8ofDuevvqwpiF75UcLrLyplBnnKb+yvUpnfx/Jjb3EXXCxYKihz+bsRAidzZMF3zV8Yu+sXNCpzi16xarx/nZsnPJ1eYcfvbcHmGRVlcUpATfc6UJsuQYWs8QkG5roTMdjgHYiip03mhD797yEo4YKmSaJ7pkVAJx2Wk/vmGjT055G8nh0eDOagL7ku0htm6j6oR+P3b38ghxlVGM3Guz31LE6sgCjTbp9flLP/114y/+nYcy7upFXGoOmgxVkIxPbN7wKr7DdhSD4z+4j+UnTYba7Mpy5efqMCVWwbcqkrnW+qQER5UJnSuGwHLtgWnw+MQceyCCVrrQdOw0n9KZbbH/KrJ05wDlA7p06gOBpLoPaGg5hDdze6LR2s9uV+gT0lsam+M7ud3gVW0SmyIRqj7mVXjbxn8/kH7bZfMuQZpc2SesVvbzF16o0izAmJKpHwT1lepdjPtvwH8Z4LP/hgVnW4vWZsq5bKWD8eeT4XGhcOEuChbNfJJf1s+XNquRBCxtrVVb+K0YMA+DYEexOJ/u60+el34L9ZQWfF8Krww0PBtTfQlitrPC3p7oj+XTx7g= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(136003)(376002)(366004)(346002)(316002)(8936002)(5660300002)(186003)(54906003)(107886003)(2906002)(86362001)(110136005)(55016002)(33656002)(4744005)(9686003)(26005)(52536014)(66946007)(71200400001)(6506007)(7696005)(66446008)(66556008)(66476007)(64756008)(76116006)(122000001)(83380400001)(8676002)(478600001)(4326008)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?uyrfXW3U8bUMjuUd+DnEEhYh7pZfsfSRTyKJZyyqx5bk32SWsRZVONHcSh7O?= =?us-ascii?Q?rBuMylI/T76LAhKg3vox/2f5lLRWyAZ8aQooXSaELh8hGURD5j35G1KWxr4x?= =?us-ascii?Q?lub3z5NBvnhk4v0SteirWiWzJ3VPZ+GdJlRuAL3LBUwc4KWvXmikSNgmAo0e?= =?us-ascii?Q?Se1HUFQFmF9+8jP5NMhPePDtqceodGFv5c0AEXWnJL3yvJI/HHyyJIdtSUUo?= =?us-ascii?Q?bg7UH0eUjySTjTeR+j0pz626xZ7iRx5Lrk6paRgfx65lf3uc0vOG5UOzrf5u?= =?us-ascii?Q?u1c2/BiE9hgtb8WvvoKyeSxxUlwTC+VHrMA90VnRBOytx4z3IZxt2ZPrAX/O?= =?us-ascii?Q?t+Bx6c5PJHb0BR9/FMmQ47jaWPIwx5Mmr76Z7ZWrtGqqDB3xQjRtyTodoN9Z?= =?us-ascii?Q?REvpaEpBWPhvdHKeZbvfuxjFE5bYBsJPi99iVWezyc0+BOM7NmS0M2BDzm3T?= =?us-ascii?Q?6+oLqqpMzb1zPcEIHQtYy9H3xUqREfHQWAnqG9tlayCCpBiZh7MJnLYf88ox?= =?us-ascii?Q?VyCwiF637Avg7/fL4j17L5BdBpuXcPMvZ3aG9mF149z2OvtX6h1cSfWcPMQq?= =?us-ascii?Q?qKV55QRO0vSU9DrEPcd3niWdiFi3RKtsN2Is89FgbbLs9mxUQQsQQgp4MYmM?= =?us-ascii?Q?Xwg6xMSl+qsu0mulCPR/cCNaAkCV1/RjCG7svMzBB36xMOPYWAutJWMJc2rz?= =?us-ascii?Q?GpvW/j8vAzxgUtSZyp7naO8W4inFd0Z+tjvBBg92iL9q9f6VnQR+0PW2b0Y0?= =?us-ascii?Q?X0b2V8PoLYWrOl8xN+giPwc/QIEQGgzb1T53nCF3NBSoy4ATIkO7PIS/PZcG?= =?us-ascii?Q?EH9huoFnhzQubWHgVk/1IkGEw9t1zjB9p8JN3ed4F+sSRdVDsUHkl7yusi7E?= =?us-ascii?Q?YgEcznj6MJe8Ivor/a4Vbu4vePIWGpVD2h2YBYKw/D/u2OBV/zsn8n3y/NSg?= =?us-ascii?Q?ib3ZKl4WZaP2pgnRAeRlgndppxjDP7LG9mf9cbbWB5JqyrxnYiToLfnq2PSJ?= =?us-ascii?Q?f1h0xz/KjOV1yKaqXEzNJkKvjSh8js/CegdBMMYOjMdpPolXh03eYu5eOD/B?= =?us-ascii?Q?3xC04kraGAsfFCq/Ck2k8uNv5OVtBsqXke8e63mJSW8yif2TcpG0YSeAxDgj?= =?us-ascii?Q?QaEKUjeWw59WCs8VwOBSTh2tPM12CzRJiGwlDcFg6ONNgsIwKwLIQQQFutnv?= =?us-ascii?Q?HSpqC32H5SWsTKHveCnKRkJFF31aJW9xi/Jec8mO6mnEKwOgELZ9HsjrtSOt?= =?us-ascii?Q?8K8SaNl+Wq/rNEj4ztzUi/nA3psbaVpl0B2DaIi7Nv4XuDs56bpfaDpZwMeD?= =?us-ascii?Q?axE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 242e463f-053a-44f0-6945-08d91507446f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2021 05:32:00.5079 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Exyqe1ZpydJJ8HxJ3F3Twz0f+eizTiXzY3LpAzPInNHVj2wzYdOwzLQBzuTKE9HSudkeQJmeDnQcnyAbmVSEgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5200 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Akhil Goyal > > > > > > +fmt_name =3D 'mlx5_crypto' > > > > > > +deps +=3D ['common_mlx5', 'eal', 'cryptodev'] > > > > > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > > > > > See RTE_LOG_REGISTER. > > > > > > Compilation works fine even after removing this dependency. > > > I believe it is internally managed in cryptodev. > > > > Yes, but it is better to add the libs we use directly. > > > Please remove eal so that it is consistent with other PMDs I don't understand why you don't give a claim to explain why not to add lib= s the PMD accesses directly. One day when other dependency will remove the direct dependency, it may be = problematic. Because I see you strongly insist on it and this is tiny I will remove.=20