From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58581A0C4B; Thu, 25 Nov 2021 09:11:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D61E40DFD; Thu, 25 Nov 2021 09:11:17 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2070.outbound.protection.outlook.com [40.107.93.70]) by mails.dpdk.org (Postfix) with ESMTP id 960A840DF5; Thu, 25 Nov 2021 09:11:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SnbRcZpI2irKcb7VFrNygE8ppYZecy5A1IvlDCV2+Poiohnkxt7Lcs8L72GWJeLAZyd6kqOr31eCOVwbzbYr4W/sq+ECdZWQZeSkDTb3TWbME8c8v8CZb7yR0C/BE5DQg+Duz3wVTm56xFm5a4VT/6Eec4Y0PquwUaqHxeLtUbrFKLHVBEFvGh4qpxyi5fMRKmAL3Mat9yEkiAXnmWVRLhq3f9nB0hosFgkua/WV2k67B+7j+f2ZFG6mNZYL6xoi9BdUogWrfqPTXW3MOV9kAxbwX44DKEtHngPPNOxgqIRmFFV3RLEoEOartNafB75Mtoa6chPQ+W0Bdzbmf1FK/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4J21LJjvfKiTvAw+G1lWZbfm1jQ29QYwvNLtXUXb5vg=; b=NZrbCKx3nYdJw14YLoA7xSCGCrTAA8oQWkSeL+gLC7BlT1vwP1x0Pjpgv4/KTA+5NhCuqsw9l0sAx12zlHWBu78dJO0mBdx+4Sa6gE8Xz4M6ytLACmTOvHI5PBmPVrAqbfM9AeYP13GGomuUHbBzbZzdwBEMWAYmfHDvZ0+QcPzebz2iHPJnhnjdNDlVRg0ZArsvlyBQKTY2swCMKFUw4CWJ1NuE2u9rCsYXpzow9wSt33AJFyRyDcwgDOLiCHbr8vEEF0qUPXHJ+Y/xBlxsTE8fMH/H4U8IVi9F904pfMT1zR95ff2H+wgXEExIFTHR4iin1xodAv2yFnA+6KKRUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4J21LJjvfKiTvAw+G1lWZbfm1jQ29QYwvNLtXUXb5vg=; b=hact5UzW+tEQ71QZzg3qWxTYIak05M8lezcRR9HaSHemf7oKslLoRNpuN3X7h2z2LdoufyEfeBRugKpE+e0sb2qWMD//JgR35tnLfYi8M74Wma9aoWbUA8hAjHRm4Y19qPpMsX3C8FtWzZImZ5yBJHffKW76mPZvQExzauYUai6IZvjuZwYkAafQHbNZvdpegtLtPwjjRA+7XP7bXc/oPMbe6fiqD9XH+M79COy1U//eLrge0MWTQURAcwT/nXTiW47PgvoGwrHW43qj/uXinDjdBNYJN3+L8LFVRlVmshmhQ94OBDU9S8qHfXPyMLenWabZNXp5cp8ryeT+PBytAQ== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5167.namprd12.prod.outlook.com (2603:10b6:5:396::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24; Thu, 25 Nov 2021 08:11:14 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::2171:cddf:7b43:3778]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::2171:cddf:7b43:3778%6]) with mapi id 15.20.4713.025; Thu, 25 Nov 2021 08:11:14 +0000 From: Matan Azrad To: Michael Baum , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH] compress/mlx5: fix double close for context device Thread-Topic: [PATCH] compress/mlx5: fix double close for context device Thread-Index: AQHX4c2T2kF0+LYOU0etfMlxxepHTKwT5EOw Date: Thu, 25 Nov 2021 08:11:14 +0000 Message-ID: References: <20211125072445.3146615-1-michaelba@nvidia.com> In-Reply-To: <20211125072445.3146615-1-michaelba@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 141d75d2-d7ac-42d8-9b32-08d9afeb2670 x-ms-traffictypediagnostic: DM4PR12MB5167: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8lJdMTAlTySb7t4nSM0WSJTk7u+1y5Q/fyW240OHZO/1TxVPsLCSprhAkC+dEanBnA6ULyrK1MqAcSIb0TwadeOhC/hp7yIuy68Z//jQO2C+h/kHmCvU7z51dqXWmOImELiJ0EMCm2lyvaEr7lKuzy7NmE4ML4csGGgjun60Jn9KHWnGR0vXnR1D4+j9x11vxABaXD/lUBaPP6GcE2TCM6HmiJEdG/nXxy6Bq5u9Pi1ZVIcBW4yjxKRxXY5E8zu6cNUjOEGPT+KbnlHhwwgiggBDwa17UYTc418W/d0ARYCXu4IUCODrELNBxuK5r7LgAJJgULac9Ni3/K9mHb3gnRplMbO6Hzrdgm1tpOaBYr0UhvxzsYwVH708CsGDbJYOYOvd29iD1aJwHTiiyGStL6sVnvReWlpJRTgdSRdVWE4hLgfr2RlAn3t7bWHV/Cp6tzuRFMIAevohmkEYmDn1o22Fj/SHRXS+EvBcPrDYk0NgsDo9cpnngMFo9JoAhPZJGfRd6AmtdDEq1N8UbTm59uTUkqhkFoMjXQrWxE0mnKToMoWyyTEfpUS0dcvgb3SbMEf5pYz2r/XDybqt6tkis67Fw+n8brYg65wcpG5pz7smGN83yCybHmOTxgx8fi5eINyQK2dylHA++rDltPRKs56+jxkBc4beKplXmLPu6CsYndYUTokSQ28dIO/PfLJ+shX+phdVRIHmEUkmLzfbGw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(33656002)(26005)(38070700005)(66556008)(7696005)(83380400001)(316002)(4326008)(186003)(9686003)(66446008)(76116006)(55016003)(66946007)(38100700002)(66476007)(2906002)(86362001)(5660300002)(4744005)(122000001)(8676002)(52536014)(110136005)(508600001)(8936002)(450100002)(71200400001)(6506007)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9tK0sJ+hi1eJmhjJIYOMBvfluFCWP20GG+s1KVpuadlrWHys0ZwJNtAHU2EQ?= =?us-ascii?Q?ij3trB3BY9jhesS3wrxQccRmGJb9ouidv7hSHpqemGEGD/Ku7+xJTUQTYOeL?= =?us-ascii?Q?kFiN5L98fVn/VFiZtYdhM3GROP4VX3VNn8B5abJ9U622qS7XKyF2XbLbl51D?= =?us-ascii?Q?pavjx2tAfqj0Vu74cxcO5R0iessyS4cNfaYPGiGxmXzl9AJWTpocMTW8v6zS?= =?us-ascii?Q?rh1Xn8Haom8L0xR4kMm7a1Z+eg5KXIiGqo0qKWmp2C3ovFJB8CtncIb7LWjJ?= =?us-ascii?Q?MeJVOUciAOIRdb8Q4LgwL1qB4gBcnp9djOVzXcksvhOu5kjTjMKJqtX+vScl?= =?us-ascii?Q?odF/TQwkaobucEh6WSQS9e+8Gy8CRLBIZTdkMvyZOnOp/gVrfr47Xg5nbYxp?= =?us-ascii?Q?ZgAUNSmflbiYI4JT9/zpwPHKRq56WMCQyUZ9WXwofSIAikWPjKMQecA6RhLn?= =?us-ascii?Q?AZIQCcpYJG8rIARD/AOC3JBb29MDYc/JH5MNqNF3N61875xnxAbxSm/DB+Om?= =?us-ascii?Q?jdXlxBDe2zDQ/nI6FRjkcyyM8TM0w9AP3qJOoCGYJdUe3l9e6rQPYyilY6EB?= =?us-ascii?Q?YbAEMX4Q2BP8Gkb9jROmAnSU3qPgMTw1Z1k08Gl3YYaQ5ZGPkDn2hijv1kAd?= =?us-ascii?Q?8OtSXzShQhrtILqpKUJRFUp1R/+rNl08vRGNUEl57IFJFpuQg9F5DyINpiRg?= =?us-ascii?Q?OHNKaZI33BRATM16/3ljZ0pHqf++iLNaHCMu630/UWx4de0Gf9lFK1H/BhRD?= =?us-ascii?Q?gASbY6zd4k0V+h5xC58VCx6N3p/KHA+pNvCvih/cOTGjpxqo2TCq8+bQvgtS?= =?us-ascii?Q?GBSJN8oAn66A4ZwUhFqwTNDppfXAB8Jc7mAmlt5uLPWJUW3Pd7H8VTGI1unh?= =?us-ascii?Q?caFYpGK1Y2h4vwjnm/FQEG+bV2Z+HgZ0AzaM+XkRz52OueiDPHbwo/Flvf2i?= =?us-ascii?Q?DCyKIOhkj5IR7BtibyiRuSBszPQZWN7TcGZNEncekEJpqQPosg+JA31MUDyC?= =?us-ascii?Q?cKicXERfgp9d0emT4pajAT8UrKnVBjoamk8JNqUj9aE5SylJZ2NPvmKrLRDH?= =?us-ascii?Q?NFwT/93JAEaRj75IMoLEsg8iSCyHf6f8eAZ7Cn1BlisVDn3m7MqXbzyQ09D2?= =?us-ascii?Q?ONzdMibTDDKBvVxrWE6yS71uNnfPHFAArYDx833t/cLC3hhG0tJOP1H/qU7Y?= =?us-ascii?Q?t8iQDmkTrWvxpmxxd0IPuUmj4F4ErJP5m2QtrfGCOGAV08sUlxUviWVnsD+U?= =?us-ascii?Q?yX0oEPaVQFjPcV+GKDCljH6nZ+FnG3dEgfY7XKm164vEOK76MGKAU+0WcJqd?= =?us-ascii?Q?4xjsIY504Pzs6UEtYnvRZ8jQlXovBSTduEkQ9PQl4SshsuZvKiAug2SvslUR?= =?us-ascii?Q?RjIXPPXq3ZW9+o2oiHOK4LMFGK2w/ohDGduVPf9dHPLrGcBJJ+8Lz5yEFfUT?= =?us-ascii?Q?wrotxgmR45/xqmyFiuE6Lyt+JMZpy0eW6DipZdlyWFYmMzTzddUDhoTp3h2z?= =?us-ascii?Q?q5BFEJgr4FcTV0dqqA1LhaVP7dyLdYmeYSwQhDeccIUxuQGZH0WtDsz9yVfb?= =?us-ascii?Q?45HE9WSvSYrYlaOrz11QJXqTi1ssemXQDs7D3AXIf4yD9GN7tfs3kyg10EH1?= =?us-ascii?Q?J3stv0ahjD9QzfREhzmNCHg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 141d75d2-d7ac-42d8-9b32-08d9afeb2670 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2021 08:11:14.5600 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KBeF+Cf+Unl0s8l+cZhXXhkLdxvIC5GGddbCQ7wZjC/Ac9QlnBARr4nXywyh+ZDlHPKAKvNhiqHYat8tLb46cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5167 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Michael Baum > The context of the device opens once in the common probe and closes with > its removal. >=20 > If the probe of one of the drivers fails, it releases its resources and t= hen the > common closes the context. > But mistakenly in the compress probe, if ther isn't enough capabilities t= o > support compress operations, it closes the device and then common probe > closes it again. >=20 > Remove the redundent closing from compress probe. >=20 > Fixes: 2efd26544554 ("compress/mlx5: support partial transformation") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum Acked-by: Matan Azrad