From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA16BA0524; Thu, 6 May 2021 11:34:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5055F410DB; Thu, 6 May 2021 11:34:37 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2075.outbound.protection.outlook.com [40.107.236.75]) by mails.dpdk.org (Postfix) with ESMTP id AFF3540040 for ; Thu, 6 May 2021 11:34:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GXDmnEBTWIQbOsJpMDsjFosB62IH/R9kFGPA+aeK5FWLYnN516Jipl56Zml98MGGBoCvqmid9CxqTrOs0ccU9j23kAeMu6uBDeSKij0iHDai5e0YmmXBrrYTVZ1PxNPvImJbRMZE0Suc5chPL1jAbO4fTB3jBxPYBvqBEGPW2ezqx3pdivTqL+2n7Ynrzxc87nhJySSj8IRNU7dSQ9YxqyvoWVK5bvEl0VVq298fhMUzOaFAwyy+5sXteOA2wIYxq6dSvQoLGbz7y5/UX0KtSenH+LjgjcbU6Stnrii1gJn2P4NrkoBgtQj4ZEG0X+ieZF8jfJ85OO9bnT4YhiQn1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=peI784DcvFcUbofQVYPHk56ZHisGSPlUY8quldA7yfk=; b=O+lH3Seg8v9+A6XOixHb12nKac4pDvm8EK19zEha3MrKfGT5XMYkVvsyYUutytYTVWxQrnOXrRTToPjr64h0pdWVHoIGgRa+S5jTzDkfz5C4wRiLWmQdcC56l6R8RA+Vl4gbNJpNStkohVJ9bgsXsF2Tmmygd92lvJhlMVDu99C5LCDXvepliUucPsZPpParu0+I1eKHR0rwZpfn22qnLiIkY3F9a0Lg1h1wOdaAcO7YkVP/VAEC8O4ugfN9SGkjhVxLFKDgwWG1zJbK5f2EF/EWkPjJj+Tt93hCvAmqQpeD2NMad+eZuLmnHFpLfGmSs/FtLTLX3Bms1ZvkRtUcYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=peI784DcvFcUbofQVYPHk56ZHisGSPlUY8quldA7yfk=; b=Z1M8JDfC1nG0jr1QcRiR5aWxPElZqGv8VHGwUv8V/68Z/u426nKdaGmfZkl+BW8ssfCkW1YOH4/B24xmV6i97ns50zrJoRIKdigYMU8GY/TuD5mHCrLMClADHEIrUGi67sWqtDOrOkFGH7Z550KZHkOedBJU5/dQJcUjLf99440otzZnDRfO3WG/7ANS2uzvz8JrTYEhdgb/PNTsYQoEHXLJfzCMgYbVsl7dUYfsi9tsnHaNYeqsBf4wnfLMJvCTGzhFYHy6zaaG/98z59XaEzY/zjCZ6e9J9rERmZavKUKvY9vCMF2oevMv90YzPEc6NSdWQXKrCO3ahVfBGMiu2w== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.38; Thu, 6 May 2021 09:34:34 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.025; Thu, 6 May 2021 09:34:34 +0000 From: Matan Azrad To: Kamil Vojanec , "dev@dpdk.org" CC: "viktorin@cesnet.cz" , Shahaf Shuler , Slava Ovsiienko Thread-Topic: [PATCH] net/mlx5/linux: fix missing firmware version copying Thread-Index: AQHW+55X/rFdnHokkEiHlfZCQM+H5KrWvKhg Date: Thu, 6 May 2021 09:34:34 +0000 Message-ID: References: <20210205090045.12047-1-xvojan00@stud.fit.vutbr.cz> In-Reply-To: <20210205090045.12047-1-xvojan00@stud.fit.vutbr.cz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: stud.fit.vutbr.cz; dkim=none (message not signed) header.d=none;stud.fit.vutbr.cz; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [109.64.57.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c6ad59ba-2315-42ba-fa96-08d9107228ca x-ms-traffictypediagnostic: DM4PR12MB5373: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3383; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G8eaZxG5ikcYiBw5MvI+2f1m5w8EauxV2+r0UUoly0+CM55qwrmHSyxxRvWUV8dZPRXyuI1teg08IQN9YgikhXZ1mCicTL2SQMWKw8P2Jxf5r/seWT97V+dE036SynMExHjL6cAVebG0qfIFUEqSbh3Ipkv8EwW6OIXfL3pl0gBO6m+sKR25MS4OZFn8ajBkp5+XHWAA5TuH0uzPr+l9MXVZW/bNkuzpExiIY+T4F7jrk5T2LBjQoxugdyUicHrqyQxLSGp6Cgc43jcf2uGbiWQQEmgyeCDcNzd8AgWxysX+bbhhbNaGuSRdTnKvpNhr6xtvxh/pjDBOVzweLt9QHqS2ZnOvB4X/5fMIebDc+ENu1N9XsXbGBms8i8nrjZJBnMZktTi9wQRTzlBCHN3CHVEhxJ/xS/CRyNb4r6+D44XDAziQL03JVtCsgX/G1XGkaOvP4mY7VdiH2ioh9XHpBbXm66JMcLiZvjmaTeCC0CZmormu7/AWIwDMcp0jGOKx+2+JMuv5W9BKJHzTiLYlfzl+7x6NZ1ssjVPRhwJRgLsVJMVRKlHAu2zRzYexyL3fZdK1WaEeLTfPV/3Xi19h76YK46b5QMa1DDu3lxsK0fs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(366004)(396003)(39860400002)(376002)(186003)(64756008)(9686003)(33656002)(66476007)(66556008)(66946007)(26005)(76116006)(6506007)(4326008)(8676002)(110136005)(71200400001)(316002)(52536014)(66446008)(122000001)(4744005)(478600001)(7696005)(55016002)(107886003)(86362001)(38100700002)(2906002)(5660300002)(8936002)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?FMFIpxQ1/jUuFNhFLLKquyfLuOI/WkpAV2d/pvqdPWtWbVtdIWCYZMpobwcV?= =?us-ascii?Q?7M0FfIfjnX0GDRWtH9wjPEr1nkoUdU6p7/stwMC4N2y0iqNeZSZXr7t+97zo?= =?us-ascii?Q?d+mqX/5eA/YneIUt6hiU76yRKnIJEgE9JV74jiPG3SbCWJbqdwhUVR1SGy6W?= =?us-ascii?Q?Cj5RUcsJAWmz96ddVKZAxEA9yFP/MKP53WNkIkYiY/sxa99sTvaqUXognk0c?= =?us-ascii?Q?J2Ib3t8AjLc5WGm1yHRyMoPH2gN/T+Ok0plFSFKekFlq8ix/pFqU2ZSs4mZN?= =?us-ascii?Q?/tkqF40I73kFnvComPXsXnjMryxz7XV8y8ZLizgziPLFJxGWRoDBcGUM5qb8?= =?us-ascii?Q?d8cVZi5INAU5qhAbBLKFV5D78KvLfrKgOCM5t3UDxlOCLYg5VCLsCAM3g1K0?= =?us-ascii?Q?i1d7eTtj5fLHuRkT+A9nkyyMtb1ax5U5TGPP/4faqy1XF1P1wtSaPZP7dYTX?= =?us-ascii?Q?2lKGvLaCCXCi7J5PrDBkUwczAWsmRFYuv/Y1y0dvmuFblD3pfIY9hKdCTDCT?= =?us-ascii?Q?wItJdbnCjRRr4jxjN7dI7qq/dIgVv35jqjCJIVAF/UPmW3AuVbwVUJyDLqvh?= =?us-ascii?Q?Dnf4QPHR7fvEw978YoS7yg+STxizhelSnW2eRAjtmn3QFh+5FXNqZrMfip6D?= =?us-ascii?Q?qjLCP+TdNNccbZvz1vwWNumsCb0cc6eHS/SITIWkxrPvURoTL9WQ3pJ0NgAR?= =?us-ascii?Q?pJqQg0VcXhkENR5xmGN+TsAM4AqeFUYF3iLkrjtvkKZKSdaQHXJ4r9LXYPhM?= =?us-ascii?Q?65y3CxWZxbX3zWt3M09xjKmEbMiIfrbNbzcXBkmbMR6YVSZJBRmKgp8NCZmp?= =?us-ascii?Q?+QhFvGhG1/Hpjej6aurSSkYKXUR65lmeWVBnL+fp91Qy35bxy35CicgQm+f5?= =?us-ascii?Q?Q8zBppsKbrP3NUkDq2NHG5qddxRnaiu8Oy43HQf8KWz4vSHQBbLsQsvtWAzQ?= =?us-ascii?Q?7zA2fK5OI91NNw7SDhIESwR/0sqGwZtzuzLX2NJpSLVXAP1nRGjTuPHOTLU/?= =?us-ascii?Q?1T0jdNsESBB1Pm22J79SZe6ni0KXo5E0BowwhEqYiFzU3go4vsfi2EhSvsWF?= =?us-ascii?Q?UN8HrNrI7wsHitGioQ72ngMgrZ623cMBDkyfTsm/FCCTgFND1ebLEb5Dpn8Z?= =?us-ascii?Q?bvBkxj7LqyDNYMhXnR7v9V4NIX7axzhI55usu37ZV2L1I1TtoxbXscmhwGGj?= =?us-ascii?Q?HrgfomJBcy95ZU86Pm+rpxIbttPzmhI5IDpxRPIH2KRiq+zJactaRu5Vn7L0?= =?us-ascii?Q?UczOtGcyqBVYSXkyF/uTMki0/xC62Tb9Kl4iEwhZyB8sbHhNbeS/C6ScmA2n?= =?us-ascii?Q?DwXqoBoSs3K4jV1dgJnypeAt?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6ad59ba-2315-42ba-fa96-08d9107228ca X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2021 09:34:34.5297 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E/kSHDxgsgjVwoYRXNzrhaZ9pgjtw9t7KzbNo9j/IdoCIZwyUCY+thSJoIn/N3ZiREGWnTXh63MHlwxvctWKbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5373 Subject: Re: [dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version copying X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kamil Vojanec > This patch fixes a bug where firmware version was not copied from > ibv_device_attr structure into mlx5_dev_attr structure, resulting in inab= ility > to read firmware version. >=20 > Signed-off-by: Kamil Vojanec Acked-by: Matan Azrad > --- > drivers/net/mlx5/linux/mlx5_os.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/mlx5/linux/mlx5_os.c > b/drivers/net/mlx5/linux/mlx5_os.c > index a8cc5f311..fa35c06e7 100644 > --- a/drivers/net/mlx5/linux/mlx5_os.c > +++ b/drivers/net/mlx5/linux/mlx5_os.c > @@ -152,6 +152,7 @@ mlx5_os_get_dev_attr(void *ctx, struct > mlx5_dev_attr *device_attr) #ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT > device_attr->tunnel_offloads_caps =3D dv_attr.tunnel_offloads_cap= s; > #endif > + strlcpy(device_attr->fw_ver, attr_ex.orig_attr.fw_ver, > + sizeof(device_attr->fw_ver)); >=20 > return err; > } > -- > 2.17.1