From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9230DA00C4; Sun, 6 Nov 2022 14:26:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 377B140691; Sun, 6 Nov 2022 14:26:08 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2072.outbound.protection.outlook.com [40.107.244.72]) by mails.dpdk.org (Postfix) with ESMTP id E4EF24003C; Sun, 6 Nov 2022 14:26:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W62KKlXCXDw9dqTj/AfNVaeUOwgp+ajORzEZQ/F5pDckceL/OPIXM3Lu9Pc1mitepMYxi8+hoeSsOz82StFQrW7m/2LmFWM7KmXrQXNNZkKeuRFLmFG24kWjDyWwHPyulfR65w9XaAzl9p2w6gtTrvWgbB7QkKo0nPCLQRIAykafWtpagUvDQFkuettCudVTjr9er3QQVigTXVvdPDEXnY76i6WhOlSiPQ+13v0Y4MlKfXBpP/piw2ZVVvdrHioMp/Cg4tvulvcgbNKSdwbYSP986lRtQpPKN49wSBxWhiWfD/FfW6dOV6ah5sqbe1xi887iT+ZWROIOSUXP766yiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gsqFLWSMErNA9CUZ7wmVMFLdqTyunNX81rnB0pC5SeM=; b=B8TEa0uJ8BhfAGLsTP9EYlXEgn+OSLMVmom3R2qX2PIuXUdr+Cct34pnV0vYprqD2EQpJ8leB2AGkM/KavnyvCRi/m410WICoEilPI8yYtMy/CuLQ5XXjQ1rPUhkFVITWtoGxETPNkAH34qTVoYZT+NU2YhgjKXAvrQKfv9/z7Urbhv0AUxJPXHF3T4XKpxj1RYEDL38JE0jDwttyU11lQb42cld/6tPu6bswvbs2Ww++7Cp4Ifmv+upIBKJcKZizd0uoyZj7Ih6HvasLQOBZYC3bwedw52onWLdyReWVlMuGQxo7hHGUnc/hFDEiARMER9Hcf6DSvj2+i+Sc37l3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gsqFLWSMErNA9CUZ7wmVMFLdqTyunNX81rnB0pC5SeM=; b=mnkJ7rItpQhdR56nGfI+TgibDpSmYMkd/2MOdOyVnf4/o/RbuCumhmV9eX+uMfd6MOu4v5C9jLRfLO9sjwm3nTiWDwe8wXOuWWR2jTdd3E73cokSbv0QYnBQRVibuJLPyV0Qal12sx4QUAvanKLe/JZXC8OR2tW7rzbYv6ELgRxqz8e+IVIms6BF7iCcD7X7f9arq679I3sgItdaKfvUcY05LSgJ/s1L3oEtTdgyhllvM34zHYqF8GejOBmBjrWJWt7oQbjjHChL8DMvFSIgCMjW0OVlvuye7RfYIksLRoO5Ben0ybs6NrLKq/u5DBFl8pyXCfnnDZJHGyloO5+r8Q== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39e::8) by IA0PR12MB7698.namprd12.prod.outlook.com (2603:10b6:208:432::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Sun, 6 Nov 2022 13:26:04 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::415f:9643:ea7c:b3dd]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::415f:9643:ea7c:b3dd%5]) with mapi id 15.20.5791.025; Sun, 6 Nov 2022 13:26:04 +0000 From: Matan Azrad To: Spike Du , Slava Ovsiienko , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Shahaf Shuler CC: "dev@dpdk.org" , Raslan Darawsheh , "stable@dpdk.org" Subject: RE: [PATCH v2] mlx5/testpmd: fix crash on quit with avail thresh enabled Thread-Topic: [PATCH v2] mlx5/testpmd: fix crash on quit with avail thresh enabled Thread-Index: AQHY7rCISxA4pVpInUuG8Sn+qU4it64x6Ssg Date: Sun, 6 Nov 2022 13:26:04 +0000 Message-ID: References: <20221024031403.1572010-1-spiked@nvidia.com> <20221102114425.2091580-1-spiked@nvidia.com> In-Reply-To: <20221102114425.2091580-1-spiked@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5389:EE_|IA0PR12MB7698:EE_ x-ms-office365-filtering-correlation-id: e1ff2fa7-8236-43af-a5cf-08dabffa7463 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O4kgbhHMO5lNpx7hUFFdXyXQh35RvNBRYMGeDxFiUsVUrefwH8Bn3j3F36JvEZG4NNpwojDE3oh+JndyjtPHBHnJ/gQxeD1N0EqkFKoYYpuk1/LdhbVkbvgQVInI//2QLMCsrDRt1s6yexWo2Xf0teQtGdpHG4iiEtgKKqHmMsFZxZWcFr2C/9IqgvR/fugCzks8C+ZQPrraqEmOynStrGB19CsxE85nlzWpuKwNhwAj4B1kY91kktTRrNbQkBNtWrr6lM348iprlZVPN1MAOF/556+yp/0/Gu97AcHyg/Tg6eDY8xiFC3gcLSLT7gUzV9haraTYtGL09A1/Te/tD81/YjPmgExlVaQFk/pjns6Mpx8urfoI/THU2Ta2dR07xf7t9+AXGDkBN0+qwkDrxvGTUByG1Y3lkCstN20jtLG4n0kTjId9Pvz0B3YJQMU803eFdqVTHNQxk9c8jD90+NOTqFOrwEqowSMtEYUN7SQaoiQqpgPx7d4DeKp1YvMplZp076uvk0A/nkS73RdDDdVA7dL5KBGmJ4MCnHzWMKUqtOXUVX3Min3LZUoCiZO2FlQk+7R1lTB0pwerwGtZiJUs5eqjnF3UwZ8I3GTXN2+QxidiV+1wg30C4E5H/SokGRBGsTUbQA9ul8NgpRFQyZvXfN5lfrIS9KpM7d31IQf3v6qSm9US5fegtRwSI+GTy8geypMj8T+ueKRQ3ulw745vaTqy7KiBldqGVCr/Py5xEwu6Ij0QBSMSxJJtbl4SZsasKx6qbJa7VmLRx3oP2w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(366004)(39860400002)(346002)(376002)(136003)(451199015)(110136005)(6636002)(4744005)(55016003)(54906003)(71200400001)(38100700002)(8936002)(478600001)(2906002)(52536014)(66556008)(64756008)(8676002)(41300700001)(66476007)(66446008)(66946007)(76116006)(4326008)(33656002)(5660300002)(316002)(38070700005)(9686003)(186003)(122000001)(86362001)(6506007)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?V9U5YjEz0PNNZK2M85Qiv7a1q5fnoXBiwnE0l/Czv2JYh9gJ6L5pjir/YUne?= =?us-ascii?Q?Jyf+JLPYfbHHW/rV0/fIUJUy6E3FZY1deQQXD619ZlnYYAH3tpL3YRiFzQco?= =?us-ascii?Q?ynPT12xBNZSrAJP35AXA4YLJt9az3jizchCuTpPw0r6AWNoFooQi2ewfr7+J?= =?us-ascii?Q?+q1g+jQClxdcCNCwI47/dv34TaPvuzlUDJ41bTGQWIMnxrfRKuIFmQmWmBx/?= =?us-ascii?Q?awmNqgIpGggGym0RyyBseZbodUMP6AQDdkzya9skNVUH5HlaniQ+0cNvA9cU?= =?us-ascii?Q?/I5n0a050KkLrMPAlGQSbM1BFqiJ0j4QuBjSHrChuPp/BUB9kHyR8/YD+In2?= =?us-ascii?Q?4XxQZ++YVSt38EZguAOFgWspSl+c7vrkASLbBKVVexarSl/gIylb5bdaESxh?= =?us-ascii?Q?+85aSGLNxeGu+OAy1lPTre+r6eKLPYILgl2zZp4Lrqrudu/0Bs3NISshrEX9?= =?us-ascii?Q?lZujEMBsY1TPZabd8HAYpIauq8/Rko0BBnrJIR+tyqXigMYikhXBeqs2XH5o?= =?us-ascii?Q?EBslpBOzpQIR4FhfbdHALg0wmrn/fTxrZo3fqPX8DnkZzKSdeEFAF24VYFY/?= =?us-ascii?Q?CrpakLkt0IMe0Zlr2OC6AI/EYNo5NKKSaW7OWVyGkDuQhIhxvW9P64QAQ22E?= =?us-ascii?Q?n7SgmcLaLmhvHqSFEjyiY52s04fOSOEGC90bnVjnRwdrItACahL3ZTetfAdx?= =?us-ascii?Q?365we3/dyB0+J2GfjePoqxFz3x0tx2Y0ARRxX2aOx1Z0SNyisCqcbRD0DksT?= =?us-ascii?Q?1D6S5EuTcRlpY7krQpwoaNLknsikuuENbjzDvZXj4dIdTjHq42cxefzUOeW/?= =?us-ascii?Q?x2Fb5FIl+jvmeA0FQlFkymLry0bp7UX70RgWB+LSJK1JOKrr6sDMsAwAo0NN?= =?us-ascii?Q?gDi4UaqW/f9WwkdnQt1qVMMb+9ynVql9X7U707mZF+Ako9CzDEgix5c5uPGK?= =?us-ascii?Q?g/KIVe52LBEpCZLAFbaOtuKAhb1ZmW/iYewh0so+rpaurrqMx6HwDYxc4Q1l?= =?us-ascii?Q?C6I7aIMohf/Gv6HQthyP4FvcXCDm9pTVKGu+UseSFg4cieNLAG2OT/hMck2s?= =?us-ascii?Q?rTQJ2shkbtGdZEnW726INcruLuWRXhqofv7MGvETcPwHKxQ5c+6VxoITBrkx?= =?us-ascii?Q?oKaWi3j7p1HgQTQq4ae5O5mOXnt9cvaPEwzGXpkGBUDCUccVUiRGZ/uoyfFq?= =?us-ascii?Q?E73K0+x1mUNYRHUqNQMK8VZ7Kr/UzueeSs48LnOChCgkgiNpf+NxKa3kbWOI?= =?us-ascii?Q?5dTSzXs1hBVRsyXw8DOy/fCGE6q/MAXEzhmWMbm9B1mTYFi4dCR9Z0oI3JfT?= =?us-ascii?Q?+c+xmVG4m+xPTNKEam5Ot2aya9dJgBKErW5josYuYY3SXfF/0B21LEA9kxQc?= =?us-ascii?Q?uP+mqyGd4OILccHrP5b9r2/wcM3ppgLVyl92AQuuGNbY6Nta6ryR1C7WKPSx?= =?us-ascii?Q?KnYyR5Zr6upfMDoxa3dkdQRQtGkpiktJMmUdtp4NKRbA36EAN4HJrCl6LhAb?= =?us-ascii?Q?IYoFn1pVSrXJTOiB8ac6Ih5oPhXOY5MqDbcLlUYf5nzzRFOCpaOJkRQJBQC/?= =?us-ascii?Q?sHA74zca8ljViyWelgRIMJC9iDdIkieYZ1+NheyP2rEw2tU6wXpEasH229zO?= =?us-ascii?Q?cabxQLpdir1n2wz/OMaPAEE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1ff2fa7-8236-43af-a5cf-08dabffa7463 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2022 13:26:04.1295 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QhIRXggL9xKOcMrOjX9EnQBrYLPTGs5HzrCoS8Z+zALJZ2+Fznog1E9TXPzi6E+CDLNbzVlQR6kzYiHrTWH2XQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7698 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Spike Du > When testpmd quit with mlx5 avail_thresh enabled, a rte timer handler > delays to reconfigure rx queue to re-arm this event. However at the same > time, testpmd is destroying rx queues. > It's never a valid use case for mlx5 avail_thresh. Before testpmd quit, u= ser > should disable avail_thresh configuration to not handle the events. > This is documented in mlx5 driver guide. >=20 > To avoid the crash in such use case, check port status, if it is not > RTE_PORT_STARTED, don't process the avail_thresh event. >=20 > Fixes: f41a5092e6ae ("app/testpmd: add host shaper command") > Cc: stable@dpdk.org >=20 > Signed-off-by: Spike Du Acked-by: Matan Azrad