From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E734A0548; Sun, 9 May 2021 10:04:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8034E406FF; Sun, 9 May 2021 10:04:00 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2074.outbound.protection.outlook.com [40.107.220.74]) by mails.dpdk.org (Postfix) with ESMTP id E14E740140 for ; Sun, 9 May 2021 10:03:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mfwp+n4RDAFZ+iCeKsJOOWhF1RldXzPegjHu+vgcQPqPIHIqusW2pe0N9s0btCmBnqD05GQMxpsSkCF3N2ke2KeNkCxwiI4LBP8gRJO+pvjCqL80UYdCzREf/SL/LjMcUAvSMAEAkXGGZsODmntBkj/hTDIzJxolrUyr18vV8DC3XsfKDIx0Vrs15a9YM0/XHB6sDX6VB8tq/2cmbzFMNKGw/No4BmFCmxxUBed0c1N+03KMcjqlm/g912P+oAjUaoTwHKlvnMLHJ/UAUCDPCyGks3otjP7y7A+zbjiTiLxsdcoKWsgif0eNcWm5yAdxT9mfPbk7kqL7Uvr+fM37kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TMr1ixLV9tz8CyluIaRxB3ZFWs0tSp6MwXMp19wvba4=; b=JmZ2ec0KT2ogLttiAX/JQWWKDbIp1/rqidElG4k37T2ZxUHy1rMLdackL5q1T9nPmqQE1LaWlTOT/xGbAuOyYcFjA++CUr9LaUVFH1pWSVdlm47d+HNqFj2CsVWjxi8iYy1stbGoXYqPheDjMb6E/koOd1e6hjwcUXjbllyI65mODOQOrwx7a1+OdSV278PBSGyEQlcmAKhmU5bH6Agmz9bY169iEaJJZPKUljzf826EOyK1BIXc9kUqaFraUZRGcTcnFGUanrrzgwavCHl0DGbOTK2PlCxp9EHOULUxk+fwtaEkEiet3hFkg0ia/Bm39Wf5P/day8BIXXGKW82GkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TMr1ixLV9tz8CyluIaRxB3ZFWs0tSp6MwXMp19wvba4=; b=tpFOlqBzhrfXZ5rhz3J7kIG62CvfGcN4bI1cE8wFIE7/MV/vWqiPCrnBIF5GNXdcjVf+5W5DjT2mwpf7sPVBd/L7uYw/erDO+7//8bVNK1XV8FAg1x7jPtL1UAbuxHtTRggLCvZaTggRq0X35bLs3L/YaJjnT8O+cGjRk447ehVF8tmx1EGM9rydUxLIs2k8rBGzk4HFO3J3wxUopTmNcmXUWAi1hQOxoXdMH/L9ChJM9hmEgoGb5va8A/cUiPVCjixkeGLUH7MtOD8C5ZnizeqYnpSmw8I/6L0lOhwgL/l+oY/IGHRYZD6h5vti7bIpjrc1izEwjCwKbGo/KwyIww== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5264.namprd12.prod.outlook.com (2603:10b6:5:39c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Sun, 9 May 2021 08:03:54 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.031; Sun, 9 May 2021 08:03:54 +0000 From: Matan Azrad To: Akhil Goyal , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations Thread-Index: AQHXQSnFZsqHi0ROBkyLX1cinh9IRKrZjXoAgAFCeWA= Date: Sun, 9 May 2021 08:03:54 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-4-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [79.179.26.253] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fdf09031-2ba2-4af2-c0ef-08d912c0fdb2 x-ms-traffictypediagnostic: DM4PR12MB5264: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mDxUQvd3me5PLzIxqLVQAuwIcd4OyRKFfeWltt+INNvcoCNa+19fqGEy75flOUONW2f7bIsVYipgI94Bkj+flR2fKj6sYWnFWgK5cRno8ju2qL3Ctzj7LND+47trcZZPnvOE7WaA6/YPcMp5No2UUSx8o59WDMSPwMthA0BX2XKuFUpEF0w1xmjvHFdFVVVfhvuxSbfuF+MWDsTPPqlPIzkyGIYHuKgUhelcGOeqY+0qrCcc6aDsodgmbj+4P74lsuksUI2FJUJl4MuQWX/QDyWFoT8QzxB5e1zOE0oqBkWQvNVdHCZ+hEuktM6JTYsAaQ1aMArhD8l3/vVUtHfk9sLJX+tb+buI7DLOtQK+3raPPEPJ99sQwaUMY4tAqnpCJDM80pHkZcTfbbA3Y9f5FVPP1rMw710eOInmRX3zMwROFK0WlVnWzlleDCXof3+STMs4uAH2V3rpe9I80lpz9hCFdFLoBxQTp9CBL4TQBYZJ+3QmFkaAS/51ylrvZMaznSrueCXoRJcg92rr4XUeb3iFh0EBsw8gefqyCO2jl/eLAxDDy0sVfaQBjQdepJVXM2Qz6e1GEZ6/t6dc5e+LKZWqF0ayD6QgEAOH6lv7Qh8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(366004)(39860400002)(346002)(396003)(316002)(54906003)(122000001)(6506007)(55016002)(2906002)(9686003)(86362001)(26005)(110136005)(8676002)(186003)(8936002)(4744005)(38100700002)(5660300002)(478600001)(33656002)(64756008)(66476007)(66446008)(4326008)(52536014)(107886003)(7696005)(66946007)(71200400001)(76116006)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?SqxNGeYn8bBqSUClAiaXhrLv6Jmu9FhANRwpx68tiZpwRkyOV5zCKEx6qsus?= =?us-ascii?Q?F9rvyt2PjKFFLpDm+76+tKd5KCulGralooewLW0/vk8hAEuho7CK8Ejx1HMG?= =?us-ascii?Q?Y0QLLvucRjKNUUfkRJVAK69wdRFINS3N9X1kJCJ6QrJdA7aC+CkwMwkW90ag?= =?us-ascii?Q?ulIEpB6Im1BQ4NQjPF55yb/62hLE5UgAMwK4eLh50cYosBr2po8apQXT0efP?= =?us-ascii?Q?MfOqTcvZVZIuC9csdrswWWpEVtRXCV+gPr28O/J2dL5jOJEKvZacJHO/R75j?= =?us-ascii?Q?xDf3OvgtO6PMUttnNeOJIyMCtSVj5FP+Gzy+zNpL+hYG3E0u4g2dSB8XLQ9X?= =?us-ascii?Q?Anh6yjrk7p3YdQJiZYqUrCBdz9Wpz8phcWZuch4JMRxUHNhOIvOHr5cPYHqQ?= =?us-ascii?Q?61j0Qxw2AGZWtpTSvUKifFb50Lx4g21M74CyMsFteiV70qZY69CWBeAOrbON?= =?us-ascii?Q?DfWyzRNMGkqC+gDbA08GEQcavbWp+Vxm0+TjVeVzC3TWhgr5p37LNQxwXCD6?= =?us-ascii?Q?vk66cU4nHKYdIrJM+nkIFaPbJ7tq9sjvuuGxC5pysLAvE5N6FHeDzN2P9VwB?= =?us-ascii?Q?HT1aCXSO03jAy/nQnUpgdo34FV16rbWhQ2yHlhERarUSlF4VqFcdVG9h6yud?= =?us-ascii?Q?5Z6IlS80FqXtsscPn3rUo/RfR7j+bC0o15GO/5LMXFDLRhHl2nK+DEv5KQMO?= =?us-ascii?Q?XbNrpfAgCI2sODse16QZB6x2x9T5DXxz2fWRciiJ0/MbeDKRjVKu7UIkGXPF?= =?us-ascii?Q?hCWlCE8Q5X8/ztBPMB8h8z79AouXLElmjcsl3sLEg3HD7FqF5s/AUR79wQJk?= =?us-ascii?Q?DEInldqyb1xTKz5YtbfHQNgSb9czQUfdlCHfX7uelUB+Lu0mHq/kFM2isxRV?= =?us-ascii?Q?Wemmb8WXTOAITebhxbLSCQ35ULsUQNii+vF23qV4bGuVki/I1jWhTAYhslLs?= =?us-ascii?Q?Jakfng2k/jHAeFIrBJza5YstbZV29Ytpc5jm3eUQCoIbsBZfsQFH9O5vWPny?= =?us-ascii?Q?GVUhRCpZKG1i87B0GmsmuYnEWohQCFKFYz0JIZHqGl3Nfup9/HCRuB+U0fGD?= =?us-ascii?Q?MLs65i1i4ua43GBmzDRiVpKWpOv98yzc1ywyVubKX56A1riW7rSm9p0GKjxK?= =?us-ascii?Q?+iR9GYF/z+8mTRr54WnmGivce/pHILzb6yK00IEp39f/+qo7RhQIcJNCp1jz?= =?us-ascii?Q?vW8+wUNYeWf/G0LrPpMXfynKp4qGwiJ3G/8d+LES27Ke9BHznOLbYxioggVZ?= =?us-ascii?Q?zDMUJ4NT7+HMOe6Cthh6qo7hXXtRKQAWHt81+gIeZXjGW/Km4nBzSc4nfber?= =?us-ascii?Q?qI65aEsgFehv/cz5IUkk4c3r?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdf09031-2ba2-4af2-c0ef-08d912c0fdb2 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2021 08:03:54.7493 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eEf1udbi7PehYQlw1tZw3MfdyXD9OBZ8ssamS64Rw/LWMKSEuDS8MDk4KVrWXBKAZWBd2gGJfhyubfmi9w6cMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5264 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Akhil Goyal > > +static void > > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev, > > + struct rte_cryptodev_sym_session *sess) { > > + struct mlx5_crypto_priv *priv =3D dev->data->dev_private; > > + struct mlx5_crypto_session *sess_private_data =3D > > + get_sym_session_private_data(sess, > > +dev->driver_id); > > + > > + if (unlikely(sess_private_data =3D=3D NULL)) { > > + DRV_LOG(ERR, "Failed to get session %p private data.", > > + sess_private_data); > > + return; > > + } > > + mlx5_crypto_dek_destroy(priv, sess_private_data->dek); > > + DRV_LOG(DEBUG, "Session %p was cleared.", sess_private_data); } >=20 > Memory leakage, mempool is not freed. Yes, good catch, this part was missed. > IMO, this driver is not properly tested with the unit test app. The only app we tested until now is l2fwd_crypto and it works fine! We can add it to doc. > Please add a note in the documentation that it is tested with autotest. The next app we want to test with, is test-crypto-perf. =20