From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80274A0548; Sun, 9 May 2021 17:42:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFCB740140; Sun, 9 May 2021 17:42:00 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2055.outbound.protection.outlook.com [40.107.243.55]) by mails.dpdk.org (Postfix) with ESMTP id 550BF4003E for ; Sun, 9 May 2021 17:41:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TBR/UXP+L2FZJ118LJmNgWcbAWuTRBXKm70KPUFM6TCJJyNX4eIYxFOUpnMLD2vTENSG9wihKfwKUNaSYQl2aan+fGvc6vPyWxP2ZFoR1bOy6Y91wsQYEH7ULiw9uHUfg3RQZFI7H6S4Ow8ZwHubfrTxhZo8FdnDkgR6NpJeiNNYvnHd31Vl+smRiFG5C2kzNncjMU7u433iHnnRCJrTYFCj1tddONdYhPQgwpQCaHfw/uDGwVbv5PSmMlwDZXiPupxxbRAPmlR8qPhF8SE7kp8ScQxljq2ULQ0zW618IKkz0PkUsnfiSq+W6OmYX0OIafCpFZvuEmnxIACFKwo2uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H9OrZLePPzCiFPUJcWI+o7S556Wy8vJcCd+vXvQrwRo=; b=XORw6BSrIRO+5+KBOT/n6hcTK+MiDSWNS98pC25ZX8EUrSfpI+hJllowhuf4BDQ7cIYvffa6ItV8gk1JDdYsjP7jZWThjsu3q1F76K4RK91uV7vWU1Ka+TSmCkoXMkeokvcSVuc4xSgYfT0O6Joy0sAfQqeX+LX4Ynwv+SD8lzK1iTmwlVs6EyjMsP46dSESM4yzn/bhWpROvfKq+nEaLY1AhVS0SEydBSJPDsJJD/7T5Gs3kQEUVCtZkVJ0Ttttf6OEiezW4vqP+2ugPuBKEWRCOQcokaFZuOVj7V8T2thld8XHDvFlj9R9JGqwJMu9v2zcF9RY42Um1+L50NtTxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H9OrZLePPzCiFPUJcWI+o7S556Wy8vJcCd+vXvQrwRo=; b=X5osB/JmiH0PVnvRnC/XBBd1chDOn9CI7u/cbJQ/gy3p1OuLZYEDZ9uo+sSU17J5jDg5elbocmS8ujIFF71B92TYIrLCfSmhK5a+KMPHAtOuu7EcyF4u3GIuKWLRCwx4dpMKLrZG7Ox+/Xx/Il/6tKTPdooo4UwR+pnJrekO095npP8bOEkLm+nHXpRIo6fIBVkuhgG/Mg2JcfQmmmIKArit+QNtGU+bUB7Mebla3hRphJF6qs4vCYjVTToKd3alI3xmhOZtqdFdqQFnCrh2nEwtqrpj95EU4CEfSQ+AWbF8hXUNtZLF2nb9WPlvIR628/fczSUCl/t5ZjKoHGb7Dw== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM8PR12MB5478.namprd12.prod.outlook.com (2603:10b6:8:29::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Sun, 9 May 2021 15:41:57 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.031; Sun, 9 May 2021 15:41:57 +0000 From: Matan Azrad To: NBU-Contact-Thomas Monjalon , Akhil Goyal , "dev@dpdk.org" CC: Suanming Mou Thread-Topic: [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument Thread-Index: AQHXQSnSPX12ALWtTU2ZgSHu5s6FNarZibiAgAFLZ/CAAArRAIAAcIyQ Date: Sun, 9 May 2021 15:41:57 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <2243665.ILJxVsgWGn@thomas> In-Reply-To: <2243665.ILJxVsgWGn@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [79.179.26.253] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3beebd2a-f691-46a6-cac1-08d91300fa91 x-ms-traffictypediagnostic: DM8PR12MB5478: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1468; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: idrcfw/ZNuVEj7tJxsHY6QNND/PnmG0VEUibYnSKpuk7jhrZDPNp9+3nkLaraW/mpsro9WqG1iEJBspWTxsV0yF9HAvVOgFCacfts9pin8EW4EQjpgcpejDRhFzVgXInThWAzU1GRcB8GPrp0Pd1dhGD9xD/XbDbHtlgWzLwbKp87IbO6FpPSdTsf7LqPirdtSdPg/1oy0KJg25gywxgxWJXr6LXf0/1x4yFE1XEeSPSSNBDqA6JkmJWEQOPttY5GyrSbtZBUIkxvYeToxrlOi63AcchENRKJ952Yl+bNnVVFBau2rnxcYo3MrAmPHikbQDjMdS3dZzIpSYp5o6b+oMoC8XN0Yul2SHe73C0jFQmWDxLLopVZv5P78oaKt2oXHGkq2BJ8aeH7mZPba+QM3uXqkj0esUsp+JbG/c2xpW6jOxSu/1BW2eEC2HlOhNEXZxFHaPEp+t0WP5Pt7P5hMBmCJkbdYlNYzBfVK+CQaioMhGIa+I+HM/Nb9GHFgR1XOONnQoRXPpGjC9IW2pYhIBbWVL2p0fe3P0irULwRjlSenj1LmyRIthCpYJBQ4kCbAzTE8BRqgzLstHhOFabn+B7BAM16amBd1+bawG+OaM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(66446008)(76116006)(110136005)(66946007)(64756008)(107886003)(66556008)(55016002)(66476007)(186003)(316002)(33656002)(9686003)(52536014)(5660300002)(38100700002)(4326008)(86362001)(6506007)(7696005)(26005)(8936002)(478600001)(122000001)(2906002)(8676002)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?wddK05/N2GirxJMdVNjrf/U4yuXALnAPr3VLItBkWXg/6e0hQeSlF2xHPtcs?= =?us-ascii?Q?F2wEj52h1YwT/RvlISldINlk49YLK65FoPCLXOY8g+4qDx1RSXLfPEGsE4a/?= =?us-ascii?Q?Q5B+/DHNmmyQHlRr1PQhiHJ/2Th8zk7fEWjO60R8B0HSOeHpsNyVX6s0nLvj?= =?us-ascii?Q?4Sx1B1o6baOjEoSo7mngaZqrHemcHPeGvTNp5ddRH13pD14ISGJ0RsD3kpXA?= =?us-ascii?Q?NgNzSUhHR8vhrxsPIfg78flcgo5+KF6XpBatNO7IcOXM7g85ZyjYsykO1/2V?= =?us-ascii?Q?yonuTDbAyXs6uIN1wwQn297mf08e7RPjhrfOqt2p3NwgTV5EnSsP7JScH9Fg?= =?us-ascii?Q?OFwbwQHTui42XVV8aDYHSfqB3cJuFC7CHzO/tDkMmGvTx2CDiLXut5BSeYM+?= =?us-ascii?Q?0E/T45TFLMFhCX0WGhUlGdyJhA8nZBrtkugh0xWvaK8Y8WFPCIniQh3UhApr?= =?us-ascii?Q?1F1p4IDmL4V/6AoQXkLq/4N4bA23houGksHBA8/AOQh0oI11dvrMF0DFaHzI?= =?us-ascii?Q?uXx2MnI7ozbBkAhUiyFP+DrBDGMAJOHrBWK9e6MMxUZR8bHmp8pVh5u7Rqp0?= =?us-ascii?Q?KcnukukfK7dE3u9oYAA59ioJU3iYpWBBwCxJwQbRPtiLam9Dvoe5+bXOhKv7?= =?us-ascii?Q?lQ1qye8EWZ2NCpZ3GBGK1K58Emqh+uDYDE7tcyQjhRNzAK8oRZ9YlCTKWHkK?= =?us-ascii?Q?C/lr9oKOOm41yGsH21J+bA0prf1GZf+kpSYcIw7FiZfBPrEvVm0GRwdlZ2Vy?= =?us-ascii?Q?iwr/oJo67Jc906386gjK9cgwnkG15Blure94OwdMWmR53+Z2rJXfhNtJ8ubB?= =?us-ascii?Q?mgk98wIOAwllZxLwbOmjXMY5KqjkJmJotnn0fSMhqBS3LmYti/Ka2giO5JLU?= =?us-ascii?Q?gNs0A3OGS341q4GnkoThfAwauQ5V1fBp6JC7Y02WrQY88JRyH2fCsCc36wlz?= =?us-ascii?Q?JhsFDXefbU1v4pBtY9V1PHgwwtd6HDYZ1IjggaaoOihrC/+aZgpz9iEl1ou7?= =?us-ascii?Q?ciJTK2N3UDd/ICfLL1WHJHLr16shfOV/fVkjky0gbECTw5mU3XwAhDCygU5S?= =?us-ascii?Q?1c8Va7nvmsjG0FXkdN6UV+GSr9V0w2rvMJVJ9RYwwnY+FrAwePzHHEzCsJO2?= =?us-ascii?Q?O9mpio0s/z/P73fOKT2G4YvzC42ikEZT4za4wr6keAEHOm8TRVGqV82GuOB2?= =?us-ascii?Q?GSVUNkMlr8yd2aoKBNGI2DznO6WXz1z3NV2ixGDwFNcGLd0EE50tMOBSkmbJ?= =?us-ascii?Q?etEpqZdaR2y2tpgNJiACW/oqh3ZRXFyXrL0XJ0rWG5FtBqMHcQPIJAC+SkY7?= =?us-ascii?Q?Ttk6x9KV+hnzN84HdzH4poa7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3beebd2a-f691-46a6-cac1-08d91300fa91 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2021 15:41:57.1883 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h1xoPsPWbEZqFHfpzDQhZkDuZWkENAjMY+s5VHWDt2W1zvpWXEggMD8/7gYYVQsSLlbS52MhAs1tr5NjAkP9DQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5478 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon > 09/05/2021 10:31, Matan Azrad: > > > > From: Akhil Goyal > > > > From: Suanming Mou > > > > > > > > A keytag is a piece of data encrypted together with a DEK. > > > > > > > > When a DEK is referenced by an MKEY.bsf through its index, the > > > > keytag is also supplied in the BSF as plaintext. The HW will > > > > decrypt the DEK (and the attached keytag) and will fail the > > > > operation if the keytags don't match. > > > > > > > > This commit adds the configuration of the keytag with devargs. > > > > > > > > Signed-off-by: Suanming Mou > > > > Signed-off-by: Matan Azrad > > > > --- > > > Documentation for devargs should be part of this patch. > > > Please split the last patch accordingly. > > > > > > Title can be shortened to > > > Crypto/mlx5: add keytag devarg > > > > > > Fix other patches of devargs accordingly. > > > > As I said before, no devargs is really active before adding datapath pa= tches. > > The option to add all the supported features \ documentations in the pa= tch > which actually adds the support is correct. > > > > The last patch adds the capabilities and docs when all of them are real= ly > supported. >=20 > I think it is better for git history (blame, etc) to have doc added at th= e same > time of the code, even if the datapath is not active. > I agree with Akhil. User can read the commit log which explain things enough for blame case.=20 I don't agree, here the devargs has no any usage, just saved in the pmd mem= . The devargs is actually active in the last datapath patch, we can squash th= e doc to datapath patch if you realy insist...