From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD375A0C4B; Tue, 13 Jul 2021 15:43:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9369C41263; Tue, 13 Jul 2021 15:43:01 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2053.outbound.protection.outlook.com [40.107.220.53]) by mails.dpdk.org (Postfix) with ESMTP id 7475F406FF; Tue, 13 Jul 2021 15:43:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C5qD64DeUr1BOqlu1HGuXqlNlR/erB1nZz+PobU/Iv+sR3lQ5O1Q8hDHJoOBpP7pR2VBSSa8AvqYMMaEdft+8wWKY6dGMaQWT5qC1+VSXhszwNPvfXX7DtKA+O1nn9VxcwUtkibB6aTgonyEkwSMEKgb8deSD+FHTlgg7SxzfWJfSkWrBzgY6r9dKF69v6DOQ2COxywDezibYCaA3bF75rWYJr2tHbZjqLO5HmjJxczF07j9nPMmOaJbwcTGVCi+apWrTbyXjKPdc+6dqkV66pPBxHtIgJ8QiOEtvYIAGYE1iKUdHjKhl3cFfDO5y7+RbwK8Wb9DkNPrdx0DAAKiFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ThllhUXFDwsKhxCvO0M3/XPAOAjSXE2vIYWviOw/tpw=; b=S0sMm5ZwUyDycIXbg5oxJGXGpOFacX4xjzZ1otG51y6PObzVWlxjIseL25GSE6qlqId6RdmkLQ8vevMvB3aP6V4q5kHNqXvAm3PqvlX9XHb3YYMMldhCS1WFldpBNzyUqm9SOp9ORG7Utqvz0hKf4FRT87zw/9usYYNEPHY2su5TZ74+LXvANV4QnHgO1aVh9l0ClAXp04Cp+nJ/J4TEB99V05QJQu4X28FFeYxg+kvKVrbIu9L1Lh3mJYxDaNom260EkNfFBD2EIGrNv3vgfD4Hd9KJa02H6sE/e8Z5Ag7VFmsBulATHzq6m4RVDbAxJe2DpoZU0pd7CEaUIEH44Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ThllhUXFDwsKhxCvO0M3/XPAOAjSXE2vIYWviOw/tpw=; b=FnNcecKwLxXmj7Zm+Ul6e8AcVWNphwPlsLZxHw+mCWbKGCWYa3Xye6Fs8yPMISHNty1mZHosLLWedkc9d8wkn79L2DX2EfgKrzGFtb+qyTYXrqb38NuqNPJYF6CXm+HfOrFQgBJuhJyx1fS0VOL9sCRyeyo5d5iP4AOP4MTV4PZdMVelUtX1GfUz0Ki7wOE9jlOkVqZdH9d+sVOhDHD+gE394KPjThUQ2eexWltUmwtytNHrMkUVTna+lLr1psoYNFlF3W5i2beJhcrXxg4k05mCndq/PlnurYnOhaSZmcNJpx6oz3pFRCPLUeKQzkHydL+rQ0W/9qxmCLLhIAbfOQ== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM8PR12MB5462.namprd12.prod.outlook.com (2603:10b6:8:24::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Tue, 13 Jul 2021 13:42:59 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::6823:63cc:f7d6:dd00]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::6823:63cc:f7d6:dd00%7]) with mapi id 15.20.4287.036; Tue, 13 Jul 2021 13:42:59 +0000 From: Matan Azrad To: NBU-Contact-Thomas Monjalon , "dev@dpdk.org" CC: "stable@dpdk.org" , Ferruh Yigit , Andrew Rybchenko Thread-Topic: [PATCH] ethdev: avoid unregistering a non-allocated callback Thread-Index: AQHXd+lwF6vUIBfc9UuIyi787+gG1KtA6C4A Date: Tue, 13 Jul 2021 13:42:58 +0000 Message-ID: References: <20210713131714.964500-1-thomas@monjalon.net> In-Reply-To: <20210713131714.964500-1-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a40fa043-f601-4e08-2751-08d9460420a5 x-ms-traffictypediagnostic: DM8PR12MB5462: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r3zD1dpJyDf/nLy9O15qKIOvq85IpT1lz/tN1yKPDo5vioc4uNrTw/TQfgy09MEx5mvGXAfyC3T0mYFsBhxp41psVT93gw4rqRFi/R4EL3t1YId+KVacDFYq1NVftbydqdhWLDyyJnJG/w5hYiXaxTYYHquhVFKyNSnpAU28QWFBUHpRYP7HnyJixsIN8KvBqwUgwrTylOoHAlK8GUnblt+Gs81kEnOREt8EbkzGmsxsJb03bFR9U6YKkBMI71jolL0/GY5QzRrD5sAKiqwuhBXXlV535eILWDVMT+z11QMCWXqUgQcFEL85ERTVh67KTcfp+jPkduO9/uKFBgnOiFnFZrnJh/odO5pUpqHDz4D3sQ0/0OimCJaGjW/UGzao6luE0gvU28wtbz4jHieLe/6Ov3MdH0U81kNlXim3qrVRB471TQeflKJ65XB+s1oiLK7sryNNVDZrW/jbHNiax4YJSHODAg+Gddc1W2hrEYhUb+RzFh+cmrorNKpG/bIjaqiaAe/6LojcW21JaVjnt7C4+zNfU8eA3tFfObV+3Ehzr33kJOZC8U//Dm+HPIEVpFb1thN7I1cK7FgEratC3WSGy+jOvgdSPsmLcEPwAUWPxL4iZI7Qhb/9+v/yAiz1f+Vc+2bcwidfO76wmf7dXw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(8936002)(8676002)(9686003)(33656002)(38100700002)(478600001)(4326008)(316002)(54906003)(110136005)(86362001)(2906002)(186003)(52536014)(64756008)(66946007)(66556008)(5660300002)(76116006)(66446008)(66476007)(122000001)(55016002)(7696005)(83380400001)(26005)(71200400001)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YH2Uy11fKiI1douev48gEAmupSrM4/4VOxlKCOOvTRpfxsiHcIn3TgXMGshp?= =?us-ascii?Q?3TF8Nd2gZdZetfIqH4hZGbejF+5A5Sk2w5NU7mmfNqSSz7ykopBJ/KfFOvAr?= =?us-ascii?Q?utJjbjJGnmafT0Z092fG17S1ndoilJNWGTPR0eeUvfd0x+L2geD93BF6SBNk?= =?us-ascii?Q?lsVinuDsrkUMEC0TmR4b2E4X98hUDtbsqHrx/ulGEUUXGcZpGQPBLrfa3J8N?= =?us-ascii?Q?ib/mjGOaNbd7mwKCcqiON7UwIwNAGKK5fE5xGiDpAdi5IQ7gWe/jmUXx15aG?= =?us-ascii?Q?r4I9lMCl77VB7lhcHCn6J5NShK0LJPtKlaoFXiLYcomcsPMsRNeIFmQy3jCi?= =?us-ascii?Q?nq1EUnAPO1gF7YUZ9sMaQxUNf1pM3SlI1bcmM6vPc+BXsttEnKH2KWGAV+R8?= =?us-ascii?Q?5Jl0ltacdK7K8t0Jpcvbkzi3vEjm4qS7Iv/GXGCqTS/tSdUe3JzvTApoNHCL?= =?us-ascii?Q?j7NDqBi1VYZH/LrJ0u4Vz8EuTSj1QjltlXHw5KI9fYdmSD6TOaTVKHGnYlNT?= =?us-ascii?Q?PR6Zezz+i4KEt3EO5ec3IAn+yVkxWyiRM8C5O38BRCB+AANcjAtA4GjaBF4h?= =?us-ascii?Q?Wey4d7kRZkifFOiWD4xONAls8bqA3CtjkU/pfaVI331NNR+i2W0pC3Q/tNrk?= =?us-ascii?Q?tRxIS4FZ0LmZqyyzD3dz/1CqVQ61MlSTvPd8Vozz+WocUlrKgRwc0GfwgID5?= =?us-ascii?Q?QdCkuynWtqEWPh5U662Yxw8IajRyINuDhBRQiHRVdWq0sWG3B42ifKuMnRxX?= =?us-ascii?Q?OQGhP9cbfI2eMpLZFxiBXdpQJLwFlijT5DABJPmALl88rksE7CWB084pKRs0?= =?us-ascii?Q?VnhjjLfmH5foJtUb2T7+uPnauzq6NqB6iTm9/ewHhMh2ZII0xKGrXXJBQASd?= =?us-ascii?Q?QVU0SeQcXD+v+QGgf1thiSseSihG6iJpgSxMmhhyloj/34phHH7pAekw6o60?= =?us-ascii?Q?fhsyFDydH1UACHTMgWdH4JyNeO5PmZ8U0/v3KCuVJ8mGBeH/U31QmsHy5A97?= =?us-ascii?Q?ShI0r/dSlID84Kc2Yf3JjfwPWD4h0kyJpvX9BolnRexcCWj1BFvd3PaXBeuZ?= =?us-ascii?Q?19WgpGvGPa9rNBzH9Q2yjbagY3W0Ob7ZJGx0qF0o5QMgAGwwBG9hIQ4meNq2?= =?us-ascii?Q?8/iPR9vEdWLUwXoGbEAkourk89/2taqRdBQCbQv+eZXWSn6QhuLKNPFHeuMe?= =?us-ascii?Q?3E1NYlOwaSotmxaPmMuXvcPrt9qrXuSe0PJ1tKFcMPGBkFhhaEP78Mqo3os4?= =?us-ascii?Q?Jb/T4YHbnoR9yzEQydrnAv+brWhBedeCTCVGLFuaMx4i3f2J/supSUsdGebn?= =?us-ascii?Q?Zhg=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a40fa043-f601-4e08-2751-08d9460420a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 13:42:59.0377 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DBZtFpWzm00A0wzw0WhUELd4QuuRvI/Jv3y0RtpXHRYa+U7Zutiv+edBxur6IW3/j1G7LvlIMKoSRo/GqhPcsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5462 Subject: Re: [dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas From: Thomas Monjalon > When registering a new event callback, if allocation fails, there is no n= eed for > unregistering the callback, because it is not registered. >=20 > Fixes: 9ec0b3869d8d ("ethdev: allow event registration for all ports") > Cc: stable@dpdk.org >=20 > Signed-off-by: Thomas Monjalon > --- > lib/ethdev/rte_ethdev.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index > 9d95cd11e1..1731854628 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -4649,8 +4649,6 @@ rte_eth_dev_callback_register(uint16_t port_id, > user_cb, next); > } else { > rte_spinlock_unlock(ð_dev_cb_lock); > - rte_eth_dev_callback_unregister(port_id, = event, > - cb_fn, cb= _arg); Please pay attention to the case of port_id=3DRTE_ETH_ALL where the user wa= nts to register the event for all the ports. In this case, when a failure happens for one of the ports, this unregister = call cleans the callback from all the ports. =20 > return -ENOMEM; > } >=20 > -- > 2.31.1