From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE509A0C47; Sun, 31 Oct 2021 15:06:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EBAD4068E; Sun, 31 Oct 2021 15:06:15 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2066.outbound.protection.outlook.com [40.107.223.66]) by mails.dpdk.org (Postfix) with ESMTP id E139540689 for ; Sun, 31 Oct 2021 15:06:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LMeD/NsRgDHVqCvZsL7HrRtu+upN3mzKMfQ+sKZktPn7GBVudLVBnmylROX+LAiIvz39jyJGopBy6XIqs4HGaTfcaJvRUG+CHD+LLEJupIDgcbCfi35DFIV+h8q3GddC9gbGUFDPvBqGn94TQIAQhyWmP888lVLSYgDkXxOVnt941o0jD5f4ghvpwY/jWfIfGzMcUjo22HlwLvST/1CZ0/FE1f/jqMnQK/S+zaQROUBdbAzq02DgQa+sGRRwSATkz9eyziGJdm7Ee6Oa6uxEmnPLyLLMPXkjHDq400+rLUtFTbmY4JUjn888yL0nbuGgUu4ViKGj0VVzgMAU3tA+Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/ubLnH4jMutiQsaqTBdgs1GrINkznEbmVY5EJGYFg7U=; b=F/1EMM4J6C6QtnZxmvytrAzivWa/8vZsnvEjOY70eENR0TeJy2gNlznpovxviGagVm8FxMEyI5lwjHxdZrztjFzykV2o9kPYr0GKFslra8bf+QHdXYTwrWG6LQNT0uf0i/w2GLsLYriar9puQ4CaUN+caA52uMUho31SoBNlUEqrRtWEPs6bgc496DnO5TW6rJtXK+nbwXEeOdfrdcyQxnLh5RPTki9usV3EE90gkgsBqFlgTqin0LwTcUybS/sKzsfLqcwPkuIX2mZkyfq6Be2iXjDFrXe1k/ltGpsnG9B8b6Y447oTpgMr3oCdZjz0Yg7nPXXKM+k9kdjy2MHheQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/ubLnH4jMutiQsaqTBdgs1GrINkznEbmVY5EJGYFg7U=; b=it59CmGKSTMLBHY2dEbFHARnP+cFhBhAmXOoCclKw4pQu6U9eH59YdHRDE9XEapgUXD5oBG9sJAOnRMyB3RmNfuC0nkIR9X/bMsZUr8BRpEvXLQGDu7mcpGmEPQlPa4ppz9tZ3Jk0opdOs2Q/9AJoiYapOpJjJNicH8RYERDxC//gSUVOzd3g46TP/jIYcUj4xKDzo6AlwlmdKCohVSNduw0cLNVPCLDiTl9xDZAoaQdFyk22oZ1tXXhFnsEzaw2pdM4Cn/6abA7RKlJQ2109jzseOGDb+mSQ3hjXegWcgeP+wQ1twRsxvHfRtmSh5kEdYrbwpCadJhGxWYHffzYjA== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5134.namprd12.prod.outlook.com (2603:10b6:5:391::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Sun, 31 Oct 2021 14:06:12 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::45be:2914:19ef:f4bb]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::45be:2914:19ef:f4bb%3]) with mapi id 15.20.4649.018; Sun, 31 Oct 2021 14:06:12 +0000 From: Tal Shnaiderman To: Akhil Goyal , "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , "bruce.richardson@intel.com" , "Yigit, Ferruh" CC: Matan Azrad , Raslan Darawsheh , Asaf Penso , "declan.doherty@intel.com" , Slava Ovsiienko , Eilon Greenstein Thread-Topic: [EXT] [PATCH v3 5/5] crypto/mlx5: support on Windows Thread-Index: AQHXyyrPxM5GzGn+g0e6Q3Nh1GOzeKvm0WqggAZXElA= Date: Sun, 31 Oct 2021 14:06:12 +0000 Message-ID: References: <20211017094133.18988-2-talshn@nvidia.com> <20211025084617.4952-1-talshn@nvidia.com> <20211025084617.4952-6-talshn@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 409a64fa-5b9c-442e-d1f0-08d99c779875 x-ms-traffictypediagnostic: DM4PR12MB5134: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FpcSUo5CQn19Vsyn3hrD5ZlN2XFO6JQ3Y2cMvuj2elxBhmDSKdSbh1iUwhxuqbbx7ukSSEuI2XtRNZ+09Q8Pp+1ECPJEMlpJMeINFVCX4eWPvrymXs3RyyixkakcxYNMZmkAmQdvNR4Ho/Z6McZDFXW7hWdRrJD6h++x4mbtxdko1PeH0YwK4J7De0G3x9aa98bmCcrIitw1tpZQDgj4m0JyjXFSQ2LIMePV9IXAjplv4+TwdYGvNCGKeJq8JkfXaQ/VnoK8WEByJEf2UZeVWsIzQMVFHVz70Xfy/DZfXJU8RLruNQUR+FNDn0znAsloVT4inZtQm78bi7UudVKYMO1D40wKDPS5s4JdjB92saBKxn2AGH5KMllutI3e+14HHsesmuTUKC8zR1msKbZ92tbqp6e9NZ+nBDDcEL0calwESxD0QqDbHMWUIrfsg4IM8e5GowqzlhI08UxyrmzJ0eyATQ6Lc3/W/FRtGJeB3tQjC8aUtqObOsDCITOHpfX/ULdBiPgRD3zwqLk6cDPK6zDfBRzzohpQG8gz4+/RHctOq2j5vTWvLiqASlYY3pfHBLKcvTv2QjNZeS0G/qo1J/o8jp8TEdCi6APDM0Fe4iyjbaqV2i9ZLrGCrFiGOUp4Kap5Yc3DglOoAy5gEvxuUZ0cfOQkvK2DlK3ZGos2td2DLJHNMjmr31dTzEdOtE2Xew6dEHtAJreBcu03hFfb4FCbGwqkliHbi8zPkcubcd71jPBA62lBBh9jR8lBYUn/3pAJlcw8DTIFNOJD6JvRh7mc67QYZgHXhD64ohTMTuI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(71200400001)(186003)(86362001)(5660300002)(8936002)(4326008)(2906002)(52536014)(55016002)(316002)(9686003)(83380400001)(54906003)(110136005)(38070700005)(66446008)(6506007)(966005)(66476007)(66556008)(64756008)(107886003)(33656002)(122000001)(8676002)(76116006)(66946007)(7696005)(508600001)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ja4sIU51dJGu42+NwLhpFQ/8SvLMhbdDb4BR2orGP4hhgOvx82nNuyAfqsUT?= =?us-ascii?Q?V8OeCkMSLf42F9H31MSqzfMtigW7bvDrndOCV63aYPK8U2yUhWAzM0plySxb?= =?us-ascii?Q?UReJUWC1/u0El4a36B+1eUedxZL9radiSV9KgMoRyTkm9wdCFTI+2GKe0CWz?= =?us-ascii?Q?J+rEHyQD+6k6xoqMLNqUPO5a8ENI82QavWwv/zUWGrSgv8Lg5kGWqLHpcIEf?= =?us-ascii?Q?3v/8TbKSqkW4b/W0GZ9CXILZo7jzYt7AafJTfeCE2ho3NzOzoN0RUb4KTxI1?= =?us-ascii?Q?RHDXmr/hLppZLZP2wEDmpY42YuSDO+ZGfs3yPI5eZqMtxBQA/PX/WcyyvbT6?= =?us-ascii?Q?mqg+FH1wzIr+JpNSmaJlWvDpodZ2NYh3BKQsIv8it///npUCy+VPjnrPHdB3?= =?us-ascii?Q?4WWxbUC3ImMpSJEVYByjYm/7DebnCLXi4lVd/dgCNv9+wXB5ZnZgrZolegRX?= =?us-ascii?Q?1V4HOPTNsjMwa9go5Jj75i7N+qbcxiX4lM4021qs7OjKs75p8swM4Ce5tZ6H?= =?us-ascii?Q?EKv+S1D9dJeka1l/8Dk1diYMmZLEqTIajCqHRzl7jx83nr6Wjg/UZBuewApT?= =?us-ascii?Q?cOtXo84N+HrG3Fz1Y0d87OSXqdWSlU7IJFvRsG9BVXeMVANxH3jrihLNJwHr?= =?us-ascii?Q?zMsnElblnGEDNH6Vn8SBjlonvUNFefzadMreM18fu522iBN6NuP/1LFszMOy?= =?us-ascii?Q?zGr/c5KULvZ8fDeKN7id79SxLVCnZTBxTTPesFd8NiQMG3oyR+qUS1yxrKPy?= =?us-ascii?Q?kNVxB/lL9siLNwzPzOO5EPq1+MVu1QvXv75THY7ZfCGO1yNgzlfrQAmpCdiT?= =?us-ascii?Q?i8WJ9Abn/mYTmkq2Kc/41Fs2kU2wvLjzHKce21IQGHbivll+ATCJqm6z26LV?= =?us-ascii?Q?mDHxWZo16qWwmqVRoEKwTyNiTHKbwSAud2Hmeksik/MKmRarZY49AZbKOYAt?= =?us-ascii?Q?Un5L8jlh1Ueyly3wbGHfZTra95TVauA4F2WC6XflpBOMIZKcyeuAzQrgjG1F?= =?us-ascii?Q?UY7ZJpl6BMbLr5EjeWEX5PcWezvUiH1Tm0O60tbel7Y4PSS8Ymhoc6vX6wSr?= =?us-ascii?Q?RzMJNObRiLXg7qen69827xP/P3jBThtDr5uE/TFPVixcpc0g/XJVkmTaeOPv?= =?us-ascii?Q?JUOqS1heV1SA6eNxdpJHa/5mViyW0IyD6TGuvMFLqfqYuCnmvr98L0xWjvoX?= =?us-ascii?Q?p+GYM9qTDXvJS37a3QvNRd0nxBIgNZaaTkCSHb7s2PgfXLUGO+eYlJoYgXmT?= =?us-ascii?Q?9fU4Qhg2QRpChw1MZ3N37jxwRB6diGY0azRm0ju3lE3+QyBOyOZWtVZOGCXB?= =?us-ascii?Q?khjcu+Rx5vRLgaDVV973hzpgo66bL2J9P1jBNO9LEIUbZvYl0E7KoiZrnO4Y?= =?us-ascii?Q?rgleXam9NAypTbAjDRFKOPIJxz4V27xg7cy61NHOL4YKdbBUlRWVXPQKXYXq?= =?us-ascii?Q?XiZPre3oGn1Kv2ABBgYsEh6WXBJtguSRtvPbSoVUkKC+Nk66CcP+QgFpNu8y?= =?us-ascii?Q?oySYx7i0qSfCLYwNC/CUnk86YlycwQwTZ6bemoG/khs3dN8yepvJ3VwGuGjc?= =?us-ascii?Q?CiXcarENUOi2Xlasad+tosZs6rafKBmWs9JmMsOOU+HWBXomMsuuNvVnsJq5?= =?us-ascii?Q?Cw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 409a64fa-5b9c-442e-d1f0-08d99c779875 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2021 14:06:12.1201 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RK86AdqDA26ZYrjq8ICSN4rjA+XTk8Qyrm2KS18n3kW6qBdfMSXXmz3MGnp2U8xOSJjmM/H03SOD1pjedv6oYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5134 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 5/5] crypto/mlx5: support on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: RE: [EXT] [PATCH v3 5/5] crypto/mlx5: support on Windows >=20 > > Subject: RE: [EXT] [PATCH v3 5/5] crypto/mlx5: support on Windows > > > > External email: Use caution opening links or attachments > > > > > > > Add support for mlx5 crypto pmd on Windows OS. > > > Add changes to release note and pmd guide. > > > > > > Signed-off-by: Tal Shnaiderman > > > Acked-by: Matan Azrad > > > --- > > > doc/guides/cryptodevs/mlx5.rst | 15 ++++++++++++--- > > > doc/guides/rel_notes/release_21_11.rst | 1 + > > > drivers/common/mlx5/version.map | 2 +- > > > drivers/common/mlx5/windows/mlx5_common_os.c | 2 +- > > > drivers/crypto/mlx5/meson.build | 4 ++-- > > > 5 files changed, 17 insertions(+), 7 deletions(-) > > > > > > diff --git a/doc/guides/cryptodevs/mlx5.rst > > > b/doc/guides/cryptodevs/mlx5.rst index 68bfdf3a83..7338c0c493 100644 > > > --- a/doc/guides/cryptodevs/mlx5.rst > > > +++ b/doc/guides/cryptodevs/mlx5.rst > > > @@ -39,12 +39,12 @@ or to access the hardware components directly. > > > There are different levels of objects and bypassing abilities. > > > To get the best performances: > > > > > > -- Verbs is a complete high-level generic API. > > > -- Direct Verbs is a device-specific API. > > > +- Verbs is a complete high-level generic API (Linux only). > > > +- Direct Verbs is a device-specific API (Linux only). > > > - DevX allows to access firmware objects. > > > > > > Enabling ``librte_crypto_mlx5`` causes DPDK applications -to be > > > linked against libibverbs. > > > +to be linked against libibverbs on Linux OS. > > > > > > In order to move the device to crypto operational mode, credential > > > and KEK (Key Encrypting Key) should be set as the first step. > > > @@ -155,8 +155,17 @@ Limitations > > > Prerequisites > > > ------------- > > > > > > +Linux Prerequisites > > > +~~~~~~~~~~~~~~~~~~~ > > > + > > > - Mellanox OFED version: **5.3** > > > see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. > > > > > > - Compilation can be done also with rdma-core v15+. > > > see :doc:`../../nics/mlx5` guide for more rdma-core details. > > > + > > > +Windows Prerequisites > > > +~~~~~~~~~~~~~~~~~~~~~ > > > + > > > +- Mellanox WINOF-2 version: **2.60** or higher. > > > + see :doc:`../../nics/mlx5` guide for more Mellanox WINOF-2 details= . > > > > I do not see a way to cross compile this driver with MinGW. How are we > > expected to Test compilation for such cases? Do we need to build it > > over Windows? I personally don't Think it is a good idea. > > > > Others please suggest. >=20 > Yes, this driver can be built only using clang on Windows, net/mlx5 behav= es > the same way. >=20 > DPDK CI has a compilation test for Windows [1], it will fail if a patch i= s > introduced that caused compilation to fail on Windows. >=20 > [1] https://lab.dpdk.org/results/dashboard/patchsets/19686/ Any other comments? If not, can this series be merged?