From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id CF8A4A00C2;
Sun, 30 Oct 2022 10:16:30 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C36A64280E;
Sun, 30 Oct 2022 10:16:30 +0100 (CET)
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam10on2048.outbound.protection.outlook.com [40.107.93.48])
by mails.dpdk.org (Postfix) with ESMTP id 8E0D84281A
for <dev@dpdk.org>; Sun, 30 Oct 2022 10:16:29 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=FZk3cfRm4MUyVa+WKqbHo4jfFVpeHPvXLQCbA7K1bADcS9kwa7vklTothaHMcrjwWk9He38fxNm/s19UQD8qtoQLpm+wlAbjreRLMIbeb/8aRwxG1bYPXj/Ck3AFKJhd6tbM7GOD9hbg5kIyEZiL7lgdL0AuBUHV5QCTaY6IfCtLVEVRfcg3mDAOA7sbY8TYNppFTtlmok5snNgIL6onapJve7sBpZ+ln4n67d39gDX5rcwTagrWlB88aQjpw+OOEoibAVggRRd4tJMYXWYCFR2nKSRb1h/WhgdiC5qfDqJGKm4DQjJ3OzgDP98xGwMkD+thQT1X2G4E8VjGTHbLLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=IT8KDIadXAEJ3lXLIYPpa/x5FYBxK6i8WTylV8pw5PU=;
b=oVaPZo83cFRE00Nx7ajuRpVWtZpOpuJnt+FfOpgem2HH/g8T5vTjEqb8vJBl4MN278q4fBmqtPMC4nb2rwvbRtWRYayTve64CLVjdp1bO033JzIyX4WGsTmmCg1kWKynfvPITI384e3nDU1JzbSUQVuwiNoBGyC2uZ/Fl9UAWxmmy4oMtRUmIWvZLe0A+l4VvutvVbUcOnsrCWrls8Ftulw2jEXikRpEsxlICjECRzV6qcVVxEXjR+498GEJo4WDln09tIC9LdEzKU20qYpSo8o1qGKAy3ClhMvZitk/dj0Dr/N+FRG/WV1A8RNBBqpiavxmXISYS1QpKcD9GmiQTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=IT8KDIadXAEJ3lXLIYPpa/x5FYBxK6i8WTylV8pw5PU=;
b=lIK6pGlizFH/qrQi+3L1lqoCEio8tNHg4PDMFWE+PWKh+WkWE5Q5N+A0rTc6KLETQs6BpKTimZpHwu8JUd/fl7ZHSJ2b6dpMKCz0W621tpFLmtP1Tx2beUCPE4XiMYBafw4WgTykMC8Vlyf7T3HtA/EpcRlAYDz3Y+FL+Z+IjYxbJwQdh0nll6ZUKUHG1ySIPNqLYGPy1vGEh0gkCUjzk/3nhVmbAJidk6IsWvzH3/i0Ei9CNN35+p9gcwBuOaZ7cK8DYYC4TzxutRemHrCm5xNwLB34OKSn5vkAqoH9ODXpa3FPrMbqEE9K67/YQi68lOcxznkCEN7JgOtlZm6F6Q==
Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39e::8) by
DM4PR12MB6181.namprd12.prod.outlook.com (2603:10b6:8:a9::22) with
Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.5769.18; Sun, 30 Oct 2022 09:16:28 +0000
Received: from DM4PR12MB5389.namprd12.prod.outlook.com
([fe80::2d6:9f4e:4ff7:c45e]) by DM4PR12MB5389.namprd12.prod.outlook.com
([fe80::2d6:9f4e:4ff7:c45e%8]) with mapi id 15.20.5769.018; Sun, 30 Oct 2022
09:16:28 +0000
From: Matan Azrad <matan@nvidia.com>
To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>
CC: Alex Vesker <valex@nvidia.com>, "ferruh.yigit@amd.com"
<ferruh.yigit@amd.com>, "andrew.rybchenko@oktetlabs.ru"
<andrew.rybchenko@oktetlabs.ru>, Raslan Darawsheh <rasland@nvidia.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>, Fan Zhang
<royzhang1980@gmail.com>, Ashish Gupta <ashish.gupta@marvell.com>, Slava
Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>
Subject: RE: [PATCH v2 1/2] common/mlx5: fix build disabling
Thread-Topic: [PATCH v2 1/2] common/mlx5: fix build disabling
Thread-Index: AQHY7Dl6ZmBz2+NPFEq2lex1ZeNWz64mqBAg
Date: Sun, 30 Oct 2022 09:16:27 +0000
Message-ID: <DM4PR12MB5389F8C9DEFFC9A6080CC05BDF349@DM4PR12MB5389.namprd12.prod.outlook.com>
References: <abaa5419-b66e-ff21-a5b8-da953a8542ec@oktetlabs.ru>
<20221030082722.1333530-1-thomas@monjalon.net>
<20221030082722.1333530-2-thomas@monjalon.net>
In-Reply-To: <20221030082722.1333530-2-thomas@monjalon.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM4PR12MB5389:EE_|DM4PR12MB6181:EE_
x-ms-office365-filtering-correlation-id: 4c4886a6-8ed0-4015-1f26-08daba576d05
x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: q+t57wPOKy3KO1q6SYyhr2jeYceGRNLvKXrynpo9SJIFt7lMomhiXz5LzlOm+WVHsaCuHXSV830TBXo36CJ+c5dPToWgvJ/dpreqVELVQNmnwgzlNNgc21cLh3CTG6ks6AcDfBsnf/WpEX7CFE2KspKwaXy0CcyzPXW7jlK3gtTj8grO4IkrmR6zqt+Uw2tPFBnNktdwVIKPaeN47vH9CWpvUlgv1hGJdf2UxL8p+617UCluxbd21Pp7CEE/9WGb38S7/rZLVSB5Z0RaL40RxU5dUWZ3XAx19tR0YFUmZtc3HOqPlndBQT9jcOQ1a2awM0rKCss8yk9aOWHeW1EAu3IQky1h0DIySkoefR60YhWGgw3MjrwSLyQJrPXpbbyBhyng9MpXcUmrzsxpOE6m7ngJzsHejmcrOb2XDdNhvisIyEyfvjZXD0nt3Mt1JzWysExaPY77xHf1KUgL4++0KlNkvvLMTGmH++sHeqpPxVUKBYSbkVpzrOjpUq9IFMtoZJ9Rubmow1h0LkX8eR1vQUQKLQ01Xqh41Bs8Coxcm4hcSQPpdmtV8GI/1xlKsHOVd1rkGExUeeut2hrYuJI+kD6uFKLstQRHTk6qc8buqql5p7YJEVjeo960Hs/xYoRLJ+TVE1eWDIyoMywV19PYU6JpuH6SoWuSAqTkrYmnGEI3VCFkLCiXvskHluVuAS6muhwixBO8PvO18//y9unUFKyUvnMzHJ0/pigqmeaRlxeGaNprqpxpHsmVBZlaxzxHJJaNoC0lcVxSrH2eY5mywg==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(366004)(346002)(451199015)(54906003)(316002)(110136005)(66946007)(4326008)(76116006)(64756008)(66556008)(66476007)(66446008)(6506007)(5660300002)(186003)(38070700005)(122000001)(71200400001)(2906002)(33656002)(38100700002)(55016003)(52536014)(8676002)(7696005)(86362001)(8936002)(83380400001)(41300700001)(9686003)(107886003)(4744005)(478600001);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m8LNqPzUFsg8qOP0tZr4slv9LJoLbKCDz6JS1iWV4gAhk5SexXEvjUKX3WUB?=
=?us-ascii?Q?rUW8He1VmwmzA/vLuMrAMFchSC64MFJFe0VU+2hu2fLESpEjEgmoGI2q43b1?=
=?us-ascii?Q?d1O+LEaEEkEK5O0z7ur/ccLhEkjOLduQYIdvb5CtbCoIJAR+XVv1Ge9RGnrW?=
=?us-ascii?Q?xJpdU6oUOV/E8SCRkJM7mts9lQPJAiir16oLjZxDzZM2CtD8HRZQx+GjWAtK?=
=?us-ascii?Q?OoVK/x20cwtq0+e+YiexHt7euNf4l7gapU/xoEad+wloCOp6DNhOpQFXikGG?=
=?us-ascii?Q?r6EZ5+prnRUjVgFn17QcRJoaRKBdWLF2u2VRMChdR1uIZmqUqYL2dusjGb+L?=
=?us-ascii?Q?Zt9BOkE3lTU4S1op2SmwTvPhFL5ITGTGyl6RRptFnhM3DlkUUEdIsYaBA74A?=
=?us-ascii?Q?fMId3bpW1YJknjvnrDfcM2idi9ymguDC0VagwW8A7EcFebpCC+i1edyEQdhk?=
=?us-ascii?Q?71Ss+DJCCqmMKPSZ8xU00T7mMv0PMqnImZYOV2DhAQVh2VaFP+3LXyg7MqWN?=
=?us-ascii?Q?bUQmi9z8lUIJpYT4PnEbzAqt0KJBOVSTrF+RwbHcGtpVyRcrnzqhqVoOeDYY?=
=?us-ascii?Q?IGVqYFX/BIVHepvVc5cqQnE1FrQybiXOSZeXSl6OxCdVp8QLDHIhYMBK4IIx?=
=?us-ascii?Q?REXN7AGMnno6OVNsyHjZpEeOenADIsyZqsNwFo3coEszHHnDcD6f+wJ1oKPO?=
=?us-ascii?Q?dGjoSsAL3nkJSaJktZ4NdfC/Ou4sHkxHKrjGFXyta1ahNsdkIpcSpGRr94kF?=
=?us-ascii?Q?n4JY96vfUhYndxYKtZAQptzfKQlRoVTSltpCRBtBiq3D8ZqLz6ywwE3SewAt?=
=?us-ascii?Q?QxGTaM9ZqpurUBw44obZph8KfOajLnKuHkITZRAAikpiXm8s6INAEiSS9u43?=
=?us-ascii?Q?L1C5K4/YKjG9W7TK5SWnKH6CpZsOAM1EftCYwfZHCPbNMXEtnrv5DLfgE47o?=
=?us-ascii?Q?wekhIW8eaQGm3oGgq+07a2Pnti/RBvmADi/g2MX0iRYEskOc0R9zaaQjioY9?=
=?us-ascii?Q?vWe8WXI6apJDFD868rlF2laI0PZLV9+dECRyeCj4+Z2P2OQD6Dh8BEIn3v03?=
=?us-ascii?Q?jtDsQr0b7dJ+uxz11UeH/JlfZNee7NTXulwTRQeUEUiadXbDezsAi0gCBqTf?=
=?us-ascii?Q?vXSEUJI0y1BnLtrK+3QIotcnzy7+y2UnqewqpdTQcKFoTkxLElsDivnBdXcG?=
=?us-ascii?Q?d4lHR9afJZMzPJXMowmjfD8bpMEzZYQxHNku7JV1AqxvfhuNZLUIwTVmOFRi?=
=?us-ascii?Q?Fg02VX0noCUPTuFpL2uE6PL52zUOeYupJVcltLNI/WqMxKRhjChMo62DI0a8?=
=?us-ascii?Q?59YwcwH668R6WNET7arrvhiR+AgG0gVKQhOc0n9FGIByOvxyDpFzFv7pGFSl?=
=?us-ascii?Q?y52b+RQi/FUOm7E/tEXdRW82UCpbv1eRb5TAmQi+FvAkLqsf6XLTq0c+WB4H?=
=?us-ascii?Q?yU7KTgXBYlky9+R3RXTqepL0FGp5hlcBSSAoOjUPMeQTii4dmTnAnBTag7MJ?=
=?us-ascii?Q?7nQy7kiLj/4VX9wNUybrvCkN4ybh1/Y0kGvRA0giPjZef+8V5RmZUxuATGez?=
=?us-ascii?Q?H9G0vFQa3aifiNA44YhPSU+rJXooberp72zj2J7QDy4Fo2m0NxPt0IKiO+RH?=
=?us-ascii?Q?X00mLcxOLFznd3SSWKY3XsNIV2Vzc7V+rOCwSMmp3Pu8?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c4886a6-8ed0-4015-1f26-08daba576d05
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2022 09:16:28.0007 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 88x8a5MSXWwNcRoPwzouikZ3vr8ud1OVGv3Sz248Duy1r0H7R1ogf9JcFe7hcUSuOpLhOcgyW07rZje4SfQ/Og==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6181
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
> If the dependency common/mlx5 is explicitly disabled, but net/mlx5 is not
> explicitly disabled, Meson will read the full recipe of net/mlx5 and will=
fail
> when accessing a variable from common/mlx5:
> drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable
> "mlx5_config".
>=20
> The solution is to stop parsing net/mlx5 if common/mlx5 is disabled.
> The deps array must be defined before stopping, in order to automatically
> disable the build of net/mlx5 and print the reason.
>=20
> The same protection is applied to other mlx5 drivers, so it will allow us=
ing the
> variable mlx5_config in future.
>=20
> Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering")
>=20
> Reported-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Tested-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Acked-by: Matan Azrad <matan@nvidia.com>